X-Git-Url: http://git.heureux-cyclage.org/?a=blobdiff_plain;f=includes%2FSpecialPopularpages.php;h=39fc4c684114238e58de211a767c4430cae8a110;hb=8890d458ddd37134594e8e5aa97ac0f013da57d3;hp=18dbb0d978bbf724bd50c40b23efe8b931a0f7bb;hpb=4dac4d85c61f5163bfd703b6252e620f546e652f;p=lhc%2Fweb%2Fwiklou.git

diff --git a/includes/SpecialPopularpages.php b/includes/SpecialPopularpages.php
index 18dbb0d978..39fc4c6841 100644
--- a/includes/SpecialPopularpages.php
+++ b/includes/SpecialPopularpages.php
@@ -1,7 +1,20 @@
 <?php
-
-include_once( "QueryPage.php" );
-
+/**
+ *
+ * @package MediaWiki
+ * @subpackage SpecialPage
+ */
+
+/**
+ *
+ */
+require_once( "QueryPage.php" );
+
+/**
+ *
+ * @package MediaWiki
+ * @subpackage SpecialPage
+ */
 class PopularPagesPage extends QueryPage {
 
 	function getName() {
@@ -9,25 +22,35 @@ class PopularPagesPage extends QueryPage {
 	}
 
 	function isExpensive() {
-		return 1;
+		# cur_counter is not indexed
+		return true;
 	}
 
-	function getSQL( $offset, $limit ) {
-		return "SELECT cur_title, cur_counter FROM cur " .
-		  "WHERE cur_namespace=0 AND cur_is_redirect=0 ORDER BY " .
-		  "cur_counter DESC LIMIT {$offset}, {$limit}";
+	function getSQL() {
+		$dbr =& wfGetDB( DB_SLAVE );
+		$cur = $dbr->tableName( 'cur' );
+
+		return
+			"SELECT 'Popularpages' as type,
+			        cur_namespace as namespace,
+			        cur_title as title,
+			        cur_counter as value
+			FROM $cur
+			WHERE cur_namespace=0 AND cur_is_redirect=0";
 	}
 
 	function formatResult( $skin, $result ) {
 		global $wgLang;
-		$link = $skin->makeKnownLink( $result->cur_title, "" );
-		$nv = wfMsg( "nviews", $wgLang->formatNum( $result->cur_counter ) );
+		$link = $skin->makeKnownLink( $result->title, "" );
+		$nv = wfMsg( "nviews", $wgLang->formatNum( $result->value ) );
 		return "{$link} ({$nv})";
 	}
 }
 
-function wfSpecialPopularpages()
-{
+/**
+ * Constructor
+ */
+function wfSpecialPopularpages() {
     list( $limit, $offset ) = wfCheckLimits();
     
     $ppp = new PopularPagesPage();