RELEASE-NOTES for last two commits

[lhc/web/wiklou.git] / maintenance / findDeprecated.php

diff --git a/maintenance/findDeprecated.php b/maintenance/findDeprecated.php
index 9022292..ae2ee42 100644 (file)
--- a/maintenance/findDeprecated.php
+++ b/maintenance/findDeprecated.php
@@ -53,7 +53,7 @@ class DeprecatedInterfaceFinder extends FileAwareNodeVisitor {
 
        private $currentClass = null;
 
-       private $foundNodes = array();
+       private $foundNodes = [];
 
        public function getFoundNodes() {
                // Sort results by version, then by filename, then by name.
@@ -69,8 +69,13 @@ class DeprecatedInterfaceFinder extends FileAwareNodeVisitor {
        /**
         * Check whether a function or method includes a call to wfDeprecated(),
         * indicating that it is a hard-deprecated interface.
+        * @param PhpParser\Node $node
+        * @return bool
         */
        public function isHardDeprecated( PhpParser\Node $node ) {
+               if ( !$node->stmts ) {
+                       return false;
+               }
                foreach ( $node->stmts as $stmt ) {
                        if (
                                $stmt instanceof PhpParser\Node\Expr\FuncCall
@@ -105,12 +110,12 @@ class DeprecatedInterfaceFinder extends FileAwareNodeVisitor {
                                $name = $node->name;
                        }
 
-                       $this->foundNodes[ $version ][] = array(
+                       $this->foundNodes[ $version ][] = [
                                'filename' => $node->filename,
                                'line'     => $node->getLine(),
                                'name'     => $name,
                                'hard'     => $this->isHardDeprecated( $node ),
-                       );
+                       ];
                }
 
                return $retVal;
@@ -127,6 +132,9 @@ class FindDeprecated extends Maintenance {
                $this->addDescription( 'Find deprecated interfaces' );
        }
 
+       /**
+        * @return SplFileInfo[]
+        */
        public function getFiles() {
                global $IP;
 
@@ -142,7 +150,7 @@ class FindDeprecated extends Maintenance {
                $files = $this->getFiles();
                $chunkSize = ceil( count( $files ) / 72 );
 
-               $parser = new PhpParser\Parser( new PhpParser\Lexer\Emulative );
+               $parser = ( new PhpParser\ParserFactory )->create( PhpParser\ParserFactory::PREFER_PHP7 );
                $traverser = new PhpParser\NodeTraverser;
                $finder = new DeprecatedInterfaceFinder;
                $traverser->addVisitor( $finder );
@@ -158,7 +166,7 @@ class FindDeprecated extends Maintenance {
                        }
 
                        $finder->setCurrentFile( substr( $file->getPathname(), strlen( $IP ) + 1 ) );
-                       $nodes = $parser->parse( $code, array( 'throwOnError' => false ) );
+                       $nodes = $parser->parse( $code );
                        $traverser->traverse( $nodes );
 
                        if ( $i % $chunkSize === 0 ) {
@@ -194,5 +202,5 @@ class FindDeprecated extends Maintenance {
        }
 }
 
-$maintClass = 'FindDeprecated';
+$maintClass = FindDeprecated::class;
 require_once RUN_MAINTENANCE_IF_MAIN;