Function out query building, to allow easier overriding
[lhc/web/wiklou.git] / includes / specials / SpecialRecentchanges.php
index cb718bd..2f13fe5 100644 (file)
@@ -1,13 +1,36 @@
 <?php
-
 /**
  * Implements Special:Recentchanges
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ * @ingroup SpecialPage
+ */
+
+/**
+ * A special page that lists last changes made to the wiki
+ *
  * @ingroup SpecialPage
  */
-class SpecialRecentChanges extends SpecialPage {
-       public function __construct() {
-               SpecialPage::SpecialPage( 'Recentchanges' );
-               $this->includable( true );
+class SpecialRecentChanges extends IncludableSpecialPage {
+       var $rcOptions, $rcSubpage;
+
+       public function __construct( $name = 'Recentchanges' ) {
+               parent::__construct( $name );
        }
 
        /**
@@ -16,17 +39,18 @@ class SpecialRecentChanges extends SpecialPage {
         * @return FormOptions
         */
        public function getDefaultOptions() {
+               global $wgUser;
                $opts = new FormOptions();
 
-               $opts->add( 'days',  (int)User::getDefaultOption( 'rcdays' ) );
-               $opts->add( 'limit', (int)User::getDefaultOption( 'rclimit' ) );
+               $opts->add( 'days',  (int)$wgUser->getOption( 'rcdays' ) );
+               $opts->add( 'limit', (int)$wgUser->getOption( 'rclimit' ) );
                $opts->add( 'from', '' );
 
-               $opts->add( 'hideminor',     false );
+               $opts->add( 'hideminor',     $wgUser->getBoolOption( 'hideminor' ) );
                $opts->add( 'hidebots',      true  );
                $opts->add( 'hideanons',     false );
                $opts->add( 'hideliu',       false );
-               $opts->add( 'hidepatrolled', false );
+               $opts->add( 'hidepatrolled', $wgUser->getBoolOption( 'hidepatrolled' ) );
                $opts->add( 'hidemyself',    false );
 
                $opts->add( 'namespace', '', FormOptions::INTNULL );
@@ -34,26 +58,23 @@ class SpecialRecentChanges extends SpecialPage {
 
                $opts->add( 'categories', '' );
                $opts->add( 'categories_any', false );
-
+               $opts->add( 'tagfilter', '' );
                return $opts;
        }
 
        /**
-        * Get a FormOptions object with options as specified by the user
+        * Create a FormOptions object with options as specified by the user
         *
         * @return FormOptions
         */
        public function setup( $parameters ) {
-               global $wgUser, $wgRequest;
+               global $wgRequest;
 
                $opts = $this->getDefaultOptions();
-               $opts['days'] = (int)$wgUser->getOption( 'rcdays', $opts['days'] );
-               $opts['limit'] = (int)$wgUser->getOption( 'rclimit', $opts['limit'] );
-               $opts['hideminor'] = $wgUser->getOption( 'hideminor', $opts['hideminor'] );
                $opts->fetchValuesFromRequest( $wgRequest );
 
                // Give precedence to subpage syntax
-               if ( $parameters !== null ) {
+               if( $parameters !== null ) {
                        $this->parseParameters( $parameters, $opts );
                }
 
@@ -62,82 +83,95 @@ class SpecialRecentChanges extends SpecialPage {
        }
 
        /**
-        * Get a FormOptions object sepcific for feed requests
+        * Create a FormOptions object specific for feed requests and return it
         *
         * @return FormOptions
         */
        public function feedSetup() {
                global $wgFeedLimit, $wgRequest;
                $opts = $this->getDefaultOptions();
-               $opts->fetchValuesFromRequest( $wgRequest, array( 'days', 'limit', 'hideminor' ) );
+               # Feed is cached on limit,hideminor,namespace; other params would randomly not work
+               $opts->fetchValuesFromRequest( $wgRequest, array( 'limit', 'hideminor', 'namespace' ) );
                $opts->validateIntBounds( 'limit', 0, $wgFeedLimit );
                return $opts;
        }
 
+       /**
+        * Get the current FormOptions for this request
+        */
+       public function getOptions() {
+               if ( $this->rcOptions === null ) {
+                       global $wgRequest;
+                       $feedFormat = $wgRequest->getVal( 'feed' );
+                       $this->rcOptions = $feedFormat ? $this->feedSetup() : $this->setup( $this->rcSubpage );
+               }
+               return $this->rcOptions;
+       }
+
+
        /**
         * Main execution point
         *
-        * @param $parameters string
+        * @param $subpage String
         */
-       public function execute( $parameters ) {
+       public function execute( $subpage ) {
                global $wgRequest, $wgOut;
+               $this->rcSubpage = $subpage;
                $feedFormat = $wgRequest->getVal( 'feed' );
 
                # 10 seconds server-side caching max
                $wgOut->setSquidMaxage( 10 );
-
+               # Check if the client has a cached version
                $lastmod = $this->checkLastModified( $feedFormat );
-               if( $lastmod === false ){
+               if( $lastmod === false ) {
                        return;
                }
 
-               $opts = $feedFormat ? $this->feedSetup() : $this->setup( $parameters );
+               $opts = $this->getOptions();
                $this->setHeaders();
                $this->outputHeader();
 
                // Fetch results, prepare a batch link existence check query
-               $rows = array();
-               $batch = new LinkBatch;
                $conds = $this->buildMainQueryConds( $opts );
-               $res = $this->doMainQuery( $conds, $opts );
-               if( $res === false ){
-                       $this->doHeader( $opts );
+               $rows = $this->doMainQuery( $conds, $opts );
+               if( $rows === false ){
+                       if( !$this->including() ) {
+                               $this->doHeader( $opts );
+                       }
                        return;
                }
-               $dbr = wfGetDB( DB_SLAVE );
-               while( $row = $dbr->fetchObject( $res ) ){
-                       $rows[] = $row;
-                       if ( !$feedFormat ) {
-                               // User page and talk links
+
+               if( !$feedFormat ) {
+                       $batch = new LinkBatch;
+                       foreach( $rows as $row ) {
                                $batch->add( NS_USER, $row->rc_user_text  );
                                $batch->add( NS_USER_TALK, $row->rc_user_text  );
+                               $batch->add( $row->rc_namespace, $row->rc_title );
                        }
-
+                       $batch->execute();
                }
-               $dbr->freeResult( $res );
-
-               if ( $feedFormat ) {
-                       list( $feed, $feedObj ) = $this->getFeedObject( $feedFormat );
-                       $feed->execute( $feedObj, $rows, $opts['limit'], $opts['hideminor'], $lastmod );
+               if( $feedFormat ) {
+                       list( $changesFeed, $formatter ) = $this->getFeedObject( $feedFormat );
+                       $changesFeed->execute( $formatter, $rows, $lastmod, $opts );
                } else {
-                       $batch->execute();
                        $this->webOutput( $rows, $opts );
                }
-       
+
+               $rows->free();
        }
 
        /**
         * Return an array with a ChangesFeed object and ChannelFeed object
         *
-        * @return array
+        * @return Array
         */
        public function getFeedObject( $feedFormat ){
-               $feed = new ChangesFeed( $feedFormat, 'rcfeed' );
-               $feedObj = $feed->getFeedObject(
+               $changesFeed = new ChangesFeed( $feedFormat, 'rcfeed' );
+               $formatter = $changesFeed->getFeedObject(
                        wfMsgForContent( 'recentchanges' ),
                        wfMsgForContent( 'recentchanges-feed-description' )
                );
-               return array( $feed, $feedObj );
+               return array( $changesFeed, $formatter );
        }
 
        /**
@@ -149,21 +183,21 @@ class SpecialRecentChanges extends SpecialPage {
         */
        public function parseParameters( $par, FormOptions $opts ) {
                $bits = preg_split( '/\s*,\s*/', trim( $par ) );
-               foreach ( $bits as $bit ) {
-                       if ( 'hidebots' === $bit ) $opts['hidebots'] = true;
-                       if ( 'bots' === $bit ) $opts['hidebots'] = false;
-                       if ( 'hideminor' === $bit ) $opts['hideminor'] = true;
-                       if ( 'minor' === $bit ) $opts['hideminor'] = false;
-                       if ( 'hideliu' === $bit ) $opts['hideliu'] = true;
-                       if ( 'hidepatrolled' === $bit ) $opts['hidepatrolled'] = true;
-                       if ( 'hideanons' === $bit ) $opts['hideanons'] = true;
-                       if ( 'hidemyself' === $bit ) $opts['hidemyself'] = true;
-
-                       if ( is_numeric( $bit ) ) $opts['limit'] =  $bit;
+               foreach( $bits as $bit ) {
+                       if( 'hidebots' === $bit ) $opts['hidebots'] = true;
+                       if( 'bots' === $bit ) $opts['hidebots'] = false;
+                       if( 'hideminor' === $bit ) $opts['hideminor'] = true;
+                       if( 'minor' === $bit ) $opts['hideminor'] = false;
+                       if( 'hideliu' === $bit ) $opts['hideliu'] = true;
+                       if( 'hidepatrolled' === $bit ) $opts['hidepatrolled'] = true;
+                       if( 'hideanons' === $bit ) $opts['hideanons'] = true;
+                       if( 'hidemyself' === $bit ) $opts['hidemyself'] = true;
+
+                       if( is_numeric( $bit ) ) $opts['limit'] =  $bit;
 
                        $m = array();
-                       if ( preg_match( '/^limit=(\d+)$/', $bit, $m ) ) $opts['limit'] = $m[1];
-                       if ( preg_match( '/^days=(\d+)$/', $bit, $m ) ) $opts['days'] = $m[1];
+                       if( preg_match( '/^limit=(\d+)$/', $bit, $m ) ) $opts['limit'] = $m[1];
+                       if( preg_match( '/^days=(\d+)$/', $bit, $m ) ) $opts['days'] = $m[1];
                }
        }
 
@@ -173,14 +207,14 @@ class SpecialRecentChanges extends SpecialPage {
         * update the timestamp
         *
         * @param $feedFormat String
-        * @return int or false
+        * @return String or false
         */
        public function checkLastModified( $feedFormat ) {
                global $wgUseRCPatrol, $wgOut;
                $dbr = wfGetDB( DB_SLAVE );
-               $lastmod = $dbr->selectField( 'recentchanges', 'MAX(rc_timestamp)', false, __FUNCTION__ );
-               if ( $feedFormat || !$wgUseRCPatrol ) {
-                       if( $lastmod && $wgOut->checkLastModified( $lastmod ) ){
+               $lastmod = $dbr->selectField( 'recentchanges', 'MAX(rc_timestamp)', false, __METHOD__ );
+               if( $feedFormat || !$wgUseRCPatrol ) {
+                       if( $lastmod && $wgOut->checkLastModified( $lastmod ) ) {
                                # Client cache fresh and headers sent, nothing more to do.
                                return false;
                        }
@@ -232,12 +266,12 @@ class SpecialRecentChanges extends SpecialPage {
                $hideLoggedInUsers = $opts['hideliu'] && !$forcebot;
                $hideAnonymousUsers = $opts['hideanons'] && !$forcebot;
 
-               if ( $opts['hideminor'] )  $conds['rc_minor'] = 0;
-               if ( $opts['hidebots'] )   $conds['rc_bot'] = 0;
-               if ( $hidePatrol )         $conds['rc_patrolled'] = 0;
-               if ( $forcebot )           $conds['rc_bot'] = 1;
-               if ( $hideLoggedInUsers )  $conds[] = 'rc_user = 0';
-               if ( $hideAnonymousUsers ) $conds[] = 'rc_user != 0';
+               if( $opts['hideminor'] )  $conds['rc_minor'] = 0;
+               if( $opts['hidebots'] )   $conds['rc_bot'] = 0;
+               if( $hidePatrol )         $conds['rc_patrolled'] = 0;
+               if( $forcebot )           $conds['rc_bot'] = 1;
+               if( $hideLoggedInUsers )  $conds[] = 'rc_user = 0';
+               if( $hideAnonymousUsers ) $conds[] = 'rc_user != 0';
 
                if( $opts['hidemyself'] ) {
                        if( $wgUser->getId() ) {
@@ -248,8 +282,8 @@ class SpecialRecentChanges extends SpecialPage {
                }
 
                # Namespace filtering
-               if ( $opts['namespace'] !== '' ) {
-                       if ( !$opts['invert'] ) {
+               if( $opts['namespace'] !== '' ) {
+                       if( !$opts['invert'] ) {
                                $conds[] = 'rc_namespace = ' . $dbr->addQuotes( $opts['namespace'] );
                        } else {
                                $conds[] = 'rc_namespace != ' . $dbr->addQuotes( $opts['namespace'] );
@@ -262,7 +296,7 @@ class SpecialRecentChanges extends SpecialPage {
        /**
         * Process the query
         *
-        * @param $conds array
+        * @param $conds Array
         * @param $opts FormOptions
         * @return database result or false (for Recentchangeslinked only)
         */
@@ -271,46 +305,71 @@ class SpecialRecentChanges extends SpecialPage {
 
                $tables = array( 'recentchanges' );
                $join_conds = array();
+               $query_options = array( 'USE INDEX' => array('recentchanges' => 'rc_timestamp') );
 
                $uid = $wgUser->getId();
                $dbr = wfGetDB( DB_SLAVE );
                $limit = $opts['limit'];
                $namespace = $opts['namespace'];
+               $select = '*';
                $invert = $opts['invert'];
 
                // JOIN on watchlist for users
                if( $uid ) {
                        $tables[] = 'watchlist';
-                       $join_conds = array( 'watchlist' => array('LEFT JOIN',"wl_user={$uid} AND wl_title=rc_title AND wl_namespace=rc_namespace") );
+                       $join_conds['watchlist'] = array('LEFT JOIN',
+                               "wl_user={$uid} AND wl_title=rc_title AND wl_namespace=rc_namespace");
+               }
+               if ($wgUser->isAllowed("rollback")) {
+                       $tables[] = 'page';
+                       $join_conds['page'] = array('LEFT JOIN', 'rc_cur_id=page_id');
+               }
+               if ( !$this->including() ) {
+                       // Tag stuff.
+                       // Doesn't work when transcluding. See bug 23293
+                       $fields = array();
+                       // Fields are * in this case, so let the function modify an empty array to keep it happy.
+                       ChangeTags::modifyDisplayQuery(
+                               $tables, $fields, $conds, $join_conds, $query_options, $opts['tagfilter']
+                       );
                }
 
-               wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );
-
-               // Is there either one namespace selected or excluded?
-               // Also, if this is "all" or main namespace, just use timestamp index.
-               if( is_null($namespace) || $invert || $namespace == NS_MAIN ) {
+               if ( !wfRunHooks( 'SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts, &$query_options, &$select ) ) )
+                       return false;
+
+               // Don't use the new_namespace_time timestamp index if:
+               // (a) "All namespaces" selected
+               // (b) We want all pages NOT in a certain namespaces (inverted)
+               // (c) There is a tag to filter on (use tag index instead)
+               // (d) UNION + sort/limit is not an option for the DBMS
+               if( is_null( $namespace )
+                       || ( $invert && !is_null( $namespace ) )
+                       || $opts['tagfilter'] != ''
+                       || !$dbr->unionSupportsOrderAndLimit() )
+               {
                        $res = $dbr->select( $tables, '*', $conds, __METHOD__,
-                               array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit,
-                                       'USE INDEX' => array('recentchanges' => 'rc_timestamp') ),
+                               array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit ) +
+                               $query_options,
                                $join_conds );
                // We have a new_namespace_time index! UNION over new=(0,1) and sort result set!
                } else {
                        // New pages
-                       $sqlNew = $dbr->selectSQLText( $tables, '*',
+                       $sqlNew = $dbr->selectSQLText( $tables, $select,
                                array( 'rc_new' => 1 ) + $conds,
                                __METHOD__,
                                array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit,
-                                       'USE INDEX' =>  array('recentchanges' => 'new_name_timestamp') ),
+                                       'USE INDEX' =>  array('recentchanges' => 'rc_timestamp') ),
                                $join_conds );
                        // Old pages
                        $sqlOld = $dbr->selectSQLText( $tables, '*',
                                array( 'rc_new' => 0 ) + $conds,
                                __METHOD__,
                                array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit,
-                                       'USE INDEX' =>  array('recentchanges' => 'new_name_timestamp') ),
+                                       'USE INDEX' =>  array('recentchanges' => 'rc_timestamp') ),
                                $join_conds );
                        # Join the two fast queries, and sort the result set
-                       $sql = "($sqlNew) UNION ($sqlOld) ORDER BY rc_timestamp DESC LIMIT $limit";
+                       $sql = $dbr->unionQueries(array($sqlNew, $sqlOld), false).' ORDER BY rc_timestamp DESC';
+                       $sql = $dbr->limitResult($sql, $limit, false);
                        $res = $dbr->query( $sql, __METHOD__ );
                }
 
@@ -320,7 +379,7 @@ class SpecialRecentChanges extends SpecialPage {
        /**
         * Send output to $wgOut, only called if not used feeds
         *
-        * @param $rows array of database rows
+        * @param $rows Array of database rows
         * @param $opts FormOptions
         */
        public function webOutput( $rows, $opts ) {
@@ -329,68 +388,67 @@ class SpecialRecentChanges extends SpecialPage {
 
                $limit = $opts['limit'];
 
-               if ( !$this->including() ) {
+               if( !$this->including() ) {
                        // Output options box
                        $this->doHeader( $opts );
                }
 
                // And now for the content
-               $wgOut->setSyndicated( true );
-
-               $list = ChangesList::newFromUser( $wgUser );
+               $wgOut->setFeedAppendQuery( $this->getFeedQuery() );
 
-               if ( $wgAllowCategorizedRecentChanges ) {
+               if( $wgAllowCategorizedRecentChanges ) {
                        $this->filterByCategories( $rows, $opts );
                }
 
-               $s = $list->beginRecentChangesList();
-               $counter = 1;
-
                $showWatcherCount = $wgRCShowWatchingUsers && $wgUser->getOption( 'shownumberswatching' );
                $watcherCache = array();
 
                $dbr = wfGetDB( DB_SLAVE );
 
-               foreach( $rows as $obj ){
-                       if( $limit == 0) {
-                               break;
-                       }
-
-                       if ( ! ( $opts['hideminor']     && $obj->rc_minor     ) &&
-                            ! ( $opts['hidepatrolled'] && $obj->rc_patrolled ) ) {
-                               $rc = RecentChange::newFromRow( $obj );
-                               $rc->counter = $counter++;
-
-                               if ($wgShowUpdatedMarker
-                                       && !empty( $obj->wl_notificationtimestamp )
-                                       && ($obj->rc_timestamp >= $obj->wl_notificationtimestamp)) {
-                                               $rc->notificationtimestamp = true;
-                               } else {
-                                       $rc->notificationtimestamp = false;
-                               }
+               $counter = 1;
+               $list = ChangesList::newFromUser( $wgUser );
 
-                               $rc->numberofWatchingusers = 0; // Default
-                               if ($showWatcherCount && $obj->rc_namespace >= 0) {
-                                       if (!isset($watcherCache[$obj->rc_namespace][$obj->rc_title])) {
-                                               $watcherCache[$obj->rc_namespace][$obj->rc_title] =
-                                                       $dbr->selectField( 'watchlist',
-                                                               'COUNT(*)',
-                                                               array(
-                                                                       'wl_namespace' => $obj->rc_namespace,
-                                                                       'wl_title' => $obj->rc_title,
-                                                               ),
-                                                               __METHOD__ . '-watchers' );
-                                       }
-                                       $rc->numberofWatchingusers = $watcherCache[$obj->rc_namespace][$obj->rc_title];
+               $s = $list->beginRecentChangesList();
+               foreach( $rows as $obj ) {
+                       if( $limit == 0 ) break;
+                       $rc = RecentChange::newFromRow( $obj );
+                       $rc->counter = $counter++;
+                       # Check if the page has been updated since the last visit
+                       if( $wgShowUpdatedMarker && !empty($obj->wl_notificationtimestamp) ) {
+                               $rc->notificationtimestamp = ($obj->rc_timestamp >= $obj->wl_notificationtimestamp);
+                       } else {
+                               $rc->notificationtimestamp = false; // Default
+                       }
+                       # Check the number of users watching the page
+                       $rc->numberofWatchingusers = 0; // Default
+                       if( $showWatcherCount && $obj->rc_namespace >= 0 ) {
+                               if( !isset($watcherCache[$obj->rc_namespace][$obj->rc_title]) ) {
+                                       $watcherCache[$obj->rc_namespace][$obj->rc_title] =
+                                                $dbr->selectField( 'watchlist',
+                                                       'COUNT(*)',
+                                                       array(
+                                                               'wl_namespace' => $obj->rc_namespace,
+                                                               'wl_title' => $obj->rc_title,
+                                                       ),
+                                                       __METHOD__ . '-watchers' );
                                }
-                               $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ) );
-                               --$limit;
+                               $rc->numberofWatchingusers = $watcherCache[$obj->rc_namespace][$obj->rc_title];
                        }
+                       $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ), $counter );
+                       --$limit;
                }
                $s .= $list->endRecentChangesList();
                $wgOut->addHTML( $s );
        }
 
+       /**
+        * Get the query string to append to feed link URLs.
+        * This is overridden by RCL to add the target parameter
+        */
+       public function getFeedQuery() {
+               return false;
+       }
+
        /**
         * Return the text to be displayed above the changes
         *
@@ -404,40 +462,48 @@ class SpecialRecentChanges extends SpecialPage {
 
                $defaults = $opts->getAllValues();
                $nondefaults = $opts->getChangedValues();
-               $opts->consumeValues( array( 'namespace', 'invert' ) );
+               $opts->consumeValues( array( 'namespace', 'invert', 'tagfilter',
+                       'categories', 'categories_any' ) );
 
                $panel = array();
                $panel[] = $this->optionsPanel( $defaults, $nondefaults );
                $panel[] = '<hr />';
 
                $extraOpts = $this->getExtraOptions( $opts );
+               $extraOptsCount = count( $extraOpts );
+               $count = 0;
+               $submit = ' ' . Xml::submitbutton( wfMsg( 'allpagessubmit' ) );
+
+               $out = Xml::openElement( 'table', array( 'class' => 'mw-recentchanges-table' ) );
+               foreach( $extraOpts as $optionRow ) {
+                       # Add submit button to the last row only
+                       ++$count;
+                       $addSubmit = $count === $extraOptsCount ? $submit : '';
 
-               $out = Xml::openElement( 'table' );
-               foreach ( $extraOpts as $optionRow ) {
                        $out .= Xml::openElement( 'tr' );
-                       if ( is_array($optionRow) ) {
-                               $out .= Xml::tags( 'td', null, $optionRow[0] );
-                               $out .= Xml::tags( 'td', null, $optionRow[1] );
+                       if( is_array( $optionRow ) ) {
+                               $out .= Xml::tags( 'td', array( 'class' => 'mw-label' ), $optionRow[0] );
+                               $out .= Xml::tags( 'td', array( 'class' => 'mw-input' ), $optionRow[1] . $addSubmit );
                        } else {
-                               $out .= Xml::tags( 'td', array( 'colspan' => 2 ), $optionRow );
+                               $out .= Xml::tags( 'td', array( 'class' => 'mw-input', 'colspan' => 2 ), $optionRow . $addSubmit );
                        }
                        $out .= Xml::closeElement( 'tr' );
                }
                $out .= Xml::closeElement( 'table' );
 
                $unconsumed = $opts->getUnconsumedValues();
-               foreach ( $unconsumed as $key => $value ) {
-                       $out .= Xml::hidden( $key, $value );
+               foreach( $unconsumed as $key => $value ) {
+                       $out .= Html::hidden( $key, $value );
                }
 
                $t = $this->getTitle();
-               $out .= Xml::hidden( 'title', $t->getPrefixedText() );
+               $out .= Html::hidden( 'title', $t->getPrefixedText() );
                $form = Xml::tags( 'form', array( 'action' => $wgScript ), $out );
                $panel[] = $form;
                $panelString = implode( "\n", $panel );
 
                $wgOut->addHTML(
-                       Xml::fieldset( wfMsg( strtolower( $this->mName )  ), $panelString, array( 'class' => 'rcoptions' ) )
+                       Xml::fieldset( wfMsg( 'recentchanges-legend' ), $panelString, array( 'class' => 'rcoptions' ) )
                );
 
                $this->setBottomText( $wgOut, $opts );
@@ -447,19 +513,22 @@ class SpecialRecentChanges extends SpecialPage {
         * Get options to be displayed in a form
         *
         * @param $opts FormOptions
-        * @return array
+        * @return Array
         */
        function getExtraOptions( $opts ){
                $extraOpts = array();
                $extraOpts['namespace'] = $this->namespaceFilterForm( $opts );
 
                global $wgAllowCategorizedRecentChanges;
-               if ( $wgAllowCategorizedRecentChanges ) {
+               if( $wgAllowCategorizedRecentChanges ) {
                        $extraOpts['category'] = $this->categoryFilterForm( $opts );
                }
 
+               $tagFilter = ChangeTags::buildTagFilterSelector( $opts['tagfilter'] );
+               if ( count($tagFilter) )
+                       $extraOpts['tagfilter'] = $tagFilter;
+
                wfRunHooks( 'SpecialRecentChangesPanel', array( &$extraOpts, $opts ) );
-               $extraOpts['submit'] = Xml::submitbutton( wfMsg('allpagessubmit') );
                return $extraOpts;
        }
 
@@ -469,7 +538,7 @@ class SpecialRecentChanges extends SpecialPage {
         * @param $out OutputPage
         * @param $opts FormOptions
         */
-       function setTopText( &$out, $opts ){
+       function setTopText( OutputPage $out, FormOptions $opts ){
                $out->addWikiText( wfMsgForContentNoTrans( 'recentchangestext' ) );
        }
 
@@ -480,16 +549,16 @@ class SpecialRecentChanges extends SpecialPage {
         * @param $out OutputPage
         * @param $opts FormOptions
         */
-       function setBottomText( &$out, $opts ){}
+       function setBottomText( OutputPage $out, FormOptions $opts ){}
 
        /**
         * Creates the choose namespace selection
         *
         * @param $opts FormOptions
-        * @return string
+        * @return String
         */
        protected function namespaceFilterForm( FormOptions $opts ) {
-               $nsSelect = HTMLnamespaceselector( $opts['namespace'], '' );
+               $nsSelect = Xml::namespaceSelector( $opts['namespace'], '' );
                $nsLabel = Xml::label( wfMsg('namespace'), 'namespace' );
                $invert = Xml::checkLabel( wfMsg('invert'), 'invert', 'nsinvert', $opts['invert'] );
                return array( $nsLabel, "$nsSelect $invert" );
@@ -499,7 +568,7 @@ class SpecialRecentChanges extends SpecialPage {
         * Create a input to filter changes by categories
         *
         * @param $opts FormOptions
-        * @return array
+        * @return Array
         */
        protected function categoryFilterForm( FormOptions $opts ) {
                list( $label, $input ) = Xml::inputLabelSep( wfMsg('rc_categories'),
@@ -514,55 +583,57 @@ class SpecialRecentChanges extends SpecialPage {
        /**
         * Filter $rows by categories set in $opts
         *
-        * @param $rows array of database rows
+        * @param $rows Array of database rows
         * @param $opts FormOptions
         */
        function filterByCategories( &$rows, FormOptions $opts ) {
-               $categories = array_map( 'trim', explode( "|" , $opts['categories'] ) );
+               $categories = array_map( 'trim', explode( '|' , $opts['categories'] ) );
 
-               if( empty($categories) ) {
+               if( !count( $categories ) ) {
                        return;
                }
 
                # Filter categories
                $cats = array();
-               foreach ( $categories as $cat ) {
+               foreach( $categories as $cat ) {
                        $cat = trim( $cat );
-                       if ( $cat == "" ) continue;
+                       if( $cat == '' ) continue;
                        $cats[] = $cat;
                }
 
                # Filter articles
                $articles = array();
                $a2r = array();
-               foreach ( $rows AS $k => $r ) {
+               $rowsarr = array();
+               foreach( $rows AS $k => $r ) {
                        $nt = Title::makeTitle( $r->rc_namespace, $r->rc_title );
                        $id = $nt->getArticleID();
-                       if ( $id == 0 ) continue; # Page might have been deleted...
-                       if ( !in_array($id, $articles) ) {
+                       if( $id == 0 ) continue; # Page might have been deleted...
+                       if( !in_array( $id, $articles ) ) {
                                $articles[] = $id;
                        }
-                       if ( !isset($a2r[$id]) ) {
+                       if( !isset( $a2r[$id] ) ) {
                                $a2r[$id] = array();
                        }
                        $a2r[$id][] = $k;
+                       $rowsarr[$k] = $r;
                }
 
                # Shortcut?
-               if ( !count($articles) || !count($cats) )
+               if( !count( $articles ) || !count( $cats ) )
                        return ;
 
                # Look up
-               $c = new Categoryfinder ;
+               $c = new Categoryfinder;
                $c->seed( $articles, $cats, $opts['categories_any'] ? "OR" : "AND" ) ;
                $match = $c->run();
 
                # Filter
                $newrows = array();
-               foreach ( $match AS $id ) {
-                       foreach ( $a2r[$id] AS $rev ) {
+               foreach( $match AS $id ) {
+                       foreach( $a2r[$id] AS $rev ) {
                                $k = $rev;
-                               $newrows[$k] = $rows[$k];
+                               $newrows[$k] = $rowsarr[$k];
                        }
                }
                $rows = $newrows;
@@ -570,64 +641,72 @@ class SpecialRecentChanges extends SpecialPage {
 
        /**
         * Makes change an option link which carries all the other options
-        * @param $title see Title
-        * @param $override
-        * @param $options
+        *
+        * @param $title Title
+        * @param $override Array: options to override
+        * @param $options Array: current options
+        * @param $active Boolean: whether to show the link in bold
         */
        function makeOptionsLink( $title, $override, $options, $active = false ) {
                global $wgUser;
                $sk = $wgUser->getSkin();
-               return $sk->makeKnownLinkObj( $this->getTitle(), htmlspecialchars( $title ),
-                       wfArrayToCGI( $override, $options ), '', '', $active ? 'style="font-weight: bold;"' : '' );
+               $params = $override + $options;
+               if ( $active ) {
+                       return $sk->link( $this->getTitle(), '<strong>' . htmlspecialchars( $title ) . '</strong>',
+                                                         array(), $params, array( 'known' ) );
+               } else {
+                       return $sk->link( $this->getTitle(), htmlspecialchars( $title ), array() , $params, array( 'known' ) );
+               }
        }
 
        /**
         * Creates the options panel.
-        * @param $defaults array
-        * @param $nondefaults array
+        *
+        * @param $defaults Array
+        * @param $nondefaults Array
         */
        function optionsPanel( $defaults, $nondefaults ) {
                global $wgLang, $wgUser, $wgRCLinkLimits, $wgRCLinkDays;
 
                $options = $nondefaults + $defaults;
 
-               if( $options['from'] )
-                       $note = wfMsgExt( 'rcnotefrom', array( 'parseinline' ),
-                               $wgLang->formatNum( $options['limit'] ),
-                               $wgLang->timeanddate( $options['from'], true ) );
-               else
-                       $note = wfMsgExt( 'rcnote', array( 'parseinline' ),
+               $note = '';
+               if( !wfEmptyMsg( 'rclegend' ) ) {
+                       $note .= '<div class="mw-rclegend">' . wfMsgExt( 'rclegend', array('parseinline') ) . "</div>\n";
+               }
+               if( $options['from'] ) {
+                       $note .= wfMsgExt( 'rcnotefrom', array( 'parseinline' ),
                                $wgLang->formatNum( $options['limit'] ),
-                               $wgLang->formatNum( $options['days'] ),
-                               $wgLang->timeAndDate( wfTimestampNow(), true ),
-                               $wgLang->date( wfTimestampNow(), true ),
-                               $wgLang->time( wfTimestampNow(), true ) );
+                               $wgLang->timeanddate( $options['from'], true ),
+                               $wgLang->date( $options['from'], true ),
+                               $wgLang->time( $options['from'], true ) ) . '<br />';
+               }
 
                # Sort data for display and make sure it's unique after we've added user data.
                $wgRCLinkLimits[] = $options['limit'];
                $wgRCLinkDays[] = $options['days'];
-               sort($wgRCLinkLimits);
-               sort($wgRCLinkDays);
-               $wgRCLinkLimits = array_unique($wgRCLinkLimits);
-               $wgRCLinkDays = array_unique($wgRCLinkDays);
+               sort( $wgRCLinkLimits );
+               sort( $wgRCLinkDays );
+               $wgRCLinkLimits = array_unique( $wgRCLinkLimits );
+               $wgRCLinkDays = array_unique( $wgRCLinkDays );
 
                // limit links
                foreach( $wgRCLinkLimits as $value ) {
                        $cl[] = $this->makeOptionsLink( $wgLang->formatNum( $value ),
                                array( 'limit' => $value ), $nondefaults, $value == $options['limit'] ) ;
                }
-               $cl = implode( ' | ', $cl);
+               $cl = $wgLang->pipeList( $cl );
 
                // day links, reset 'from' to none
                foreach( $wgRCLinkDays as $value ) {
                        $dl[] = $this->makeOptionsLink( $wgLang->formatNum( $value ),
                                array( 'days' => $value, 'from' => '' ), $nondefaults, $value == $options['days'] ) ;
                }
-               $dl = implode( ' | ', $dl);
+               $dl = $wgLang->pipeList( $dl );
 
 
                // show/hide links
-               $showhide = array( wfMsg( 'show' ), wfMsg( 'hide' ));
+               $showhide = array( wfMsg( 'show' ), wfMsg( 'hide' ) );
                $minorLink = $this->makeOptionsLink( $showhide[1-$options['hideminor']],
                        array( 'hideminor' => 1-$options['hideminor'] ), $nondefaults);
                $botLink = $this->makeOptionsLink( $showhide[1-$options['hidebots']],
@@ -648,15 +727,15 @@ class SpecialRecentChanges extends SpecialPage {
                if( $wgUser->useRCPatrol() )
                        $links[] = wfMsgHtml( 'rcshowhidepatr', $patrLink );
                $links[] = wfMsgHtml( 'rcshowhidemine', $myselfLink );
-               $hl = implode( ' | ', $links );
+               $hl = $wgLang->pipeList( $links );
 
                // show from this onward link
                $now = $wgLang->timeanddate( wfTimestampNow(), true );
-               $tl =  $this->makeOptionsLink( $now, array( 'from' => wfTimestampNow()), $nondefaults );
+               $tl =  $this->makeOptionsLink( $now, array( 'from' => wfTimestampNow() ), $nondefaults );
 
-               $rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter'),
+               $rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter' ),
                        $cl, $dl, $hl );
-               $rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter'), $tl );
-               return "$note<br />$rclinks<br />$rclistfrom";
+               $rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter' ), $tl );
+               return "{$note}$rclinks<br />$rclistfrom";
        }
 }