protected function parseParams( $par ) {
$bits = preg_split( '/\s*,\s*/', trim( $par ) );
foreach ( $bits as $bit ) {
- if ( 'shownav' == $bit ) {
+ if ( $bit === 'shownav' ) {
$this->showNavigation = true;
}
- if ( 'hideliu' === $bit ) {
+ if ( $bit === 'hideliu' ) {
$this->opts->setValue( 'hideliu', true );
}
- if ( 'hidepatrolled' == $bit ) {
+ if ( $bit === 'hidepatrolled' ) {
$this->opts->setValue( 'hidepatrolled', true );
}
- if ( 'hidebots' == $bit ) {
+ if ( $bit === 'hidebots' ) {
$this->opts->setValue( 'hidebots', true );
}
- if ( 'showredirs' == $bit ) {
+ if ( $bit === 'showredirs' ) {
$this->opts->setValue( 'hideredirs', false );
}
if ( is_numeric( $bit ) ) {
$ut = Title::makeTitleSafe( NS_USER, $username );
$userText = $ut ? $ut->getText() : '';
- // Store query values in hidden fields so that form submission doesn't lose them
- $hidden = [];
- foreach ( $this->opts->getUnconsumedValues() as $key => $value ) {
- $hidden[] = Html::hidden( $key, $value );
- }
- $hidden = implode( "\n", $hidden );
-
$formDescriptor = [
'namespace' => [
'type' => 'namespaceselect',
];
$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext() );
+
+ // Store query values in hidden fields so that form submission doesn't lose them
+ foreach ( $this->opts->getUnconsumedValues() as $key => $value ) {
+ $htmlForm->addHiddenField( $key, $value );
+ }
+
$htmlForm
->setMethod( 'get' )
->setFormIdentifier( 'newpagesform' )
'div',
null,
$this->filterLinks()
- ) . $hidden )
+ ) )
->show();
$out->addModuleStyles( 'mediawiki.special' );
}