$this->request = $request;
$this->logger = $resourceLoader->getLogger();
- // Future developers: Use WebRequest::getRawVal() instead of getVal().
- // The getVal() method performs slow Language+UTF logic. (f303bb9360)
+ // Optimisation: Use WebRequest::getRawVal() instead of getVal(). We don't
+ // need the slow Language+UTF logic meant for user input here. (f303bb9360)
// List of modules
$modules = $request->getRawVal( 'modules' );
// Various parameters
$this->user = $request->getRawVal( 'user' );
$this->debug = $request->getRawVal( 'debug' ) === 'true';
- $this->only = $request->getRawVal( 'only', null );
- $this->version = $request->getRawVal( 'version', null );
+ $this->only = $request->getRawVal( 'only' );
+ $this->version = $request->getRawVal( 'version' );
$this->raw = $request->getFuzzyBool( 'raw' );
// Image requests
}
}
- /**
- * Reverse the process done by ResourceLoader::makePackedModulesString().
- *
- * @deprecated since 1.33 Use ResourceLoader::expandModuleNames instead.
- * @param string $modules Packed module name list
- * @return array Array of module names
- * @codeCoverageIgnore
- */
- public static function expandModuleNames( $modules ) {
- wfDeprecated( __METHOD__, '1.33' );
- return ResourceLoader::expandModuleNames( $modules );
- }
-
/**
* Return a dummy ResourceLoaderContext object suitable for passing into
* things that don't "really" need a context.
* @deprecated since 1.34 Use ResourceLoaderModule::getConfig instead
* inside module methods. Use ResourceLoader::getConfig elsewhere.
* @return Config
+ * @codeCoverageIgnore
*/
public function getConfig() {
+ wfDeprecated( __METHOD__, '1.34' );
return $this->getResourceLoader()->getConfig();
}
* @param string|string[]|MessageSpecifier $key Message key, or array of keys,
* or a MessageSpecifier.
* @param mixed $args,...
+ * @suppress PhanCommentParamWithoutRealParam HHVM bug T228695#5450847
* @return Message
*/
public function msg( $key ) {