Merge "Permit destructors in MediaWikiTestCaseTrait::createNoOpMock"

[lhc/web/wiklou.git] / includes / language / Message.php

diff --git a/includes/language/Message.php b/includes/language/Message.php
index 0b3113f..35cc348 100644 (file)
--- a/includes/language/Message.php
+++ b/includes/language/Message.php
@@ -20,6 +20,8 @@
  * @file
  * @author Niklas Laxström
  */
+
+use MediaWiki\Logger\LoggerFactory;
 use MediaWiki\MediaWikiServices;
 
 /**
@@ -156,6 +158,8 @@ use MediaWiki\MediaWikiServices;
  * @see https://www.mediawiki.org/wiki/Localisation
  *
  * @since 1.17
+ * @phan-file-suppress PhanCommentParamOnEmptyParamList Cannot make variadic due to HHVM bug,
+ *   T191668#5263929
  */
 class Message implements MessageSpecifier, Serializable {
        /** Use message text as-is */
@@ -402,6 +406,7 @@ class Message implements MessageSpecifier, Serializable {
         *
         * @param string|string[]|MessageSpecifier $key
         * @param mixed $param,... Parameters as strings.
+        * @suppress PhanCommentParamWithoutRealParam HHVM bug T228695#5450847
         *
         * @return Message
         */
@@ -856,7 +861,7 @@ class Message implements MessageSpecifier, Serializable {
        public function toString( $format = null ) {
                if ( $format === null ) {
                        $ex = new LogicException( __METHOD__ . ' using implicit format: ' . $this->format );
-                       \MediaWiki\Logger\LoggerFactory::getInstance( 'message-format' )->warning(
+                       LoggerFactory::getInstance( 'message-format' )->warning(
                                $ex->getMessage(), [ 'exception' => $ex, 'format' => $this->format, 'key' => $this->key ] );
                        $format = $this->format;
                }
@@ -1206,7 +1211,7 @@ class Message implements MessageSpecifier, Serializable {
                                if ( !is_scalar( $param ) ) {
                                        $param = serialize( $param );
                                }
-                               \MediaWiki\Logger\LoggerFactory::getInstance( 'Bug58676' )->warning(
+                               LoggerFactory::getInstance( 'Bug58676' )->warning(
                                        'Invalid parameter for message "{msgkey}": {param}',
                                        [
                                                'exception' => new Exception,