A few more ok -> done
[lhc/web/wiklou.git] / includes / installer / WebInstallerPage.php
index 65fa0a2..80c939b 100644 (file)
@@ -32,6 +32,15 @@ abstract class WebInstallerPage {
                $this->parent = $parent;
        }
 
+       /**
+        * Is this a slow-running page in the installer? If so, WebInstaller will
+        * set_time_limit(0) before calling execute(). Right now this only applies
+        * to Install and Upgrade pages
+        */
+       public function isSlow() {
+               return false;
+       }
+
        public function addHTML( $html ) {
                $this->parent->output->addHTML( $html );
        }
@@ -60,7 +69,8 @@ abstract class WebInstallerPage {
                if ( $continue ) {
                        // Fake submit button for enter keypress (bug 26267)
                        $s .= Xml::submitButton( wfMsg( "config-$continue" ),
-                               array( 'name' => "enter-$continue", 'style' => 'visibility:hidden;overflow:hidden;width:1px;margin:0' ) ) . "\n";
+                               array( 'name' => "enter-$continue", 'style' =>
+                                       'visibility:hidden;overflow:hidden;width:1px;margin:0' ) ) . "\n";
                }
 
                if ( $back ) {
@@ -113,7 +123,7 @@ abstract class WebInstallerPage {
        /**
         * Get the end tag of a fieldset.
         *
-        * @returns string
+        * @return string
         */
        protected function getFieldsetEnd() {
                return "</fieldset>\n";
@@ -124,9 +134,11 @@ abstract class WebInstallerPage {
         */
        protected function startLiveBox() {
                $this->addHTML(
-                       '<div id="config-spinner" style="display:none;"><img src="../skins/common/images/ajax-loader.gif" /></div>' .
+                       '<div id="config-spinner" style="display:none;">' .
+                       '<img src="../skins/common/images/ajax-loader.gif" /></div>' .
                        '<script>jQuery( "#config-spinner" ).show();</script>' .
-                       '<textarea id="config-live-log" name="LiveLog" rows="10" cols="30" readonly="readonly">'
+                       '<div id="config-live-log">' .
+                       '<textarea name="LiveLog" rows="10" cols="30" readonly="readonly">'
                );
                $this->parent->output->flush();
        }
@@ -135,7 +147,7 @@ abstract class WebInstallerPage {
         * Opposite to startLiveBox()
         */
        protected function endLiveBox() {
-               $this->addHTML( '</textarea>
+               $this->addHTML( '</textarea></div>
 <script>jQuery( "#config-spinner" ).hide()</script>' );
                $this->parent->output->flush();
        }
@@ -146,7 +158,7 @@ class WebInstaller_Language extends WebInstallerPage {
        public function execute() {
                global $wgLang;
                $r = $this->parent->request;
-               $userLang = $r->getVal( 'UserLang' );
+               $userLang = $r->getVal( 'userlang' );
                $contLang = $r->getVal( 'ContLang' );
 
                $lifetime = intval( ini_get( 'session.gc_maxlifetime' ) );
@@ -181,7 +193,8 @@ class WebInstaller_Language extends WebInstallerPage {
                } elseif ( $this->parent->showSessionWarning ) {
                        # The user was knocked back from another page to the start
                        # This probably indicates a session expiry
-                       $this->parent->showError( 'config-session-expired', $wgLang->formatTimePeriod( $lifetime ) );
+                       $this->parent->showError( 'config-session-expired',
+                               $wgLang->formatTimePeriod( $lifetime ) );
                }
 
                $this->parent->setSession( 'test', true );
@@ -194,8 +207,10 @@ class WebInstaller_Language extends WebInstallerPage {
                }
                $this->startForm();
                $s = Html::hidden( 'LanguageRequestTime', time() ) .
-                       $this->getLanguageSelector( 'UserLang', 'config-your-language', $userLang, $this->parent->getHelpBox( 'config-your-language-help' ) ) .
-                       $this->getLanguageSelector( 'ContLang', 'config-wiki-language', $contLang, $this->parent->getHelpBox( 'config-wiki-language-help' ) );
+                       $this->getLanguageSelector( 'userlang', 'config-your-language', $userLang,
+                               $this->parent->getHelpBox( 'config-your-language-help' ) ) .
+                       $this->getLanguageSelector( 'ContLang', 'config-wiki-language', $contLang,
+                               $this->parent->getHelpBox( 'config-wiki-language-help' ) );
                $this->addHTML( $s );
                $this->endForm( 'continue', false );
        }
@@ -203,6 +218,10 @@ class WebInstaller_Language extends WebInstallerPage {
        /**
         * Get a <select> for selecting languages.
         *
+        * @param $name
+        * @param $label
+        * @param $selectedCode
+        * @param $helpHtml string
         * @return string
         */
        public function getLanguageSelector( $name, $label, $selectedCode, $helpHtml = '' ) {
@@ -210,13 +229,13 @@ class WebInstaller_Language extends WebInstallerPage {
 
                $s = $helpHtml;
 
-               $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name ) ) . "\n";
+               $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name,
+                               'tabindex' => $this->parent->nextTabIndex() ) ) . "\n";
 
                $languages = Language::getLanguageNames();
                ksort( $languages );
-               $dummies = array_flip( $wgDummyLanguageCodes );
                foreach ( $languages as $code => $lang ) {
-                       if ( isset( $dummies[$code] ) ) continue;
+                       if ( isset( $wgDummyLanguageCodes[$code] ) ) continue;
                        $s .= "\n" . Xml::option( "$code - $lang", $code, $code == $selectedCode );
                }
                $s .= "\n</select>\n";
@@ -327,7 +346,8 @@ class WebInstaller_ExistingWiki extends WebInstallerPage {
         */
        protected function handleExistingUpgrade( $vars ) {
                // Check $wgDBtype
-               if ( !isset( $vars['wgDBtype'] ) || !in_array( $vars['wgDBtype'], Installer::getDBTypes() ) ) {
+               if ( !isset( $vars['wgDBtype'] ) ||
+                        !in_array( $vars['wgDBtype'], Installer::getDBTypes() ) ) {
                        return Status::newFatal( 'config-localsettings-connection-error', '' );
                }
 
@@ -417,7 +437,7 @@ class WebInstaller_DBConnect extends WebInstallerPage {
 
                $dbSupport = '';
                foreach( $this->parent->getDBTypes() as $type ) {
-                       $link = DatabaseBase::newFromType( $type )->getSoftwareLink();
+                       $link = DatabaseBase::factory( $type )->getSoftwareLink();
                        $dbSupport .= wfMsgNoTrans( "config-support-$type", $link ) . "\n";
                }
                $this->addHTML( $this->parent->getInfoBox(
@@ -438,12 +458,13 @@ class WebInstaller_DBConnect extends WebInstallerPage {
                                "</li>\n";
 
                        $settings .=
-                               Html::openElement( 'div', array( 'id' => 'DB_wrapper_' . $type, 'class' => 'dbWrapper' ) ) .
+                               Html::openElement( 'div', array( 'id' => 'DB_wrapper_' . $type,
+                                               'class' => 'dbWrapper' ) ) .
                                Html::element( 'h3', array(), wfMsg( 'config-header-' . $type ) ) .
                                $installer->getConnectForm() .
                                "</div>\n";
                }
-               $types .= "</ul><br clear=\"left\"/>\n";
+               $types .= "</ul><br style=\"clear: left\"/>\n";
 
                $this->addHTML(
                        $this->parent->label( 'config-db-type', false, $types ) .
@@ -467,6 +488,9 @@ class WebInstaller_DBConnect extends WebInstallerPage {
 }
 
 class WebInstaller_Upgrade extends WebInstallerPage {
+       public function isSlow() {
+               return true;
+       }
 
        public function execute() {
                if ( $this->getVar( '_UpgradeDone' ) ) {
@@ -531,7 +555,7 @@ class WebInstaller_Upgrade extends WebInstallerPage {
                $this->addHTML(
                        $this->parent->getInfoBox(
                                wfMsgNoTrans( $msg,
-                                       $GLOBALS['wgServer'] .
+                                       $this->getVar( 'wgServer' ) .
                                                $this->getVar( 'wgScriptPath' ) . '/index' .
                                                $this->getVar( 'wgScriptExtension' )
                                ), 'tick-32.png'
@@ -608,7 +632,8 @@ class WebInstaller_Name extends WebInstallerPage {
                                'label' => 'config-project-namespace',
                                'itemLabelPrefix' => 'config-ns-',
                                'values' => array( 'site-name', 'generic', 'other' ),
-                               'commonAttribs' => array( 'class' => 'enableForOther', 'rel' => 'config_wgMetaNamespace' ),
+                               'commonAttribs' => array( 'class' => 'enableForOther',
+                                       'rel' => 'config_wgMetaNamespace' ),
                                'help' => $this->parent->getHelpBox( 'config-project-namespace-help' )
                        ) ) .
                        $this->parent->getTextBox( array(
@@ -754,10 +779,16 @@ class WebInstaller_Name extends WebInstallerPage {
 
                // Validate e-mail if provided
                $email = $this->getVar( '_AdminEmail' );
-               if( $email && !User::isValidEmailAddr( $email ) ) {
+               if( $email && !Sanitizer::validateEmail( $email ) ) {
                        $this->parent->showError( 'config-admin-error-bademail' );
                        $retVal = false;
                }
+               // If they asked to subscribe to mediawiki-announce but didn't give
+               // an e-mail, show an error. Bug 29332
+               if( !$email && $this->getVar( '_Subscribe' ) ) {
+                       $this->parent->showError( 'config-subscribe-noemail' );
+                       $retVal = false;
+               }
 
                return $retVal;
        }
@@ -876,12 +907,14 @@ class WebInstaller_Options extends WebInstallerPage {
                        $this->parent->getTextBox( array(
                                'var' => 'wgDeletedDirectory',
                                'label' => 'config-upload-deleted',
+                               'attribs' => array( 'dir' => 'ltr' ),
                                'help' => $this->parent->getHelpBox( 'config-upload-deleted-help' )
                        ) ) .
                        '</div>' .
                        $this->parent->getTextBox( array(
                                'var' => 'wgLogo',
                                'label' => 'config-logo',
+                               'attribs' => array( 'dir' => 'ltr' ),
                                'help' => $this->parent->getHelpBox( 'config-logo-help' )
                        ) )
                );
@@ -900,6 +933,15 @@ class WebInstaller_Options extends WebInstallerPage {
                }
                $caches[] = 'memcached';
 
+               // We'll hide/show this on demand when the value changes, see config.js.
+               $cacheval = $this->getVar( 'wgMainCacheType' );
+               if (!$cacheval) {
+                       // We need to set a default here; but don't hardcode it
+                       // or we lose it every time we reload the page for validation
+                       // or going back!
+                       $cacheval = 'none';
+               }
+               $hidden = ($cacheval == 'memcached') ? '' : 'display: none';
                $this->addHTML(
                        # Advanced settings
                        $this->getFieldSetStart( 'config-advanced-settings' ) .
@@ -909,10 +951,10 @@ class WebInstaller_Options extends WebInstallerPage {
                                'label' => 'config-cache-options',
                                'itemLabelPrefix' => 'config-cache-',
                                'values' => $caches,
-                               'value' => 'none',
+                               'value' => $cacheval,
                        ) ) .
                        $this->parent->getHelpBox( 'config-cache-help' ) .
-                       '<div id="config-memcachewrapper">' .
+                       "<div id=\"config-memcachewrapper\" style=\"$hidden\">" .
                        $this->parent->getTextArea( array(
                                'var' => '_MemCachedServers',
                                'label' => 'config-memcached-servers',
@@ -928,8 +970,8 @@ class WebInstaller_Options extends WebInstallerPage {
         * @return string
         */
        public function getCCPartnerUrl() {
-               global $wgServer;
-               $exitUrl = $wgServer . $this->parent->getUrl( array(
+               $server = $this->getVar( 'wgServer' );
+               $exitUrl = $server . $this->parent->getUrl( array(
                        'page' => 'Options',
                        'SubmitCC' => 'indeed',
                        'config__LicenseCode' => 'cc',
@@ -937,7 +979,7 @@ class WebInstaller_Options extends WebInstallerPage {
                        'config_wgRightsText' => '[license_name]',
                        'config_wgRightsIcon' => '[license_button]',
                ) );
-               $styleUrl = $wgServer . dirname( dirname( $this->parent->getUrl() ) ) .
+               $styleUrl = $server . dirname( dirname( $this->parent->getUrl() ) ) .
                        '/skins/common/config-cc.css';
                $iframeUrl = 'http://creativecommons.org/license/?' .
                        wfArrayToCGI( array(
@@ -1061,8 +1103,10 @@ class WebInstaller_Options extends WebInstallerPage {
                        }
 
                        foreach( $memcServers as $server ) {
-                               $memcParts = explode( ":", $server );
-                               if( !IP::isValid( $memcParts[0] ) ) {
+                               $memcParts = explode( ":", $server, 2 );
+                               if ( !isset( $memcParts[0] )
+                                               || ( !IP::isValid( $memcParts[0] )
+                                                       && ( gethostbyname( $memcParts[0] ) == $memcParts[0] ) ) ) {
                                        $this->parent->showError( 'config-memcache-badip', $memcParts[0] );
                                        return false;
                                } elseif( !isset( $memcParts[1] )  ) {
@@ -1080,6 +1124,9 @@ class WebInstaller_Options extends WebInstallerPage {
 }
 
 class WebInstaller_Install extends WebInstallerPage {
+       public function isSlow() {
+               return true;
+       }
 
        public function execute() {
                if( $this->getVar( '_UpgradeDone' ) ) {
@@ -1141,11 +1188,13 @@ class WebInstaller_Complete extends WebInstallerPage {
        public function execute() {
                // Pop up a dialog box, to make it difficult for the user to forget
                // to download the file
-               $lsUrl = $GLOBALS['wgServer'] . $this->parent->getURL( array( 'localsettings' => 1 ) );
-               if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && strpos( $_SERVER['HTTP_USER_AGENT'], 'MSIE' ) !== false ) {
+               $lsUrl = $this->getVar( 'wgServer' ) . $this->parent->getURL( array( 'localsettings' => 1 ) );
+               if ( isset( $_SERVER['HTTP_USER_AGENT'] ) &&
+                        strpos( $_SERVER['HTTP_USER_AGENT'], 'MSIE' ) !== false ) {
                        // JS appears the only method that works consistently with IE7+
-                       $this->addHtml( "\n<script type=\"" . $GLOBALS['wgJsMimeType'] . '">jQuery( document ).ready( function() { document.location='
-                               . Xml::encodeJsVar( $lsUrl) . "; } );</script>\n" );
+                       $this->addHtml( "\n<script type=\"" . $GLOBALS['wgJsMimeType'] .
+                               '">jQuery( document ).ready( function() { document.location=' .
+                               Xml::encodeJsVar( $lsUrl) . "; } );</script>\n" );
                } else {
                        $this->parent->request->response()->header( "Refresh: 0;url=$lsUrl" );
                }
@@ -1156,7 +1205,7 @@ class WebInstaller_Complete extends WebInstallerPage {
                        $this->parent->getInfoBox(
                                wfMsgNoTrans( 'config-install-done',
                                        $lsUrl,
-                                       $GLOBALS['wgServer'] .
+                                       $this->getVar( 'wgServer' ) .
                                                $this->getVar( 'wgScriptPath' ) . '/index' .
                                                $this->getVar( 'wgScriptExtension' ),
                                        '<downloadlink/>'
@@ -1194,45 +1243,16 @@ abstract class WebInstaller_Document extends WebInstallerPage {
 
        public  function execute() {
                $text = $this->getFileContents();
-               $text = $this->formatTextFile( $text );
+               $text = InstallDocFormatter::format( $text );
                $this->parent->output->addWikiText( $text );
                $this->startForm();
                $this->endForm( false );
        }
 
-       public  function getFileContents() {
+       public function getFileContents() {
                return file_get_contents( dirname( __FILE__ ) . '/../../' . $this->getFileName() );
        }
 
-       protected function formatTextFile( $text ) {
-               // Use Unix line endings, escape some wikitext stuff
-               $text = str_replace( array( '<', '{{', '[[', "\r" ),
-                       array( '&lt;', '&#123;&#123;', '&#91;&#91;', '' ), $text );
-               // join word-wrapped lines into one
-               do {
-                       $prev = $text;
-                       $text = preg_replace( "/\n([\\*#\t])([^\n]*?)\n([^\n#\\*:]+)/", "\n\\1\\2 \\3", $text );
-               } while ( $text != $prev );
-               // Replace tab indents with colons
-               $text = preg_replace( '/^\t\t/m', '::', $text );
-               $text = preg_replace( '/^\t/m', ':', $text );
-               // turn (bug nnnn) into links
-               $text = preg_replace_callback('/bug (\d+)/', array( $this, 'replaceBugLinks' ), $text );
-               // add links to manual to every global variable mentioned
-               $text = preg_replace_callback('/(\$wg[a-z0-9_]+)/i', array( $this, 'replaceConfigLinks' ), $text );
-               return $text;
-       }
-
-       private function replaceBugLinks( $matches ) {
-               return '<span class="config-plainlink">[https://bugzilla.wikimedia.org/' .
-                       $matches[1] . ' bug ' . $matches[1] . ']</span>';
-       }
-
-       private function replaceConfigLinks( $matches ) {
-               return '<span class="config-plainlink">[http://www.mediawiki.org/wiki/Manual:' .
-                       $matches[1] . ' ' . $matches[1] . ']</span>';
-       }
-
 }
 
 class WebInstaller_Readme extends WebInstaller_Document {