Merge "(bug 19195) Make user IDs more readily available with the API"
[lhc/web/wiklou.git] / includes / api / ApiQueryUsers.php
index fa90c38..a07ee7f 100644 (file)
  * @file
  */
 
-if ( !defined( 'MEDIAWIKI' ) ) {
-       // Eclipse helper - will be ignored in production
-       require_once( 'ApiQueryBase.php' );
-}
-
 /**
  * Query module to get information about a list of users
  *
  * @ingroup API
  */
- class ApiQueryUsers extends ApiQueryBase {
+class ApiQueryUsers extends ApiQueryBase {
 
        private $tokenFunctions, $prop;
 
@@ -66,11 +61,15 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                return $this->tokenFunctions;
        }
 
+       /**
+        * @param $user User
+        * @return String
+        */
        public static function getUserrightsToken( $user ) {
                global $wgUser;
                // Since the permissions check for userrights is non-trivial,
                // don't bother with it here
-               return $wgUser->editToken( $user->getName() );
+               return $wgUser->getEditToken( $user->getName() );
        }
 
        public function execute() {
@@ -104,31 +103,29 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                        }
                }
 
+               $result = $this->getResult();
+
                if ( count( $goodNames ) ) {
-                       $this->addTables( 'user', 'u1' );
-                       $this->addFields( 'u1.*' );
-                       $this->addWhereFld( 'u1.user_name', $goodNames );
+                       $this->addTables( 'user' );
+                       $this->addFields( '*' );
+                       $this->addWhereFld( 'user_name', $goodNames );
 
-                       if ( isset( $this->prop['groups'] ) ) {
+                       if ( isset( $this->prop['groups'] ) || isset( $this->prop['rights'] ) ) {
                                $this->addTables( 'user_groups' );
-                               $this->addJoinConds( array( 'user_groups' => array( 'LEFT JOIN', 'ug_user=u1.user_id' ) ) );
+                               $this->addJoinConds( array( 'user_groups' => array( 'LEFT JOIN', 'ug_user=user_id' ) ) );
                                $this->addFields( 'ug_group' );
                        }
-                       if ( isset( $this->prop['blockinfo'] ) ) {
-                               $this->addTables( 'ipblocks' );
-                               $this->addTables( 'user', 'u2' );
-                               $u2 = $this->getAliasedName( 'user', 'u2' );
-                               $this->addJoinConds( array(
-                                       'ipblocks' => array( 'LEFT JOIN', 'ipb_user=u1.user_id' ),
-                                       $u2 => array( 'LEFT JOIN', 'ipb_by=u2.user_id' ) ) );
-                               $this->addFields( array( 'ipb_reason', 'u2.user_name AS blocker_name', 'ipb_expiry' ) );
-                       }
+
+                       $this->showHiddenUsersAddBlockInfo( isset( $this->prop['blockinfo'] ) );
 
                        $data = array();
                        $res = $this->select( __METHOD__ );
+
                        foreach ( $res as $row ) {
                                $user = User::newFromRow( $row );
                                $name = $user->getName();
+
+                               $data[$name]['userid'] = $user->getId();
                                $data[$name]['name'] = $name;
 
                                if ( isset( $this->prop['editcount'] ) ) {
@@ -139,19 +136,38 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                                        $data[$name]['registration'] = wfTimestampOrNull( TS_ISO_8601, $user->getRegistration() );
                                }
 
-                               if ( isset( $this->prop['groups'] ) && !is_null( $row->ug_group ) ) {
-                                       // This row contains only one group, others will be added from other rows
-                                       $data[$name]['groups'][] = $row->ug_group;
+                               if ( isset( $this->prop['groups'] ) ) {
+                                       if ( !isset( $data[$name]['groups'] ) ) {
+                                               $data[$name]['groups'] = self::getAutoGroups( $user );
+                                       }
+
+                                       if ( !is_null( $row->ug_group ) ) {
+                                               // This row contains only one group, others will be added from other rows
+                                               $data[$name]['groups'][] = $row->ug_group;
+                                       }
                                }
 
-                               if ( isset( $this->prop['rights'] ) && !isset( $data[$name]['rights'] ) ) {
-                                       // User::getRights() may return duplicate values, strip them
-                                       $data[$name]['rights'] = array_values( array_unique( $user->getRights() ) );
-                                       $result->setIndexedTagName( $data[$name]['rights'], 'r' );      // even if empty
+                               if ( isset( $this->prop['implicitgroups'] ) && !isset( $data[$name]['implicitgroups'] ) ) {
+                                       $data[$name]['implicitgroups'] =  self::getAutoGroups( $user );
                                }
 
-                               if ( isset( $this->prop['blockinfo'] ) && !is_null( $row->blocker_name ) ) {
-                                       $data[$name]['blockedby'] = $row->blocker_name;
+                               if ( isset( $this->prop['rights'] ) ) {
+                                       if ( !isset( $data[$name]['rights'] ) ) {
+                                               $data[$name]['rights'] = User::getGroupPermissions( $user->getAutomaticGroups() );
+                                       }
+
+                                       if ( !is_null( $row->ug_group ) ) {
+                                               $data[$name]['rights'] = array_unique( array_merge( $data[$name]['rights'],
+                                                       User::getGroupPermissions( array( $row->ug_group ) ) ) );
+                                       }
+                               }
+                               if ( $row->ipb_deleted ) {
+                                       $data[$name]['hidden'] = '';
+                               }
+                               if ( isset( $this->prop['blockinfo'] ) && !is_null( $row->ipb_by_text ) ) {
+                                       $data[$name]['blockid'] = $row->ipb_id;
+                                       $data[$name]['blockedby'] = $row->ipb_by_text;
+                                       $data[$name]['blockedbyid'] = $row->ipb_by;
                                        $data[$name]['blockreason'] = $row->ipb_reason;
                                        $data[$name]['blockexpiry'] = $row->ipb_expiry;
                                }
@@ -181,6 +197,7 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                                }
                        }
                }
+
                // Second pass: add result data to $retval
                foreach ( $goodNames as $u ) {
                        if ( !isset( $data[$u] ) ) {
@@ -208,13 +225,16 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                                }
                        } else {
                                if ( isset( $this->prop['groups'] ) && isset( $data[$u]['groups'] ) ) {
-                                       $autolist = ApiQueryUsers::getAutoGroups( User::newFromName( $u ) );
-
-                                       $data[$u]['groups'] = array_merge( $autolist, $data[$u]['groups'] );
-
-                                       $this->getResult()->setIndexedTagName( $data[$u]['groups'], 'g' );
+                                       $result->setIndexedTagName( $data[$u]['groups'], 'g' );
+                               }
+                               if ( isset( $this->prop['implicitgroups'] ) && isset( $data[$u]['implicitgroups'] ) ) {
+                                       $result->setIndexedTagName( $data[$u]['implicitgroups'], 'g' );
+                               }
+                               if ( isset( $this->prop['rights'] ) && isset( $data[$u]['rights'] ) ) {
+                                       $result->setIndexedTagName( $data[$u]['rights'], 'r' );
                                }
                        }
+
                        $fit = $result->addValue( array( 'query', $this->getModuleName() ),
                                        null, $data[$u] );
                        if ( !$fit ) {
@@ -224,15 +244,17 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                        }
                        $done[] = $u;
                }
-               return $this->getResult()->setIndexedTagName_internal( array( 'query', $this->getModuleName() ), 'user' );
+               return $result->setIndexedTagName_internal( array( 'query', $this->getModuleName() ), 'user' );
        }
 
        /**
-       * Gets all the groups that a user is automatically a member of
+       * Gets all the groups that a user is automatically a member of (implicit groups)
+       * @param $user User
        * @return array
        */
        public static function getAutoGroups( $user ) {
-               $groups = array( '*' );
+               $groups = array();
+               $groups[] = '*';
 
                if ( !$user->isAnon() ) {
                        $groups[] = 'user';
@@ -245,7 +267,7 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                if ( isset( $params['token'] ) ) {
                        return 'private';
                } else {
-                       return 'public';
+                       return 'anon-public-user-private';
                }
        }
 
@@ -257,6 +279,7 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                                ApiBase::PARAM_TYPE => array(
                                        'blockinfo',
                                        'groups',
+                                       'implicitgroups',
                                        'rights',
                                        'editcount',
                                        'registration',
@@ -278,13 +301,14 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                return array(
                        'prop' => array(
                                'What pieces of information to include',
-                               '  blockinfo    - Tags if the user is blocked, by whom, and for what reason',
-                               '  groups       - Lists all the groups the user(s) belongs to',
-                               '  rights       - Lists all the rights the user(s) has',
-                               '  editcount    - Adds the user\'s edit count',
-                               '  registration - Adds the user\'s registration timestamp',
-                               '  emailable    - Tags if the user can and wants to receive e-mail through [[Special:Emailuser]]',
-                               '  gender       - Tags the gender of the user. Returns "male", "female", or "unknown"',
+                               '  blockinfo      - Tags if the user is blocked, by whom, and for what reason',
+                               '  groups         - Lists all the groups the user(s) belongs to',
+                               '  implicitgroups - Lists all the groups a user is automatically a member of',
+                               '  rights         - Lists all the rights the user(s) has',
+                               '  editcount      - Adds the user\'s edit count',
+                               '  registration   - Adds the user\'s registration timestamp',
+                               '  emailable      - Tags if the user can and wants to receive e-mail through [[Special:Emailuser]]',
+                               '  gender         - Tags the gender of the user. Returns "male", "female", or "unknown"',
                        ),
                        'users' => 'A list of users to obtain the same information for',
                        'token' => 'Which tokens to obtain for each user',
@@ -295,10 +319,14 @@ if ( !defined( 'MEDIAWIKI' ) ) {
                return 'Get information about a list of users';
        }
 
-       protected function getExamples() {
+       public function getExamples() {
                return 'api.php?action=query&list=users&ususers=brion|TimStarling&usprop=groups|editcount|gender';
        }
 
+       public function getHelpUrls() {
+               return 'https://www.mediawiki.org/wiki/API:Users';
+       }
+
        public function getVersion() {
                return __CLASS__ . ': $Id$';
        }