Fix the last assignment in conditional, bit of code duplication, as the next isn...
[lhc/web/wiklou.git] / includes / api / ApiDelete.php
index 22360fb..0eba219 100644 (file)
@@ -1,10 +1,10 @@
 <?php
-
-/*
+/**
+ *
+ *
  * Created on Jun 30, 2007
- * API for MediaWiki 1.8+
  *
- * Copyright (C) 2007 Roan Kattouw <Firstname>.<Lastname>@home.nl
+ * Copyright © 2007 Roan Kattouw <Firstname>.<Lastname>@gmail.com
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  *
  * You should have received a copy of the GNU General Public License along
  * with this program; if not, write to the Free Software Foundation, Inc.,
- * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
  */
 
-if (!defined('MEDIAWIKI')) {
+if ( !defined( 'MEDIAWIKI' ) ) {
        // Eclipse helper - will be ignored in production
-       require_once ("ApiBase.php");
+       require_once( "ApiBase.php" );
 }
 
-
 /**
- * API module that facilitates deleting pages. The API eqivalent of action=delete. 
+ * API module that facilitates deleting pages. The API equivalent of action=delete.
  * Requires API write mode to be enabled.
  *
- * @addtogroup API
+ * @ingroup API
  */
 class ApiDelete extends ApiBase {
 
-       public function __construct($main, $action) {
-               parent :: __construct($main, $action);
+       public function __construct( $main, $action ) {
+               parent::__construct( $main, $action );
        }
 
-       /* Return values for the delete function. */
-       const DELETE_SUCCESS = 0;
-       const DELETE_PERM = 1;
-       const DELETE_BLOCKED = 2;
-       const DELETE_READONLY = 3;
-       const DELETE_BADTOKEN = 4;
-       const DELETE_BADARTICLE = 5;
-
        /**
         * Extracts the title, token, and reason from the request parameters and invokes
-        * the local delete() function with these as arguments. It does not make use of 
-        * the delete function specified by Article.php. If the deletion succeeds, the 
-        * details of the article deleted and the reason for deletion are added to the 
+        * the local delete() function with these as arguments. It does not make use of
+        * the delete function specified by Article.php. If the deletion succeeds, the
+        * details of the article deleted and the reason for deletion are added to the
         * result object.
         */
        public function execute() {
-               global $wgUser;
-               $this->getMain()->requestWriteMode();
                $params = $this->extractRequestParams();
-               
-               $titleObj = NULL;
-               if(!isset($params['title']))
-                       $this->dieUsage('The title parameter must be set', 'notitle');
-               if(!isset($params['token']))
-                       $this->dieUsage('The token parameter must be set', 'notoken');
-
-               // delete() also checks for these, but we wanna save some work
-               if(!$wgUser->isAllowed('delete'))
-                       $this->dieUsage('You don\'t have permission to delete pages', 'permissiondenied');
-               if($wgUser->isBlocked())
-                       $this->dieUsage('You have been blocked from editing', 'blocked');
-               if(wfReadOnly())
-                       $this->dieUsage('The wiki is in read-only mode', 'readonly');
-
-               $titleObj = Title::newFromText($params['title']);
-               if(!$titleObj)
-                       $this->dieUsage("Bad title ``{$params['title']}''", 'invalidtitle');
-               if(!$titleObj->exists())
-                       $this->dieUsage("``{$params['title']}'' doesn't exist", 'missingtitle');
-
-               $articleObj = new Article($titleObj);
-               $reason = (isset($params['reason']) ? $params['reason'] : NULL);
-               $dbw = wfGetDb(DB_MASTER);
-               $dbw->begin();
-               $retval = self::delete(&$articleObj, $params['token'], &$reason);
-
-               switch($retval)
-               {
-                       case self::DELETE_SUCCESS:
-                               break; // We'll deal with that later
-                       case self::DELETE_PERM:  // If we get PERM, BLOCKED or READONLY that's weird, but it's possible
-                               $this->dieUsage('You don\'t have permission to delete', 'permissiondenied');
-                       case self::DELETE_BLOCKED:
-                               $this->dieUsage('You have been blocked from editing', 'blocked');
-                       case self::DELETE_READONLY:
-                               $this->dieUsage('The wiki is in read-only mode', 'readonly');
-                       case self::DELETE_BADTOKEN:
-                               $this->dieUsage('Invalid token', 'badtoken');
-                       case self::DELETE_BADARTICLE:
-                               $this->dieUsage("The article ``{$params['title']}'' doesn't exist or has already been deleted", 'missingtitle');
-                       default:
-                               // delete() has apparently invented a new error, which is extremely weird
-                               $this->dieDebug(__METHOD__, "delete() returned an unknown error ($retval)");
+
+               $this->requireOnlyOneParameter( $params, 'title', 'pageid' );
+
+               if ( isset( $params['title'] ) ) {
+                       $titleObj = Title::newFromText( $params['title'] );
+                       if ( !$titleObj ) {
+                               $this->dieUsageMsg( array( 'invalidtitle', $params['title'] ) );
+                       }
+               } elseif ( isset( $params['pageid'] ) ) {
+                       $titleObj = Title::newFromID( $params['pageid'] );
+                       if ( !$titleObj ) {
+                               $this->dieUsageMsg( array( 'nosuchpageid', $params['pageid'] ) );
+                       }
+               }
+               if ( !$titleObj->exists() ) {
+                       $this->dieUsageMsg( array( 'notanarticle' ) );
+               }
+
+               $reason = ( isset( $params['reason'] ) ? $params['reason'] : null );
+               if ( $titleObj->getNamespace() == NS_FILE ) {
+                       $retval = self::deleteFile( $params['token'], $titleObj, $params['oldimage'], $reason, false );
+                       if ( count( $retval ) ) {
+                               $this->dieUsageMsg( reset( $retval ) ); // We don't care about multiple errors, just report one of them
+                       }
+               } else {
+                       $articleObj = new Article( $titleObj );
+                       $retval = self::delete( $articleObj, $params['token'], $reason );
+
+                       if ( count( $retval ) ) {
+                               $this->dieUsageMsg( reset( $retval ) ); // We don't care about multiple errors, just report one of them
+                       }
+
+                       // Deprecated parameters
+                       if ( $params['watch'] ) {
+                               $watch = 'watch';
+                       } elseif ( $params['unwatch'] ) {
+                               $watch = 'unwatch';
+                       } else {
+                               $watch = $params['watchlist'];
+                       }
+                       $this->setWatch( $watch, $titleObj, 'watchdeletion' );
                }
-               // $retval has to be self::DELETE_SUCCESS if we get here
-               $dbw->commit();
-               $r = array('title' => $titleObj->getPrefixedText(), 'reason' => $reason);
-               $this->getResult()->addValue(null, $this->getModuleName(), $r);
+
+               $r = array( 'title' => $titleObj->getPrefixedText(), 'reason' => $reason );
+               $this->getResult()->addValue( null, $this->getModuleName(), $r );
        }
 
        /**
-        * We have our own delete() function, since Article.php's implementation is split in two phases
         *
-        * @param Article $article - Article object to work on
-        * @param string $token - Delete token (same as edit token)
-        * @param string $reason - Reason for the deletion. Autogenerated if NULL
-        * @return DELETE_SUCCESS on success, DELETE_* on failure
+        * @param &$title Title
+        * @param $token String
         */
-       public static function delete(&$article, $token, &$reason = NULL)
-       {
+       private static function getPermissionsError( &$title, $token ) {
                global $wgUser;
 
-               // Check permissions first
-               if(!$article->mTitle->userCan('delete'))
-                       return self::DELETE_PERM;
-               if($wgUser->isBlocked())
-                       return self::DELETE_BLOCKED;
-               if(wfReadOnly())
-                       return self::DELETE_READONLY;
+               // Check permissions
+               $errors = $title->getUserPermissionsErrors( 'delete', $wgUser );
+               if ( count( $errors ) > 0 ) {
+                       return $errors;
+               }
 
-               // Check token
-               if(!$wgUser->matchEditToken($token))
-                       return self::DELETE_BADTOKEN;
+               return array();
+       }
+
+       /**
+        * We have our own delete() function, since Article.php's implementation is split in two phases
+        *
+        * @param $article Article object to work on
+        * @param $token String: delete token (same as edit token)
+        * @param $reason String: reason for the deletion. Autogenerated if NULL
+        * @return Title::getUserPermissionsErrors()-like array
+        */
+       public static function delete( &$article, $token, &$reason = null ) {
+               global $wgUser;
+               if ( $article->isBigDeletion() && !$wgUser->isAllowed( 'bigdelete' ) ) {
+                       global $wgDeleteRevisionsLimit;
+                       return array( array( 'delete-toobig', $wgDeleteRevisionsLimit ) );
+               }
+               $title = $article->getTitle();
+               $errors = self::getPermissionsError( $title, $token );
+               if ( count( $errors ) ) {
+                       return $errors;
+               }
 
                // Auto-generate a summary, if necessary
-               if(is_null($reason))
-               {
-                       $reason = $article->generateReason($hasHistory);
-                       if($reason === false)
-                               return self::DELETE_BADARTICLE;
+               if ( is_null( $reason ) ) {
+                       // Need to pass a throwaway variable because generateReason expects
+                       // a reference
+                       $hasHistory = false;
+                       $reason = $article->generateReason( $hasHistory );
+                       if ( $reason === false ) {
+                               return array( array( 'cannotdelete' ) );
+                       }
                }
 
+               $error = '';
                // Luckily, Article.php provides a reusable delete function that does the hard work for us
-               if($article->doDeleteArticle($reason))
-                       return self::DELETE_SUCCESS;
-               return self::DELETE_BADARTICLE;
+               if ( $article->doDeleteArticle( $reason, false, 0, true, $error ) ) {
+                       return array();
+               } else {
+                       return array( array( 'cannotdelete', $article->mTitle->getPrefixedText() ) );
+               }
        }
-       
-       protected function getAllowedParams() {
-               return array (
+
+       /**
+        * @static
+        * @param $token
+        * @param $title Title
+        * @param $oldimage
+        * @param $reason
+        * @param $suppress bool
+        * @return \type|array|Title
+        */
+       public static function deleteFile( $token, &$title, $oldimage, &$reason = null, $suppress = false ) {
+               $errors = self::getPermissionsError( $title, $token );
+               if ( count( $errors ) ) {
+                       return $errors;
+               }
+
+               if ( $oldimage && !FileDeleteForm::isValidOldSpec( $oldimage ) ) {
+                       return array( array( 'invalidoldimage' ) );
+               }
+
+               $file = wfFindFile( $title, array( 'ignoreRedirect' => true ) );
+               $oldfile = false;
+
+               if ( $oldimage ) {
+                       $oldfile = RepoGroup::singleton()->getLocalRepo()->newFromArchiveName( $title, $oldimage );
+               }
+
+               if ( !FileDeleteForm::haveDeletableFile( $file, $oldfile, $oldimage ) ) {
+                       return self::delete( new Article( $title ), $token, $reason );
+               }
+               if ( is_null( $reason ) ) { // Log and RC don't like null reasons
+                       $reason = '';
+               }
+               $status = FileDeleteForm::doDelete( $title, $file, $oldimage, $reason, $suppress );
+
+               if ( !$status->isGood() ) {
+                       return array( array( 'cannotdelete', $title->getPrefixedText() ) );
+               }
+
+               return array();
+       }
+
+       public function mustBePosted() {
+               return true;
+       }
+
+       public function isWriteMode() {
+               return true;
+       }
+
+       public function getAllowedParams() {
+               return array(
                        'title' => null,
+                       'pageid' => array(
+                               ApiBase::PARAM_TYPE => 'integer'
+                       ),
                        'token' => null,
                        'reason' => null,
+                       'watch' => array(
+                               ApiBase::PARAM_DFLT => false,
+                               ApiBase::PARAM_DEPRECATED => true,
+                       ),
+                       'watchlist' => array(
+                               ApiBase::PARAM_DFLT => 'preferences',
+                               ApiBase::PARAM_TYPE => array(
+                                       'watch',
+                                       'unwatch',
+                                       'preferences',
+                                       'nochange'
+                               ),
+                       ),
+                       'unwatch' => array(
+                               ApiBase::PARAM_DFLT => false,
+                               ApiBase::PARAM_DEPRECATED => true,
+                       ),
+                       'oldimage' => null,
                );
        }
 
-       protected function getParamDescription() {
-               return array (
-                       'title' => 'Title of the page you want to delete.',
+       public function getParamDescription() {
+               $p = $this->getModulePrefix();
+               return array(
+                       'title' => "Title of the page you want to delete. Cannot be used together with {$p}pageid",
+                       'pageid' => "Page ID of the page you want to delete. Cannot be used together with {$p}title",
                        'token' => 'A delete token previously retrieved through prop=info',
-                       'reason' => 'Reason for the deletion. If not set, an automatically generated reason will be used.'
+                       'reason' => 'Reason for the deletion. If not set, an automatically generated reason will be used',
+                       'watch' => 'Add the page to your watchlist',
+                       'watchlist' => 'Unconditionally add or remove the page from your watchlist, use preferences or do not change watch',
+                       'unwatch' => 'Remove the page from your watchlist',
+                       'oldimage' => 'The name of the old image to delete as provided by iiprop=archivename'
                );
        }
 
-       protected function getDescription() {
-               return array(
-                       'Deletes a page. You need to be logged in as a sysop to use this function, see also action=login.'
+       public function getDescription() {
+               return 'Delete a page';
+       }
+
+       public function getPossibleErrors() {
+               return array_merge( parent::getPossibleErrors(),
+                       $this->getRequireOnlyOneParameterErrorMessages( array( 'title', 'pageid' ) ),
+                       array(
+                               array( 'invalidtitle', 'title' ),
+                               array( 'nosuchpageid', 'pageid' ),
+                               array( 'notanarticle' ),
+                               array( 'hookaborted', 'error' ),
+                       )
                );
        }
 
+       public function needsToken() {
+               return true;
+       }
+
+       public function getTokenSalt() {
+               return '';
+       }
+
        protected function getExamples() {
-               return array (
+               return array(
                        'api.php?action=delete&title=Main%20Page&token=123ABC',
                        'api.php?action=delete&title=Main%20Page&token=123ABC&reason=Preparing%20for%20move'
                );