Revert r113650 and reapply r113619 and r113649 with one modification: User::createNew...
[lhc/web/wiklou.git] / includes / Wiki.php
index c896f49..b20cb95 100644 (file)
@@ -33,11 +33,6 @@ class MediaWiki {
         */
        private $context;
 
-       /**
-        * @var string
-        */
-       private $performedAction = 'nosuchaction';
-
        /**
         * @param $x null|WebRequest
         * @return WebRequest
@@ -81,6 +76,7 @@ class MediaWiki {
                $request = $this->context->getRequest();
                $curid = $request->getInt( 'curid' );
                $title = $request->getVal( 'title' );
+               $action = $request->getVal( 'action', 'view' );
 
                if ( $request->getCheck( 'search' ) ) {
                        // Compatibility with old search URLs which didn't use Special:Search
@@ -90,7 +86,7 @@ class MediaWiki {
                } elseif ( $curid ) {
                        // URLs like this are generated by RC, because rc_title isn't always accurate
                        $ret = Title::newFromID( $curid );
-               } elseif ( $title == '' && $this->getAction() != 'delete' ) {
+               } elseif ( $title == '' && $action != 'delete' ) {
                        $ret = Title::newMainPage();
                } else {
                        $ret = Title::newFromURL( $title );
@@ -171,7 +167,7 @@ class MediaWiki {
                {
                        $this->context->setTitle( SpecialPage::getTitleFor( 'Badtitle' ) );
                        wfProfileOut( __METHOD__ );
-                       throw new ErrorPageError( 'badtitle', 'badtitletext' );
+                       throw new BadTitleError();
                }
 
                // Check user's permissions to read this page.
@@ -218,7 +214,7 @@ class MediaWiki {
                        } else {
                                $this->context->setTitle( SpecialPage::getTitleFor( 'Badtitle' ) );
                                wfProfileOut( __METHOD__ );
-                               throw new ErrorPageError( 'badtitle', 'badtitletext' );
+                               throw new BadTitleError();
                        }
                // Redirect loops, no title in URL, $wgUsePathInfo URLs, and URLs with a variant
                } elseif ( $request->getVal( 'action', 'view' ) == 'view' && !$request->wasPosted()
@@ -273,11 +269,10 @@ class MediaWiki {
                                $pageView = true;
                                /**
                                 * $wgArticle is deprecated, do not use it.
-                                * This will be removed entirely in 1.20.
                                 * @deprecated since 1.18
                                 */
                                global $wgArticle;
-                               $wgArticle = $article;
+                               $wgArticle = new DeprecatedGlobal( 'wgArticle', $article, '1.18' );
 
                                $this->performAction( $article );
                        } elseif ( is_string( $article ) ) {
@@ -310,38 +305,15 @@ class MediaWiki {
        }
 
        /**
-        * Returns the action that will be executed, not necessarily the one passed
-        * passed through the "action" parameter. Actions disabled in
-        * $wgDisabledActions will be replaced by "nosuchaction".
-        *
-        * The return value is merely a suggestion, not the actually performed action,
-        * which may be different. The actually performed action is determined by performAction().
-        * Requests like action=nonsense will make this function return "nonsense".
-        * Use getPerformedAction() to get the performed action.
+        * Returns the name of the action that will be executed.
         *
         * @return string: action
         */
        public function getAction() {
-               global $wgDisabledActions;
-
-               $request = $this->context->getRequest();
-               $action = $request->getVal( 'action', 'view' );
-
-               // Check for disabled actions
-               if ( in_array( $action, $wgDisabledActions ) ) {
-                       return 'nosuchaction';
-               }
-
-               // Workaround for bug #20966: inability of IE to provide an action dependent
-               // on which submit button is clicked.
-               if ( $action === 'historysubmit' ) {
-                       if ( $request->getBool( 'revisiondelete' ) ) {
-                               return 'revisiondelete';
-                       } else {
-                               return 'view';
-                       }
-               } elseif ( $action == 'editredlink' ) {
-                       return 'edit';
+               static $action = null;
+               
+               if ( $action === null ) {
+                       $action = Action::getActionName( $this->context );
                }
 
                return $action;
@@ -458,9 +430,9 @@ class MediaWiki {
 
                while ( $n-- && false != ( $job = Job::pop() ) ) {
                        $output = $job->toString() . "\n";
-                       $t = -wfTime();
+                       $t = - microtime( true );
                        $success = $job->run();
-                       $t += wfTime();
+                       $t += microtime( true );
                        $t = round( $t * 1000 );
                        if ( !$success ) {
                                $output .= "Error: " . $job->getLastError() . ", Time: $t ms\n";
@@ -487,11 +459,9 @@ class MediaWiki {
        /**
         * Perform one of the "standard" actions
         *
-        * @param $article Article
+        * @param $page Page
         */
-       private function performAction( Page $article ) {
-               global $wgSquidMaxage;
-
+       private function performAction( Page $page ) {
                wfProfileIn( __METHOD__ );
 
                $request = $this->context->getRequest();
@@ -500,7 +470,7 @@ class MediaWiki {
                $user = $this->context->getUser();
 
                if ( !wfRunHooks( 'MediaWikiPerformAction',
-                       array( $output, $article, $title, $user, $request, $this ) ) )
+                       array( $output, $page, $title, $user, $request, $this ) ) )
                {
                        wfProfileOut( __METHOD__ );
                        return;
@@ -508,34 +478,20 @@ class MediaWiki {
 
                $act = $this->getAction();
 
-               $action = Action::factory( $act, $article );
+               $action = Action::factory( $act, $page );
                if ( $action instanceof Action ) {
-                       $this->performedAction = $act;
                        $action->show();
                        wfProfileOut( __METHOD__ );
                        return;
                }
 
-               if ( wfRunHooks( 'UnknownAction', array( $act, $article ) ) ) {
-                       $this->performedAction = 'nosuchaction';
+               if ( wfRunHooks( 'UnknownAction', array( $request->getVal( 'action', 'view' ), $page ) ) ) {
                        $output->showErrorPage( 'nosuchaction', 'nosuchactiontext' );
                }
 
                wfProfileOut( __METHOD__ );
        }
 
-       /**
-        * Returns the real action as determined by performAction.
-        * Do not use internally in this class as it depends on the actions by this class.
-        *
-        * @since 1.19
-        *
-        * @return string: action
-        */
-       public function getPerformedAction() {
-               return $this->performedAction;
-       }
-
        /**
         * Run the current MediaWiki instance
         * index.php just calls this
@@ -588,32 +544,42 @@ class MediaWiki {
 
                wfProfileIn( __METHOD__ );
 
-               # Set title from request parameters
-               $wgTitle = $this->getTitle();
-               $action = $this->getAction();
+               $request = $this->context->getRequest();
+
+               // Send Ajax requests to the Ajax dispatcher.
+               if ( $wgUseAjax && $request->getVal( 'action', 'view' ) == 'ajax' ) {
+
+                       // Set a dummy title, because $wgTitle == null might break things
+                       $title = Title::makeTitle( NS_MAIN, 'AJAX' );
+                       $this->context->setTitle( $title );
+                       $wgTitle = $title;
 
-               # Send Ajax requests to the Ajax dispatcher.
-               if ( $wgUseAjax && $action == 'ajax' ) {
                        $dispatcher = new AjaxDispatcher();
                        $dispatcher->performAction();
                        wfProfileOut( __METHOD__ );
                        return;
                }
 
-               if ( $wgUseFileCache && $this->getTitle()->getNamespace() >= 0 ) {
+               // Get title from request parameters,
+               // is set on the fly by parseTitle the first time.
+               $title = $this->getTitle();
+               $action = $this->getAction();
+               $wgTitle = $title;
+
+               if ( $wgUseFileCache && $title->getNamespace() >= 0 ) {
                        wfProfileIn( 'main-try-filecache' );
                        if ( HTMLFileCache::useFileCache( $this->context ) ) {
-                               /* Try low-level file cache hit */
-                               $cache = HTMLFileCache::newFromTitle( $this->getTitle(), $action );
+                               // Try low-level file cache hit
+                               $cache = HTMLFileCache::newFromTitle( $title, $action );
                                if ( $cache->isCacheGood( /* Assume up to date */ ) ) {
-                                       /* Check incoming headers to see if client has this cached */
+                                       // Check incoming headers to see if client has this cached
                                        $timestamp = $cache->cacheTimestamp();
                                        if ( !$this->context->getOutput()->checkLastModified( $timestamp ) ) {
                                                $cache->loadFromFileCache( $this->context );
                                        }
-                                       # Do any stats increment/watchlist stuff
+                                       // Do any stats increment/watchlist stuff
                                        $this->context->getWikiPage()->doViewUpdates( $this->context->getUser() );
-                                       # Tell OutputPage that output is taken care of
+                                       // Tell OutputPage that output is taken care of
                                        $this->context->getOutput()->disable();
                                        wfProfileOut( 'main-try-filecache' );
                                        wfProfileOut( __METHOD__ );