* (bug 20494) OutputPage::getArticleBodyOnly() no longer requires an useless argument
[lhc/web/wiklou.git] / includes / User.php
index 78cb5ef..df95f3f 100644 (file)
@@ -14,7 +14,7 @@ define( 'USER_TOKEN_LENGTH', 32 );
  * \int Serialized record version.
  * @ingroup Constants
  */
-define( 'MW_USER_VERSION', 6 );
+define( 'MW_USER_VERSION', 8 );
 
 /**
  * \string Some punctuation to prevent editing from broken text-mangling proxies.
@@ -43,7 +43,7 @@ class PasswordError extends MWException {
 class User {
 
        /**
-        * \type{\arrayof{\string}} A list of default user toggles, i.e., boolean user 
+        * \type{\arrayof{\string}} A list of default user toggles, i.e., boolean user
          * preferences that are displayed by Special:Preferences as checkboxes.
         * This list can be extended via the UserToggles hook or by
         * $wgContLang::getExtraUserToggles().
@@ -95,8 +95,8 @@ class User {
        );
 
        /**
-        * \type{\arrayof{\string}} List of member variables which are saved to the 
-        * shared cache (memcached). Any operation which changes the 
+        * \type{\arrayof{\string}} List of member variables which are saved to the
+        * shared cache (memcached). Any operation which changes the
         * corresponding database fields must call a cache-clearing function.
         * @showinitializer
         */
@@ -109,7 +109,6 @@ class User {
                'mNewpassword',
                'mNewpassTime',
                'mEmail',
-               'mOptions',
                'mTouched',
                'mToken',
                'mEmailAuthenticated',
@@ -119,11 +118,13 @@ class User {
                'mEditCount',
                // user_group table
                'mGroups',
+               // user_properties table
+               'mOptionOverrides',
        );
 
        /**
         * \type{\arrayof{\string}} Core rights.
-        * Each of these should have a corresponding message of the form 
+        * Each of these should have a corresponding message of the form
         * "right-$right".
         * @showinitializer
         */
@@ -163,7 +164,6 @@ class User {
                'proxyunbannable',
                'purge',
                'read',
-               'reset-passwords',
                'reupload',
                'reupload-shared',
                'rollback',
@@ -188,14 +188,14 @@ class User {
        /** @name Cache variables */
        //@{
        var $mId, $mName, $mRealName, $mPassword, $mNewpassword, $mNewpassTime,
-               $mEmail, $mOptions, $mTouched, $mToken, $mEmailAuthenticated,
-               $mEmailToken, $mEmailTokenExpires, $mRegistration, $mGroups;
+               $mEmail, $mTouched, $mToken, $mEmailAuthenticated,
+               $mEmailToken, $mEmailTokenExpires, $mRegistration, $mGroups, $mOptionOverrides;
        //@}
 
        /**
         * \bool Whether the cache variables have been loaded.
         */
-       var $mDataLoaded, $mAuthLoaded;
+       var $mDataLoaded, $mAuthLoaded, $mOptionsLoaded;
 
        /**
         * \string Initialization data source if mDataLoaded==false. May be one of:
@@ -211,14 +211,16 @@ class User {
        /** @name Lazy-initialized variables, invalidated with clearInstanceCache */
        //@{
        var $mNewtalk, $mDatePreference, $mBlockedby, $mHash, $mSkin, $mRights,
-               $mBlockreason, $mBlock, $mEffectiveGroups, $mBlockedGlobally, 
-               $mLocked, $mHideName;
+               $mBlockreason, $mBlock, $mEffectiveGroups, $mBlockedGlobally,
+               $mLocked, $mHideName, $mOptions;
        //@}
+       
+       static $idCacheByName = array();
 
        /**
         * Lightweight constructor for an anonymous user.
         * Use the User::newFrom* factory functions for other kinds of users.
-        * 
+        *
         * @see newFromName()
         * @see newFromId()
         * @see newFromConfirmationCode()
@@ -311,6 +313,7 @@ class User {
        function saveToCache() {
                $this->load();
                $this->loadGroups();
+               $this->loadOptions();
                if ( $this->isAnon() ) {
                        // Anonymous users are uncached
                        return;
@@ -324,8 +327,8 @@ class User {
                global $wgMemc;
                $wgMemc->set( $key, $data );
        }
-       
-       
+
+
        /** @name newFrom*() static factory methods */
        //@{
 
@@ -340,8 +343,8 @@ class User {
         *    User::getCanonicalName(), except that true is accepted as an alias
         *    for 'valid', for BC.
         *
-        * @return \type{User} The User object, or null if the username is invalid. If the 
-        *    username is not present in the database, the result will be a user object 
+        * @return \type{User} The User object, or null if the username is invalid. If the
+        *    username is not present in the database, the result will be a user object
         *    with a name, zero user ID and default settings.
         */
        static function newFromName( $name, $validate = 'valid' ) {
@@ -419,9 +422,9 @@ class User {
                $user->loadFromRow( $row );
                return $user;
        }
-       
+
        //@}
-       
+
 
        /**
         * Get the username corresponding to a given user ID
@@ -455,14 +458,27 @@ class User {
                        # Illegal name
                        return null;
                }
+               
+               if ( isset(self::$idCacheByName[$name]) ) {
+                       return self::$idCacheByName[$name];
+               }
+               
                $dbr = wfGetDB( DB_SLAVE );
                $s = $dbr->selectRow( 'user', array( 'user_id' ), array( 'user_name' => $nt->getText() ), __METHOD__ );
 
                if ( $s === false ) {
-                       return 0;
+                       $result = 0;
                } else {
-                       return $s->user_id;
+                       $result = $s->user_id;
+               }
+               
+               self::$idCacheByName[$name] = $result;
+               
+               if ( count(self::$idCacheByName) > 1000 ) {
+                       self::$idCacheByName = array();
                }
+               
+               return $result;
        }
 
        /**
@@ -594,27 +610,29 @@ class User {
                        self::isUsableName( $name ) &&
 
                        // Registration-time character blacklisting...
-                       !preg_match( '/[' . preg_quote( $wgInvalidUsernameCharacters, ']/' ) . ']/', $name );
+                       !preg_match( '/[' . preg_quote( $wgInvalidUsernameCharacters, '/' ) . ']/', $name );
        }
 
        /**
         * Is the input a valid password for this user?
         *
-        * @param $password \string Desired password
-        * @return \bool True or false
+        * @param $password String Desired password
+        * @return mixed: true on success, string of error message on failure
         */
        function isValidPassword( $password ) {
                global $wgMinimalPasswordLength, $wgContLang;
 
-               $result = null;
                if( !wfRunHooks( 'isValidPassword', array( $password, &$result, $this ) ) )
                        return $result;
-               if( $result === false )
-                       return false;
 
-               // Password needs to be long enough, and can't be the same as the username
-               return strlen( $password ) >= $wgMinimalPasswordLength
-                       && $wgContLang->lc( $password ) !== $wgContLang->lc( $this->mName );
+               // Password needs to be long enough
+               if( strlen( $password ) < $wgMinimalPasswordLength ) {
+                       return 'passwordtooshort';
+               } elseif( $wgContLang->lc( $password ) == $wgContLang->lc( $this->mName ) ) {
+                       return 'password-name-match';
+               } else {
+                       return true;
+               }
        }
 
        /**
@@ -660,7 +678,7 @@ class User {
                        return false;
 
                # Clean up name according to title rules
-               $t = ($validate === 'valid') ? 
+               $t = ($validate === 'valid') ?
                        Title::newFromText( $name ) : Title::makeTitle( NS_USER, $name );
                # Check for invalid titles
                if( is_null( $t ) ) {
@@ -754,9 +772,9 @@ class User {
        }
 
        /**
-        * Set cached properties to default. 
+        * Set cached properties to default.
         *
-        * @note This no longer clears uncached lazy-initialised properties; 
+        * @note This no longer clears uncached lazy-initialised properties;
         *       the constructor does that instead.
         * @private
         */
@@ -771,7 +789,8 @@ class User {
                $this->mPassword = $this->mNewpassword = '';
                $this->mNewpassTime = null;
                $this->mEmail = '';
-               $this->mOptions = null; # Defer init
+               $this->mOptionOverrides = null;
+               $this->mOptionsLoaded = false;
 
                if ( isset( $_COOKIE[$wgCookiePrefix.'LoggedOut'] ) ) {
                        $this->mTouched = wfTimestamp( TS_MW, $_COOKIE[$wgCookiePrefix.'LoggedOut'] );
@@ -817,7 +836,7 @@ class User {
                        $sId = intval( $_COOKIE["{$wgCookiePrefix}UserID"] );
                        if( isset( $_SESSION['wsUserID'] ) && $sId != $_SESSION['wsUserID'] ) {
                                $this->loadDefaults(); // Possible collision!
-                               wfDebugLog( 'loginSessions', "Session user ID ({$_SESSION['wsUserID']}) and 
+                               wfDebugLog( 'loginSessions', "Session user ID ({$_SESSION['wsUserID']}) and
                                        cookie user ID ($sId) don't match!" );
                                return false;
                        }
@@ -935,7 +954,7 @@ class User {
                $this->mEmailToken = $row->user_email_token;
                $this->mEmailTokenExpires = wfTimestampOrNull( TS_MW, $row->user_email_token_expires );
                $this->mRegistration = wfTimestampOrNull( TS_MW, $row->user_registration );
-               $this->mEditCount = $row->user_editcount; 
+               $this->mEditCount = $row->user_editcount;
        }
 
        /**
@@ -970,6 +989,7 @@ class User {
                $this->mSkin = null;
                $this->mRights = null;
                $this->mEffectiveGroups = null;
+               $this->mOptions = null;
 
                if ( $reloadFrom ) {
                        $this->mDataLoaded = false;
@@ -988,7 +1008,7 @@ class User {
                /**
                 * Site defaults will override the global/language defaults
                 */
-               global $wgDefaultUserOptions, $wgContLang;
+               global $wgDefaultUserOptions, $wgContLang, $wgDefaultSkin;
                $defOpt = $wgDefaultUserOptions + $wgContLang->getDefaultUserOptionOverrides();
 
                /**
@@ -997,10 +1017,11 @@ class User {
                $variant = $wgContLang->getPreferredVariant( false );
                $defOpt['variant'] = $variant;
                $defOpt['language'] = $variant;
-
-               foreach( $wgNamespacesToBeSearchedDefault as $nsnum => $val ) {
-                       $defOpt['searchNs'.$nsnum] = $val;
+               foreach(  SearchEngine::searchableNamespaces() as $nsnum => $nsname ) {
+                       $defOpt['searchNs'.$nsnum] = !empty($wgNamespacesToBeSearchedDefault[$nsnum]);
                }
+               $defOpt['skin'] = $wgDefaultSkin;
+               
                return $defOpt;
        }
 
@@ -1015,7 +1036,7 @@ class User {
                if( isset( $defOpts[$opt] ) ) {
                        return $defOpts[$opt];
                } else {
-                       return '';
+                       return null;
                }
        }
 
@@ -1061,7 +1082,7 @@ class User {
                // due to -1 !== 0. Probably session-related... Nothing should be
                // overwriting mBlockedby, surely?
                $this->load();
-               
+
                $this->mBlockedby = 0;
                $this->mHideName = 0;
                $this->mAllowUsertalk = 0;
@@ -1085,8 +1106,8 @@ class User {
                                $this->spreadBlock();
                        }
                } else {
-                       // Bug 13611: don't remove mBlock here, to allow account creation blocks to 
-                       // apply to users. Note that the existence of $this->mBlock is not used to 
+                       // Bug 13611: don't remove mBlock here, to allow account creation blocks to
+                       // apply to users. Note that the existence of $this->mBlock is not used to
                        // check for edit blocks, $this->mBlockedby is instead.
                }
 
@@ -1165,17 +1186,10 @@ class User {
         */
        public function isPingLimitable() {
                global $wgRateLimitsExcludedGroups;
-               global $wgRateLimitsExcludedIPs;
                if( array_intersect( $this->getEffectiveGroups(), $wgRateLimitsExcludedGroups ) ) {
                        // Deprecated, but kept for backwards-compatibility config
                        return false;
                }
-               if( in_array( wfGetIP(), $wgRateLimitsExcludedIPs ) ) {
-                       // No other good way currently to disable rate limits
-                       // for specific IPs. :P
-                       // But this is a crappy hack and should die.
-                       return false;
-               }
                return !$this->isAllowed('noratelimit');
        }
 
@@ -1278,7 +1292,7 @@ class User {
 
        /**
         * Check if user is blocked
-        * 
+        *
         * @param $bFromSlave \bool Whether to check the slave database instead of the master
         * @return \bool True if blocked, false otherwise
         */
@@ -1290,7 +1304,7 @@ class User {
 
        /**
         * Check if user is blocked from editing a particular article
-        * 
+        *
         * @param $title      \string Title to check
         * @param $bFromSlave \bool   Whether to check the slave database instead of the master
         * @return \bool True if blocked, false otherwise
@@ -1330,7 +1344,7 @@ class User {
                $this->getBlockedStatus();
                return $this->mBlockreason;
        }
-       
+
        /**
         * If user is blocked, return the ID for the block
         * @return \int Block ID
@@ -1339,12 +1353,12 @@ class User {
                $this->getBlockedStatus();
                return ($this->mBlock ? $this->mBlock->mId : false);
        }
-       
+
        /**
         * Check if user is blocked on all wikis.
         * Do not use for actual edit permission checks!
         * This is intented for quick UI checks.
-        * 
+        *
         * @param $ip \type{\string} IP address, uses current client if none given
         * @return \type{\bool} True if blocked, false otherwise
         */
@@ -1363,10 +1377,10 @@ class User {
                $this->mBlockedGlobally = (bool)$blocked;
                return $this->mBlockedGlobally;
        }
-       
+
        /**
         * Check if user account is locked
-        * 
+        *
         * @return \type{\bool} True if locked, false otherwise
         */
        function isLocked() {
@@ -1378,10 +1392,10 @@ class User {
                $this->mLocked = (bool)$authUser->isLocked();
                return $this->mLocked;
        }
-       
+
        /**
         * Check if user account is hidden
-        * 
+        *
         * @return \type{\bool} True if hidden, false otherwise
         */
        function isHidden() {
@@ -1702,9 +1716,10 @@ class User {
                                throw new PasswordError( wfMsg( 'password-change-forbidden' ) );
                        }
 
-                       if( !$this->isValidPassword( $str ) ) {
+                       $valid = $this->isValidPassword( $str );
+                       if( $valid !== true ) {
                                global $wgMinimalPasswordLength;
-                               throw new PasswordError( wfMsgExt( 'passwordtooshort', array( 'parsemag' ),
+                               throw new PasswordError( wfMsgExt( $valid, array( 'parsemag' ),
                                        $wgMinimalPasswordLength ) );
                        }
                }
@@ -1736,7 +1751,7 @@ class User {
                $this->mNewpassword = '';
                $this->mNewpassTime = null;
        }
-       
+
        /**
         * Get the user's current token.
         * @return \string Token
@@ -1745,7 +1760,7 @@ class User {
                $this->load();
                return $this->mToken;
        }
-       
+
        /**
         * Set the random token (used for persistent authentication)
         * Called from loadDefaults() among other places.
@@ -1769,7 +1784,7 @@ class User {
                        $this->mToken = $token;
                }
        }
-       
+
        /**
         * Set the cookie password
         *
@@ -1796,7 +1811,7 @@ class User {
        }
 
        /**
-        * Has password reminder email been sent within the last 
+        * Has password reminder email been sent within the last
         * $wgPasswordReminderResendTime hours?
         * @return \bool True or false
         */
@@ -1867,8 +1882,8 @@ class User {
         * @see getBoolOption()
         * @see getIntOption()
         */
-       function getOption( $oname, $defaultOverride = '' ) {
-               $this->load();
+       function getOption( $oname, $defaultOverride = null ) {
+               $this->loadOptions();
 
                if ( is_null( $this->mOptions ) ) {
                        if($defaultOverride != '') {
@@ -1878,12 +1893,12 @@ class User {
                }
 
                if ( array_key_exists( $oname, $this->mOptions ) ) {
-                       return trim( $this->mOptions[$oname] );
+                       return $this->mOptions[$oname];
                } else {
                        return $defaultOverride;
                }
        }
-       
+
        /**
         * Get the user's current setting for a given option, as a boolean value.
         *
@@ -1895,7 +1910,7 @@ class User {
                return (bool)$this->getOption( $oname );
        }
 
-       
+
        /**
         * Get the user's current setting for a given option, as a boolean value.
         *
@@ -1920,32 +1935,26 @@ class User {
         */
        function setOption( $oname, $val ) {
                $this->load();
-               if ( is_null( $this->mOptions ) ) {
-                       $this->mOptions = User::getDefaultOptions();
-               }
+               $this->loadOptions();
+               
                if ( $oname == 'skin' ) {
                        # Clear cached skin, so the new one displays immediately in Special:Preferences
                        unset( $this->mSkin );
                }
-               // Filter out any newlines that may have passed through input validation.
-               // Newlines are used to separate items in the options blob.
-               if( $val ) {
-                       $val = str_replace( "\r\n", "\n", $val );
-                       $val = str_replace( "\r", "\n", $val );
-                       $val = str_replace( "\n", " ", $val );
-               }
+               
                // Explicitly NULL values should refer to defaults
                global $wgDefaultUserOptions;
                if( is_null($val) && isset($wgDefaultUserOptions[$oname]) ) {
                        $val = $wgDefaultUserOptions[$oname];
                }
+               
                $this->mOptions[$oname] = $val;
        }
-       
+
        /**
         * Reset all options to the site defaults
-        */     
-       function restoreOptions() {
+        */
+       function resetOptions() {
                $this->mOptions = User::getDefaultOptions();
        }
 
@@ -2121,7 +2130,7 @@ class User {
                        if( !$wgUseRCPatrol && !$wgUseNPPatrol )
                                return false;
                }
-               # Use strict parameter to avoid matching numeric 0 accidentally inserted 
+               # Use strict parameter to avoid matching numeric 0 accidentally inserted
                # by misconfiguration: 0 == 'foo'
                return in_array( $action, $this->getRights(), true );
        }
@@ -2145,27 +2154,37 @@ class User {
        }
 
        /**
-        * Get the current skin, loading it if required
-        * @return \type{Skin} Current skin
+        * Get the current skin, loading it if required, and setting a title
+        * @param $t Title: the title to use in the skin
+        * @return Skin The current skin
         * @todo FIXME : need to check the old failback system [AV]
         */
-       function &getSkin() {
-               global $wgRequest, $wgAllowUserSkin, $wgDefaultSkin;
+       function &getSkin( $t = null ) {
                if ( ! isset( $this->mSkin ) ) {
                        wfProfileIn( __METHOD__ );
 
-                       if( $wgAllowUserSkin ) {
+                       global $wgHiddenPrefs;
+                       if( !in_array( 'skin', $wgHiddenPrefs ) ) {
                                # get the user skin
+                               global $wgRequest;
                                $userSkin = $this->getOption( 'skin' );
                                $userSkin = $wgRequest->getVal('useskin', $userSkin);
                        } else {
                                # if we're not allowing users to override, then use the default
+                               global $wgDefaultSkin;
                                $userSkin = $wgDefaultSkin;
                        }
-                       
+
                        $this->mSkin =& Skin::newFromKey( $userSkin );
                        wfProfileOut( __METHOD__ );
                }
+               if( $t || !$this->mSkin->getTitle() ) {
+                       if ( !$t ) {
+                               global $wgOut;
+                               $t = $wgOut->getTitle();
+                       }
+                       $this->mSkin->setTitle( $t );
+               }
                return $this->mSkin;
        }
 
@@ -2286,53 +2305,42 @@ class User {
                }
        }
 
-       /**
-        * Encode this user's options as a string
-        * @return \string Encoded options
-        * @private
-        */
-       function encodeOptions() {
-               $this->load();
-               if ( is_null( $this->mOptions ) ) {
-                       $this->mOptions = User::getDefaultOptions();
-               }
-               $a = array();
-               foreach ( $this->mOptions as $oname => $oval ) {
-                       array_push( $a, $oname.'='.$oval );
-               }
-               $s = implode( "\n", $a );
-               return $s;
-       }
-
        /**
         * Set this user's options from an encoded string
         * @param $str \string Encoded options to import
         * @private
         */
        function decodeOptions( $str ) {
+               if (!$str)
+                       return;
+                       
+               $this->mOptionsLoaded = true;
+               $this->mOptionOverrides = array();
+               
                $this->mOptions = array();
                $a = explode( "\n", $str );
                foreach ( $a as $s ) {
                        $m = array();
                        if ( preg_match( "/^(.[^=]*)=(.*)$/", $s, $m ) ) {
                                $this->mOptions[$m[1]] = $m[2];
+                               $this->mOptionOverrides[$m[1]] = $m[2];
                        }
                }
        }
-       
+
        /**
-        * Set a cookie on the user's client. Wrapper for 
+        * Set a cookie on the user's client. Wrapper for
         * WebResponse::setCookie
         * @param $name \string Name of the cookie to set
         * @param $value \string Value to set
-        * @param $exp \int Expiration time, as a UNIX time value; 
+        * @param $exp \int Expiration time, as a UNIX time value;
         *                   if 0 or not specified, use the default $wgCookieExpiration
         */
        protected function setCookie( $name, $value, $exp=0 ) {
                global $wgRequest;
                $wgRequest->response()->setcookie( $name, $value, $exp );
        }
-       
+
        /**
         * Clear a cookie on the user's client
         * @param $name \string Name of the cookie to clear
@@ -2347,7 +2355,7 @@ class User {
        function setCookies() {
                $this->load();
                if ( 0 == $this->mId ) return;
-               $session = array( 
+               $session = array(
                        'wsUserID' => $this->mId,
                        'wsToken' => $this->mToken,
                        'wsUserName' => $this->getName()
@@ -2361,9 +2369,9 @@ class User {
                } else {
                        $cookies['Token'] = false;
                }
-               
+
                wfRunHooks( 'UserSetCookies', array( $this, &$session, &$cookies ) );
-               #check for null, since the hook could cause a null value 
+               #check for null, since the hook could cause a null value
                if ( !is_null( $session ) && isset( $_SESSION ) ){
                        $_SESSION = $session + $_SESSION;
                }
@@ -2380,7 +2388,6 @@ class User {
         * Log this user out.
         */
        function logout() {
-               global $wgUser;
                if( wfRunHooks( 'UserLogout', array(&$this) ) ) {
                        $this->doLogout();
                }
@@ -2424,7 +2431,7 @@ class User {
                                'user_real_name' => $this->mRealName,
                                'user_email' => $this->mEmail,
                                'user_email_authenticated' => $dbw->timestampOrNull( $this->mEmailAuthenticated ),
-                               'user_options' => $this->encodeOptions(),
+                               'user_options' => '',
                                'user_touched' => $dbw->timestamp($this->mTouched),
                                'user_token' => $this->mToken,
                                'user_email_token' => $this->mEmailToken,
@@ -2433,6 +2440,9 @@ class User {
                                'user_id' => $this->mId
                        ), __METHOD__
                );
+               
+               $this->saveOptions();
+               
                wfRunHooks( 'UserSaveSettings', array( $this ) );
                $this->clearSharedCache();
                $this->getUserPage()->invalidateCache();
@@ -2487,7 +2497,7 @@ class User {
                        'user_email' => $user->mEmail,
                        'user_email_authenticated' => $dbw->timestampOrNull( $user->mEmailAuthenticated ),
                        'user_real_name' => $user->mRealName,
-                       'user_options' => $user->encodeOptions(),
+                       'user_options' => '',
                        'user_token' => $user->mToken,
                        'user_registration' => $dbw->timestamp( $user->mRegistration ),
                        'user_editcount' => 0,
@@ -2521,7 +2531,7 @@ class User {
                                'user_email' => $this->mEmail,
                                'user_email_authenticated' => $dbw->timestampOrNull( $this->mEmailAuthenticated ),
                                'user_real_name' => $this->mRealName,
-                               'user_options' => $this->encodeOptions(),
+                               'user_options' => '',
                                'user_token' => $this->mToken,
                                'user_registration' => $dbw->timestamp( $this->mRegistration ),
                                'user_editcount' => 0,
@@ -2531,6 +2541,8 @@ class User {
 
                // Clear instance cache other than user table data, which is already accurate
                $this->clearInstanceCache();
+               
+               $this->saveOptions();
        }
 
        /**
@@ -2675,32 +2687,6 @@ class User {
        function isNewbie() {
                return !$this->isAllowed( 'autoconfirmed' );
        }
-       
-       /**
-        * Is the user active? We check to see if they've made at least
-        * X number of edits in the last Y days.
-        * 
-        * @return \bool True if the user is active, false if not.
-        */
-       public function isActiveEditor() {
-               global $wgActiveUserEditCount, $wgActiveUserDays;
-               $dbr = wfGetDB( DB_SLAVE );
-               
-               // Stolen without shame from RC
-               $cutoff_unixtime = time() - ( $wgActiveUserDays * 86400 );
-               $cutoff_unixtime = $cutoff_unixtime - ( $cutoff_unixtime % 86400 );
-               $oldTime = $dbr->addQuotes( $dbr->timestamp( $cutoff_unixtime ) );
-               
-               $res = $dbr->select( 'revision', '1',
-                               array( 'rev_user_text' => $this->getName(), "rev_timestamp > $oldTime"),
-                               __METHOD__,
-                               array('LIMIT' => $wgActiveUserEditCount ) );
-               
-               $count = $dbr->numRows($res);
-               $dbr->freeResult($res);
-
-               return $count == $wgActiveUserEditCount;
-       }
 
        /**
         * Check to see if the given clear-text password is one of the accepted passwords
@@ -2716,7 +2702,7 @@ class User {
                // to. Certain authentication plugins do NOT want to save
                // domain passwords in a mysql database, so we should
                // check this (incase $wgAuth->strict() is false).
-               if( !$this->isValidPassword( $password ) ) {
+               if( $this->isValidPassword( $password ) !== true ) {
                        return false;
                }
 
@@ -2839,14 +2825,16 @@ class User {
                $url = $this->confirmationTokenUrl( $token );
                $invalidateURL = $this->invalidationTokenUrl( $token );
                $this->saveSettings();
-               
+
                return $this->sendMail( wfMsg( 'confirmemail_subject' ),
                        wfMsg( 'confirmemail_body',
                                wfGetIP(),
                                $this->getName(),
                                $url,
                                $wgLang->timeanddate( $expiration, false ),
-                               $invalidateURL ) );
+                               $invalidateURL,
+                               $wgLang->date( $expiration, false ),
+                               $wgLang->time( $expiration, false ) ) );
        }
 
        /**
@@ -2911,7 +2899,7 @@ class User {
        function invalidationTokenUrl( $token ) {
                return $this->getTokenUrl( 'Invalidateemail', $token );
        }
-       
+
        /**
         * Internal function to format the e-mail validation/invalidation URLs.
         * This uses $wgArticlePath directly as a quickie hack to use the
@@ -3043,7 +3031,7 @@ class User {
                        ? $this->mRegistration
                        : false;
        }
-       
+
        /**
         * Get the timestamp of the first edit
         *
@@ -3060,7 +3048,7 @@ class User {
                );
                if( !$time ) return false; // no edits
                return wfTimestamp( TS_MW, $time );
-       }       
+       }
 
        /**
         * Get the permissions associated with a given list of groups
@@ -3069,8 +3057,9 @@ class User {
         * @return \type{\arrayof{\string}} List of permission key names for given groups combined
         */
        static function getGroupPermissions( $groups ) {
-               global $wgGroupPermissions;
+               global $wgGroupPermissions, $wgRevokePermissions;
                $rights = array();
+               // grant every granted permission first
                foreach( $groups as $group ) {
                        if( isset( $wgGroupPermissions[$group] ) ) {
                                $rights = array_merge( $rights,
@@ -3078,12 +3067,19 @@ class User {
                                        array_keys( array_filter( $wgGroupPermissions[$group] ) ) );
                        }
                }
+               // now revoke the revoked permissions
+               foreach( $groups as $group ) {
+                       if( isset( $wgRevokePermissions[$group] ) ) {
+                               $rights = array_diff( $rights,
+                                       array_keys( array_filter( $wgRevokePermissions[$group] ) ) );
+                       }
+               }
                return array_unique($rights);
        }
-       
+
        /**
         * Get all the groups who have a given permission
-        * 
+        *
         * @param $role \string Role to check
         * @return \type{\arrayof{\string}} List of internal group names with the given permission
         */
@@ -3137,9 +3133,9 @@ class User {
         * @return \type{\arrayof{\string}} Array of internal group names
         */
        static function getAllGroups() {
-               global $wgGroupPermissions;
+               global $wgGroupPermissions, $wgRevokePermissions;
                return array_diff(
-                       array_keys( $wgGroupPermissions ),
+                       array_merge( array_keys( $wgGroupPermissions ), array_keys( $wgRevokePermissions ) ),
                        self::getImplicitGroups()
                );
        }
@@ -3191,7 +3187,7 @@ class User {
        }
 
        /**
-        * Create a link to the group in HTML, if available; 
+        * Create a link to the group in HTML, if available;
         * else return the group name.
         *
         * @param $group \string Internal name of the group
@@ -3206,14 +3202,14 @@ class User {
                if( $title ) {
                        global $wgUser;
                        $sk = $wgUser->getSkin();
-                       return $sk->makeLinkObj( $title, htmlspecialchars( $text ) );
+                       return $sk->link( $title, htmlspecialchars( $text ) );
                } else {
                        return $text;
                }
        }
 
        /**
-        * Create a link to the group in Wikitext, if available; 
+        * Create a link to the group in Wikitext, if available;
         * else return the group name.
         *
         * @param $group \string Internal name of the group
@@ -3232,7 +3228,7 @@ class User {
                        return $text;
                }
        }
-       
+
        /**
         * Returns an array of the groups that a particular group can add/remove.
         *
@@ -3262,7 +3258,7 @@ class User {
                } elseif( is_array($wgRemoveGroups[$group]) ) {
                        $groups['remove'] = $wgRemoveGroups[$group];
                }
-               
+
                // Re-map numeric keys of AddToSelf/RemoveFromSelf to the 'user' key for backwards compatibility
                if( empty($wgGroupsAddToSelf['user']) || $wgGroupsAddToSelf['user'] !== true ) {
                        foreach($wgGroupsAddToSelf as $key => $value) {
@@ -3271,7 +3267,7 @@ class User {
                                }
                        }
                }
-               
+
                if( empty($wgGroupsRemoveFromSelf['user']) || $wgGroupsRemoveFromSelf['user'] !== true ) {
                        foreach($wgGroupsRemoveFromSelf as $key => $value) {
                                if( is_int($key) ) {
@@ -3279,7 +3275,7 @@ class User {
                                }
                        }
                }
-               
+
                // Now figure out what groups the user can add to him/herself
                if( empty($wgGroupsAddToSelf[$group]) ) {
                } elseif( $wgGroupsAddToSelf[$group] === true ) {
@@ -3288,17 +3284,17 @@ class User {
                } elseif( is_array($wgGroupsAddToSelf[$group]) ) {
                        $groups['add-self'] = $wgGroupsAddToSelf[$group];
                }
-               
+
                if( empty($wgGroupsRemoveFromSelf[$group]) ) {
                } elseif( $wgGroupsRemoveFromSelf[$group] === true ) {
                        $groups['remove-self'] = User::getAllGroups();
                } elseif( is_array($wgGroupsRemoveFromSelf[$group]) ) {
                        $groups['remove-self'] = $wgGroupsRemoveFromSelf[$group];
                }
-               
+
                return $groups;
        }
-       
+
        /**
         * Returns an array of groups that this user can add and remove
         * @return Array array( 'add' => array( addablegroups ),
@@ -3384,7 +3380,7 @@ class User {
                // edit count in user cache too
                $this->invalidateCache();
        }
-       
+
        /**
         * Get the description of a given right
         *
@@ -3421,7 +3417,7 @@ class User {
         * Make a new-style password hash
         *
         * @param $password \string Plain-text password
-        * @param $salt \string Optional salt, may be random or the user ID. 
+        * @param $salt \string Optional salt, may be random or the user ID.
         *                     If unspecified or false, will generate one automatically
         * @return \string Password hash
         */
@@ -3432,7 +3428,7 @@ class User {
                if( !wfRunHooks( 'UserCryptPassword', array( &$password, &$salt, &$wgPasswordSalt, &$hash ) ) ) {
                        return $hash;
                }
-               
+
                if( $wgPasswordSalt ) {
                        if ( $salt === false ) {
                                $salt = substr( wfGenerateToken(), 0, 8 );
@@ -3455,12 +3451,12 @@ class User {
        static function comparePasswords( $hash, $password, $userId = false ) {
                $m = false;
                $type = substr( $hash, 0, 3 );
-               
+
                $result = false;
                if( !wfRunHooks( 'UserComparePasswords', array( &$hash, &$password, &$userId, &$result ) ) ) {
                        return $result;
                }
-               
+
                if ( $type == ':A:' ) {
                        # Unsalted
                        return md5( $password ) === substr( $hash, 3 );
@@ -3473,7 +3469,7 @@ class User {
                        return self::oldCrypt( $password, $userId ) === $hash;
                }
        }
-       
+
        /**
         * Add a newuser log entry for this user
         * @param $byEmail Boolean: account made by email?
@@ -3509,5 +3505,130 @@ class User {
                $log->addEntry( 'autocreate', $this->getUserPage(), '', array( $this->getId() ) );
                return true;
        }
+       
+       protected function loadOptions() {
+               $this->load();
+               if ($this->mOptionsLoaded || !$this->getId() )
+                       return;
+       
+               $this->mOptions = self::getDefaultOptions();
+               
+               // Maybe load from the object
+               
+               if ( !is_null($this->mOptionOverrides) ) {
+                       wfDebug( "Loading options for user ".$this->getId()." from override cache.\n" ); 
+                       foreach( $this->mOptionOverrides as $key => $value ) {
+                               $this->mOptions[$key] = $value;
+                       }
+               } else {
+                       wfDebug( "Loading options for user ".$this->getId()." from database.\n" );
+                       // Load from database
+                       $dbr = wfGetDB( DB_SLAVE );
+                       
+                       $res = $dbr->select( 'user_properties',
+                                                                       '*',
+                                                                       array('up_user' => $this->getId()),
+                                                                       __METHOD__
+                                                               );
+                       
+                       while( $row = $dbr->fetchObject( $res ) ) {
+                               $this->mOptionOverrides[$row->up_property] = $row->up_value;
+                               $this->mOptions[$row->up_property] = $row->up_value;
+                       }
+               }
+               
+               $this->mOptionsLoaded = true;
+               
+               wfRunHooks( 'UserLoadOptions', array( $this, &$this->mOptions ) );
+       }
+       
+       protected function saveOptions() {
+               global $wgAllowPrefChange;
+
+               $extuser = ExternalUser::newFromUser( $this );
+
+               $this->loadOptions();
+               $dbw = wfGetDB( DB_MASTER );
+               
+               $insert_rows = array();
+               
+               $saveOptions = $this->mOptions;
+               
+               // Allow hooks to abort, for instance to save to a global profile.
+               // Reset options to default state before saving.
+               if (!wfRunHooks( 'UserSaveOptions', array($this, &$saveOptions) ) )
+                       return;
+               
+               foreach( $saveOptions as $key => $value ) {
+                       # Don't bother storing default values
+                       if ( ( is_null( self::getDefaultOption( $key ) ) &&
+                                       !( $value === false || is_null($value) ) ) ||
+                                       $value != self::getDefaultOption( $key ) ) {
+                               $insert_rows[] = array(
+                                               'up_user' => $this->getId(),
+                                               'up_property' => $key,
+                                               'up_value' => $value,
+                                       );
+                       }
+                       if ( $extuser && isset( $wgAllowPrefChange[$key] ) ) {
+                               switch ( $wgAllowPrefChange[$key] ) {
+                                       case 'local': case 'message':
+                                               break;
+                                       case 'semiglobal': case 'global':
+                                               $extuser->setPref( $key, $value );
+                               }
+                       }
+               }
+               
+               $dbw->begin();
+               $dbw->delete( 'user_properties', array( 'up_user' => $this->getId() ), __METHOD__ );
+               $dbw->insert( 'user_properties', $insert_rows, __METHOD__ );
+               $dbw->commit();
+       }
 
+       /**
+        * Provide an array of HTML 5 attributes to put on an input element
+        * intended for the user to enter a new password.  This may include
+        * required, title, and/or pattern, depending on $wgMinimalPasswordLength.
+        *
+        * Do *not* use this when asking the user to enter his current password!
+        * Regardless of configuration, users may have invalid passwords for whatever
+        * reason (e.g., they were set before requirements were tightened up).
+        * Only use it when asking for a new password, like on account creation or
+        * ResetPass.
+        *
+        * Obviously, you still need to do server-side checking.
+        *
+        * @return array Array of HTML attributes suitable for feeding to
+        *   Html::element(), directly or indirectly.  (Don't feed to Xml::*()!
+        *   That will potentially output invalid XHTML 1.0 Transitional, and will
+        *   get confused by the boolean attribute syntax used.)
+        */
+       public static function passwordChangeInputAttribs() {
+               global $wgMinimalPasswordLength;
+
+               if ( $wgMinimalPasswordLength == 0 ) {
+                       return array();
+               }
+
+               # Note that the pattern requirement will always be satisfied if the
+               # input is empty, so we need required in all cases.
+               $ret = array( 'required' );
+
+               # We can't actually do this right now, because Opera 9.6 will print out
+               # the entered password visibly in its error message!  When other
+               # browsers add support for this attribute, or Opera fixes its support,
+               # we can add support with a version check to avoid doing this on Opera
+               # versions where it will be a problem.  Reported to Opera as
+               # DSK-262266, but they don't have a public bug tracker for us to follow.
+               /*
+               if ( $wgMinimalPasswordLength > 1 ) {
+                       $ret['pattern'] = '.{' . intval( $wgMinimalPasswordLength ) . ',}';
+                       $ret['title'] = wfMsgExt( 'passwordtooshort', 'parsemag',
+                               $wgMinimalPasswordLength );
+               }
+               */
+
+               return $ret;
+       }
 }