# either a GET parameter or a subpage-style parameter, so have a member
# variable for it.
protected $mTarget;
+ protected $isself = false;
public function __construct() {
parent::__construct( 'Userrights' );
public function userCanExecute( $user ) {
$available = $this->changeableGroups();
- return !empty( $available['add'] ) or !empty( $available['remove'] );
+ return !empty( $available['add'] )
+ or !empty( $available['remove'] )
+ or ($this->isself and
+ (!empty( $available['add-self'] )
+ or !empty( $available['remove-self'] )));
}
/**
function execute( $par ) {
// If the visitor doesn't have permissions to assign or remove
// any groups, it's a bit silly to give them the user search prompt.
- global $wgUser;
+ global $wgUser, $wgRequest;
+
+ if( $par ) {
+ $this->mTarget = $par;
+ } else {
+ $this->mTarget = $wgRequest->getVal( 'user' );
+ }
+
+ if (!$this->mTarget) {
+ /*
+ * If the user specified no target, and they can only
+ * edit their own groups, automatically set them as the
+ * target.
+ */
+ $available = $this->changeableGroups();
+ if (empty($available['add']) && empty($available['remove']))
+ $this->mTarget = $wgUser->getName();
+ }
+
+ if ($this->mTarget == $wgUser->getName())
+ $this->isself = true;
+
if( !$this->userCanExecute( $wgUser ) ) {
// fixme... there may be intermediate groups we can mention.
global $wgOut;
return;
}
- global $wgRequest;
- if( $par ) {
- $this->mTarget = $par;
- } else {
- $this->mTarget = $wgRequest->getVal( 'user' );
+ if ( wfReadOnly() ) {
+ global $wgOut;
+ $wgOut->readOnlyPage();
+ return;
}
+ $this->outputHeader();
+
$this->setHeaders();
// show the general form
* @return null
*/
function saveUserGroups( $username, $removegroup, $addgroup, $reason = '') {
+ global $wgUser, $wgGroupsAddToSelf, $wgGroupsRemoveFromSelf;
+
$user = $this->fetchUser( $username );
if( !$user ) {
return;
// Validate input set...
$changeable = $this->changeableGroups();
+ if ($wgUser->getId() != 0 && $wgUser->getId() == $user->getId()) {
+ $addable = array_merge($changeable['add'], $wgGroupsAddToSelf);
+ $removable = array_merge($changeable['remove'], $wgGroupsRemoveFromSelf);
+ } else {
+ $addable = $changeable['add'];
+ $removable = $changeable['remove'];
+ }
+
$removegroup = array_unique(
- array_intersect( (array)$removegroup, $changeable['remove'] ) );
+ array_intersect( (array)$removegroup, $removable ) );
$addgroup = array_unique(
- array_intersect( (array)$addgroup, $changeable['add'] ) );
+ array_intersect( (array)$addgroup, $addable ) );
$oldGroups = $user->getGroups();
$newGroups = $oldGroups;
wfRunHooks( 'UserRights', array( &$user, $addgroup, $removegroup ) );
}
- $log = new LogPage( 'rights' );
+ if( $newGroups != $oldGroups ) {
+ $log = new LogPage( 'rights' );
- global $wgRequest;
- $log->addEntry( 'rights',
- $user->getUserPage(),
- $wgRequest->getText( 'user-reason' ),
- array(
- $this->makeGroupNameList( $oldGroups ),
- $this->makeGroupNameList( $newGroups )
- )
- );
+ global $wgRequest;
+ $log->addEntry( 'rights',
+ $user->getUserPage(),
+ $wgRequest->getText( 'user-reason' ),
+ array(
+ $this->makeGroupNameList( $oldGroups ),
+ $this->makeGroupNameList( $newGroups )
+ )
+ );
+ }
}
/**
list( $name, $database ) = array_map( 'trim', $parts );
if( !$wgUser->isAllowed( 'userrights-interwiki' ) ) {
- $wgOut->addWikiText( wfMsg( 'userrights-no-interwiki' ) );
+ $wgOut->addWikiMsg( 'userrights-no-interwiki' );
return null;
}
if( !UserRightsProxy::validDatabase( $database ) ) {
- $wgOut->addWikiText( wfMsg( 'userrights-nodatabase', $database ) );
+ $wgOut->addWikiMsg( 'userrights-nodatabase', $database );
return null;
}
}
if( $name == '' ) {
- $wgOut->addWikiText( wfMsg( 'nouserspecified' ) );
+ $wgOut->addWikiMsg( 'nouserspecified' );
return false;
}
}
if( !$name ) {
- $wgOut->addWikiText( wfMsg( 'noname' ) );
+ $wgOut->addWikiMsg( 'noname' );
return null;
}
}
}
if( !$user || $user->isAnon() ) {
- $wgOut->addWikiText( wfMsg( 'nosuchusershort', wfEscapeWikiText( $username ) ) );
+ $wgOut->addWikiMsg( 'nosuchusershort', $username );
return null;
}
* @return Array: Tuple of addable, then removable groups
*/
protected function splitGroups( $groups ) {
+ global $wgGroupsAddToSelf, $wgGroupsRemoveFromSelf;
list($addable, $removable) = array_values( $this->changeableGroups() );
- $removable = array_intersect($removable, $groups ); // Can't remove groups the user doesn't have
- $addable = array_diff( $addable, $groups ); // Can't add groups the user does have
+
+ $removable = array_intersect(
+ array_merge($this->isself ? $wgGroupsRemoveFromSelf : array(), $removable),
+ $groups ); // Can't remove groups the user doesn't have
+ $addable = array_diff(
+ array_merge($this->isself ? $wgGroupsAddToSelf : array(), $addable),
+ $groups ); // Can't add groups the user does have
return array( $addable, $removable );
}
}
$wgOut->addHTML(
Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->getTitle()->escapeLocalURL(), 'name' => 'editGroup' ) ) .
- Xml::hidden( 'user', $user->getName() ) .
- Xml::hidden( 'wpEditToken', $wgUser->editToken( $user->getName() ) ) .
+ Xml::hidden( 'user', $this->mTarget ) .
+ Xml::hidden( 'wpEditToken', $wgUser->editToken( $this->mTarget ) ) .
Xml::openElement( 'fieldset' ) .
Xml::element( 'legend', array(), wfMsg( 'userrights-editusergroup' ) ) .
wfMsgExt( 'editinguser', array( 'parse' ),
global $wgUser, $wgLang;
$out = array();
- list( $add, $remove ) = array_values( $this->changeableGroups() );
+ list( $add, $remove, $addself, $rmself ) = array_values( $this->changeableGroups() );
if( count( $add ) > 0 )
- $out[] = wfMsgExt( 'userrights-available-add', 'parseinline', $wgLang->listToText( $add ), count( $add ) );
+ $out[] = wfMsgExt( 'userrights-available-add', 'parseinline',
+ $wgLang->listToText( $add ), count( $add ) );
if( count( $remove ) > 0 )
- $out[] = wfMsgExt( 'userrights-available-remove', 'parseinline', $wgLang->listToText( $remove ), count( $add ) );
+ $out[] = wfMsgExt( 'userrights-available-remove', 'parseinline',
+ $wgLang->listToText( $remove ), count( $add ) );
+ if( count( $addself ) > 0 )
+ $out[] = wfMsgExt( 'userrights-available-add-self', 'parseinline',
+ $wgLang->listToText( $addself ), count( $addself ) );
+ if( count( $rmself ) > 0 )
+ $out[] = wfMsgExt( 'userrights-available-remove-self', 'parseinline',
+ $wgLang->listToText( $rmself ), count( $rmself ) );
return count( $out ) > 0
? implode( '<br />', $out )
* @return Array array( 'add' => array( addablegroups ), 'remove' => array( removablegroups ) )
*/
function changeableGroups() {
- global $wgUser;
+ global $wgUser, $wgGroupsAddToSelf, $wgGroupsRemoveFromSelf;
if( $wgUser->isAllowed( 'userrights' ) ) {
// This group gives the right to modify everything (reverse-
$all = array_merge( User::getAllGroups() );
return array(
'add' => $all,
- 'remove' => $all
+ 'remove' => $all,
+ 'add-self' => array(),
+ 'remove-self' => array()
);
}
// Okay, it's not so simple, we will have to go through the arrays
- $groups = array( 'add' => array(), 'remove' => array() );
+ $groups = array(
+ 'add' => array(),
+ 'remove' => array(),
+ 'add-self' => $wgGroupsAddToSelf,
+ 'remove-self' => $wgGroupsRemoveFromSelf);
$addergroups = $wgUser->getEffectiveGroups();
foreach ($addergroups as $addergroup) {
dépôts / lhc / web / wiklou.git / blobdiff