oops
[lhc/web/wiklou.git] / includes / SpecialPreferences.php
index 687ed39..b608222 100644 (file)
@@ -5,7 +5,10 @@
  * @subpackage SpecialPage
  */
 
-/* to get a list of languages in setting user's language preference */
+if( !defined( 'MEDIAWIKI' ) )
+       die();
+
+/** to get a list of languages in setting user's language preference */
 require_once('languages/Names.php');
 
 /**
@@ -27,7 +30,7 @@ function wfSpecialPreferences() {
 class PreferencesForm {
        var $mQuickbar, $mOldpass, $mNewpass, $mRetypePass, $mStubs;
        var $mRows, $mCols, $mSkin, $mMath, $mDate, $mUserEmail, $mEmailFlag, $mNick;
-       var $mUserLanguage;
+       var $mUserLanguage, $mUserVariant;
        var $mSearch, $mRecent, $mHourDiff, $mSearchLines, $mSearchChars, $mAction;
        var $mReset, $mPosted, $mToggles, $mSearchNs, $mRealName, $mImageSize;
 
@@ -36,7 +39,7 @@ class PreferencesForm {
         * Load some values
         */
        function PreferencesForm( &$request ) { 
-               global $wgLang, $wgAllowRealName;
+               global $wgLang, $wgContLang, $wgUser, $wgAllowRealName;
                
                $this->mQuickbar = $request->getVal( 'wpQuickbar' );
                $this->mOldpass = $request->getVal( 'wpOldpass' );
@@ -53,17 +56,21 @@ class PreferencesForm {
                $this->mEmailFlag = $request->getCheck( 'wpEmailFlag' ) ? 1 : 0;
                $this->mNick = $request->getVal( 'wpNick' );
                $this->mUserLanguage = $request->getVal( 'wpUserLanguage' );
+               $this->mUserVariant = $request->getVal( 'wpUserVariant' );
                $this->mSearch = $request->getVal( 'wpSearch' );
                $this->mRecent = $request->getVal( 'wpRecent' );
                $this->mHourDiff = $request->getVal( 'wpHourDiff' );
                $this->mSearchLines = $request->getVal( 'wpSearchLines' );
                $this->mSearchChars = $request->getVal( 'wpSearchChars' );
                $this->mImageSize = $request->getVal( 'wpImageSize' );
+               $this->mThumbSize = $request->getInt( 'wpThumbSize' );
 
                $this->mAction = $request->getVal( 'action' );
                $this->mReset = $request->getCheck( 'wpReset' );
                $this->mPosted = $request->wasPosted();
-               $this->mSaveprefs = $request->getCheck( 'wpSaveprefs' ) && $this->mPosted;
+               $this->mSaveprefs = $request->getCheck( 'wpSaveprefs' ) &&
+                       $this->mPosted &&
+                       $wgUser->matchEditToken( $request->getVal( 'wpEditToken' ) );
 
                # User toggles  (the big ugly unsorted list of checkboxes)
                $this->mToggles = array();
@@ -80,19 +87,24 @@ class PreferencesForm {
                # Note: namespaces don't necessarily have consecutive keys
                $this->mSearchNs = array();
                if ( $this->mPosted ) {
-                       $namespaces = $wgLang->getNamespaces();
+                       $namespaces = $wgContLang->getNamespaces();
                        foreach ( $namespaces as $i => $namespace ) {
                                if ( $i >= 0 ) {
                                        $this->mSearchNs[$i] = $request->getCheck( "wpNs$i" ) ? 1 : 0;
                                }
                        }
                }
+
+               # Validate language
+               if ( !preg_match( '/^[a-z\-]*$/', $this->mUserLanguage ) ) {
+                       $this->mUserLanguage = 'nolanguage';
+               }
        }
 
        function execute() {
-               global $wgUser, $wgOut, $wgUseDynamicDates;
+               global $wgUser, $wgOut;
                
-               if ( 0 == $wgUser->getID() ) {
+               if ( $wgUser->isAnon() ) {
                        $wgOut->errorpage( 'prefsnologin', 'prefsnologintext' );
                        return;
                }
@@ -134,7 +146,13 @@ class PreferencesForm {
        }
 
        /**
+        * Used to validate the user inputed timezone before saving it as
+        * 'timeciorrection', will return '00:00' if fed bogus data.
+        * Note: It's not a 100% correct implementation timezone-wise, it will
+        * accept stuff like '14:30',
         * @access private
+        * @param string $s the user input
+        * @return string
         */
        function validateTimeZone( $s ) {
                if ( $s !== '' ) {
@@ -148,8 +166,10 @@ class PreferencesForm {
                                $hour = intval( $minute / 60 );
                                $minute = abs( $minute ) % 60;
                        }
-                       $hour = min( $hour, 15 );
-                       $hour = max( $hour, -15 );
+                       # Max is +14:00 and min is -12:00, see:
+                       # http://en.wikipedia.org/wiki/Timezone
+                       $hour = min( $hour, 14 );
+                       $hour = max( $hour, -12 );
                        $minute = min( $minute, 59 );
                        $minute = max( $minute, 0 );
                        $s = sprintf( "%02d:%02d", $hour, $minute );
@@ -161,7 +181,9 @@ class PreferencesForm {
         * @access private
         */
        function savePreferences() {
-               global $wgUser, $wgLang, $wgDeferredUpdateList, $wgOut;
+               global $wgUser, $wgLang, $wgOut;
+               global $wgEnableUserEmail, $wgEnableEmail;
+               global $wgEmailAuthentication, $wgMinimalPasswordLength;
 
                if ( '' != $this->mNewpass ) {
                        if ( $this->mNewpass != $this->mRetypePass ) {
@@ -169,15 +191,20 @@ class PreferencesForm {
                                return;
                        }
 
+                       if ( strlen( $this->mNewpass ) < $wgMinimalPasswordLength ) {
+                               $this->mainPrefsForm( wfMsg( 'passwordtooshort', $wgMinimalPasswordLength ) );
+                               return;
+                       }
+
                        if (!$wgUser->checkPassword( $this->mOldpass )) {
                                $this->mainPrefsForm( wfMsg( 'wrongpassword' ) );
                                return;
                        }
                        $wgUser->setPassword( $this->mNewpass );
                }
-               $wgUser->setEmail( $this->mUserEmail );
                $wgUser->setRealName( $this->mRealName );
                $wgUser->setOption( 'language', $this->mUserLanguage );
+               $wgUser->setOption( 'variant', $this->mUserVariant );
                $wgUser->setOption( 'nickname', $this->mNick );
                $wgUser->setOption( 'quickbar', $this->mQuickbar );
                $wgUser->setOption( 'skin', $this->mSkin );
@@ -192,21 +219,55 @@ class PreferencesForm {
                $wgUser->setOption( 'stubthreshold', $this->validateIntOrNull( $this->mStubs ) );
                $wgUser->setOption( 'timecorrection', $this->validateTimeZone( $this->mHourDiff, -12, 14 ) );
                $wgUser->setOption( 'imagesize', $this->mImageSize );
+               $wgUser->setOption( 'thumbsize', $this->mThumbSize );
 
                # Set search namespace options
                foreach( $this->mSearchNs as $i => $value ) {
                        $wgUser->setOption( "searchNs{$i}", $value );
                }
                
-               $wgUser->setOption( 'disablemail', $this->mEmailFlag );
+               if( $wgEnableEmail && $wgEnableUserEmail ) {
+                       $wgUser->setOption( 'disablemail', $this->mEmailFlag );
+               }
 
                # Set user toggles
                foreach ( $this->mToggles as $tname => $tvalue ) {
                        $wgUser->setOption( $tname, $tvalue );
                }
                $wgUser->setCookies();
-               $up = new UserUpdate();
-               array_push( $wgDeferredUpdateList, $up );
+               $wgUser->saveSettings();
+               
+               if( $wgEnableEmail ) {
+                       $newadr = strtolower( $this->mUserEmail );
+                       $oldadr = strtolower($wgUser->getEmail());
+                       if (($newadr <> '') && ($newadr <> $oldadr)) { # the user has supplied a new email address on the login page
+                               # prepare for authentication and mail a temporary password to newadr
+                               require_once( 'SpecialUserlogin.php' );
+                               if ( !$wgUser->isValidEmailAddr( $newadr ) ) {
+                                       $this->mainPrefsForm( wfMsg( 'invalidemailaddress' ) );
+                                       return;
+                               }
+                               $wgUser->mEmail = $newadr; # new behaviour: set this new emailaddr from login-page into user database record
+                               $wgUser->mEmailAuthenticationtimestamp = 0; # but flag as "dirty" = unauthenticated
+                               $wgUser->saveSettings();
+                               if ($wgEmailAuthentication) {
+                                       # mail a temporary password to the dirty address
+                                       # on "save options", this user will be logged-out automatically
+                                       $error = LoginForm::mailPasswordInternal( $wgUser, true, $dummy );
+                                       if ($error === '') {
+                                               return LoginForm::mainLoginForm( wfMsg( 'passwordsentforemailauthentication', $wgUser->getName() ) );
+                                       } else {
+                                               return LoginForm::mainLoginForm( wfMsg( 'mailerror', $error ) );
+                                       }
+                                       # if user returns, that new email address gets authenticated in checkpassword()
+                               }
+                       } else {
+                               $wgUser->setEmail( strtolower($this->mUserEmail) );
+                               $wgUser->setCookies();
+                               $wgUser->saveSettings();
+                       }
+               }
+
                $wgOut->setParserOptions( ParserOptions::newFromUser( $wgUser ) );
                $po = ParserOptions::newFromUser( $wgUser );
                $this->mainPrefsForm( wfMsg( 'savedprefs' ) );
@@ -216,12 +277,19 @@ class PreferencesForm {
         * @access private
         */
        function resetPrefs() {
-               global $wgUser, $wgLang, $wgAllowRealName;
+               global $wgUser, $wgLang, $wgContLang, $wgAllowRealName;
 
                $this->mOldpass = $this->mNewpass = $this->mRetypePass = '';
                $this->mUserEmail = $wgUser->getEmail();
+               $this->mUserEmailAuthenticationtimestamp = $wgUser->getEmailAuthenticationtimestamp();
                $this->mRealName = ($wgAllowRealName) ? $wgUser->getRealName() : '';
-               $this->mUserLanguage = $wgUser->getOption( 'language');
+               $this->mUserLanguage = $wgUser->getOption( 'language' );
+               if( empty( $this->mUserLanguage ) ) {
+                       # Quick hack for conversions, where this value is blank
+                       global $wgContLanguageCode;
+                       $this->mUserLanguage = $wgContLanguageCode;
+               }
+               $this->mUserVariant = $wgUser->getOption( 'variant');
                if ( 1 == $wgUser->getOption( 'disablemail' ) ) { $this->mEmailFlag = 1; }
                else { $this->mEmailFlag = 0; }
                $this->mNick = $wgUser->getOption( 'nickname' );
@@ -238,6 +306,7 @@ class PreferencesForm {
                $this->mSearchLines = $wgUser->getOption( 'contextlines' );
                $this->mSearchChars = $wgUser->getOption( 'contextchars' );
                $this->mImageSize = $wgUser->getOption( 'imagesize' );
+               $this->mThumbSize = $wgUser->getOption( 'thumbsize' );
                $this->mRecent = $wgUser->getOption( 'rclimit' );
 
                $togs = $wgLang->getUserToggles();
@@ -246,7 +315,7 @@ class PreferencesForm {
                        $this->mToggles[$tname] = $wgUser->getOption( $tname );
                }
 
-               $namespaces = $wgLang->getNamespaces();
+               $namespaces = $wgContLang->getNamespaces();
                foreach ( $namespaces as $i => $namespace ) {
                        if ( $i >= 0 ) {
                                $this->mSearchNs[$i] = $wgUser->getOption( 'searchNs'.$i );
@@ -258,10 +327,10 @@ class PreferencesForm {
         * @access private
         */
        function namespacesCheckboxes() {
-               global $wgLang, $wgUser;
+               global $wgContLang, $wgUser;
                
                # Determine namespace checkboxes
-               $namespaces = $wgLang->getNamespaces();
+               $namespaces = $wgContLang->getNamespaces();
                $r1 = '';
 
                foreach ( $namespaces as $i => $name ) {
@@ -288,7 +357,7 @@ class PreferencesForm {
        }
 
 
-       function getToggle( $tname ) {
+       function getToggle( $tname, $trailer = false) {
                global $wgUser, $wgLang;
                
                $this->mUsedToggles[$tname] = true;
@@ -299,19 +368,22 @@ class PreferencesForm {
                } else {
                        $checked = '';
                }               
+               $trailer =($trailer) ? $trailer : '';
                return "<div><input type='checkbox' value=\"1\" "
-                 . "id=\"$tname\" name=\"wpOp$tname\"$checked /><label for=\"$tname\">$ttext</label></div>\n";
+                 . "id=\"$tname\" name=\"wpOp$tname\"$checked /><label for=\"$tname\">$ttext</label>$trailer</div>\n";
        }
 
        /**
         * @access private
         */
-
        function mainPrefsForm( $err ) {
-               global $wgUser, $wgOut, $wgLang, $wgUseDynamicDates, $wgValidSkinNames;
-               global $wgAllowRealName, $wgImageLimits;
-        
-           global $wgLanguageNames;
+               global $wgUser, $wgOut, $wgLang, $wgContLang, $wgValidSkinNames;
+               global $wgAllowRealName, $wgImageLimits, $wgThumbLimits;
+               global $wgLanguageNames, $wgDisableLangConversion;
+               global $wgEmailNotificationForWatchlistPages, $wgEmailNotificationForUserTalkPages,$wgEmailNotificationForMinorEdits;
+               global $wgRCShowWatchingUsers, $wgEmailNotificationRevealPageEditorAddress;
+               global $wgEnableEmail, $wgEnableUserEmail, $wgEmailAuthentication;
+               global $wgContLanguageCode;
 
                $wgOut->setPageTitle( wfMsg( 'preferences' ) );
                $wgOut->setArticleRelated( false );
@@ -339,6 +411,7 @@ class PreferencesForm {
                $cp = wfMsg( 'changepassword' );
                $sk = wfMsg( 'skin' );
                $math = wfMsg( 'math' );
+               $files = wfMsg( 'files' );
                $dateFormat = wfMsg('dateformat');
                $opw = wfMsg( 'oldpassword' );
                $npw = wfMsg( 'newpassword' );
@@ -357,6 +430,7 @@ class PreferencesForm {
                $yem = wfMsg( 'youremail' );
                $yrn = ($wgAllowRealName) ? wfMsg( 'yourrealname' ) : '';
                $yl  = wfMsg( 'yourlanguage' );
+               $yv  = wfMsg( 'yourvariant' );
                $emf = wfMsg( 'emailflag' );
                $ynn = wfMsg( 'yournick' );
                $stt = wfMsg ( 'stubthreshold' ) ;
@@ -379,25 +453,104 @@ class PreferencesForm {
                if ( $this->mEmailFlag ) { $emfc = 'checked="checked"'; }
                else { $emfc = ''; }
 
+               if ($wgEmailAuthentication && ($this->mUserEmail != '') ) {
+                       if ($wgUser->getEmailAuthenticationtimestamp() != 0) {
+                               $emailauthenticated = wfMsg('emailauthenticated',$wgLang->timeanddate($wgUser->getEmailAuthenticationtimestamp(), true ) ).'<br />';
+                               $disabled = '';
+                       } else {
+                               $emailauthenticated = wfMsg('emailnotauthenticated').'<br />';
+                               $disabled = ' '.wfMsg('disableduntilauthent');
+                       }
+               } else {
+                       $emailauthenticated = '';
+               }
+
+               if ($this->mUserEmail == '') {
+                       $disabled = ' '.wfMsg('disablednoemail');
+               }
+
                $ps = $this->namespacesCheckboxes();
 
+               $enotifwatchlistpages = ($wgEmailNotificationForWatchlistPages) ? $this->getToggle( 'enotifwatchlistpages', $disabled) : '';
+               $enotifusertalkpages = ($wgEmailNotificationForUserTalkPages) ? $this->getToggle( 'enotifusertalkpages', $disabled) : '';
+               $enotifminoredits = ($wgEmailNotificationForMinorEdits) ? $this->getToggle( 'enotifminoredits', $disabled) : '';
+               $enotifrevealaddr = ($wgEmailNotificationRevealPageEditorAddress) ? $this->getToggle( 'enotifrevealaddr', $disabled) : '';
+               $prefs_help_email_enotif = ( $wgEmailNotificationForWatchlistPages || $wgEmailNotificationForUserTalkPages) ? ' ' . wfMsg('prefs-help-email-enotif') : '';
+               $prefs_help_realname = '';
+
                $wgOut->addHTML( "<fieldset>
                <legend>".wfMsg('prefs-personal')."</legend>");
-               if ($wgAllowRealName) {
-                   $wgOut->addHTML("<div><label>$yrn: <input type='text' name=\"wpRealName\" value=\"{$this->mRealName}\" size='20' /></label></div>");
+
+                       if ($wgAllowRealName) {
+                       $wgOut->addHTML("<div><label>$yrn: <input type='text' name=\"wpRealName\" value=\"{$this->mRealName}\" size='20' /></label></div>");
+                       $prefs_help_realname = wfMsg('prefs-help-realname').'<br />';
+               }
+               
+               if( $wgEnableEmail ) {
+                       $wgOut->addHTML("
+                       <div><label>$yem: <input type='text' name=\"wpUserEmail\" value=\"{$this->mUserEmail}\" size='20' /></label></div>" );
+                       $wgOut->addHTML(
+                               $emailauthenticated.
+                               $enotifrevealaddr.
+                               $enotifwatchlistpages.
+                               $enotifusertalkpages.
+                               $enotifminoredits );
+                       if( $wgEnableUserEmail ) {
+                               $wgOut->addHTML(
+                               "<div><label><input type='checkbox' $emfc value=\"1\" name=\"wpEmailFlag\" />$emf.$disabled</label></div>" );
+                       }
                }
-               $wgOut->addHTML("
-               <div><label>$yem: <input type='text' name=\"wpUserEmail\" value=\"{$this->mUserEmail}\" size='20' /></label></div>
-               <div><label><input type='checkbox' $emfc value=\"1\" name=\"wpEmailFlag\" /> $emf</label></div>
-               <div><label>$ynn: <input type='text' name=\"wpNick\" value=\"{$this->mNick}\" size='12' /></label></div>
-               <div><label>$yl: <select name=\"wpUserLanguage\" />\n");
-
-        foreach($wgLanguageNames as $code => $name) {
-            $sel = ($code == $this->mUserLanguage)? "selected" : "";
-            $wgOut->addHtml("\t<option value=\"$code\" $sel>$code - $name</option>\n");
-        }
-        $wgOut->addHtml("</label></div>\n" );
+               
+               $fancysig = $this->getToggle( 'fancysig' );
+               $wgOut->addHTML("
+               <div><label>$ynn: <input type='text' name=\"wpNick\" value=\"{$this->mNick}\" size='25' /></label></div>
+               <div>$fancysig<br /></div>
+               <div><label>$yl: <select name=\"wpUserLanguage\">\n");
+
+               /**
+                * If a bogus value is set, default to the content language.
+                * Otherwise, no default is selected and the user ends up
+                * with an Afrikaans interface since it's first in the list.
+                */
+               if( isset( $wgLanguageNames[$this->mUserLanguage] ) ) {
+                       $selectedLang = $this->mUserLanguage;
+               } else {
+                       $selectedLang = $wgContLanguageCode;
+               }
+               foreach($wgLanguageNames as $code => $name) {
+                       global $IP;
+                       /* only add languages that have a file */
+                       $langfile="$IP/languages/Language".str_replace('-', '_', ucfirst($code)).".php";
+                       if(file_exists($langfile) || $code == $wgContLanguageCode) {
+                               $sel = ($code == $selectedLang)? 'selected="selected"' : '';
+                               $wgOut->addHtml("\t<option value=\"$code\" $sel>$code - $name</option>\n");
+                       }
+               }
+               $wgOut->addHtml("</select></label></div>\n" );
 
+               /* see if there are multiple language variants to choose from*/
+               if(!$wgDisableLangConversion) {
+                       $variants = $wgContLang->getVariants();
+                       $size=sizeof($variants);
+               
+                       $variantArray=array();
+                       foreach($variants as $v) {
+                               $v = str_replace( '_', '-', strtolower($v));
+                               if($name=$wgLanguageNames[$v]) {
+                                       $variantArray[$v] = $name;
+                               }
+                       }
+                       $size=sizeof($variantArray);
+               
+                       if(sizeof($variantArray) > 1) {
+                       $wgOut->addHtml("
+                               <div><label>$yv: <select name=\"wpUserVariant\">\n");
+                               foreach($variantArray as $code => $name) {
+                                       $sel = ($code==$this->mUserVariant)? 'selected="selected"' : '';
+                                       $wgOut->addHtml("\t<option value=\"$code\" $sel>$code - $name</option>\n");
+                               }
+                       }
+               }
                # Fields for changing password
                #
                $this->mOldpass = htmlspecialchars( $this->mOldpass );
@@ -411,20 +564,19 @@ class PreferencesForm {
        <div><label>$rpw: <input type='password' name=\"wpRetypePass\" value=\"{$this->mRetypePass}\" size='20' /></label></div>
        " . $this->getToggle( "rememberpassword" ) . "
        </fieldset>
-       <div class='prefsectiontip'>".wfMsg('prefs-help-userdata')."</div>\n</fieldset>\n" );
+       <div class='prefsectiontip'>".$prefs_help_realname.wfMsg('prefs-help-email').$prefs_help_email_enotif."</div>\n</fieldset>\n" );
 
-       
                # Quickbar setting
                #
-               $wgOut->addHtml( "<fieldset>\n<legend>$qb</legend>\n" );
-               for ( $i = 0; $i < count( $qbs ); ++$i ) {
-                       if ( $i == $this->mQuickbar ) { $checked = ' checked="checked"'; }
-                       else { $checked = ""; }
-                       $wgOut->addHTML( "<div><label><input type='radio' name=\"wpQuickbar\"
-       value=\"$i\"$checked /> {$qbs[$i]}</label></div>\n" );
+               if ($this->mSkin == 'cologneblue' || $this->mSkin == 'standard') {
+                       $wgOut->addHtml( "<fieldset>\n<legend>$qb</legend>\n" );
+                       for ( $i = 0; $i < count( $qbs ); ++$i ) {
+                               if ( $i == $this->mQuickbar ) { $checked = ' checked="checked"'; }
+                               else { $checked = ""; }
+                               $wgOut->addHTML( "<div><label><input type='radio' name=\"wpQuickbar\" value=\"$i\"$checked />{$qbs[$i]}</label></div>\n" );
+                       }
+                       $wgOut->addHtml( "</fieldset>\n\n" );
                }
-               $wgOut->addHtml('<div class="prefsectiontip">'.wfMsg('qbsettingsnote').'</div>');
-               $wgOut->addHtml( "</fieldset>\n\n" );
 
                # Skin setting
                #
@@ -442,8 +594,11 @@ class PreferencesForm {
                        } else {
                                $sn = $skinname;
                        }
-                       $wgOut->addHTML( "<div><label><input type='radio' name=\"wpSkin\"
-       value=\"$skinkey\"$checked /> {$sn}</label></div>\n" );
+                       global $wgDefaultSkin;
+                       if( $skinkey == $wgDefaultSkin ) {
+                               $sn .= ' (' . wfMsg( 'default' ) . ')';
+                       }
+                       $wgOut->addHTML( "<div><label><input type='radio' name=\"wpSkin\" value=\"$skinkey\"$checked /> {$sn}</label></div>\n" );
                }
                $wgOut->addHTML( "</fieldset>\n\n" );
 
@@ -457,64 +612,87 @@ class PreferencesForm {
        value=\"$i\"$checked /> ".wfMsg($mathopts[$i])."</label></div>\n" );
                }
                $wgOut->addHTML( "</fieldset>\n\n" );
-               
-               # Date format
+
+               # Files
                #
-               if ( $wgUseDynamicDates ) {
+               $wgOut->addHTML("<fieldset>
+                       <legend>$files</legend>
+                       <div><label>" . wfMsg('imagemaxsize') . "<select name=\"wpImageSize\">");
+                       
+                       $imageLimitOptions = null;
+                       foreach ( $wgImageLimits as $index => $limits ) {
+                               $selected = ($index == $this->mImageSize) ? 'selected="selected"' : '';
+                               $imageLimitOptions .= "<option value=\"{$index}\" {$selected}>{$limits[0]}x{$limits[1]}</option>\n";
+                       }
+                       
+                       $imageThumbOptions = null;
+                       $wgOut->addHTML( "{$imageLimitOptions}</select></label></div>
+                               <div><label>" . wfMsg('thumbsize') . "<select name=\"wpThumbSize\">");
+                       foreach ( $wgThumbLimits as $index => $size ) {
+                               $selected = ($index == $this->mThumbSize) ? 'selected="selected"' : '';
+                               $imageThumbOptions .= "<option value=\"{$index}\" {$selected}>{$size}px</option>\n";
+                       }
+                       $wgOut->addHTML( "{$imageThumbOptions}</select></label></div></fieldset>\n\n");
+
+                # Date format
+                #
+               if ($dateopts) {
                        $wgOut->addHTML( "<fieldset>\n<legend>$dateFormat</legend>\n" );
-                       for ( $i = 0; $i < count( $dateopts ); ++$i) {
-                               if ( $i == $this->mDate ) {
-                                       $checked = ' checked="checked"';
-                               } else {
-                                       $checked = "";
-                               }
+                       foreach($dateopts as $key => $option) {
+                               ($key == $this->mDate) ? $checked = ' checked="checked"' : $checked = '';
                                $wgOut->addHTML( "<div><label><input type='radio' name=\"wpDate\" ".
-                                       "value=\"$i\"$checked /> {$dateopts[$i]}</label></div>\n" );
+                                       "value=\"$key\"$checked />$option</label></div>\n" );
                        }
                        $wgOut->addHTML( "</fieldset>\n\n");
                }
-               
-               # Textbox rows, cols
+
+               # Time zone
                #
+               
                $nowlocal = $wgLang->time( $now = wfTimestampNow(), true );
                $nowserver = $wgLang->time( $now, false );
+                
+               $wgOut->addHTML( "<fieldset>
+                       <legend>$timezone</legend>
+                       <div><b>$tzServerTime:</b>" .  $nowserver . "</div>
+                       <div><b>$ltz:</b> $nowlocal</div>
+                       <div><label>$tzo*: <input type='text' name=\"wpHourDiff\" value=\"" . htmlspecialchars( $this->mHourDiff ) . "\" size='6' /></label></div>
+                       <div><input type=\"button\" value=\"$tzGuess\" onclick=\"javascript:guessTimezone()\" id=\"guesstimezonebutton\" style=\"display:none\" /></div>
+                       <div class='prefsectiontip'>* {$tzt}</div>
+               </fieldset>\n\n" );             
+               
+               # Editing
+               #
                $wgOut->addHTML( "<fieldset>
        <legend>$tbs</legend>\n
                <div>
                        <label>$tbr: <input type='text' name=\"wpRows\" value=\"{$this->mRows}\" size='6' /></label>
                        <label>$tbc: <input type='text' name=\"wpCols\" value=\"{$this->mCols}\" size='6' /></label>
                </div> " .
+               $this->getToggle( "editsection" ) .
+               $this->getToggle( "editsectiononrightclick" ) .
+               $this->getToggle( "editondblclick" ) .
                $this->getToggle( "editwidth" ) .
                $this->getToggle( "showtoolbar" ) .
+               $this->getToggle( "previewonfirst" ) .
                $this->getToggle( "previewontop" ) .
                $this->getToggle( "watchdefault" ) .
-               $this->getToggle( "minordefault" ) . "
-       </fieldset>
+               $this->getToggle( "minordefault" ) . 
+               $this->getToggle( "externaleditor" ) .
+               $this->getToggle( "externaldiff" ) .
+               "
+       </fieldset>");
        
-       <fieldset>
-               <legend>$timezone</legend>
-               <div><b>$tzServerTime:</b> $nowserver</div>
-               <div><b>$ltz:</b> $nowlocal</div>
-               <div><label>$tzo*: <input type='text' name=\"wpHourDiff\" value=\"{$this->mHourDiff}\" size='6' /></label></div>
-               <div><input type=\"button\" value=\"$tzGuess\" onClick=\"javascript:guessTimezone()\" id=\"guesstimezonebutton\" style=\"display:none\" /></div>
-               <div class='prefsectiontip'>* {$tzt}</div>
-       </fieldset>\n\n" );
+               $shownumberswatching = ($wgRCShowWatchingUsers) ? $this->getToggle('shownumberswatching') : '';
 
                $wgOut->addHTML( "
        <fieldset><legend>".wfMsg('prefs-rc')."</legend>
-               <div><label>$rcc: <input type='text' name=\"wpRecent\" value=\"$this->mRecent\" size='6' /></label></div>
-               " . $this->getToggle( "hideminor" ) .
-               $this->getToggle( "usenewrc" ) . "
-               <div><label>$stt: <input type='text' name=\"wpStubs\" value=\"$this->mStubs\" size='6' /></label></div>
-                <div><label>".wfMsg('imagemaxsize')."<select name=\"wpImageSize\">");
-               
-               $imageLimitOptions='';
-               foreach ( $wgImageLimits as $index => $limits ) {
-                       $selected = ($index == $this->mImageSize) ? ' selected ': '';
-                       $imageLimitOptions .= "<option value=\"{$index}\" {$selected}>{$limits[0]}x{$limits[1]}</option>\n";
-               }
-               $wgOut->addHTML( "{$imageLimitOptions}</select></label></div>
-
+               <div><label>$rcc: <input type='text' name=\"wpRecent\" value=\"$this->mRecent\" size='6' /></label></div>" .
+               $this->getToggle( "hideminor" ) . $shownumberswatching .
+               $this->getToggle( "usenewrc" ) . 
+               $this->getToggle( "rcusemodstyle" ) .
+               $this->getToggle('showupdated', wfMsg('updatedmarker')) .
+               "<div><label>$stt: <input type='text' name=\"wpStubs\" value=\"$this->mStubs\" size='6' /></label></div>
        </fieldset>
        
        <fieldset>
@@ -533,6 +711,7 @@ class PreferencesForm {
                # Various checkbox options
                #
                $wgOut->addHTML("<fieldset><legend>".wfMsg('prefs-misc')."</legend>");
+
                foreach ( $togs as $tname ) {
                        if( !array_key_exists( $tname, $this->mUsedToggles ) ) {
                                $wgOut->addHTML( $this->getToggle( $tname ) );
@@ -540,6 +719,7 @@ class PreferencesForm {
                }
                $wgOut->addHTML( "</fieldset>\n\n" );
 
+               $token = htmlspecialchars( $wgUser->editToken() );
                $wgOut->addHTML( "
        <div id='prefsubmit'>
        <div>
@@ -550,6 +730,7 @@ class PreferencesForm {
        
        </div>
        
+       <input type='hidden' name='wpEditToken' value=\"{$token}\" />
        </form>\n" );
        }
 }