With &debugmsg=1, PHP output a warning because the link trail no longer

[lhc/web/wiklou.git] / includes / SpecialPopularpages.php

diff --git a/includes/SpecialPopularpages.php b/includes/SpecialPopularpages.php
index 387ecbe..23ad570 100644 (file)
--- a/includes/SpecialPopularpages.php
+++ b/includes/SpecialPopularpages.php
@@ -1,47 +1,46 @@
-<?
+<?php
 
-function wfSpecialPopularpages()
-{
-       global $wgUser, $wgOut, $wgLang, $wgTitle;
-       global $limit, $offset; # From query string
-       $fname = "wfSpecialPopularpages";
-
-       global $wgMiserMode;
-       if ( $wgMiserMode ) {
-               $wgOut->addWikiText( wfMsg( "perfdisabled" ) );
-               return;
-       }
+require_once( "QueryPage.php" );
 
-       if ( ! $limit ) {
-               $limit = $wgUser->getOption( "rclimit" );
-               if ( ! $limit ) { $limit = 50; }
-       }
-       if ( ! $offset ) { $offset = 0; }
-
-       $sql = "SELECT DISTINCT cur_title, cur_counter FROM cur " .
-         "WHERE cur_namespace=0 AND cur_is_redirect=0 ORDER BY " .
-         "cur_counter DESC LIMIT {$offset}, {$limit}";
-       $res = wfQuery( $sql, $fname );
+class PopularPagesPage extends QueryPage {
 
-       $sk = $wgUser->getSkin();
+       function getName() {
+               return "Popularpages";
+       }
 
-       $top = wfShowingResults( $offset, $limit );
-       $wgOut->addHTML( "<p>{$top}\n" );
+       function isExpensive() {
+               # cur_counter is not indexed
+               return true;
+       }
 
-       $sl = wfViewPrevNext( $offset, $limit,
-         $wgLang->specialPage( "Popularpages" ) );
-       $wgOut->addHTML( "<br>{$sl}\n" );
+       function getSQL() {
+               $dbr =& wfGetDB( DB_SLAVE );
+               $cur = $dbr->tableName( 'cur' );
+
+               return
+                       "SELECT 'Popularpages' as type,
+                               cur_namespace as namespace,
+                               cur_title as title,
+                               cur_counter as value
+                       FROM $cur
+                       WHERE cur_namespace=0 AND cur_is_redirect=0";
+       }
 
-       $s = "<ol start=" . ( $offset + 1 ) . ">";
-       while ( $obj = wfFetchObject( $res ) ) {
-               $nv = str_replace( "$1", $obj->cur_counter, wfMsg( "nviews" ) );
-               $link = $sk->makeKnownLink( $obj->cur_title, "" );
-               $s .= "<li>{$link} ({$nv})</li>\n";
+       function formatResult( $skin, $result ) {
+               global $wgLang;
+               $link = $skin->makeKnownLink( $result->title, "" );
+               $nv = wfMsg( "nviews", $wgLang->formatNum( $result->value ) );
+               return "{$link} ({$nv})";
        }
-       wfFreeResult( $res );
-       $s .= "</ol>";
-       $wgOut->addHTML( $s );
-       $wgOut->addHTML( "<p>{$sl}\n" );
+}
+
+function wfSpecialPopularpages()
+{
+    list( $limit, $offset ) = wfCheckLimits();
+    
+    $ppp = new PopularPagesPage();
+    
+    return $ppp->doQuery( $offset, $limit );
 }
 
 ?>