(bug 28978) jquery.autoEllipsis cache doesn't take position into account, leads to...
[lhc/web/wiklou.git] / includes / SkinTemplate.php
index 4f60d55..7351265 100644 (file)
@@ -116,10 +116,10 @@ class SkinTemplate extends Skin {
         * and eventually it spits out some HTML. Should have interface
         * roughly equivalent to PHPTAL 0.7.
         *
-        * @param $classname string (or file)
+        * @param $classname String
         * @param $repository string: subdirectory where we keep template files
         * @param $cache_dir string
-        * @return object
+        * @return QuickTemplate
         * @private
         */
        function setupTemplate( $classname, $repository = false, $cache_dir = false ) {
@@ -134,18 +134,16 @@ class SkinTemplate extends Skin {
        function outputPage( OutputPage $out ) {
                global $wgUser, $wgLang, $wgContLang;
                global $wgScript, $wgStylePath, $wgLanguageCode;
-               global $wgMimeType, $wgJsMimeType, $wgOutputEncoding, $wgRequest;
+               global $wgMimeType, $wgJsMimeType, $wgRequest;
                global $wgXhtmlDefaultNamespace, $wgXhtmlNamespaces, $wgHtml5Version;
                global $wgDisableCounters, $wgLogo, $wgHideInterlanguageLinks;
                global $wgMaxCredits, $wgShowCreditsIfMax;
                global $wgPageShowWatchingUsers;
                global $wgUseTrackbacks, $wgUseSiteJs, $wgDebugComments;
-               global $wgArticlePath, $wgScriptPath, $wgServer, $wgProfiler;
+               global $wgArticlePath, $wgScriptPath, $wgServer;
 
                wfProfileIn( __METHOD__ );
-               if ( is_object( $wgProfiler ) ) {
-                       $wgProfiler->setTemplated( true );
-               }
+               Profiler::instance()->setTemplated( true );
 
                $oldid = $wgRequest->getVal( 'oldid' );
                $diff = $wgRequest->getVal( 'diff' );
@@ -154,13 +152,12 @@ class SkinTemplate extends Skin {
                wfProfileIn( __METHOD__ . '-init' );
                $this->initPage( $out );
 
-               $this->setMembers();
                $tpl = $this->setupTemplate( $this->template, 'skins' );
                wfProfileOut( __METHOD__ . '-init' );
 
                wfProfileIn( __METHOD__ . '-stuff' );
-               $this->thispage = $this->mTitle->getPrefixedDBkey();
-               $this->thisurl = $this->mTitle->getPrefixedURL();
+               $this->thispage = $this->getTitle()->getPrefixedDBkey();
+               $this->thisurl = $this->getTitle()->getPrefixedURL();
                $query = array();
                if ( !$wgRequest->wasPosted() ) {
                        $query = $wgRequest->getValues();
@@ -170,7 +167,7 @@ class SkinTemplate extends Skin {
                }
                $this->thisquery = wfUrlencode( wfArrayToCGI( $query ) );
                $this->loggedin = $wgUser->isLoggedIn();
-               $this->iscontent = ( $this->mTitle->getNamespace() != NS_SPECIAL );
+               $this->iscontent = ( $this->getTitle()->getNamespace() != NS_SPECIAL );
                $this->iseditable = ( $this->iscontent and !( $action == 'edit' or $action == 'submit' ) );
                $this->username = $wgUser->getName();
 
@@ -182,7 +179,7 @@ class SkinTemplate extends Skin {
                        $this->userpageUrlDetails = self::makeKnownUrlDetails( $this->userpage );
                }
 
-               $this->titletxt = $this->mTitle->getPrefixedText();
+               $this->titletxt = $this->getTitle()->getPrefixedText();
                wfProfileOut( __METHOD__ . '-stuff' );
 
                wfProfileIn( __METHOD__ . '-stuff-head' );
@@ -194,7 +191,7 @@ class SkinTemplate extends Skin {
                        $this->setupUserCss( $out );
 
                        $tpl->set( 'pagecss', $this->setupPageCss() );
-                       $tpl->setRef( 'usercss', $this->usercss );
+                       $tpl->set( 'usercss', false );
 
                        $this->userjs = $this->userjsprev = false;
                        # FIXME: this is the only use of OutputPage::isUserJsAllowed() anywhere; can we
@@ -231,19 +228,19 @@ class SkinTemplate extends Skin {
                $tpl->set( 'title', $out->getPageTitle() );
                $tpl->set( 'pagetitle', $out->getHTMLTitle() );
                $tpl->set( 'displaytitle', $out->mPageLinkTitle );
-               $tpl->set( 'pageclass', $this->getPageClasses( $this->mTitle ) );
+               $tpl->set( 'pageclass', $this->getPageClasses( $this->getTitle() ) );
                $tpl->set( 'skinnameclass', ( 'skin-' . Sanitizer::escapeClass( $this->getSkinName() ) ) );
 
-               $nsname = MWNamespace::exists( $this->mTitle->getNamespace() ) ?
-                                       MWNamespace::getCanonicalName( $this->mTitle->getNamespace() ) :
-                                       $this->mTitle->getNsText();
+               $nsname = MWNamespace::exists( $this->getTitle()->getNamespace() ) ?
+                                       MWNamespace::getCanonicalName( $this->getTitle()->getNamespace() ) :
+                                       $this->getTitle()->getNsText();
 
                $tpl->set( 'nscanonical', $nsname );
-               $tpl->set( 'nsnumber', $this->mTitle->getNamespace() );
-               $tpl->set( 'titleprefixeddbkey', $this->mTitle->getPrefixedDBKey() );
-               $tpl->set( 'titletext', $this->mTitle->getText() );
-               $tpl->set( 'articleid', $this->mTitle->getArticleId() );
-               $tpl->set( 'currevisionid', $this->mTitle->getLatestRevID() );
+               $tpl->set( 'nsnumber', $this->getTitle()->getNamespace() );
+               $tpl->set( 'titleprefixeddbkey', $this->getTitle()->getPrefixedDBKey() );
+               $tpl->set( 'titletext', $this->getTitle()->getText() );
+               $tpl->set( 'articleid', $this->getTitle()->getArticleId() );
+               $tpl->set( 'currevisionid', $this->getTitle()->getLatestRevID() );
 
                $tpl->set( 'isarticle', $out->isArticle() );
 
@@ -277,7 +274,7 @@ class SkinTemplate extends Skin {
 
                $tpl->setRef( 'mimetype', $wgMimeType );
                $tpl->setRef( 'jsmimetype', $wgJsMimeType );
-               $tpl->setRef( 'charset', $wgOutputEncoding );
+               $tpl->set( 'charset', 'UTF-8' );
                $tpl->setRef( 'wgScript', $wgScript );
                $tpl->setRef( 'skinname', $this->skinname );
                $tpl->set( 'skinclass', get_class( $this ) );
@@ -285,12 +282,12 @@ class SkinTemplate extends Skin {
                $tpl->set( 'printable', $out->isPrintable() );
                $tpl->set( 'handheld', $wgRequest->getBool( 'handheld' ) );
                $tpl->setRef( 'loggedin', $this->loggedin );
-               $tpl->set( 'notspecialpage', $this->mTitle->getNamespace() != NS_SPECIAL );
+               $tpl->set( 'notspecialpage', $this->getTitle()->getNamespace() != NS_SPECIAL );
                /* XXX currently unused, might get useful later
-               $tpl->set( 'editable', ( $this->mTitle->getNamespace() != NS_SPECIAL ) );
-               $tpl->set( 'exists', $this->mTitle->getArticleID() != 0 );
-               $tpl->set( 'watch', $this->mTitle->userIsWatching() ? 'unwatch' : 'watch' );
-               $tpl->set( 'protect', count( $this->mTitle->isProtected() ) ? 'unprotect' : 'protect' );
+               $tpl->set( 'editable', ( $this->getTitle()->getNamespace() != NS_SPECIAL ) );
+               $tpl->set( 'exists', $this->getTitle()->getArticleID() != 0 );
+               $tpl->set( 'watch', $this->getTitle()->userIsWatching() ? 'unwatch' : 'watch' );
+               $tpl->set( 'protect', count( $this->getTitle()->isProtected() ) ? 'unprotect' : 'protect' );
                $tpl->set( 'helppage', wfMsg( 'helppage' ) );
                */
                $tpl->set( 'searchaction', $this->escapeSearchLink() );
@@ -329,12 +326,12 @@ class SkinTemplate extends Skin {
 
                        // The content of SpecialPages should be presented in the
                        // user's language. Content of regular pages should not be touched.
-                       if( $this->mTitle->isSpecialPage() ) {
+                       if( $this->getTitle()->isSpecialPage() ) {
                                $tpl->set( 'specialpageattributes', $attrs );
                        }
                }
 
-               $newtalks = $this->getNewtalks();
+               $newtalks = $this->getNewtalks( $out );
 
                wfProfileOut( __METHOD__ . '-stuff2' );
 
@@ -343,9 +340,9 @@ class SkinTemplate extends Skin {
                $tpl->setRef( 'skin', $this );
                $tpl->set( 'logo', $this->logoText() );
                if ( $out->isArticle() && ( !isset( $oldid ) || isset( $diff ) ) &&
-                       $this->mTitle->exists() )
+                       $this->getTitle()->exists() )
                {
-                       $article = new Article( $this->mTitle, 0 );
+                       $article = new Article( $this->getTitle(), 0 );
                        if ( !$wgDisableCounters ) {
                                $viewcount = $wgLang->formatNum( $article->getCount() );
                                if ( $viewcount ) {
@@ -361,7 +358,7 @@ class SkinTemplate extends Skin {
                                $dbr = wfGetDB( DB_SLAVE );
                                $res = $dbr->select( 'watchlist',
                                        array( 'COUNT(*) AS n' ),
-                                       array( 'wl_title' => $dbr->strencode( $this->mTitle->getDBkey() ), 'wl_namespace' => $this->mTitle->getNamespace() ),
+                                       array( 'wl_title' => $dbr->strencode( $this->getTitle()->getDBkey() ), 'wl_namespace' => $this->getTitle()->getNamespace() ),
                                        __METHOD__
                                );
                                $x = $dbr->fetchObject( $res );
@@ -383,7 +380,7 @@ class SkinTemplate extends Skin {
                        $this->credits = false;
 
                        if( $wgMaxCredits != 0 ){
-                               $this->credits = Credits::getCredits( $article, $wgMaxCredits, $wgShowCreditsIfMax );
+                               $this->credits = Action::factory( 'credits', $article )->getCredits( $wgMaxCredits, $wgShowCreditsIfMax );
                        } else {
                                $tpl->set( 'lastmod', $this->lastModified( $article ) );
                        }
@@ -455,14 +452,13 @@ class SkinTemplate extends Skin {
                $tpl->set( 'reporttime', wfReportTime() );
                $tpl->set( 'sitenotice', $this->getSiteNotice() );
                $tpl->set( 'bottomscripts', $this->bottomScripts( $out ) );
+               $tpl->set( 'printfooter', $this->printSource() );
 
-               $printfooter = "<div class=\"printfooter\">\n" . $this->printSource() . "</div>\n";
                global $wgBetterDirectionality;
                if ( $wgBetterDirectionality ) {
                        $realBodyAttribs = array( 'lang' => $wgLanguageCode, 'dir' => $wgContLang->getDir() );
                        $out->mBodytext = Html::rawElement( 'div', $realBodyAttribs, $out->mBodytext );
                }
-               $out->mBodytext .= $printfooter . $this->generateDebugHTML();
                $tpl->setRef( 'bodytext', $out->mBodytext );
 
                # Language links
@@ -510,6 +506,8 @@ class SkinTemplate extends Skin {
                        $tpl->set( 'headscripts', $out->getScript() );
                }
 
+               $tpl->set( 'debughtml', $this->generateDebugHTML() );
+
                // original version by hansm
                if( !wfRunHooks( 'SkinTemplateOutputPageBeforeExec', array( &$this, &$tpl ) ) ) {
                        wfDebug( __METHOD__ . ": Hook SkinTemplateOutputPageBeforeExec broke outputPage execution!\n" );
@@ -568,10 +566,26 @@ class SkinTemplate extends Skin {
 
                /* set up the default links for the personal toolbar */
                $personal_urls = array();
-               $page = $wgRequest->getVal( 'returnto', $this->thisurl );
-               $query = $wgRequest->getVal( 'returntoquery', $this->thisquery );
-               $returnto = wfArrayToCGI( array( 'returnto' => $page ) );
-               if( $this->thisquery != '' ) {
+               
+               // Get the returnto and returntoquery parameters from the query string
+               // or fall back on $this->thisurl or $this->thisquery
+               // We can't use getVal()'s default value feature here because
+               // stuff from $wgRequest needs to be escaped, but thisurl and thisquery
+               // are already escaped.
+               $page = $wgRequest->getVal( 'returnto' );
+               if ( !is_null( $page ) ) {
+                       $page = wfUrlencode( $page );
+               } else {
+                       $page = $this->thisurl;
+               }
+               $query = $wgRequest->getVal( 'returntoquery' );
+               if ( !is_null( $query ) ) {
+                       $query = wfUrlencode( $query );
+               } else {
+                       $query = $this->thisquery;
+               }
+               $returnto = "returnto=$page";
+               if( $query != '' ) {
                        $returnto .= "&returntoquery=$query";
                }
                if( $this->loggedin ) {
@@ -608,8 +622,7 @@ class SkinTemplate extends Skin {
                        # contain the original alias-with-subpage.
                        $origTitle = Title::newFromText( $wgRequest->getText( 'title' ) );
                        if( $origTitle instanceof Title && $origTitle->getNamespace() == NS_SPECIAL ) {
-                               list( $spName, $spPar ) =
-                                       SpecialPage::resolveAliasWithSubpage( $origTitle->getText() );
+                               list( $spName, $spPar ) = SpecialPageFactory::resolveAlias( $origTitle->getText() );
                                $active = $spName == 'Contributions'
                                        && ( ( $spPar && $spPar == $this->username )
                                                || $wgRequest->getText( 'target' ) == $this->username );
@@ -626,7 +639,9 @@ class SkinTemplate extends Skin {
                        $personal_urls['logout'] = array(
                                'text' => wfMsg( 'userlogout' ),
                                'href' => self::makeSpecialUrl( 'Userlogout',
-                                       $title->isSpecial( 'Preferences' ) ? '' : $returnto
+                                       // userlogout link must always contain an & character, otherwise we might not be able
+                                       // to detect a buggy precaching proxy (bug 17790)
+                                       $title->isSpecial( 'Preferences' ) ? 'noreturnto' : $returnto
                                ),
                                'active' => false
                        );
@@ -663,7 +678,7 @@ class SkinTemplate extends Skin {
                                        $createaccount_url['class'] = 'link-https';  # FIXME class depends on skin
                                }
                        }
-                       
+
 
                        if( $this->showIPinHeader() ) {
                                $href = &$this->userpageUrlDetails['href'];
@@ -682,12 +697,12 @@ class SkinTemplate extends Skin {
                                        'active' => ( $pageurl == $href )
                                );
                                $personal_urls['anonlogin'] = $login_url;
-                               if ( isset($createaccount_url) ) {
-                                       $personal_urls['createaccount'] = $createaccount_url;
-                               }
                        } else {
                                $personal_urls['login'] = $login_url;
                        }
+                       if ( isset($createaccount_url) ) {
+                               $personal_urls['createaccount'] = $createaccount_url;
+                       }
                }
 
                wfRunHooks( 'PersonalUrls', array( &$personal_urls, &$title ) );
@@ -695,6 +710,15 @@ class SkinTemplate extends Skin {
                return $personal_urls;
        }
 
+       /**
+        * TODO document
+        * @param  $title Title
+        * @param  $message String message key
+        * @param  $selected Bool
+        * @param  $query String
+        * @param  $checkEdit Bool
+        * @return array
+        */
        function tabAction( $title, $message, $selected, $query = '', $checkEdit = false ) {
                $classes = array();
                if( $selected ) {
@@ -758,13 +782,13 @@ class SkinTemplate extends Skin {
 
        /**
         * a structured array of links usually used for the tabs in a skin
-        * 
+        *
         * There are 4 standard sections
         * namespaces: Used for namespace tabs like special, page, and talk namespaces
         * views: Used for primary page views like read, edit, history
         * actions: Used for most extra page actions like deletion, protection, etc...
         * variants: Used to list the language variants for the page
-        * 
+        *
         * Each section's value is a key/value array of links for that section.
         * The links themseves have these common keys:
         * - class: The css classes to apply to the tab
@@ -774,11 +798,11 @@ class SkinTemplate extends Skin {
         * - redundant: If true the tab will be dropped in skins using content_actions
         *   this is useful for tabs like "Read" which only have meaning in skins that
         *   take special meaning from the grouped structure of content_navigation
-        * 
+        *
         * Views also have an extra key which can be used:
         * - primary: If this is not true skins like vector may try to hide the tab
         *            when the user has limited space in their browser window
-        * 
+        *
         * content_navigation using code also expects these ids to be present on the
         * links, however these are usually automatically generated by SkinTemplate
         * itself and are not necessary when using a hook. The only things these may
@@ -786,7 +810,7 @@ class SkinTemplate extends Skin {
         * - id: A "preferred" id, most skins are best off outputting this preferred id for best compatibility
         * - tooltiponly: This is set to true for some tabs in cases where the system
         *                believes that the accesskey should not be added to the tab.
-        * 
+        *
         * @return array
         */
        protected function buildContentNavigationUrls( OutputPage $out ) {
@@ -794,10 +818,10 @@ class SkinTemplate extends Skin {
                global $wgDisableLangConversion;
 
                wfProfileIn( __METHOD__ );
-               
+
                $title = $this->getRelevantTitle(); // Display tabs for the relevant title rather than always the title itself
-               $onPage = $title->equals($this->mTitle);
-               
+               $onPage = $title->equals($this->getTitle());
+
                $content_navigation = array(
                        'namespaces' => array(),
                        'views' => array(),
@@ -935,7 +959,7 @@ class SkinTemplate extends Skin {
                                if ( $title->quickUserCan( 'move' ) ) {
                                        $moveTitle = SpecialPage::getTitleFor( 'Movepage', $title->getPrefixedDBkey() );
                                        $content_navigation['actions']['move'] = array(
-                                               'class' => $this->mTitle->isSpecial( 'Movepage' ) ? 'selected' : false,
+                                               'class' => $this->getTitle()->isSpecial( 'Movepage' ) ? 'selected' : false,
                                                'text' => wfMessageFallback( "$skname-action-move", 'move' )->text(),
                                                'href' => $moveTitle->getLocalURL()
                                        );
@@ -958,7 +982,7 @@ class SkinTemplate extends Skin {
                                                // If the user can't undelete but can view deleted history show them a "View .. deleted" tab instead
                                                $msgKey = $wgUser->isAllowed( 'undelete' ) ? 'undelete' : 'viewdeleted';
                                                $content_navigation['actions']['undelete'] = array(
-                                                       'class' => $this->mTitle->isSpecial( 'Undelete' ) ? 'selected' : false,
+                                                       'class' => $this->getTitle()->isSpecial( 'Undelete' ) ? 'selected' : false,
                                                        'text' => wfMessageFallback( "$skname-action-$msgKey", "{$msgKey}_short" )
                                                                ->params( $wgLang->formatNum( $n ) )->text(),
                                                        'href' => $undelTitle->getLocalURL( array( 'target' => $title->getPrefixedDBkey() ) )
@@ -995,7 +1019,7 @@ class SkinTemplate extends Skin {
                                        'href' => $title->getLocalURL( 'action=' . $mode )
                                );
                        }
-                       
+
                        wfRunHooks( 'SkinTemplateNavigation', array( &$this, &$content_navigation ) );
                } else {
                        // If it's not content, it's got to be a special page
@@ -1005,7 +1029,7 @@ class SkinTemplate extends Skin {
                                'href' => $wgRequest->getRequestURL(), // @bug 2457, 2510
                                'context' => 'subject'
                        );
-                       
+
                        wfRunHooks( 'SkinTemplateNavigation::SpecialPage', array( &$this, &$content_navigation ) );
                }
 
@@ -1052,7 +1076,7 @@ class SkinTemplate extends Skin {
                                $link['id'] = $xmlID;
                        }
                }
-               
+
                # We don't want to give the watch tab an accesskey if the
                # page is being edited, because that conflicts with the
                # accesskey on the watch checkbox.  We also don't want to
@@ -1070,7 +1094,7 @@ class SkinTemplate extends Skin {
                                $content_navigation['actions']['unwatch']['tooltiponly'] = true;
                        }
                }
-               
+
                wfProfileOut( __METHOD__ );
 
                return $content_navigation;
@@ -1088,18 +1112,18 @@ class SkinTemplate extends Skin {
                // content_actions has been replaced with content_navigation for backwards
                // compatibility and also for skins that just want simple tabs content_actions
                // is now built by flattening the content_navigation arrays into one
-               
+
                $content_actions = array();
-               
+
                foreach ( $content_navigation as $links ) {
-                       
+
                        foreach ( $links as $key => $value ) {
-                               
+
                                if ( isset($value["redundant"]) && $value["redundant"] ) {
                                        // Redundant tabs are dropped from content_actions
                                        continue;
                                }
-                               
+
                                // content_actions used to have ids built using the "ca-$key" pattern
                                // so the xmlID based id is much closer to the actual $key that we want
                                // for that reason we'll just strip out the ca- if present and use
@@ -1107,20 +1131,20 @@ class SkinTemplate extends Skin {
                                if ( isset($value["id"]) && substr($value["id"], 0, 3) == "ca-" ) {
                                        $key = substr($value["id"], 3);
                                }
-                               
+
                                if ( isset($content_actions[$key]) ) {
                                        wfDebug( __METHOD__ . ": Found a duplicate key for $key while flattening content_navigation into content_actions." );
                                        continue;
                                }
-                               
+
                                $content_actions[$key] = $value;
-                               
+
                        }
-                       
+
                }
-               
+
                wfProfileOut( __METHOD__ );
-               
+
                return $content_actions;
        }
 
@@ -1157,29 +1181,29 @@ class SkinTemplate extends Skin {
                        if ( !$out->isPrintable() ) {
                                $nav_urls['print'] = array(
                                        'text' => wfMsg( 'printableversion' ),
-                                       'href' => $this->mTitle->getLocalURL( $wgRequest->appendQueryValue( 'printable', 'yes', true ) )
+                                       'href' => $this->getTitle()->getLocalURL( $wgRequest->appendQueryValue( 'printable', 'yes', true ) )
                                );
                        }
 
                        // Also add a "permalink" while we're at it
-                       if ( $this->mRevisionId ) {
+                       $revid = $this->getRevisionId();
+                       if ( $revid ) {
                                $nav_urls['permalink'] = array(
                                        'text' => wfMsg( 'permalink' ),
-                                       'href' => $out->getTitle()->getLocalURL( "oldid=$this->mRevisionId" )
+                                       'href' => $out->getTitle()->getLocalURL( "oldid=$revid" )
                                );
                        }
 
-                       // Copy in case this undocumented, shady hook tries to mess with internals
-                       $revid = $this->mRevisionId;
+                       // Use the copy of revision ID in case this undocumented, shady hook tries to mess with internals
                        wfRunHooks( 'SkinTemplateBuildNavUrlsNav_urlsAfterPermalink', array( &$this, &$nav_urls, &$revid, &$revid ) );
                }
 
-               if( $this->mTitle->getNamespace() != NS_SPECIAL ) {
+               if( $this->getTitle()->getNamespace() != NS_SPECIAL ) {
                        $wlhTitle = SpecialPage::getTitleFor( 'Whatlinkshere', $this->thispage );
                        $nav_urls['whatlinkshere'] = array(
                                'href' => $wlhTitle->getLocalUrl()
                        );
-                       if( $this->mTitle->getArticleId() ) {
+                       if( $this->getTitle()->getArticleId() ) {
                                $rclTitle = SpecialPage::getTitleFor( 'Recentchangeslinked', $this->thispage );
                                $nav_urls['recentchangeslinked'] = array(
                                        'href' => $rclTitle->getLocalUrl()
@@ -1201,6 +1225,7 @@ class SkinTemplate extends Skin {
                } else {
                        $id = 0;
                        $ip = false;
+                       $rootUser = null;
                }
 
                if( $id || $ip ) { # both anons and non-anons have contribs list
@@ -1223,7 +1248,7 @@ class SkinTemplate extends Skin {
 
                        if ( $wgUser->isAllowed( 'block' ) ) {
                                $nav_urls['blockip'] = array(
-                                       'href' => self::makeSpecialUrlSubpage( 'Blockip', $rootUser )
+                                       'href' => self::makeSpecialUrlSubpage( 'Block', $rootUser )
                                );
                        } else {
                                $nav_urls['blockip'] = false;
@@ -1249,7 +1274,7 @@ class SkinTemplate extends Skin {
         * @private
         */
        function getNameSpaceKey() {
-               return $this->mTitle->getNamespaceKey();
+               return $this->getTitle()->getNamespaceKey();
        }
 
        /**
@@ -1263,7 +1288,7 @@ class SkinTemplate extends Skin {
                $action = $wgRequest->getVal( 'action', 'view' );
 
                if( $allowUserJs && $this->loggedin ) {
-                       if( $this->mTitle->isJsSubpage() and $this->userCanPreview( $action ) ) {
+                       if( $this->getTitle()->isJsSubpage() and $this->userCanPreview( $action ) ) {
                                # XXX: additional security check/prompt?
                                $this->userjsprev = '/*<![CDATA[*/ ' . $wgRequest->getText( 'wpTextbox1' ) . ' /*]]>*/';
                        } else {
@@ -1461,15 +1486,16 @@ abstract class BaseTemplate extends QuickTemplate {
                        $toolbox['print']['rel'] = 'alternate';
                        $toolbox['print']['msg'] = 'printableversion';
                }
-               if ( !empty( $this->data['nav_urls']['permalink']['href'] ) ) {
-                       $toolbox['permalink'] = $this->data['nav_urls']['permalink'];
-                       $toolbox['permalink']['id'] = 't-permalink';
-               } elseif ( $this->data['nav_urls']['permalink']['href'] === '' ) {
+               if( $this->data['nav_urls']['permalink'] ) {
                        $toolbox['permalink'] = $this->data['nav_urls']['permalink'];
-                       unset( $toolbox['permalink']['href'] );
-                       $toolbox['ispermalink']['tooltiponly'] = true;
-                       $toolbox['ispermalink']['id'] = 't-ispermalink';
-                       $toolbox['ispermalink']['msg'] = 'permalink';
+                       if( $toolbox['permalink']['href'] === '' ) {
+                               unset( $toolbox['permalink']['href'] );
+                               $toolbox['ispermalink']['tooltiponly'] = true;
+                               $toolbox['ispermalink']['id'] = 't-ispermalink';
+                               $toolbox['ispermalink']['msg'] = 'permalink';
+                       } else {
+                               $toolbox['permalink']['id'] = 't-permalink';
+                       }
                }
                wfRunHooks( 'BaseTemplateToolbox', array( &$this, &$toolbox ) );
                wfProfileOut( __METHOD__ );
@@ -1713,7 +1739,7 @@ abstract class BaseTemplate extends QuickTemplate {
 
                if ( $option == 'icononly' ) {
                        // Unset any icons which don't have an image
-                       foreach ( $footericons as $footerIconsKey => &$footerIconsBlock ) {
+                       foreach ( $footericons as &$footerIconsBlock ) {
                                foreach ( $footerIconsBlock as $footerIconKey => $footerIcon ) {
                                        if ( !is_string( $footerIcon ) && !isset( $footerIcon['src'] ) ) {
                                                unset( $footerIconsBlock[$footerIconKey] );