*/
class SiteStats {
static $row, $loaded = false;
- static $admins;
+ static $admins, $jobs;
static $pageCount = array();
+ static $groupMemberCounts = array();
static function recache() {
self::load( true );
# Update schema
$u = new SiteStatsUpdate( 0, 0, 0 );
$u->doUpdate();
+ $dbr = wfGetDB( DB_SLAVE );
self::$row = $dbr->selectRow( 'site_stats', '*', false, __METHOD__ );
}
+
+ self::$loaded = true;
}
-
+
static function loadAndLazyInit() {
wfDebug( __METHOD__ . ": reading site_stats from slave\n" );
$row = self::doLoad( wfGetDB( DB_SLAVE ) );
-
- if( $row === false ) {
- // Might have just been initialzed during this request?
- wfDebug( __METHOD__ . ": site_stats missing on slave\n" );
+
+ if( !self::isSane( $row ) ) {
+ // Might have just been initialized during this request? Underflow?
+ wfDebug( __METHOD__ . ": site_stats damaged or missing on slave\n" );
$row = self::doLoad( wfGetDB( DB_MASTER ) );
}
-
- if( $row === false ) {
+
+ if( !self::isSane( $row ) ) {
// Normally the site_stats table is initialized at install time.
- // Some manual construction scenarios may leave the table empty,
- // however, for instance when importing from a dump into a clean
- // schema with mwdumper.
- wfDebug( __METHOD__ . ": initializing empty site_stats\n" );
-
+ // Some manual construction scenarios may leave the table empty or
+ // broken, however, for instance when importing from a dump into a
+ // clean schema with mwdumper.
+ wfDebug( __METHOD__ . ": initializing damaged or missing site_stats\n" );
+
global $IP;
require_once "$IP/maintenance/initStats.inc";
-
+
ob_start();
wfInitStats();
ob_end_clean();
-
+
$row = self::doLoad( wfGetDB( DB_MASTER ) );
}
-
- if( $row === false ) {
- wfDebug( __METHOD__ . ": init of site_stats failed o_O\n" );
+
+ if( !self::isSane( $row ) ) {
+ wfDebug( __METHOD__ . ": site_stats persistently nonsensical o_O\n" );
}
return $row;
}
return self::$row->ss_users;
}
+ static function activeUsers() {
+ self::load();
+ return self::$row->ss_active_users;
+ }
+
static function images() {
self::load();
return self::$row->ss_images;
}
+ /**
+ * @deprecated Use self::numberingroup('sysop') instead
+ */
static function admins() {
- if ( !isset( self::$admins ) ) {
+ wfDeprecated(__METHOD__);
+ return self::numberingroup('sysop');
+ }
+
+ /**
+ * Find the number of users in a given user group.
+ * @param string $group Name of group
+ * @return int
+ */
+ static function numberingroup($group) {
+ if ( !isset( self::$groupMemberCounts[$group] ) ) {
+ global $wgMemc;
+ $key = wfMemcKey( 'SiteStats', 'groupcounts', $group );
+ $hit = $wgMemc->get( $key );
+ if ( !$hit ) {
+ $dbr = wfGetDB( DB_SLAVE );
+ $hit = $dbr->selectField( 'user_groups', 'COUNT(*)',
+ array( 'ug_group' => $group ), __METHOD__ );
+ $wgMemc->set( $key, $hit, 3600 );
+ }
+ self::$groupMemberCounts[$group] = $hit;
+ }
+ return self::$groupMemberCounts[$group];
+ }
+
+ static function jobs() {
+ if ( !isset( self::$jobs ) ) {
$dbr = wfGetDB( DB_SLAVE );
- self::$admins = $dbr->selectField( 'user_groups', 'COUNT(*)', array( 'ug_group' => 'sysop' ), __METHOD__ );
+ self::$jobs = $dbr->estimateRowCount('job');
+ /* Zero rows still do single row read for row that doesn't exist, but people are annoyed by that */
+ if (self::$jobs == 1) {
+ self::$jobs = 0;
+ }
}
- return self::$admins;
+ return self::$jobs;
}
static function pagesInNs( $ns ) {
return $pageCount[$ns];
}
+ /** Is the provided row of site stats sane, or should it be regenerated? */
+ private static function isSane( $row ) {
+ if(
+ $row === false
+ or $row->ss_total_pages < $row->ss_good_articles
+ or $row->ss_total_edits < $row->ss_total_pages
+ or $row->ss_users < $row->ss_admins
+ ) {
+ return false;
+ }
+ // Now check for underflow/overflow
+ foreach( array( 'total_views', 'total_edits', 'good_articles',
+ 'total_pages', 'users', 'admins', 'images' ) as $member ) {
+ if(
+ $row->{"ss_$member"} > 2000000000
+ or $row->{"ss_$member"} < 0
+ ) {
+ return false;
+ }
+ }
+ return true;
+ }
}
$fname = 'SiteStatsUpdate::doUpdate';
$dbw = wfGetDB( DB_MASTER );
- # First retrieve the row just to find out which schema we're in
- $row = $dbw->selectRow( 'site_stats', '*', false, $fname );
-
$updates = '';
$this->appendUpdate( $updates, 'ss_total_views', $this->mViews );
$this->appendUpdate( $updates, 'ss_total_edits', $this->mEdits );
$this->appendUpdate( $updates, 'ss_good_articles', $this->mGood );
+ $this->appendUpdate( $updates, 'ss_total_pages', $this->mPages );
+ $this->appendUpdate( $updates, 'ss_users', $this->mUsers );
- if ( isset( $row->ss_total_pages ) ) {
- # Update schema if required
- if ( $row->ss_total_pages == -1 && !$this->mViews ) {
- $dbr = wfGetDB( DB_SLAVE, array( 'SpecialStatistics', 'vslow') );
- list( $page, $user ) = $dbr->tableNamesN( 'page', 'user' );
-
- $sql = "SELECT COUNT(page_namespace) AS total FROM $page";
- $res = $dbr->query( $sql, $fname );
- $pageRow = $dbr->fetchObject( $res );
- $pages = $pageRow->total + $this->mPages;
-
- $sql = "SELECT COUNT(user_id) AS total FROM $user";
- $res = $dbr->query( $sql, $fname );
- $userRow = $dbr->fetchObject( $res );
- $users = $userRow->total + $this->mUsers;
-
- if ( $updates ) {
- $updates .= ',';
- }
- $updates .= "ss_total_pages=$pages, ss_users=$users";
- } else {
- $this->appendUpdate( $updates, 'ss_total_pages', $this->mPages );
- $this->appendUpdate( $updates, 'ss_users', $this->mUsers );
- }
- }
if ( $updates ) {
$site_stats = $dbw->tableName( 'site_stats' );
- $sql = $dbw->limitResultForUpdate("UPDATE $site_stats SET $updates", 1);
+ $sql = "UPDATE $site_stats SET $updates";
+
+ # Need a separate transaction because this a global lock
$dbw->begin();
$dbw->query( $sql, $fname );
$dbw->commit();
}
-
- /*
- global $wgDBname, $wgTitle;
- if ( $this->mGood && $wgDBname == 'enwiki' ) {
- $good = $dbw->selectField( 'site_stats', 'ss_good_articles', '', $fname );
- error_log( $good . ' ' . $wgTitle->getPrefixedDBkey() . "\n", 3, '/home/wikipedia/logs/million.log' );
- }
- */
+ }
+
+ public static function cacheUpdate( $dbw ) {
+ $dbr = wfGetDB( DB_SLAVE, array( 'SpecialStatistics', 'vslow') );
+ # Get non-bot users than did some recent action other than making accounts.
+ # If account creation is included, the number gets inflated ~20+ fold on enwiki.
+ $activeUsers = $dbr->selectField( 'recentchanges', 'COUNT( DISTINCT rc_user_text )',
+ array( 'rc_user != 0', 'rc_bot' => 0, "rc_log_type != 'newusers' OR rc_log_type IS NULL" ),
+ __METHOD__ );
+ $dbw->update( 'site_stats',
+ array( 'ss_active_users' => intval($activeUsers) ),
+ array( 'ss_row_id' => 1 ), __METHOD__
+ );
}
}
-?>
dépôts / lhc / web / wiklou.git / blobdiff