Be consistent with filearchive system and use whole key. This is a modified version...
[lhc/web/wiklou.git] / includes / Parser.php
index 209b712..97e4630 100644 (file)
@@ -82,14 +82,17 @@ class Parser
        const OT_WIKI = 2;
        const OT_PREPROCESS = 3;
        const OT_MSG = 3;
-       
+
+       // Marker Suffix needs to be accessible staticly.
+       const MARKER_SUFFIX = "-QINU\x7f";
+
        /**#@+
         * @private
         */
        # Persistent:
        var $mTagHooks, $mTransparentTagHooks, $mFunctionHooks, $mFunctionSynonyms, $mVariables,
-               $mImageParams, $mImageParamsMagicArray, $mStripList, $mMarkerSuffix,
-               $mExtLinkBracketedRegex, $mPreprocessor, $mDefaultStripList;
+               $mImageParams, $mImageParamsMagicArray, $mStripList, $mMarkerIndex, $mPreprocessor,
+               $mExtLinkBracketedRegex, $mDefaultStripList, $mVarCache, $mConf;
 
 
        # Cleared with clearState():
@@ -98,7 +101,8 @@ class Parser
        var $mInterwikiLinkHolders, $mLinkHolders;
        var $mIncludeSizes, $mPPNodeCount, $mDefaultSort;
        var $mTplExpandCache; // empty-frame expansion cache
-       var $mTplRedirCache, $mTplDomCache, $mHeadings;
+       var $mTplRedirCache, $mTplDomCache, $mHeadings, $mDoubleUnderscores;
+       var $mExpensiveFunctionCount; // number of expensive parser function calls
 
        # Temporary
        # These are variables reset at least once per parse regardless of $clearState
@@ -118,19 +122,21 @@ class Parser
         * @public
         */
        function __construct( $conf = array() ) {
+               $this->mConf = $conf;
                $this->mTagHooks = array();
                $this->mTransparentTagHooks = array();
                $this->mFunctionHooks = array();
                $this->mFunctionSynonyms = array( 0 => array(), 1 => array() );
                $this->mDefaultStripList = $this->mStripList = array( 'nowiki', 'gallery' );
-               $this->mMarkerSuffix = "-QINU\x7f";
                $this->mExtLinkBracketedRegex = '/\[(\b(' . wfUrlProtocols() . ')'.
                        '[^][<>"\\x00-\\x20\\x7F]+) *([^\]\\x0a\\x0d]*?)\]/S';
+               $this->mVarCache = array();
                if ( isset( $conf['preprocessorClass'] ) ) {
                        $this->mPreprocessorClass = $conf['preprocessorClass'];
                } else {
                        $this->mPreprocessorClass = 'Preprocessor_DOM';
                }
+               $this->mMarkerIndex = 0;
                $this->mFirstCall = true;
        }
        
@@ -144,51 +150,9 @@ class Parser
                $this->mFirstCall = false;
                
                wfProfileIn( __METHOD__ );
-               global $wgAllowDisplayTitle, $wgAllowSlowParserFunctions;
 
                $this->setHook( 'pre', array( $this, 'renderPreTag' ) );
-
-               # Syntax for arguments (see self::setFunctionHook):
-               #  "name for lookup in localized magic words array",
-               #  function callback,
-               #  optional SFH_NO_HASH to omit the hash from calls (e.g. {{int:...}
-               #    instead of {{#int:...}})
-               $this->setFunctionHook( 'int',              array( 'CoreParserFunctions', 'intFunction'      ), SFH_NO_HASH );
-               $this->setFunctionHook( 'ns',               array( 'CoreParserFunctions', 'ns'               ), SFH_NO_HASH );
-               $this->setFunctionHook( 'urlencode',        array( 'CoreParserFunctions', 'urlencode'        ), SFH_NO_HASH );
-               $this->setFunctionHook( 'lcfirst',          array( 'CoreParserFunctions', 'lcfirst'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'ucfirst',          array( 'CoreParserFunctions', 'ucfirst'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'lc',               array( 'CoreParserFunctions', 'lc'               ), SFH_NO_HASH );
-               $this->setFunctionHook( 'uc',               array( 'CoreParserFunctions', 'uc'               ), SFH_NO_HASH );
-               $this->setFunctionHook( 'localurl',         array( 'CoreParserFunctions', 'localurl'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'localurle',        array( 'CoreParserFunctions', 'localurle'        ), SFH_NO_HASH );
-               $this->setFunctionHook( 'fullurl',          array( 'CoreParserFunctions', 'fullurl'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'fullurle',         array( 'CoreParserFunctions', 'fullurle'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'formatnum',        array( 'CoreParserFunctions', 'formatnum'        ), SFH_NO_HASH );
-               $this->setFunctionHook( 'grammar',          array( 'CoreParserFunctions', 'grammar'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'plural',           array( 'CoreParserFunctions', 'plural'           ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofpages',    array( 'CoreParserFunctions', 'numberofpages'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofusers',    array( 'CoreParserFunctions', 'numberofusers'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofarticles', array( 'CoreParserFunctions', 'numberofarticles' ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberoffiles',    array( 'CoreParserFunctions', 'numberoffiles'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofadmins',   array( 'CoreParserFunctions', 'numberofadmins'   ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofedits',    array( 'CoreParserFunctions', 'numberofedits'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'language',         array( 'CoreParserFunctions', 'language'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'padleft',          array( 'CoreParserFunctions', 'padleft'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'padright',         array( 'CoreParserFunctions', 'padright'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'anchorencode',     array( 'CoreParserFunctions', 'anchorencode'     ), SFH_NO_HASH );
-               $this->setFunctionHook( 'special',          array( 'CoreParserFunctions', 'special'          ) );
-               $this->setFunctionHook( 'defaultsort',      array( 'CoreParserFunctions', 'defaultsort'      ), SFH_NO_HASH );
-               $this->setFunctionHook( 'filepath',         array( 'CoreParserFunctions', 'filepath'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'tag',              array( 'CoreParserFunctions', 'tagObj'           ), SFH_OBJECT_ARGS );
-
-               if ( $wgAllowDisplayTitle ) {
-                       $this->setFunctionHook( 'displaytitle', array( 'CoreParserFunctions', 'displaytitle' ), SFH_NO_HASH );
-               }
-               if ( $wgAllowSlowParserFunctions ) {
-                       $this->setFunctionHook( 'pagesinnamespace', array( 'CoreParserFunctions', 'pagesinnamespace' ), SFH_NO_HASH );
-               }
-
+               CoreParserFunctions::register( $this );
                $this->initialiseVariables();
 
                wfRunHooks( 'ParserFirstCallInit', array( &$this ) );
@@ -237,8 +201,10 @@ class Parser
                 * the behaviour of <nowiki> in a link.
                 */
                #$this->mUniqPrefix = "\x07UNIQ" . Parser::getRandomString();
+               # Changed to \x7f to allow XML double-parsing -- TS
                $this->mUniqPrefix = "\x7fUNIQ" . Parser::getRandomString();
 
+
                # Clear these on every parse, bug 4549
                $this->mTplExpandCache = $this->mTplRedirCache = $this->mTplDomCache = array();
 
@@ -251,6 +217,13 @@ class Parser
                $this->mPPNodeCount = 0;
                $this->mDefaultSort = false;
                $this->mHeadings = array();
+               $this->mDoubleUnderscores = array();
+               $this->mExpensiveFunctionCount = 0;
+
+               # Fix cloning
+               if ( isset( $this->mPreprocessor ) && $this->mPreprocessor->parser !== $this ) {
+                       $this->mPreprocessor = null;
+               }
 
                wfRunHooks( 'ParserClearState', array( &$this ) );
                wfProfileOut( __METHOD__ );
@@ -349,6 +322,7 @@ class Parser
                        '/(.) (?=\\?|:|;|!|%|\\302\\273)/' => '\\1&nbsp;\\2',
                        # french spaces, Guillemet-right
                        '/(\\302\\253) /' => '\\1&nbsp;',
+                       '/&nbsp;(!\s*important)/' => ' \\1', #Beware of CSS magic word !important, bug #11874.
                );
                $text = preg_replace( array_keys($fixtags), array_values($fixtags), $text );
 
@@ -418,17 +392,31 @@ class Parser
                                array_values( $tidyregs ),
                                $text );
                }
+               global $wgExpensiveParserFunctionLimit;
+               if ( $this->mExpensiveFunctionCount > $wgExpensiveParserFunctionLimit ) {
+                       if ( is_callable( array( $this->mOutput, 'addWarning' ) ) ) {
+                               $warning = wfMsg( 'expensive-parserfunction-warning', $this->mExpensiveFunctionCount, $wgExpensiveParserFunctionLimit );
+                               $this->mOutput->addWarning( $warning );
+                               $cat = Title::makeTitleSafe( NS_CATEGORY, wfMsgForContent( 'expensive-parserfunction-category' ) );
+                               if ( $cat ) {
+                                       $this->mOutput->addCategory( $cat->getDBkey(), $this->getDefaultSort() );
+                               }
+                       }
+               }
 
                wfRunHooks( 'ParserAfterTidy', array( &$this, &$text ) );
 
                # Information on include size limits, for the benefit of users who try to skirt them
                if ( $this->mOptions->getEnableLimitReport() ) {
+                       global $wgExpensiveParserFunctionLimit;
                        $max = $this->mOptions->getMaxIncludeSize();
+                       $PFreport = "Expensive parser function count: {$this->mExpensiveFunctionCount}/$wgExpensiveParserFunctionLimit\n";
                        $limitReport = 
                                "NewPP limit report\n" . 
                                "Preprocessor node count: {$this->mPPNodeCount}/{$this->mOptions->mMaxPPNodeCount}\n" .
                                "Post-expand include size: {$this->mIncludeSizes['post-expand']}/$max bytes\n" .
-                               "Template argument size: {$this->mIncludeSizes['arg']}/$max bytes\n";
+                               "Template argument size: {$this->mIncludeSizes['arg']}/$max bytes\n".
+                               $PFreport;
                        wfRunHooks( 'ParserLimitReport', array( $this, &$limitReport ) );
                        $text .= "\n<!-- \n$limitReport-->\n";
                }
@@ -490,7 +478,13 @@ class Parser
 
        function getFunctionLang() {
                global $wgLang, $wgContLang;
-               return $this->mOptions->getInterfaceMessage() ? $wgLang : $wgContLang;
+
+               $target = $this->mOptions->getTargetLanguage();
+               if ( $target !== null ) {
+                       return $target;
+               } else {
+                       return $this->mOptions->getInterfaceMessage() ? $wgLang : $wgContLang;
+               }
        }
 
        /**
@@ -506,7 +500,7 @@ class Parser
 
        /**
         * Replaces all occurrences of HTML-style comments and the given tags
-        * in the text with a random marker and returns teh next text. The output
+        * in the text with a random marker and returns the next text. The output
         * parameter $matches will be an associative array filled with data in
         * the form:
         *   'UNIQ-xxxxx' => array(
@@ -550,7 +544,7 @@ class Parser
                                $inside     = $p[4];
                        }
 
-                       $marker = "$uniq_prefix-$element-" . sprintf('%08X', $n++) . $this->mMarkerSuffix;
+                       $marker = "$uniq_prefix-$element-" . sprintf('%08X', $n++) . self::MARKER_SUFFIX;
                        $stripped .= $marker;
 
                        if ( $close === '/>' ) {
@@ -642,9 +636,8 @@ class Parser
         * @private
         */
        function insertStripItem( $text ) {
-               static $n = 0;
-               $rnd = "{$this->mUniqPrefix}-item-$n-{$this->mMarkerSuffix}";
-               ++$n;
+               $rnd = "{$this->mUniqPrefix}-item-{$this->mMarkerIndex}-" . self::MARKER_SUFFIX;
+               $this->mMarkerIndex++;
                $this->mStripState->general->setPair( $rnd, $text );
                return $rnd;
        }
@@ -982,11 +975,10 @@ class Parser
 
                $text = preg_replace( '/(^|\n)-----*/', '\\1<hr />', $text );
 
-               $text = $this->stripToc( $text );
-               $this->stripNoGallery( $text );
+               $text = $this->doDoubleUnderscore( $text );
                $text = $this->doHeadings( $text );
                if($this->mOptions->getUseDynamicDates()) {
-                       $df =& DateFormatter::getInstance();
+                       $df = DateFormatter::getInstance();
                        $text = $df->reformat( $this->mOptions->getDateFormat(), $text );
                }
                $text = $this->doAllQuotes( $text );
@@ -1038,9 +1030,9 @@ class Parser
                                ' ' => '',
                                'x' => 'X',
                        ));
-                       $titleObj = SpecialPage::getTitleFor( 'Booksources' );
+                       $titleObj = SpecialPage::getTitleFor( 'Booksources', $num );
                        $text = '<a href="' .
-                               $titleObj->escapeLocalUrl( "isbn=$num" ) .
+                               $titleObj->escapeLocalUrl() .
                                "\" class=\"internal\">ISBN $isbn</a>";
                } else {
                        if ( substr( $m[0], 0, 3 ) == 'RFC' ) {
@@ -2374,14 +2366,13 @@ class Parser
                 * Some of these require message or data lookups and can be
                 * expensive to check many times.
                 */
-               static $varCache = array();
-               if ( wfRunHooks( 'ParserGetVariableValueVarCache', array( &$this, &$varCache ) ) ) {
-                       if ( isset( $varCache[$index] ) ) {
-                               return $varCache[$index];
+               if ( wfRunHooks( 'ParserGetVariableValueVarCache', array( &$this, &$this->mVarCache ) ) ) {
+                       if ( isset( $this->mVarCache[$index] ) ) {
+                               return $this->mVarCache[$index];
                        }
                }
 
-               $ts = time();
+               $ts = wfTimestamp( TS_UNIX, $this->mOptions->getTimestamp() );
                wfRunHooks( 'ParserGetVariableValueTs', array( &$this, &$ts ) );
 
                # Use the time zone
@@ -2408,29 +2399,29 @@ class Parser
 
                switch ( $index ) {
                        case 'currentmonth':
-                               return $varCache[$index] = $wgContLang->formatNum( gmdate( 'm', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( gmdate( 'm', $ts ) );
                        case 'currentmonthname':
-                               return $varCache[$index] = $wgContLang->getMonthName( gmdate( 'n', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->getMonthName( gmdate( 'n', $ts ) );
                        case 'currentmonthnamegen':
-                               return $varCache[$index] = $wgContLang->getMonthNameGen( gmdate( 'n', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->getMonthNameGen( gmdate( 'n', $ts ) );
                        case 'currentmonthabbrev':
-                               return $varCache[$index] = $wgContLang->getMonthAbbreviation( gmdate( 'n', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->getMonthAbbreviation( gmdate( 'n', $ts ) );
                        case 'currentday':
-                               return $varCache[$index] = $wgContLang->formatNum( gmdate( 'j', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( gmdate( 'j', $ts ) );
                        case 'currentday2':
-                               return $varCache[$index] = $wgContLang->formatNum( gmdate( 'd', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( gmdate( 'd', $ts ) );
                        case 'localmonth':
-                               return $varCache[$index] = $wgContLang->formatNum( $localMonth );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( $localMonth );
                        case 'localmonthname':
-                               return $varCache[$index] = $wgContLang->getMonthName( $localMonthName );
+                               return $this->mVarCache[$index] = $wgContLang->getMonthName( $localMonthName );
                        case 'localmonthnamegen':
-                               return $varCache[$index] = $wgContLang->getMonthNameGen( $localMonthName );
+                               return $this->mVarCache[$index] = $wgContLang->getMonthNameGen( $localMonthName );
                        case 'localmonthabbrev':
-                               return $varCache[$index] = $wgContLang->getMonthAbbreviation( $localMonthName );
+                               return $this->mVarCache[$index] = $wgContLang->getMonthAbbreviation( $localMonthName );
                        case 'localday':
-                               return $varCache[$index] = $wgContLang->formatNum( $localDay );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( $localDay );
                        case 'localday2':
-                               return $varCache[$index] = $wgContLang->formatNum( $localDay2 );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( $localDay2 );
                        case 'pagename':
                                return wfEscapeWikiText( $this->mTitle->getText() );
                        case 'pagenamee':
@@ -2516,51 +2507,51 @@ class Parser
                        case 'subjectspacee':
                                return( wfUrlencode( $this->mTitle->getSubjectNsText() ) );
                        case 'currentdayname':
-                               return $varCache[$index] = $wgContLang->getWeekdayName( gmdate( 'w', $ts ) + 1 );
+                               return $this->mVarCache[$index] = $wgContLang->getWeekdayName( gmdate( 'w', $ts ) + 1 );
                        case 'currentyear':
-                               return $varCache[$index] = $wgContLang->formatNum( gmdate( 'Y', $ts ), true );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( gmdate( 'Y', $ts ), true );
                        case 'currenttime':
-                               return $varCache[$index] = $wgContLang->time( wfTimestamp( TS_MW, $ts ), false, false );
+                               return $this->mVarCache[$index] = $wgContLang->time( wfTimestamp( TS_MW, $ts ), false, false );
                        case 'currenthour':
-                               return $varCache[$index] = $wgContLang->formatNum( gmdate( 'H', $ts ), true );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( gmdate( 'H', $ts ), true );
                        case 'currentweek':
                                // @bug 4594 PHP5 has it zero padded, PHP4 does not, cast to
                                // int to remove the padding
-                               return $varCache[$index] = $wgContLang->formatNum( (int)gmdate( 'W', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( (int)gmdate( 'W', $ts ) );
                        case 'currentdow':
-                               return $varCache[$index] = $wgContLang->formatNum( gmdate( 'w', $ts ) );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( gmdate( 'w', $ts ) );
                        case 'localdayname':
-                               return $varCache[$index] = $wgContLang->getWeekdayName( $localDayOfWeek + 1 );
+                               return $this->mVarCache[$index] = $wgContLang->getWeekdayName( $localDayOfWeek + 1 );
                        case 'localyear':
-                               return $varCache[$index] = $wgContLang->formatNum( $localYear, true );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( $localYear, true );
                        case 'localtime':
-                               return $varCache[$index] = $wgContLang->time( $localTimestamp, false, false );
+                               return $this->mVarCache[$index] = $wgContLang->time( $localTimestamp, false, false );
                        case 'localhour':
-                               return $varCache[$index] = $wgContLang->formatNum( $localHour, true );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( $localHour, true );
                        case 'localweek':
                                // @bug 4594 PHP5 has it zero padded, PHP4 does not, cast to
                                // int to remove the padding
-                               return $varCache[$index] = $wgContLang->formatNum( (int)$localWeek );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( (int)$localWeek );
                        case 'localdow':
-                               return $varCache[$index] = $wgContLang->formatNum( $localDayOfWeek );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( $localDayOfWeek );
                        case 'numberofarticles':
-                               return $varCache[$index] = $wgContLang->formatNum( SiteStats::articles() );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::articles() );
                        case 'numberoffiles':
-                               return $varCache[$index] = $wgContLang->formatNum( SiteStats::images() );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::images() );
                        case 'numberofusers':
-                               return $varCache[$index] = $wgContLang->formatNum( SiteStats::users() );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::users() );
                        case 'numberofpages':
-                               return $varCache[$index] = $wgContLang->formatNum( SiteStats::pages() );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::pages() );
                        case 'numberofadmins':
-                               return $varCache[$index] = $wgContLang->formatNum( SiteStats::admins() );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::admins() );
                        case 'numberofedits':
-                               return $varCache[$index] = $wgContLang->formatNum( SiteStats::edits() );
+                               return $this->mVarCache[$index] = $wgContLang->formatNum( SiteStats::edits() );
                        case 'currenttimestamp':
-                               return $varCache[$index] = wfTimestampNow();
+                               return $this->mVarCache[$index] = wfTimestamp( TS_MW, $ts );
                        case 'localtimestamp':
-                               return $varCache[$index] = $localTimestamp;
+                               return $this->mVarCache[$index] = $localTimestamp;
                        case 'currentversion':
-                               return $varCache[$index] = SpecialVersion::getVersion();
+                               return $this->mVarCache[$index] = SpecialVersion::getVersion();
                        case 'sitename':
                                return $wgSitename;
                        case 'server':
@@ -2576,7 +2567,7 @@ class Parser
                                return $wgContLanguageCode;
                        default:
                                $ret = null;
-                               if ( wfRunHooks( 'ParserGetVariableValueSwitch', array( &$this, &$varCache, &$index, &$ret ) ) )
+                               if ( wfRunHooks( 'ParserGetVariableValueSwitch', array( &$this, &$this->mVarCache, &$index, &$ret ) ) )
                                        return $ret;
                                else
                                        return null;
@@ -2746,7 +2737,7 @@ class Parser
                # SUBST
                wfProfileIn( __METHOD__.'-modifiers' );
                if ( !$found ) {
-                       $mwSubst =& MagicWord::get( 'subst' );
+                       $mwSubst = MagicWord::get( 'subst' );
                        if ( $mwSubst->matchStartAndRemove( $part1 ) xor $this->ot['wiki'] ) {
                                # One of two possibilities is true:
                                # 1) Found SUBST but not in the PST phase
@@ -2772,17 +2763,17 @@ class Parser
                # MSG, MSGNW and RAW
                if ( !$found ) {
                        # Check for MSGNW:
-                       $mwMsgnw =& MagicWord::get( 'msgnw' );
+                       $mwMsgnw = MagicWord::get( 'msgnw' );
                        if ( $mwMsgnw->matchStartAndRemove( $part1 ) ) {
                                $nowiki = true;
                        } else {
                                # Remove obsolete MSG:
-                               $mwMsg =& MagicWord::get( 'msg' );
+                               $mwMsg = MagicWord::get( 'msg' );
                                $mwMsg->matchStartAndRemove( $part1 );
                        }
 
                        # Check for RAW:
-                       $mwRaw =& MagicWord::get( 'raw' );
+                       $mwRaw = MagicWord::get( 'raw' );
                        if ( $mwRaw->matchStartAndRemove( $part1 ) ) {
                                $forceRawInterwiki = true;
                        }
@@ -2828,6 +2819,10 @@ class Parser
                                                $allArgs = array_merge( $initialArgs, $funcArgs );
                                        }
 
+                                       # Workaround for PHP bug 35229 and similar
+                                       if ( !is_callable( $callback ) ) {
+                                               throw new MWException( "Tag hook for $name is not callable\n" );
+                                       }
                                        $result = call_user_func_array( $callback, $allArgs );
                                        $found = true;
 
@@ -2936,7 +2931,9 @@ class Parser
                        # Clean up argument array
                        $newFrame = $frame->newChild( $args, $title );
 
-                       if ( $titleText !== false && $newFrame->isEmpty() ) {
+                       if ( $nowiki ) {
+                               $text = $newFrame->expand( $text, PPFrame::RECOVER_ORIG );
+                       } elseif ( $titleText !== false && $newFrame->isEmpty() ) {
                                # Expansion is eligible for the empty-frame cache
                                if ( isset( $this->mTplExpandCache[$titleText] ) ) {
                                        $text = $this->mTplExpandCache[$titleText];
@@ -2949,6 +2946,10 @@ class Parser
                                $text = $newFrame->expand( $text );
                        }
                }
+               if ( $isLocalObj && $nowiki ) {
+                       $text = $frame->expand( $text, PPFrame::RECOVER_ORIG );
+                       $isLocalObj = false;
+               }
 
                # Replace raw HTML by a placeholder
                # Add a blank line preceding, to prevent it from mucking up
@@ -3152,7 +3153,13 @@ class Parser
                $argName = trim( $nameWithSpaces );
                $object = false;
                $text = $frame->getArgument( $argName );
-               if (  $text === false && ( $this->ot['html'] || $this->ot['pre'] ) && $parts->getLength() > 0 ) {
+               if (  $text === false && $parts->getLength() > 0 
+                 && ( 
+                   $this->ot['html'] 
+                   || $this->ot['pre'] 
+                   || ( $this->ot['wiki'] && $frame->isTemplate() )
+                 )
+               ) {
                        # No match in frame, use the supplied default
                        $object = $parts->item( 0 )->getChildren();
                }
@@ -3191,13 +3198,12 @@ class Parser
         */
        function extensionSubstitution( $params, $frame ) {
                global $wgRawHtml, $wgContLang;
-               static $n = 1;
 
                $name = $frame->expand( $params['name'] );
                $attrText = !isset( $params['attr'] ) ? null : $frame->expand( $params['attr'] );
                $content = !isset( $params['inner'] ) ? null : $frame->expand( $params['inner'] );
 
-               $marker = "{$this->mUniqPrefix}-$name-" . sprintf('%08X', $n++) . $this->mMarkerSuffix;
+               $marker = "{$this->mUniqPrefix}-$name-" . sprintf('%08X', $this->mMarkerIndex++) . self::MARKER_SUFFIX;
                
                if ( $this->ot['html'] ) {
                        $name = strtolower( $name );
@@ -3226,6 +3232,10 @@ class Parser
                                        break;
                                default:
                                        if( isset( $this->mTagHooks[$name] ) ) {
+                                               # Workaround for PHP bug 35229 and similar
+                                               if ( !is_callable( $this->mTagHooks[$name] ) ) {
+                                                       throw new MWException( "Tag hook for $name is not callable\n" );
+                                               }
                                                $output = call_user_func_array( $this->mTagHooks[$name],
                                                        array( $content, $attributes, $this ) );
                                        } else {
@@ -3275,32 +3285,11 @@ class Parser
        }
 
        /**
-        * Detect __NOGALLERY__ magic word and set a placeholder
-        */
-       function stripNoGallery( &$text ) {
-               # if the string __NOGALLERY__ (not case-sensitive) occurs in the HTML,
-               # do not add TOC
-               $mw = MagicWord::get( 'nogallery' );
-               $this->mOutput->mNoGallery = $mw->matchAndRemove( $text ) ;
-       }
-
-       /**
-        * Find the first __TOC__ magic word and set a <!--MWTOC-->
-        * placeholder that will then be replaced by the real TOC in
-        * ->formatHeadings, this works because at this points real
-        * comments will have already been discarded by the sanitizer.
-        *
-        * Any additional __TOC__ magic words left over will be discarded
-        * as there can only be one TOC on the page.
+        * Strip double-underscore items like __NOGALLERY__ and __NOTOC__
+        * Fills $this->mDoubleUnderscores, returns the modified text
         */
-       function stripToc( $text ) {
-               # if the string __NOTOC__ (not case-sensitive) occurs in the HTML,
-               # do not add TOC
-               $mw = MagicWord::get( 'notoc' );
-               if( $mw->matchAndRemove( $text ) ) {
-                       $this->mShowToc = false;
-               }
-
+       function doDoubleUnderscore( $text ) {
+               // The position of __TOC__ needs to be recorded
                $mw = MagicWord::get( 'toc' );
                if( $mw->match( $text ) ) {
                        $this->mShowToc = true;
@@ -3312,6 +3301,27 @@ class Parser
                        // Only keep the first one.
                        $text = $mw->replace( '', $text );
                }
+
+               // Now match and remove the rest of them
+               $mwa = MagicWord::getDoubleUnderscoreArray();
+               $this->mDoubleUnderscores = $mwa->matchAndRemove( $text );
+
+               if ( isset( $this->mDoubleUnderscores['nogallery'] ) ) {
+                       $this->mOutput->mNoGallery = true;
+               }
+               if ( isset( $this->mDoubleUnderscores['notoc'] ) && !$this->mForceTocPosition ) {
+                       $this->mShowToc = false;
+               }
+               if ( isset( $this->mDoubleUnderscores['hiddencat'] ) && $this->mTitle->getNamespace() == NS_CATEGORY ) {
+                       $this->mOutput->setProperty( 'hiddencat', 'y' );
+
+                       $containerCategory = Title::makeTitleSafe( NS_CATEGORY, wfMsgForContent( 'hidden-category-category' ) );
+                       if ( $containerCategory ) {
+                               $this->mOutput->addCategory( $containerCategory->getDBkey(), $this->getDefaultSort() );
+                       } else {
+                               wfDebug( __METHOD__.": [[MediaWiki:hidden-category-category]] is not a valid title!\n" );
+                       }
+               }
                return $text;
        }
 
@@ -3340,8 +3350,7 @@ class Parser
                }
 
                # Inhibit editsection links if requested in the page
-               $esw =& MagicWord::get( 'noeditsection' );
-               if( $esw->matchAndRemove( $text ) ) {
+               if ( isset( $this->mDoubleUnderscores['noeditsection'] ) ) {
                        $showEditLink = 0;
                }
 
@@ -3357,14 +3366,13 @@ class Parser
 
                # Allow user to stipulate that a page should have a "new section"
                # link added via __NEWSECTIONLINK__
-               $mw =& MagicWord::get( 'newsectionlink' );
-               if( $mw->matchAndRemove( $text ) )
+               if ( isset( $this->mDoubleUnderscores['newsectionlink'] ) ) {
                        $this->mOutput->setNewSection( true );
+               }
 
                # if the string __FORCETOC__ (not case-sensitive) occurs in the HTML,
                # override above conditions and always show TOC above first header
-               $mw =& MagicWord::get( 'forcetoc' );
-               if ($mw->matchAndRemove( $text ) ) {
+               if ( isset( $this->mDoubleUnderscores['forcetoc'] ) ) {
                        $this->mShowToc = true;
                        $enoughToc = true;
                }
@@ -3388,7 +3396,7 @@ class Parser
                $prevlevel = 0;
                $toclevel = 0;
                $prevtoclevel = 0;
-               $markerRegex = "{$this->mUniqPrefix}-h-(\d+)-{$this->mMarkerSuffix}";
+               $markerRegex = "{$this->mUniqPrefix}-h-(\d+)-" . self::MARKER_SUFFIX;
                $baseTitleText = $this->mTitle->getPrefixedDBkey();
                $tocraw = array();
 
@@ -3447,6 +3455,7 @@ class Parser
                                                if($prevtoclevel < $wgMaxTocLevel) {
                                                        # Unindent only if the previous toc level was shown :p
                                                        $toc .= $sk->tocUnindent( $prevtoclevel - $toclevel );
+                                                       $prevtoclevel = $toclevel;
                                                } else {
                                                        $toc .= $sk->tocLineEnd();
                                                }
@@ -3505,11 +3514,15 @@ class Parser
                        # Save headline for section edit hint before it's escaped
                        $headlineHint = $safeHeadline;
                        $safeHeadline = Sanitizer::escapeId( $safeHeadline );
+                       # HTML names must be case-insensitively unique (bug 10721)
+                       $arrayKey = strtolower( $safeHeadline );
+
+                       # XXX : Is $refers[$headlineCount] ever accessed, actually ?
                        $refers[$headlineCount] = $safeHeadline;
 
                        # count how many in assoc. array so we can track dupes in anchors
-                       isset( $refers[$safeHeadline] ) ? $refers[$safeHeadline]++ : $refers[$safeHeadline] = 1;
-                       $refcount[$headlineCount] = $refers[$safeHeadline];
+                       isset( $refers[$arrayKey] ) ? $refers[$arrayKey]++ : $refers[$arrayKey] = 1;
+                       $refcount[$headlineCount] = $refers[$arrayKey];
 
                        # Don't number the heading if it is the only one (looks silly)
                        if( $doNumberHeadings && count( $matches[3] ) > 1) {
@@ -3630,24 +3643,25 @@ class Parser
                 * the database, we use $wgContLang here in order to give
                 * everyone the same signature and use the default one rather
                 * than the one selected in each user's preferences.
+                *
+                * (see also bug 12815)
                 */
+               $ts = $this->mOptions->getTimestamp();
+               $tz = 'UTC';
                if ( isset( $wgLocaltimezone ) ) {
+                       $unixts = wfTimestamp( TS_UNIX, $ts );
                        $oldtz = getenv( 'TZ' );
                        putenv( 'TZ='.$wgLocaltimezone );
-               }
-               $d = $wgContLang->timeanddate( date( 'YmdHis' ), false, false) .
-                 ' (' . date( 'T' ) . ')';
-               if ( isset( $wgLocaltimezone ) ) {
+                       $ts = date( 'YmdHis', $unixts );
+                       $tz = date( 'T', $unixts );  # might vary on DST changeover!
                        putenv( 'TZ='.$oldtz );
                }
+               $d = $wgContLang->timeanddate( $ts, false, false ) . " ($tz)";
 
                # Variable replacement
                # Because mOutputType is OT_WIKI, this will only process {{subst:xxx}} type tags
                $text = $this->replaceVariables( $text );
 
-               # Strip out <nowiki> etc. added via replaceVariables
-               #$text = $this->strip( $text, $this->mStripState, false, array( 'gallery' ) );
-
                # Signatures
                $sigText = $this->getUserSig( $user );
                $text = strtr( $text, array(
@@ -3849,7 +3863,9 @@ class Parser
                $tag = strtolower( $tag );
                $oldVal = isset( $this->mTagHooks[$tag] ) ? $this->mTagHooks[$tag] : null;
                $this->mTagHooks[$tag] = $callback;
-               $this->mStripList[] = $tag;
+               if( !in_array( $tag, $this->mStripList ) ) {
+                       $this->mStripList[] = $tag;
+               }
 
                return $oldVal;
        }
@@ -3948,7 +3964,7 @@ class Parser
                $colours = array();
                $linkcolour_ids = array();
                $sk = $this->mOptions->getSkin();
-               $linkCache =& LinkCache::singleton();
+               $linkCache = LinkCache::singleton();
 
                if ( !empty( $this->mLinkHolders['namespaces'] ) ) {
                        wfProfileIn( $fname.'-check' );
@@ -3987,10 +4003,7 @@ class Parser
                                        # Not in the link cache, add it to the query
                                        if ( !isset( $current ) ) {
                                                $current = $ns;
-                                               $query =  "SELECT page_id, page_namespace, page_title";
-                                               if ( $threshold > 0 ) {
-                                                       $query .= ', page_len, page_is_redirect';
-                                               }
+                                               $query =  "SELECT page_id, page_namespace, page_title, page_is_redirect, page_len";
                                                $query .= " FROM $page WHERE (page_namespace=$ns AND page_title IN(";
                                        } elseif ( $current != $ns ) {
                                                $current = $ns;
@@ -4015,9 +4028,9 @@ class Parser
                                while ( $s = $dbr->fetchObject($res) ) {
                                        $title = Title::makeTitle( $s->page_namespace, $s->page_title );
                                        $pdbk = $title->getPrefixedDBkey();
-                                       $linkCache->addGoodLinkObj( $s->page_id, $title );
+                                       $linkCache->addGoodLinkObj( $s->page_id, $title, $s->page_len, $s->page_is_redirect );
                                        $this->mOutput->addLink( $title, $s->page_id );
-                                       $colours[$pdbk] = $sk->getLinkColour( $s, $threshold );
+                                       $colours[$pdbk] = $sk->getLinkColour( $title, $threshold );
                                        //add id to the extension todolist
                                        $linkcolour_ids[$s->page_id] = $pdbk;
                                }
@@ -4078,10 +4091,7 @@ class Parser
                                        // construct query
                                        $titleClause = $linkBatch->constructSet('page', $dbr);
 
-                                       $variantQuery =  "SELECT page_id, page_namespace, page_title";
-                                       if ( $threshold > 0 ) {
-                                               $variantQuery .= ', page_len, page_is_redirect';
-                                       }
+                                       $variantQuery =  "SELECT page_id, page_namespace, page_title, page_is_redirect, page_len";
 
                                        $variantQuery .= " FROM $page WHERE $titleClause";
                                        if ( $options & RLH_FOR_UPDATE ) {
@@ -4100,7 +4110,7 @@ class Parser
                                                $holderKeys = array();
                                                if(isset($variantMap[$varPdbk])){
                                                        $holderKeys = $variantMap[$varPdbk];
-                                                       $linkCache->addGoodLinkObj( $s->page_id, $variantTitle );
+                                                       $linkCache->addGoodLinkObj( $s->page_id, $variantTitle, $s->page_len, $s->page_is_redirect );
                                                        $this->mOutput->addLink( $variantTitle, $s->page_id );
                                                }
 
@@ -4118,7 +4128,7 @@ class Parser
 
                                                                // set pdbk and colour
                                                                $pdbks[$key] = $varPdbk;
-                                                               $colours[$varPdbk] = $sk->getLinkColour( $s, $threshold );
+                                                               $colours[$varPdbk] = $sk->getLinkColour( $variantTitle, $threshold );
                                                                $linkcolour_ids[$s->page_id] = $pdbk;
                                                        }
                                                        wfRunHooks( 'GetLinkColours', array( $linkcolour_ids, &$colours ) );
@@ -4371,8 +4381,6 @@ class Parser
         * Parse image options text and use it to make an image
         */
        function makeImage( $title, $options ) {
-               # @TODO: let the MediaHandler specify its transform parameters
-               #
                # Check if the options text is of the form "options|alt text"
                # Options are:
                #  * thumbnail          make a thumbnail with enlarge-icon and caption, alignment depends on lang
@@ -4418,21 +4426,57 @@ class Parser
                        'horizAlign' => array(), 'vertAlign' => array() );
                foreach( $parts as $part ) {
                        list( $magicName, $value ) = $mwArray->matchVariableStartToEnd( $part );
-                       if ( isset( $paramMap[$magicName] ) ) {
+                       $validated = false;
+                       if( isset( $paramMap[$magicName] ) ) {
                                list( $type, $paramName ) = $paramMap[$magicName];
-                               $params[$type][$paramName] = $value;
-                               
+
                                // Special case; width and height come in one variable together
                                if( $type == 'handler' && $paramName == 'width' ) {
                                        $m = array();
-                                       if ( preg_match( '/^([0-9]*)x([0-9]*)$/', $value, $m ) ) {
-                                               $params[$type]['width'] = intval( $m[1] );
-                                               $params[$type]['height'] = intval( $m[2] );
+                                       # (bug 13500) In both cases (width/height and width only),
+                                       # permit trailing "px" for backward compatibility.
+                                       if ( preg_match( '/^([0-9]*)x([0-9]*)\s*(?:px)?\s*$/', $value, $m ) ) {
+                                               $width = intval( $m[1] );
+                                               $height = intval( $m[2] );
+                                               if ( $handler->validateParam( 'width', $width ) ) {
+                                                       $params[$type]['width'] = $width;
+                                                       $validated = true;
+                                               }
+                                               if ( $handler->validateParam( 'height', $height ) ) {
+                                                       $params[$type]['height'] = $height;
+                                                       $validated = true;
+                                               }
+                                       } elseif ( preg_match( '/^[0-9]*\s*(?:px)?\s*$/', $value ) ) {
+                                               $width = intval( $value );
+                                               if ( $handler->validateParam( 'width', $width ) ) {
+                                                       $params[$type]['width'] = $width;
+                                                       $validated = true;
+                                               }
+                                       } // else no validation -- bug 13436
+                               } else {
+                                       if ( $type == 'handler' ) {
+                                               # Validate handler parameter
+                                               $validated = $handler->validateParam( $paramName, $value );
                                        } else {
-                                               $params[$type]['width'] = intval( $value );
+                                               # Validate internal parameters
+                                               switch( $paramName ) {
+                                               case "manualthumb":
+                                                       /// @fixme - possibly check validity here?
+                                                       /// downstream behavior seems odd with missing manual thumbs.
+                                                       $validated = true;
+                                                       break;
+                                               default:
+                                                       // Most other things appear to be empty or numeric...
+                                                       $validated = ( $value === false || is_numeric( trim( $value ) ) );
+                                               }
+                                       }
+
+                                       if ( $validated ) {
+                                               $params[$type][$paramName] = $value;
                                        }
                                }
-                       } else {
+                       }
+                       if ( !$validated ) {
                                $caption = $part;
                        }
                }
@@ -4445,15 +4489,6 @@ class Parser
                        $params['frame']['valign'] = key( $params['vertAlign'] );
                }
 
-               # Validate the handler parameters
-               if ( $handler ) {
-                       foreach ( $params['handler'] as $name => $value ) {
-                               if ( !$handler->validateParam( $name, $value ) ) {
-                                       unset( $params['handler'][$name] );
-                               }
-                       }
-               }
-
                # Strip bad stuff out of the alt text
                $alt = $this->replaceLinkHoldersText( $caption );
 
@@ -4466,8 +4501,10 @@ class Parser
                $params['frame']['alt'] = $alt;
                $params['frame']['caption'] = $caption;
 
+               wfRunHooks( 'ParserMakeImageParams', array( $title, $file, &$params ) );
+
                # Linker does the rest
-               $ret = $sk->makeImageLink2( $title, $file, $params['frame'], $params['handler'] );
+               $ret = $sk->makeImageLink2( $title, $file, $params['frame'], $params['handler'], $time );
 
                # Give the handler a chance to modify the parser object
                if ( $handler ) {
@@ -4548,7 +4585,6 @@ class Parser
                $this->setTitle( $wgTitle ); // not generally used but removes an ugly failure mode
                $this->mOptions = new ParserOptions;
                $this->setOutputType( self::OT_WIKI );
-               $curIndex = 0;
                $outText = '';
                $frame = $this->getPreprocessor()->newFrame();
 
@@ -4573,22 +4609,19 @@ class Parser
                        // Section zero doesn't nest, level=big
                        $targetLevel = 1000;
                } else {
-                       while ( $node ) {
-                               if ( $node->getName() == 'h' ) {
-                                       if ( $curIndex + 1 == $sectionIndex ) {
+            while ( $node ) {
+                if ( $node->getName() == 'h' ) {
+                    $bits = $node->splitHeading();
+                                       if ( $bits['i'] == $sectionIndex ) {
+                                       $targetLevel = $bits['level'];
                                                break;
                                        }
-                                       $curIndex++;
                                }
                                if ( $mode == 'replace' ) {
                                        $outText .= $frame->expand( $node, PPFrame::RECOVER_ORIG );
                                }
                                $node = $node->getNextSibling();
                        }
-                       if ( $node ) {
-                               $bits = $node->splitHeading();
-                               $targetLevel = $bits['level'];
-                       }
                }
 
                if ( !$node ) {
@@ -4603,10 +4636,9 @@ class Parser
                // Find the end of the section, including nested sections
                do {
                        if ( $node->getName() == 'h' ) {
-                               $curIndex++;
                                $bits = $node->splitHeading();
                                $curLevel = $bits['level'];
-                               if ( $curIndex != $sectionIndex && $curLevel <= $targetLevel ) {
+                               if ( $bits['i'] != $sectionIndex && $curLevel <= $targetLevel ) {
                                        break;
                                }
                        }
@@ -4776,6 +4808,9 @@ class Parser
         */
        function testSrvus( $text, $title, $options, $outputType = self::OT_HTML ) {
                $this->clearState();
+               if ( ! ( $title instanceof Title ) ) {
+                       $title = Title::newFromText( $title );
+               }
                $this->mTitle = $title;
                $this->mOptions = $options;
                $this->setOutputType( $outputType );
@@ -4787,12 +4822,42 @@ class Parser
 
        function testPst( $text, $title, $options ) {
                global $wgUser;
+               if ( ! ( $title instanceof Title ) ) {
+                       $title = Title::newFromText( $title );
+               }
                return $this->preSaveTransform( $text, $title, $wgUser, $options );
        }
 
        function testPreprocess( $text, $title, $options ) {
+               if ( ! ( $title instanceof Title ) ) {
+                       $title = Title::newFromText( $title );
+               }
                return $this->testSrvus( $text, $title, $options, self::OT_PREPROCESS );
        }
+
+       function markerSkipCallback( $s, $callback ) {
+               $i = 0;
+               $out = '';
+               while ( $i < strlen( $s ) ) {
+                       $markerStart = strpos( $s, $this->mUniqPrefix, $i );
+                       if ( $markerStart === false ) {
+                               $out .= call_user_func( $callback, substr( $s, $i ) );
+                               break;
+                       } else {
+                               $out .= call_user_func( $callback, substr( $s, $i, $markerStart - $i ) );
+                               $markerEnd = strpos( $s, self::MARKER_SUFFIX, $markerStart );
+                               if ( $markerEnd === false ) {
+                                       $out .= substr( $s, $markerStart );
+                                       break;
+                               } else {
+                                       $markerEnd += strlen( self::MARKER_SUFFIX );
+                                       $out .= substr( $s, $markerStart, $markerEnd - $markerStart );
+                                       $i = $markerEnd;
+                               }
+                       }
+               }
+               return $out;
+       }
 }
 
 /**