-<?
+<?php
# See deferred.doc
class LinksUpdate {
/* Update link tables with outgoing links from an updated article */
/* Relies on the 'link cache' to be filled out */
- if ( !$wgUseBetterLinksUpdate ) {
- $this->doDumbUpdate();
- return;
- }
-
$fname = "LinksUpdate::doUpdate";
wfProfileIn( $fname );
if ( $wgLinkCache->incrementalSetup( LINKCACHE_GOOD, $del, $add ) ) {
# Delete where necessary
if ( count( $del ) ) {
- $sql = "DELETE FROM links WHERE l_from='{$this->mTitleEnc}' AND l_to IN(".
+ $sql = "DELETE FROM links WHERE l_from={$this->mId} AND l_to IN(".
implode( ",", $del ) . ")";
wfQuery( $sql, DB_WRITE, $fname );
}
} else {
# Delete everything
- $sql = "DELETE FROM links WHERE l_from='{$this->mTitleEnc}'";
+ $sql = "DELETE FROM links WHERE l_from={$this->mId}";
wfQuery( $sql, DB_WRITE, $fname );
# Get the addition list
if ( ! $first ) { $sql .= ","; }
$first = false;
- $sql .= "('{$this->mTitleEnc}',{$lid})";
+ $sql .= "({$this->mId},{$lid})";
}
}
if ( "" != $sql ) {
# Delete where necessary
if ( count( $del ) ) {
$sql = "DELETE FROM brokenlinks WHERE bl_from={$this->mId} AND bl_to IN('" .
- implode( "','", $del ) . "')";
+ implode( "','", array_map( "wfStrencode", $del ) ) . "')";
wfQuery( $sql, DB_WRITE, $fname );
}
} else {
#------------------------------------------------------------------------------
# Image links
- $sql = "DELETE FROM imagelinks WHERE il_from='{$this->mTitleEnc}'";
+ $sql = "DELETE FROM imagelinks WHERE il_from='{$this->mId}'";
wfQuery( $sql, DB_WRITE, $fname );
# Get addition list
foreach( $add as $iname => $val ) {
# FIXME: Change all this to avoid unnecessary duplication
$nt = Title::makeTitle( $image, $iname );
+ if( !$nt ) continue;
$nt->invalidateCache();
$iname = wfStrencode( $iname );
if ( ! $first ) { $sql .= ","; }
$first = false;
- $sql .= "('{$this->mTitleEnc}','{$iname}')";
+ $sql .= "({$this->mId},'{$iname}')";
}
}
if ( "" != $sql ) { wfQuery( $sql, DB_WRITE, $fname ); }
}
wfProfileOut( $fname );
}
-
+
function doDumbUpdate()
{
- # Old update function. This can probably be removed eventually, if the new one
- # proves to be stable
+ # Old inefficient update function
+ # Used for rebuilding the link table
+
global $wgLinkCache, $wgDBtransactions;
$fname = "LinksUpdate::doDumbUpdate";
wfProfileIn( $fname );
wfQuery( $sql, DB_WRITE, $fname );
}
- $sql = "DELETE FROM links WHERE l_from='{$this->mTitleEnc}'";
+ $sql = "DELETE FROM links WHERE l_from={$this->mId}";
wfQuery( $sql, DB_WRITE, $fname );
$a = $wgLinkCache->getGoodLinks();
if ( ! $first ) { $sql .= ","; }
$first = false;
- $sql .= "('{$this->mTitleEnc}',{$lid})";
+ $sql .= "({$this->mId},{$lid})";
}
}
if ( "" != $sql ) { wfQuery( $sql, DB_WRITE, $fname ); }
}
if ( "" != $sql ) { wfQuery( $sql, DB_WRITE, $fname ); }
- $sql = "DELETE FROM imagelinks WHERE il_from='{$this->mTitleEnc}'";
+ $sql = "DELETE FROM imagelinks WHERE il_from={$this->mId}";
wfQuery( $sql, DB_WRITE, $fname );
$a = $wgLinkCache->getImageLinks();
if ( ! $first ) { $sql .= ","; }
$first = false;
- $sql .= "('{$this->mTitleEnc}','{$iname}')";
+ $sql .= "({$this->mId},'{$iname}')";
}
}
if ( "" != $sql ) { wfQuery( $sql, DB_WRITE, $fname ); }
function fixBrokenLinks() {
/* Update any brokenlinks *to* this page */
/* Call for a newly created page, or just to make sure state is consistent */
+ $fname = "LinksUpdate::fixBrokenLinks";
$sql = "SELECT bl_from FROM brokenlinks WHERE bl_to='{$this->mTitleEnc}'";
$res = wfQuery( $sql, DB_READ, $fname );
while ( $row = wfFetchObject( $res ) ) {
if ( ! $first ) { $sql .= ","; $sql2 .= ","; }
$first = false;
- $nl = wfStrencode( Title::nameOf( $row->bl_from ) );
- $sql .= "('{$nl}',{$this->mId})";
+ $sql .= "({$row->bl_from},{$this->mId})";
$sql2 .= $row->bl_from;
}
$sql2 .= ")";