* Using Database::select() instead of a raw SQL query
[lhc/web/wiklou.git] / includes / Image.php
index a1a5214..e9f2f41 100644 (file)
@@ -3,9 +3,22 @@
  * @package MediaWiki
  */
 
-if ( $wgShowEXIF ) {
-       require_once ( 'exifReader.inc' ) ;
-}
+/**
+ * NOTE FOR WINDOWS USERS:
+ * To enable EXIF functions, add the folloing lines to the
+ * "Windows extensions" section of php.ini:
+ *
+ * extension=extensions/php_mbstring.dll
+ * extension=extensions/php_exif.dll
+ */
+
+if ($wgShowEXIF)
+       require_once('Exif.php');
+
+/**
+ * Bump this number when serialized cache records may be incompatible.
+ */
+define( 'MW_IMAGE_VERSION', 1 );
 
 /**
  * Class to represent an image
@@ -30,9 +43,11 @@ class Image
                $width,         # \
                $height,        #  |
                $bits,          #   --- returned by getimagesize (loadFromXxx)
-               $type,          #  |
                $attr,          # /
+               $type,          # MEDIATYPE_xxx (bitmap, drawing, audio...)
+               $mime,          # MIME type, determined by MimeMagic::guessMimeType
                $size,          # Size in bytes (loadFromXxx)
+               $metadata,      # Metadata
                $dataLoaded;    # Whether or not all this has been loaded from the database (loadFromXxx)
 
 
@@ -57,8 +72,14 @@ class Image
        }
        
        function Image( $title ) {
+               global $wgShowEXIF;
+               
+               if( !is_object( $title ) ) {
+                       wfDebugDieBacktrace( 'Image constructor given bogus title.' );
+               }
                $this->title =& $title;
                $this->name = $title->getDBkey();
+               $this->metadata = serialize ( array() ) ;
 
                $n = strrpos( $this->name, '.' );
                $this->extension = strtolower( $n ? substr( $this->name, $n + 1 ) : '' );
@@ -95,13 +116,20 @@ class Image
                $cachedValues = $wgMemc->get( $keys[0] );
 
                // Check if the key existed and belongs to this version of MediaWiki
-               if (!empty($cachedValues) && is_array($cachedValues) && isset($cachedValues['width']) && $cachedValues['fileExists']) {
+               if (!empty($cachedValues) && is_array($cachedValues)
+                 && isset($cachedValues['version']) && ( $cachedValues['version'] == MW_IMAGE_VERSION )
+                 && $cachedValues['fileExists'] && isset( $cachedValues['mime'] ) && isset( $cachedValues['metadata'] ) ) 
+               {
                        if ( $wgUseSharedUploads && $cachedValues['fromShared']) {
                                # if this is shared file, we need to check if image
                                # in shared repository has not changed
                                if ( isset( $keys[1] ) ) {
                                        $commonsCachedValues = $wgMemc->get( $keys[1] );
-                                       if (!empty($commonsCachedValues) && is_array($commonsCachedValues) && isset($commonsCachedValues['width'])) {
+                                       if (!empty($commonsCachedValues) && is_array($commonsCachedValues)
+                                         && isset($commonsCachedValues['version'])
+                                         && ( $commonsCachedValues['version'] == MW_IMAGE_VERSION )
+                                         && isset($commonsCachedValues['mime'])) {
+                                               wfDebug( "Pulling image metadata from shared repository cache\n" );
                                                $this->name = $commonsCachedValues['name'];
                                                $this->imagePath = $commonsCachedValues['imagePath'];
                                                $this->fileExists = $commonsCachedValues['fileExists'];
@@ -109,14 +137,16 @@ class Image
                                                $this->height = $commonsCachedValues['height'];
                                                $this->bits = $commonsCachedValues['bits'];
                                                $this->type = $commonsCachedValues['type'];
+                                               $this->mime = $commonsCachedValues['mime'];
+                                               $this->metadata = $commonsCachedValues['metadata'];
                                                $this->size = $commonsCachedValues['size'];
                                                $this->fromSharedDirectory = true;
                                                $this->dataLoaded = true;
                                                $this->imagePath = $this->getFullPath(true);
                                        }
                                }
-                       }
-                       else {
+                       } else {
+                               wfDebug( "Pulling image metadata from local cache\n" );
                                $this->name = $cachedValues['name'];
                                $this->imagePath = $cachedValues['imagePath'];
                                $this->fileExists = $cachedValues['fileExists'];
@@ -124,12 +154,19 @@ class Image
                                $this->height = $cachedValues['height'];
                                $this->bits = $cachedValues['bits'];
                                $this->type = $cachedValues['type'];
+                               $this->mime = $cachedValues['mime'];
+                               $this->metadata = $cachedValues['metadata'];
                                $this->size = $cachedValues['size'];
                                $this->fromSharedDirectory = false;
                                $this->dataLoaded = true;
                                $this->imagePath = $this->getFullPath();
                        }
                }
+               if ( $this->dataLoaded ) {
+                       wfIncrStats( 'image_cache_hit' );
+               } else {
+                       wfIncrStats( 'image_cache_miss' );
+               }
 
                wfProfileOut( $fname );
                return $this->dataLoaded;
@@ -141,22 +178,30 @@ class Image
        function saveToCache() {
                global $wgMemc;
                $this->load();
-               // We can't cache metadata for non-existent files, because if the file later appears 
-               // in commons, the local keys won't be purged.
+               $keys = $this->getCacheKeys();
                if ( $this->fileExists ) {
-                       $keys = $this->getCacheKeys();
-               
-                       $cachedValues = array('name' => $this->name,
-                                                                 'imagePath' => $this->imagePath,
-                                                                 'fileExists' => $this->fileExists,
-                                                                 'fromShared' => $this->fromSharedDirectory,
-                                                                 'width' => $this->width,
-                                                                 'height' => $this->height,
-                                                                 'bits' => $this->bits,
-                                                                 'type' => $this->type,
-                                                                 'size' => $this->size);
+                       // We can't cache negative metadata for non-existent files,
+                       // because if the file later appears in commons, the local
+                       // keys won't be purged.
+                       $cachedValues = array(
+                               'version'    => MW_IMAGE_VERSION,
+                               'name'       => $this->name,
+                               'imagePath'  => $this->imagePath,
+                               'fileExists' => $this->fileExists,
+                               'fromShared' => $this->fromSharedDirectory,
+                               'width'      => $this->width,
+                               'height'     => $this->height,
+                               'bits'       => $this->bits,
+                               'type'       => $this->type,
+                               'mime'       => $this->mime,
+                               'metadata'   => $this->metadata,
+                               'size'       => $this->size );
 
                        $wgMemc->set( $keys[0], $cachedValues );
+               } else {
+                       // However we should clear them, so they aren't leftover
+                       // if we've deleted the file.
+                       $wgMemc->delete( $keys[0] );
                }
        }
        
@@ -164,13 +209,16 @@ class Image
         * Load metadata from the file itself
         */
        function loadFromFile() {
-               global $wgUseSharedUploads, $wgSharedUploadDirectory, $wgLang;
+               global $wgUseSharedUploads, $wgSharedUploadDirectory, $wgLang,
+                      $wgShowEXIF;
                $fname = 'Image::loadFromFile';
                wfProfileIn( $fname );
                $this->imagePath = $this->getFullPath();
                $this->fileExists = file_exists( $this->imagePath );
                $this->fromSharedDirectory = false;
-               $gis = false;
+               $gis = array();
+               
+               if (!$this->fileExists) wfDebug("$fname: ".$this->imagePath." not found locally!\n"); 
 
                # If the file is not found, and a shared upload directory is used, look for it there.
                if (!$this->fileExists && $wgUseSharedUploads && $wgSharedUploadDirectory) {                    
@@ -186,40 +234,67 @@ class Image
                        }
                }
 
+
                if ( $this->fileExists ) {
+                       $magic=& wfGetMimeMagic();
+               
+                       $this->mime = $magic->guessMimeType($this->imagePath,true);
+                       $this->type = $magic->getMediaType($this->imagePath,$this->mime);
+                       
                        # Get size in bytes
                        $this->size = filesize( $this->imagePath );
 
+                       $magic=& wfGetMimeMagic();
+                       
                        # Height and width
-                       # Don't try to get the width and height of sound and video files, that's bad for performance
-                       if ( !Image::isKnownImageExtension( $this->extension ) ) {
-                               $gis = false;
-                       } elseif( $this->extension == 'svg' ) {
+                       if( $this->mime == 'image/svg' ) {
                                wfSuppressWarnings();
                                $gis = wfGetSVGsize( $this->imagePath );
                                wfRestoreWarnings();
-                       } else {
+                       }
+                       elseif ( !$magic->isPHPImageType( $this->mime ) ) {
+                               # Don't try to get the width and height of sound and video files, that's bad for performance
+                               $gis[0]= 0; //width
+                               $gis[1]= 0; //height
+                               $gis[2]= 0; //unknown
+                               $gis[3]= ""; //width height string
+                       }
+                       else {
                                wfSuppressWarnings();
                                $gis = getimagesize( $this->imagePath );
                                wfRestoreWarnings();
                        }
+                       
+                       wfDebug("$fname: ".$this->imagePath." loaded, ".$this->size." bytes, ".$this->mime.".\n"); 
                }
-               if( $gis === false ) {
-                       $this->width = 0;
-                       $this->height = 0;
-                       $this->bits = 0;
-                       $this->type = 0;
-               } else {
-                       $this->width = $gis[0];
-                       $this->height = $gis[1];
-                       $this->type = $gis[2];
-                       if ( isset( $gis['bits'] ) )  {
-                               $this->bits = $gis['bits'];
-                       } else {
-                               $this->bits = 0;
-                       }
+               else {
+                       $gis[0]= 0; //width
+                       $gis[1]= 0; //height
+                       $gis[2]= 0; //unknown
+                       $gis[3]= ""; //width height string
+                       
+                       $this->mime = NULL;
+                       $this->type = MEDIATYPE_UNKNOWN;
+                       wfDebug("$fname: ".$this->imagePath." NOT FOUND!\n"); 
                }
+               
+               $this->width = $gis[0];
+               $this->height = $gis[1];
+               
+               #NOTE: $gis[2] contains a code for the image type. This is no longer used.
+               
+               #NOTE: we have to set this flag early to avoid load() to be called 
+               # be some of the functions below. This may lead to recursion or other bad things!
+               # as ther's only one thread of execution, this should be safe anyway.
                $this->dataLoaded = true;
+               
+               
+               if ($this->fileExists && $wgShowEXIF) $this->metadata = serialize ( $this->retrieveExifData() ) ;
+               else $this->metadata = serialize ( array() ) ;
+               
+               if ( isset( $gis['bits'] ) )  $this->bits = $gis['bits'];
+               else $this->bits = 0;
+               
                wfProfileOut( $fname );
        }
 
@@ -227,13 +302,17 @@ class Image
         * Load image metadata from the DB
         */
        function loadFromDB() {
-               global $wgUseSharedUploads, $wgSharedUploadDBname, $wgLang;
+               global $wgUseSharedUploads, $wgSharedUploadDBname, $wgSharedUploadDBprefix, $wgLang;
                $fname = 'Image::loadFromDB';
                wfProfileIn( $fname );
                
                $dbr =& wfGetDB( DB_SLAVE );
+               
+               $this->checkDBSchema($dbr);
+               
                $row = $dbr->selectRow( 'image', 
-                       array( 'img_size', 'img_width', 'img_height', 'img_bits', 'img_type' ),
+                       array( 'img_size', 'img_width', 'img_height', 'img_bits', 
+                              'img_media_type', 'img_major_mime', 'img_minor_mime', 'img_metadata' ),
                        array( 'img_name' => $this->name ), $fname );
                if ( $row ) {
                        $this->fromSharedDirectory = false;
@@ -241,7 +320,7 @@ class Image
                        $this->loadFromRow( $row );
                        $this->imagePath = $this->getFullPath();
                        // Check for rows from a previous schema, quietly upgrade them
-                       if ( $this->type == -1 ) {
+                       if ( is_null($this->type) ) {
                                $this->upgradeRow();
                        }
                } elseif ( $wgUseSharedUploads && $wgSharedUploadDBname ) {
@@ -250,8 +329,10 @@ class Image
                        # looking it up in the shared repository.
                        $name = $wgLang->ucfirst($this->name);
 
-                       $row = $dbr->selectRow( "`$wgSharedUploadDBname`.image", 
-                               array( 'img_size', 'img_width', 'img_height', 'img_bits', 'img_type' ),
+                       $row = $dbr->selectRow( "`$wgSharedUploadDBname`.{$wgSharedUploadDBprefix}image",
+                               array( 
+                                       'img_size', 'img_width', 'img_height', 'img_bits', 
+                                       'img_media_type', 'img_major_mime', 'img_minor_mime', 'img_metadata' ),
                                array( 'img_name' => $name ), $fname );
                        if ( $row ) {
                                $this->fromSharedDirectory = true;
@@ -261,7 +342,7 @@ class Image
                                $this->loadFromRow( $row );
                                
                                // Check for rows from a previous schema, quietly upgrade them
-                               if ( $this->type == -1 ) {
+                               if ( is_null($this->type) ) {
                                        $this->upgradeRow();
                                }
                        }
@@ -275,10 +356,12 @@ class Image
                        $this->type = 0;
                        $this->fileExists = false;
                        $this->fromSharedDirectory = false;
+                       $this->metadata = serialize ( array() ) ;
                }
 
                # Unconditionally set loaded=true, we don't want the accessors constantly rechecking
                $this->dataLoaded = true;
+               wfProfileOut( $fname );
        }
 
        /*
@@ -289,7 +372,20 @@ class Image
                $this->width = $row->img_width;
                $this->height = $row->img_height;
                $this->bits = $row->img_bits;
-               $this->type = $row->img_type;
+               $this->type = $row->img_media_type;
+               
+               $major= $row->img_major_mime;
+               $minor= $row->img_minor_mime;
+               
+               if (!$major) $this->mime = "unknown/unknown";
+               else {
+                       if (!$minor) $minor= "unknown";
+                       $this->mime = $major.'/'.$minor;
+               }
+               
+               $this->metadata = $row->img_metadata;
+               if ( $this->metadata == "" ) $this->metadata = serialize ( array() ) ;
+               
                $this->dataLoaded = true;
        }
 
@@ -318,11 +414,14 @@ class Image
        function upgradeRow() {
                global $wgDBname, $wgSharedUploadDBname;
                $fname = 'Image::upgradeRow';
+               wfProfileIn( $fname );
+
                $this->loadFromFile();
                $dbw =& wfGetDB( DB_MASTER );
 
                if ( $this->fromSharedDirectory ) {
                        if ( !$wgSharedUploadDBname ) {
+                               wfProfileOut( $fname );
                                return;
                        }
 
@@ -330,17 +429,34 @@ class Image
                        // This avoids breaking replication in MySQL
                        $dbw->selectDB( $wgSharedUploadDBname );
                }
-               $dbw->update( '`image`', 
+               
+               $this->checkDBSchema($dbw);
+               
+               if (strpos($this->mime,'/')!==false) {
+                       list($major,$minor)= explode('/',$this->mime,2);
+               }
+               else {
+                       $major= $this->mime;
+                       $minor= "unknown";
+               }
+               
+               wfDebug("$fname: upgrading ".$this->name." to 1.5 schema\n");
+               
+               $dbw->update( 'image', 
                        array( 
                                'img_width' => $this->width,
                                'img_height' => $this->height,
                                'img_bits' => $this->bits,
-                               'img_type' => $this->type,
+                               'img_media_type' => $this->type,
+                               'img_major_mime' => $major,
+                               'img_minor_mime' => $minor,
+                               'img_metadata' => $this->metadata,
                        ), array( 'img_name' => $this->name ), $fname
                );
                if ( $this->fromSharedDirectory ) {
                        $dbw->selectDB( $wgDBname );
                }
+               wfProfileOut( $fname );
        }
                                
        /**
@@ -376,8 +492,14 @@ class Image
        }
        
        function getViewURL() {
-               if( $this->mustRender() ) {
-                       return $this->createThumb( $this->getWidth() );
+               if( $this->mustRender()) {
+                       if( $this->canRender() ) {
+                               return $this->createThumb( $this->getWidth() );
+                       }
+                       else {
+                               wfDebug('Image::getViewURL(): supposed to render '.$this->name.' ('.$this->mime."), but can't!\n");
+                               return $this->getURL(); #hm... return NULL?
+                       }
                } else {
                        return $this->getURL();
                }
@@ -425,19 +547,159 @@ class Image
        }
 
        /**
-        * Return the type of the image
-        *
-        * -  1 GIF
-        * -  2 JPG
-        * -  3 PNG
-        * - 15 WBMP
-        * - 16 XBM
+        * Returns the mime type of the file.
         */
-       function getType() {
+       function getMimeType() {
+               $this->load();
+               return $this->mime;
+       }
+       
+       /**
+        * Return the type of the media in the file. 
+        * Use the value returned by this function with the MEDIATYPE_xxx constants.
+        */
+       function getMediaType() {
                $this->load();
                return $this->type;
        }
 
+       /**
+        * Checks if the file can be presented to the browser as a bitmap.
+        * 
+        * Currently, this checks if the file is an image format 
+        * that can be converted to a format
+        * supported by all browsers (namely GIF, PNG and JPEG), 
+        * or if it is an SVG image and SVG conversion is enabled.
+        *
+        * @todo remember the result of this check.
+        */
+       function canRender() {
+               global $wgUseImageMagick;
+               
+               if( $this->getWidth()<=0 || $this->getHeight()<=0 ) return false;
+       
+               $mime= $this->getMimeType();
+               
+               if (!$mime || $mime==='unknown' || $mime==='unknown/unknown') return false;
+               
+               #if it's SVG, check if ther's a converter enabled    
+               if ($mime === 'image/svg') {
+                       global $wgSVGConverters, $wgSVGConverter;
+                       
+                       if ($wgSVGConverter && isset( $wgSVGConverters[$wgSVGConverter])) {
+                               return true;
+                       }
+               }
+               
+               #image formats available on ALL browsers
+               if (  $mime === 'image/gif'
+                  || $mime === 'image/png'
+                  || $mime === 'image/jpeg' ) return true;
+                   
+               #image formats that can be converted to the above formats
+               if ($wgUseImageMagick) {
+                       #convertable by ImageMagick (there are more...)
+                       if ( $mime === 'image/vnd.wap.wbmp'
+                         || $mime === 'image/x-xbitmap' 
+                         || $mime === 'image/x-xpixmap' 
+                         #|| $mime === 'image/x-icon'   #file may be split into multiple parts
+                         || $mime === 'image/x-portable-anymap'
+                         || $mime === 'image/x-portable-bitmap'
+                         || $mime === 'image/x-portable-graymap'
+                         || $mime === 'image/x-portable-pixmap'
+                         #|| $mime === 'image/x-photoshop'  #this takes a lot of CPU and RAM!
+                         || $mime === 'image/x-rgb'
+                         || $mime === 'image/x-bmp'
+                         || $mime === 'image/tiff' ) return true;
+               }
+               else {
+                       #convertable by the PHP GD image lib
+                       if ( $mime === 'image/vnd.wap.wbmp'
+                         || $mime === 'image/x-xbitmap' ) return true;
+               }
+                  
+               return false;
+       }
+       
+
+       /**
+        * Return true if the file is of a type that can't be directly
+        * rendered by typical browsers and needs to be re-rasterized.
+        * 
+        * This returns true for everything but the bitmap types 
+        * supported by all browsers, i.e. JPEG; GIF and PNG. It will
+        * also return true for any non-image formats.
+        *
+        * @return bool
+        */
+       function mustRender() {
+               $mime= $this->getMimeType();
+               
+               if (  $mime === "image/gif"
+                  || $mime === "image/png"
+                  || $mime === "image/jpeg" ) return false;
+                  
+               return true;
+       }
+       
+       /**
+        * Determines if this media file may be shown inline on a page.
+        * 
+        * This is currently synonymous to canRender(), but this could be 
+        * extended to also allow inline display of other media,
+        * like flash animations or videos. If you do so, please keep in mind that 
+        * that could be a security risk.
+        */
+       function allowInlineDisplay() {
+               return $this->canRender();
+       }
+       
+       /**
+        * Determines if this media file is in a format that is unlikely to
+        * contain viruses or malicious content. It uses the global
+        * $wgTrustedMediaFormats list to determine if the file is safe.
+        * 
+        * This is used to show a warning on the description page of non-safe files.
+        * It may also be used to disallow direct [[media:...]] links to such files.
+        *
+        * Note that this function will always return ture if allowInlineDisplay() 
+        * or isTrustedFile() is true for this file.
+        */
+       function isSafeFile() {
+               if ($this->allowInlineDisplay()) return true;
+               if ($this->isTrustedFile()) return true;
+               
+               global $wgTrustedMediaFormats;
+               
+               $type= $this->getMediaType();
+               $mime= $this->getMimeType();
+               #wfDebug("Image::isSafeFile: type= $type, mime= $mime\n");
+               
+               if (!$type || $type===MEDIATYPE_UNKNOWN) return false; #unknown type, not trusted
+               if ( in_array( $type, $wgTrustedMediaFormats) ) return true;
+               
+               if ($mime==="unknown/unknown") return false; #unknown type, not trusted
+               if ( in_array( $mime, $wgTrustedMediaFormats) ) return true;
+               
+               return false;
+       }
+       
+       /** Returns true if the file is flagegd as trusted. Files flagged that way
+       * can be linked to directly, even if that is not allowed for this type of
+       * file normally.
+       *
+       * This is a dummy function right now and always returns false. It could be
+       * implemented to extract a flag from the database. The trusted flag could be
+       * set on upload, if the user has sufficient privileges, to bypass script-
+       * and html-filters. It may even be coupeled with cryptographics signatures
+       * or such.
+       */
+       function isTrustedFile() {
+               #this could be implemented to check a flag in the databas,
+               #look for signatures, etc
+               return false; 
+       }
+
        /**
         * Return the escapeLocalURL of this image
         * @access public
@@ -461,6 +723,7 @@ class Image
         *
         * @param string $name  Name of the image, without the leading "Image:"
         * @param boolean $fromSharedDirectory  Should this be in $wgSharedUploadPath?   
+        * @return string URL of $name image
         * @access public
         * @static
         */
@@ -479,7 +742,7 @@ class Image
 
        /**
         * Returns true if the image file exists on disk.
-        *
+        * @return boolean Whether image file exist on disk.
         * @access public
         */
        function exists() {
@@ -488,7 +751,7 @@ class Image
        }
 
        /**
-        *
+        * @todo document
         * @access private
         */
        function thumbUrl( $width, $subdir='thumb') {
@@ -511,6 +774,9 @@ class Image
                }
                if ( $script ) {
                        $url = $script . '?f=' . urlencode( $this->name ) . '&w=' . urlencode( $width );
+                       if( $this->mustRender() ) {
+                               $url.= '&r=1';
+                       }
                } else {  
                        $name = $this->thumbName( $width );             
                        if($this->fromSharedDirectory) {
@@ -541,9 +807,17 @@ class Image
         */
        function thumbName( $width ) {
                $thumb = $width."px-".$this->name;
-               if( $this->extension == 'svg' ) {
-                       # Rasterize SVG vector images to PNG
-                       $thumb .= '.png';
+               
+               if( $this->mustRender() ) {
+                       if( $this->canRender() ) {
+                               # Rasterize to PNG (for SVG vector images, etc)
+                               $thumb .= '.png';
+                       }
+                       else {
+                               #should we use iconThumb here to get a symbolic thumbnail?
+                               #or should we fail with an internal error?
+                               return NULL; //can't make bitmap
+                       }
                }
                return $thumb;
        }
@@ -585,18 +859,24 @@ class Image
                        return $this->renderThumb( $width );
                }
                $this->load();
-               if ( $width < $this->width ) {
-                       $thumbheight = $this->height * $width / $this->width;
-                       $thumbwidth = $width;
-               } else {
-                       $thumbheight = $this->height;
-                       $thumbwidth = $this->width;
-               }
-               if ( $thumbheight > $height ) {
-                       $thumbwidth = $thumbwidth * $height / $thumbheight;
-                       $thumbheight = $height;
+               
+               if ($this->canRender()) {
+                       if ( $width < $this->width ) {
+                               $thumbheight = $this->height * $width / $this->width;
+                               $thumbwidth = $width;
+                       } else {
+                               $thumbheight = $this->height;
+                               $thumbwidth = $this->width;
+                       }
+                       if ( $thumbheight > $height ) {
+                               $thumbwidth = $thumbwidth * $height / $thumbheight;
+                               $thumbheight = $height;
+                       }
+                       
+                       $thumb = $this->renderThumb( $thumbwidth );
                }
-               $thumb = $this->renderThumb( $thumbwidth );
+               else $thumb= NULL; #not a bitmap or renderable image, don't try.
+               
                if( is_null( $thumb ) ) {
                        $thumb = $this->iconThumb();
                }
@@ -611,7 +891,7 @@ class Image
                
                $try = array( 'fileicon-' . $this->extension . '.png', 'fileicon.png' );
                foreach( $try as $icon ) {
-                       $path = '/common/images/' . $icon;
+                       $path = '/common/images/icons/' . $icon;
                        $filepath = $wgStyleDirectory . $path;
                        if( file_exists( $filepath ) ) {
                                return new ThumbnailImage( $wgStylePath . $path, 120, 120 );
@@ -632,7 +912,7 @@ class Image
         * @return ThumbnailImage
         * @access private
         */
-       function /* private */ renderThumb( $width, $useScript = true ) {
+       function renderThumb( $width, $useScript = true ) {
                global $wgUseSquid, $wgInternalServer;
                global $wgThumbnailScriptPath, $wgSharedThumbnailScriptPath;
                
@@ -646,12 +926,12 @@ class Image
                }
                
                # Sanity check $width
-               if( $width <= 0 ) {
+               if( $width <= 0 || $this->width <= 0) {
                        # BZZZT
                        return null;
                }
 
-               if( $width > $this->width && !$this->mustRender() ) {
+               if( $width >= $this->width && !$this->mustRender() ) {
                        # Don't make an image bigger than the source
                        return new ThumbnailImage( $this->getViewURL(), $this->getWidth(), $this->getHeight() );
                }
@@ -695,21 +975,25 @@ class Image
                                }
                        }
                }
+               
                return new ThumbnailImage( $url, $width, $height, $thumbPath );
        } // END OF function renderThumb
 
        /**
         * Really render a thumbnail
+        * Call this only for images for which canRender() returns true.
         *
         * @access private
         */
-       function /*private*/ reallyRenderThumb( $thumbPath, $width, $height ) {
+       function reallyRenderThumb( $thumbPath, $width, $height ) {
                global $wgSVGConverters, $wgSVGConverter,
                        $wgUseImageMagick, $wgImageMagickConvertCommand;
                
                $this->load();
                
-               if( $this->extension == 'svg' ) {
+               if( $this->mime === "image/svg" ) {
+                       #Right now we have only SVG
+                       
                        global $wgSVGConverters, $wgSVGConverter;
                        if( isset( $wgSVGConverters[$wgSVGConverter] ) ) {
                                global $wgSVGConverterPath;
@@ -717,8 +1001,8 @@ class Image
                                        array( '$path/', '$width', '$input', '$output' ),
                                        array( $wgSVGConverterPath,
                                                   $width,
-                                                  escapeshellarg( $this->imagePath ),
-                                                  escapeshellarg( $thumbPath ) ),
+                                                  wfEscapeShellArg( $this->imagePath ),
+                                                  wfEscapeShellArg( $thumbPath ) ),
                                        $wgSVGConverters[$wgSVGConverter] );
                                $conv = shell_exec( $cmd );
                        } else {
@@ -730,8 +1014,9 @@ class Image
                        # in Internet Explorer/Windows instead of default black.
                        $cmd  =  $wgImageMagickConvertCommand .
                                " -quality 85 -background white -geometry {$width} ".
-                               escapeshellarg($this->imagePath) . " " .
-                               escapeshellarg($thumbPath);                             
+                               wfEscapeShellArg($this->imagePath) . " " .
+                               wfEscapeShellArg($thumbPath);                           
+                       wfDebug("reallyRenderThumb: running ImageMagick: $cmd");
                        $conv = shell_exec( $cmd );
                } else {
                        # Use PHP's builtin GD library functions.
@@ -739,30 +1024,34 @@ class Image
                        # First find out what kind of file this is, and select the correct
                        # input routine for this.
 
-                       $truecolor = false;
+                       $typemap = array(
+                               'image/gif'          => array( 'imagecreatefromgif',  'palette',   'imagegif'  ),
+                               'image/jpeg'         => array( 'imagecreatefromjpeg', 'truecolor', array( &$this, 'imageJpegWrapper' ) ),
+                               'image/png'          => array( 'imagecreatefrompng',  'bits',      'imagepng'  ),
+                               'image/vnd.wap.wmbp' => array( 'imagecreatefromwbmp', 'palette',   'imagewbmp'  ),
+                               'image/xbm'          => array( 'imagecreatefromxbm',  'palette',   'imagexbm'  ),
+                       );
+                       if( !isset( $typemap[$this->mime] ) ) {
+                               $err = 'Image type not supported';
+                               wfDebug( "$err\n" );
+                               return $err;
+                       }
+                       list( $loader, $colorStyle, $saveType ) = $typemap[$this->mime];
                        
-                       switch( $this->type ) {
-                               case 1: # GIF
-                                       $src_image = imagecreatefromgif( $this->imagePath );
-                                       break;
-                               case 2: # JPG
-                                       $src_image = imagecreatefromjpeg( $this->imagePath );
-                                       $truecolor = true;
-                                       break;
-                               case 3: # PNG
-                                       $src_image = imagecreatefrompng( $this->imagePath );
-                                       $truecolor = ( $this->bits > 8 );
-                                       break;
-                               case 15: # WBMP for WML
-                                       $src_image = imagecreatefromwbmp( $this->imagePath );
-                                       break;
-                               case 16: # XBM
-                                       $src_image = imagecreatefromxbm( $this->imagePath );
-                                       break;
-                               default:
-                                       return 'Image type not supported';
-                                       break;
+                       if( !function_exists( $loader ) ) {
+                               $err = "Incomplete GD library configuration: missing function $loader";
+                               wfDebug( "$err\n" );
+                               return $err;
                        }
+                       if( $colorStyle == 'palette' ) {
+                               $truecolor = false;
+                       } elseif( $colorStyle == 'truecolor' ) {
+                               $truecolor = true;
+                       } elseif( $colorStyle == 'bits' ) {
+                               $truecolor = ( $this->bits > 8 );
+                       }
+                       
+                       $src_image = call_user_func( $loader, $this->imagePath );
                        if ( $truecolor ) {
                                $dst_image = imagecreatetruecolor( $width, $height );
                        } else {
@@ -771,23 +1060,11 @@ class Image
                        imagecopyresampled( $dst_image, $src_image, 
                                                0,0,0,0,
                                                $width, $height, $this->width, $this->height );
-                       switch( $this->type ) {
-                               case 1:  # GIF
-                               case 3:  # PNG
-                               case 15: # WBMP
-                               case 16: # XBM
-                                       imagepng( $dst_image, $thumbPath );
-                                       break;
-                               case 2:  # JPEG
-                                       imageinterlace( $dst_image );
-                                       imagejpeg( $dst_image, $thumbPath, 95 );
-                                       break;
-                               default:
-                                       break;
-                       }
+                       call_user_func( $saveType, $dst_image, $thumbPath );
                        imagedestroy( $dst_image );
                        imagedestroy( $src_image );
                }
+               
                #
                # Check for zero-sized thumbnails. Those can be generated when 
                # no disk space is available or some other error occurs
@@ -800,6 +1077,11 @@ class Image
                }
        }
 
+       function imageJpegWrapper( $dst_image, $thumbPath ) {
+               imageinterlace( $dst_image );
+               imagejpeg( $dst_image, $thumbPath, 95 );
+       }
+               
        /** 
         * Get all thumbnail names previously generated for this image
         */
@@ -858,6 +1140,21 @@ class Image
                        wfPurgeSquidServers( $urls );
                }
        }
+       
+       function checkDBSchema(&$db) {
+               # img_name must be unique
+               if ( !$db->indexUnique( 'image', 'img_name' ) && !$db->indexExists('image','PRIMARY') ) {
+                       wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/archives/patch-image_name_unique.sql' );
+               }
+               
+               #new fields must exist
+               if ( !$db->fieldExists( 'image', 'img_media_type' ) 
+                 || !$db->fieldExists( 'image', 'img_metadata' )
+                 || !$db->fieldExists( 'image', 'img_width' ) ) {
+                 
+                       wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/update.php' );
+               }
+       }
 
        /**
         * Return the image history of this image, line by line.
@@ -872,6 +1169,9 @@ class Image
        function nextHistoryLine() {
                $fname = 'Image::nextHistoryLine()';
                $dbr =& wfGetDB( DB_SLAVE );
+               
+               $this->checkDBSchema($dbr);
+               
                if ( $this->historyLine == 0 ) {// called for the first time, return line from cur 
                        $this->historyRes = $dbr->select( 'image', 
                                array( 'img_size','img_description','img_user','img_user_text','img_timestamp', "'' AS oi_archive_name" ), 
@@ -900,16 +1200,6 @@ class Image
        function resetHistory() {
                $this->historyLine = 0;
        }
-
-       /**
-        * Return true if the file is of a type that can't be directly
-        * rendered by typical browsers and needs to be re-rasterized.
-        * @return bool
-        */
-       function mustRender() {
-               $this->load();
-               return ( $this->extension == 'svg' );
-       }
        
        /**
        * Return the full filesystem path to the file. Note that this does
@@ -951,15 +1241,6 @@ class Image
                return $shared ? $wgHashedSharedUploadDirectory : $wgHashedUploadDirectory;
        }
        
-       /**
-        * @return bool
-        * @static
-        */
-       function isKnownImageExtension( $ext ) {
-               static $extensions = array( 'svg', 'png', 'jpg', 'jpeg', 'gif', 'bmp', 'xbm' );
-               return in_array( $ext, $extensions );
-       }
-
        /**
         * Record an image upload in the upload log and the image table
         */
@@ -970,16 +1251,14 @@ class Image
                $fname = 'Image::recordUpload';
                $dbw =& wfGetDB( DB_MASTER );
 
-               # img_name must be unique
-               if ( !$dbw->indexUnique( 'image', 'img_name' ) && !$dbw->indexExists('image','PRIMARY') ) {
-                       wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/archives/patch-image_name_unique.sql' );
-               }
+               $this->checkDBSchema($dbw);
 
                // Delete thumbnails and refresh the metadata cache
                $this->purgeCache();
 
                // Fail now if the image isn't there
                if ( !$this->fileExists || $this->fromSharedDirectory ) {
+                       wfDebug( "Image::recordUpload: File ".$this->imagePath." went missing!\n" );
                        return false;
                }
 
@@ -993,6 +1272,15 @@ class Image
 
                $now = $dbw->timestamp();
 
+               #split mime type
+               if (strpos($this->mime,'/')!==false) {
+                       list($major,$minor)= explode('/',$this->mime,2);
+               }
+               else {
+                       $major= $this->mime;
+                       $minor= "unknown";
+               }
+               
                # Test to see if the row exists using INSERT IGNORE
                # This avoids race conditions by locking the row until the commit, and also
                # doesn't deadlock. SELECT FOR UPDATE causes a deadlock for every race condition.
@@ -1000,14 +1288,17 @@ class Image
                        array(
                                'img_name' => $this->name,
                                'img_size'=> $this->size,
-                               'img_width' => $this->width,
-                               'img_height' => $this->height,
+                               'img_width' => IntVal( $this->width ),
+                               'img_height' => IntVal( $this->height ),
                                'img_bits' => $this->bits,
-                               'img_type' => $this->type,
+                               'img_media_type' => $this->type,
+                               'img_major_mime' => $major,
+                               'img_minor_mime' => $minor,
                                'img_timestamp' => $now,
                                'img_description' => $desc,
                                'img_user' => $wgUser->getID(),
                                'img_user_text' => $wgUser->getName(),
+                               'img_metadata' => $this->metadata,
                        ), $fname, 'IGNORE' 
                );
                $descTitle = $this->getTitle();
@@ -1032,26 +1323,28 @@ class Image
                                        'oi_width' => 'img_width',
                                        'oi_height' => 'img_height',
                                        'oi_bits' => 'img_bits',
-                                       'oi_type' => 'img_type',
                                        'oi_timestamp' => 'img_timestamp',
                                        'oi_description' => 'img_description',
                                        'oi_user' => 'img_user',
                                        'oi_user_text' => 'img_user_text',
                                ), array( 'img_name' => $this->name ), $fname
                        );
-
+                       
                        # Update the current image row
                        $dbw->update( 'image',
                                array( /* SET */
                                        'img_size' => $this->size,
-                                       'img_width' => $this->width,
-                                       'img_height' => $this->height,
+                                       'img_width' => intval( $this->width ),
+                                       'img_height' => intval( $this->height ),
                                        'img_bits' => $this->bits,
-                                       'img_type' => $this->type,
+                                       'img_media_type' => $this->type,
+                                       'img_major_mime' => $major,
+                                       'img_minor_mime' => $minor,
                                        'img_timestamp' => $now,
+                                       'img_description' => $desc,
                                        'img_user' => $wgUser->getID(),
                                        'img_user_text' => $wgUser->getName(),
-                                       'img_description' => $desc,
+                                       'img_metadata' => $this->metadata,
                                ), array( /* WHERE */
                                        'img_name' => $this->name
                                ), $fname
@@ -1103,7 +1396,7 @@ class Image
                if ( $db->numRows( $res ) ) {
                        while ( $row = $db->fetchObject( $res ) ) {
                                if ( $titleObj = Title::makeTitle( $row->page_namespace, $row->page_title ) ) {
-                                       $wgLinkCache->addGoodLink( $row->page_id, $titleObj->getPrefixedDBkey() );
+                                       $wgLinkCache->addGoodLinkObj( $row->page_id, $titleObj );
                                        $retVal[] = $titleObj;
                                }
                        }
@@ -1111,25 +1404,66 @@ class Image
                $db->freeResult( $res );
                return $retVal;
        }
-       
+       /**
+        * Retrive Exif data from the database
+        *
+        * Retrive Exif data from the database and prune unrecognized tags
+        * and/or tags with invalid contents
+        *
+        * @return array
+        */
        function retrieveExifData () {
-               global $wgShowEXIF ;
-               if ( ! $wgShowEXIF ) return array () ;
-
-               $file = $this->getImagePath () ;
-               $per = new phpExifReader ( $file ) ;
-               $per->processFile () ;
-               $a = $per->getImageInfo() ;
-               unset ( $a["FileName"] ) ;
-               unset ( $a["Thumbnail"] ) ;
-               return $a ;
+               if ( $this->getMimeType() !== "image/jpeg" ) return array ();
+
+               $exif = new Exif( $this->imagePath );
+               return $exif->getFilteredData();
        }
                
        function getExifData () {
-               return $this->retrieveExifData () ;
+               global $wgRequest;
+               if ( $this->metadata === '0' )
+                       return array();
+               
+               $purge = $wgRequest->getVal( 'action' ) == 'purge';
+               $ret = unserialize ( $this->metadata );
+
+               $oldver = isset( $ret['MEDIAWIKI_EXIF_VERSION'] ) ? $ret['MEDIAWIKI_EXIF_VERSION'] : 0;
+               $newver = Exif::version();
+               
+               if ( !count( $ret ) || $purge || $oldver != $newver ) {
+                       $this->updateExifData( $newver );
+               }
+               if ( isset( $ret['MEDIAWIKI_EXIF_VERSION'] ) )
+                       unset( $ret['MEDIAWIKI_EXIF_VERSION'] );
+               $format = new FormatExif( $ret );
+               return $format->getFormattedData();
        }
-       
-       function storeExifData () {
+
+       function updateExifData( $version ) {
+               $fname = 'Image:updateExifData';
+               
+               if ( $this->getImagePath() === false ) # Not a local image
+                       return;
+               
+               # Get EXIF data from image
+               $exif = $this->retrieveExifData();
+               if ( count( $exif ) ) {
+                       $exif['MEDIAWIKI_EXIF_VERSION'] = $version;
+                       $this->metadata = serialize( $exif );
+               } else {
+                       $this->metadata = '0';
+               }
+               
+               # Update EXIF data in database
+               $dbw =& wfGetDB( DB_MASTER );
+               
+               $this->checkDBSchema($dbw);
+               
+               $dbw->update( 'image', 
+                       array( 'img_metadata' => $this->metadata ),
+                       array( 'img_name' => $this->name ),
+                       $fname
+               );
        }
 
 } //class
@@ -1345,23 +1679,29 @@ function wfGetSVGsize( $filename ) {
 }
 
 /**
- * Is an image on the bad image list?
+ * Determine if an image exists on the 'bad image list'
+ *
+ * @param string $name The image to check
+ * @return bool
  */
 function wfIsBadImage( $name ) {
-       global $wgLang;
-
-       $lines = explode("\n", wfMsgForContent( 'bad_image_list' ));
-       foreach ( $lines as $line ) {
-               if ( preg_match( '/^\*\s*\[\[:(' . $wgLang->getNsText( NS_IMAGE ) . ':.*(?=]]))\]\]/', $line, $m ) ) {
-                       $t = Title::newFromText( $m[1] );
-                       if ( $t->getDBkey() == $name ) {
-                               return true;
+       global $wgContLang;
+       static $titleList = false;
+       if ( $titleList === false ) {
+               $titleList = array();
+
+               $lines = explode("\n", wfMsgForContent( 'bad_image_list' ));
+               foreach ( $lines as $line ) {
+                       if ( preg_match( '/^\*\s*\[{2}:(' . $wgContLang->getNsText( NS_IMAGE ) . ':.*?)\]{2}/', $line, $m ) ) {
+                               $t = Title::newFromText( $m[1] );
+                               $titleList[$t->getDBkey()] = 1;
                        }
                }
        }
-       return false;
+
+       return array_key_exists( $name, $titleList );
 }
-       
+
 
 
 /**