* (bug 6701) Kazakh language variants in MessagesEn.php
[lhc/web/wiklou.git] / includes / EditPage.php
index f90e135..5bf3e76 100644 (file)
@@ -23,7 +23,15 @@ class EditPage {
        var $formtype;
        var $firsttime;
        var $lastDelete;
-       var $mTokenOk = true;
+       var $mTokenOk = false;
+       var $mTriedSave = false;
+       var $tooBig = false;
+       var $kblength = false;
+       var $missingComment = false;
+       var $missingSummary = false;
+       var $allowBlankSummary = false;
+       var $autoSumm = '';
+       var $hookError = '';
 
        # Form values
        var $save = false, $preview = false, $diff = false;
@@ -41,6 +49,74 @@ class EditPage {
                global $wgTitle;
                $this->mTitle =& $wgTitle;
        }
+       
+       /**
+        * Fetch initial editing page content.
+        */
+       private function getContent() {
+               global $wgRequest, $wgParser;
+
+               # Get variables from query string :P
+               $section = $wgRequest->getVal( 'section' );
+               $preload = $wgRequest->getVal( 'preload' );
+
+               wfProfileIn( __METHOD__ );
+
+               $text = '';
+               if( !$this->mTitle->exists() ) {
+
+                       # If requested, preload some text.
+                       $text = $this->getPreloadedText( $preload );
+
+                       # We used to put MediaWiki:Newarticletext here if
+                       # $text was empty at this point.
+                       # This is now shown above the edit box instead.
+               } else {
+                       // FIXME: may be better to use Revision class directly
+                       // But don't mess with it just yet. Article knows how to
+                       // fetch the page record from the high-priority server,
+                       // which is needed to guarantee we don't pick up lagged
+                       // information.
+                       
+                       $text = $this->mArticle->getContent();
+                       
+                       if( $section != '' ) {
+                               if( $section == 'new' ) {
+                                       $text = $this->getPreloadedText( $preload );
+                               } else {
+                                       $text = $wgParser->getSection( $text, $section );
+                               }
+                       }
+               }
+               
+               wfProfileOut( __METHOD__ );
+               return $text;
+       }
+
+       /**
+        * Get the contents of a page from its title and remove includeonly tags
+        *
+        * @param $preload String: the title of the page.
+        * @return string The contents of the page.
+        */
+       private function getPreloadedText($preload) {
+               if ( $preload === '' )
+                       return '';
+               else {
+                       $preloadTitle = Title::newFromText( $preload );
+                       if ( isset( $preloadTitle ) && $preloadTitle->userCanRead() ) {
+                               $rev=Revision::newFromTitle($preloadTitle);
+                               if ( is_object( $rev ) ) {
+                                       $text = $rev->getText();
+                                       // TODO FIXME: AAAAAAAAAAA, this shouldn't be implementing
+                                       // its own mini-parser! -ævar
+                                       $text = preg_replace( '~</?includeonly>~', '', $text );
+                                       return $text;
+                               } else
+                                       return '';
+                       }
+               }
+       }
 
        /**
         * This is the function that extracts metadata from the article body on the first view.
@@ -53,7 +129,7 @@ class EditPage {
                if ( !$wgUseMetadataEdit ) return ;
                if ( $wgMetadataWhitelist == '' ) return ;
                $s = '' ;
-               $t = $this->mArticle->getContent();
+               $t = $this->getContent();
 
                # MISSING : <nowiki> filtering
 
@@ -153,8 +229,8 @@ class EditPage {
         * the newly-edited page.
         */
        function edit() {
-               global $wgOut, $wgUser, $wgRequest, $wgTitle,
-                      $wgEmailConfirmToEdit;
+               global $wgOut, $wgUser, $wgRequest, $wgTitle;
+               global $wgEmailConfirmToEdit;
 
                if ( ! wfRunHooks( 'AlternateEdit', array( &$this  ) ) )
                        return;
@@ -177,7 +253,7 @@ class EditPage {
 
                if ( ! $this->mTitle->userCanEdit() ) {
                        wfDebug( "$fname: user can't edit\n" );
-                       $wgOut->readOnlyPage( $this->mArticle->getContent(), true );
+                       $wgOut->readOnlyPage( $this->getContent(), true );
                        wfProfileOut( $fname );
                        return;
                }
@@ -186,7 +262,7 @@ class EditPage {
                        # When previewing, don't check blocked state - will get caught at save time.
                        # Also, check when starting edition is done against slave to improve performance.
                        wfDebug( "$fname: user is blocked\n" );
-                       $wgOut->blockedPage();
+                       $this->blockedPage();
                        wfProfileOut( $fname );
                        return;
                }
@@ -198,7 +274,7 @@ class EditPage {
                                return;
                        } else {
                                wfDebug( "$fname: read-only page\n" );
-                               $wgOut->readOnlyPage( $this->mArticle->getContent(), true );
+                               $wgOut->readOnlyPage( $this->getContent(), true );
                                wfProfileOut( $fname );
                                return;
                        }
@@ -209,7 +285,7 @@ class EditPage {
                        wfProfileOut($fname);
                        return;
                }
-               if ( !$this->mTitle->userCan( 'create' ) && !$this->mTitle->exists() ) {
+               if ( !$this->mTitle->userCanCreate() && !$this->mTitle->exists() ) {
                        wfDebug( "$fname: no create permission\n" );
                        $this->noCreatePermission();
                        wfProfileOut( $fname );
@@ -222,7 +298,7 @@ class EditPage {
                        } else if ( $this->diff ) {
                                $this->formtype = 'diff';
                        } else {
-                               $wgOut->readOnlyPage( $this->mArticle->getContent() );
+                               $wgOut->readOnlyPage( $this->getContent() );
                                wfProfileOut( $fname );
                                return;
                        }
@@ -248,7 +324,8 @@ class EditPage {
 
                $this->isConflict = false;
                // css / js subpages of user pages get a special treatment
-               $this->isCssJsSubpage = $wgTitle->isCssJsSubpage();
+               $this->isCssJsSubpage      = $wgTitle->isCssJsSubpage();
+               $this->isValidCssJsSubpage = $wgTitle->isValidCssJsSubpage();
 
                /* Notice that we can't use isDeleted, because it returns true if article is ever deleted
                 * no matter it's current state
@@ -295,6 +372,8 @@ class EditPage {
                # checking, etc.
                if ( 'initial' == $this->formtype || $this->firsttime ) {
                        $this->initialiseForm();
+                       if( !$this->mTitle->getArticleId() ) 
+                               wfRunHooks( 'EditFormPreloadText', array( &$this->textbox1, &$this->mTitle ) );
                }
 
                $this->showEditForm();
@@ -306,7 +385,7 @@ class EditPage {
         * Return true if this page should be previewed when the edit form
         * is initially opened.
         * @return bool
-        * @access private
+        * @private
         */
        function previewOnOpen() {
                global $wgUser;
@@ -318,9 +397,10 @@ class EditPage {
 
        /**
         * @todo document
+        * @param $request
         */
        function importFormData( &$request ) {
-               global $wgLang ;
+               global $wgLang, $wgUser;
                $fname = 'EditPage::importFormData';
                wfProfileIn( $fname );
 
@@ -349,19 +429,21 @@ class EditPage {
                                $this->preview = $request->getCheck( 'wpPreview' ) || $request->getCheck( 'wpLivePreview' );
                                $this->diff = $request->getCheck( 'wpDiff' );
 
-                               if( !$this->preview ) {
-                                       if ( $this->tokenOk( $request ) ) {
-                                               # Some browsers will not report any submit button
-                                               # if the user hits enter in the comment box.
-                                               # The unmarked state will be assumed to be a save,
-                                               # if the form seems otherwise complete.
-                                               wfDebug( "$fname: Passed token check.\n" );
-                                       } else {
-                                               # Page might be a hack attempt posted from
-                                               # an external site. Preview instead of saving.
-                                               wfDebug( "$fname: Failed token check; forcing preview\n" );
-                                               $this->preview = true;
-                                       }
+                               // Remember whether a save was requested, so we can indicate
+                               // if we forced preview due to session failure.
+                               $this->mTriedSave = !$this->preview;
+                               
+                               if ( $this->tokenOk( $request ) ) {
+                                       # Some browsers will not report any submit button
+                                       # if the user hits enter in the comment box.
+                                       # The unmarked state will be assumed to be a save,
+                                       # if the form seems otherwise complete.
+                                       wfDebug( "$fname: Passed token check.\n" );
+                               } else {
+                                       # Page might be a hack attempt posted from
+                                       # an external site. Preview instead of saving.
+                                       wfDebug( "$fname: Failed token check; forcing preview\n" );
+                                       $this->preview = true;
                                }
                        }
                        $this->save    = ! ( $this->preview OR $this->diff );
@@ -377,6 +459,15 @@ class EditPage {
 
                        $this->minoredit = $request->getCheck( 'wpMinoredit' );
                        $this->watchthis = $request->getCheck( 'wpWatchthis' );
+
+                       # Don't force edit summaries when a user is editing their own user or talk page
+                       if( ( $this->mTitle->mNamespace == NS_USER || $this->mTitle->mNamespace == NS_USER_TALK ) && $this->mTitle->getText() == $wgUser->getName() ) {
+                               $this->allowBlankSummary = true;
+                       } else {
+                               $this->allowBlankSummary = $request->getBool( 'wpIgnoreBlankSummary' );
+                       }
+       
+                       $this->autoSumm = $request->getText( 'wpAutoSummary' );                 
                } else {
                        # Not a posted form? Start with nothing.
                        wfDebug( "$fname: Not a posted form.\n" );
@@ -408,9 +499,9 @@ class EditPage {
        /**
         * Make sure the form isn't faking a user's credentials.
         *
-        * @param WebRequest $request
+        * @param $request WebRequest
         * @return bool
-        * @access private
+        * @private
         */
        function tokenOk( &$request ) {
                global $wgUser;
@@ -424,6 +515,7 @@ class EditPage {
                return $this->mTokenOk;
        }
 
+       /** */
        function showIntro() {
                global $wgOut, $wgUser;
                $addstandardintro=true;
@@ -451,6 +543,7 @@ class EditPage {
         */
        function attemptSave() {
                global $wgSpamRegex, $wgFilterCallback, $wgUser, $wgOut;
+               global $wgMaxArticleSize;
 
                $fname = 'EditPage::attemptSave';
                wfProfileIn( $fname );
@@ -473,20 +566,33 @@ class EditPage {
                        wfProfileOut( "$fname-checks" );
                        return false;
                }
-               if ( !wfRunHooks( 'EditFilter', array( &$this, $this->textbox1, $this->section ) ) ) {
-                       # Error messages or other handling should be performed by the filter function
+               if ( !wfRunHooks( 'EditFilter', array( $this, $this->textbox1, $this->section, &$this->hookError ) ) ) {
+                       # Error messages etc. could be handled within the hook...
                        wfProfileOut( $fname );
                        wfProfileOut( "$fname-checks" );
                        return false;
+               } elseif( $this->hookError != '' ) {
+                       # ...or the hook could be expecting us to produce an error
+                       wfProfileOut( "$fname-checks " );
+                       wfProfileOut( $fname );
+                       return true;
                }
                if ( $wgUser->isBlockedFrom( $this->mTitle, false ) ) {
                        # Check block state against master, thus 'false'.
-                       $this->blockedIPpage();
+                       $this->blockedPage();
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
                        return false;
                }
-
+               $this->kblength = (int)(strlen( $this->textbox1 ) / 1024);
+               if ( $this->kblength > $wgMaxArticleSize ) {
+                       // Error will be displayed by showEditForm()
+                       $this->tooBig = true;
+                       wfProfileOut( "$fname-checks" );
+                       wfProfileOut( $fname );
+                       return true;
+               }
+               
                if ( !$wgUser->isAllowed('edit') ) {
                        if ( $wgUser->isAnon() ) {
                                $this->userNotLoggedInPage();
@@ -529,7 +635,7 @@ class EditPage {
                $aid = $this->mTitle->getArticleID( GAID_FOR_UPDATE );
                if ( 0 == $aid ) {
                        // Late check for create permission, just in case *PARANOIA*
-                       if ( !$this->mTitle->userCan( 'create' ) ) {
+                       if ( !$this->mTitle->userCanCreate() ) {
                                wfDebug( "$fname: no create permission\n" );
                                $this->noCreatePermission();
                                wfProfileOut( $fname );
@@ -543,6 +649,14 @@ class EditPage {
                                        return false;
                        }
 
+                       # If no edit comment was given when creating a new page, and what's being
+                       # created is a redirect, be smart and fill in a neat auto-comment
+                       if( $this->summary == '' ) {
+                               $rt = Title::newFromRedirect( $this->textbox1 );
+                               if( is_object( $rt ) )
+                                       $this->summary = wfMsgForContent( 'autoredircomment', $rt->getPrefixedText() );
+                       }
+
                        $isComment=($this->section=='new');
                        $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
                                $this->minoredit, $this->watchthis, false, $isComment);
@@ -614,10 +728,31 @@ class EditPage {
                        return true;
                }
 
+               # If no edit comment was given when turning a page into a redirect, be smart
+               # and fill in a neat auto-comment
+               if( $this->summary == '' ) {
+                       $rt = Title::newFromRedirect( $this->textbox1 );
+                       if( is_object( $rt ) )
+                               $this->summary = wfMsgForContent( 'autoredircomment', $rt->getPrefixedText() );
+               }
+
+               # Handle the user preference to force summaries here
+               if( $this->section != 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary' ) ) {
+                       if( md5( $this->summary ) == $this->autoSumm ) {
+                               $this->missingSummary = true;
+                               wfProfileOut( $fname );
+                               return( true );
+                       }
+               }
+
                # All's well
                wfProfileIn( "$fname-sectionanchor" );
                $sectionanchor = '';
                if( $this->section == 'new' ) {
+                       if ( $this->textbox1 == '' ) {
+                               $this->missingComment = true;
+                               return true;
+                       }
                        if( $this->summary != '' ) {
                                $sectionanchor = $this->sectionAnchor( $this->summary );
                        }
@@ -641,6 +776,14 @@ class EditPage {
                $this->textbox1 = $text;
                $this->section = '';
 
+               // Check for length errors again now that the section is merged in
+               $this->kblength = (int)(strlen( $text ) / 1024);
+               if ( $this->kblength > $wgMaxArticleSize ) {
+                       $this->tooBig = true;
+                       wfProfileOut( $fname );
+                       return true;
+               }
+
                # update the article here
                if( $this->mArticle->updateArticle( $text, $this->summary, $this->minoredit,
                        $this->watchthis, '', $sectionanchor ) ) {
@@ -659,10 +802,10 @@ class EditPage {
         */
        function initialiseForm() {
                $this->edittime = $this->mArticle->getTimestamp();
-               $this->textbox1 = $this->mArticle->getContent();
+               $this->textbox1 = $this->getContent();
                $this->summary = '';
                if ( !$this->mArticle->exists() && $this->mArticle->mTitle->getNamespace() == NS_MEDIAWIKI )
-                       $this->textbox1 = wfMsgWeirdKey ( $this->mArticle->mTitle->getText() ) ;
+                       $this->textbox1 = wfMsgWeirdKey( $this->mArticle->mTitle->getText() ) ;
                wfProxyCheck();
        }
 
@@ -673,7 +816,7 @@ class EditPage {
         *                      near the top, for captchas and the like.
         */
        function showEditForm( $formCallback=null ) {
-               global $wgOut, $wgUser, $wgLang, $wgContLang;
+               global $wgOut, $wgUser, $wgLang, $wgContLang, $wgMaxArticleSize;
 
                $fname = 'EditPage::showEditForm';
                wfProfileIn( $fname );
@@ -693,7 +836,7 @@ class EditPage {
                        $wgOut->addWikiText( wfMsg( 'explainconflict' ) );
 
                        $this->textbox2 = $this->textbox1;
-                       $this->textbox1 = $this->mArticle->getContent();
+                       $this->textbox1 = $this->getContent();
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
 
@@ -702,7 +845,7 @@ class EditPage {
                                        $s = wfMsg('editingcomment', $this->mTitle->getPrefixedText() );
                                } else {
                                        $s = wfMsg('editingsection', $this->mTitle->getPrefixedText() );
-                                       if( !$this->preview && !$this->diff ) {
+                                       if( !$this->summary && !$this->preview && !$this->diff ) {
                                                preg_match( "/^(=+)(.+)\\1/mi",
                                                        $this->textbox1,
                                                        $matches );
@@ -715,6 +858,19 @@ class EditPage {
                                $s = wfMsg( 'editing', $this->mTitle->getPrefixedText() );
                        }
                        $wgOut->setPageTitle( $s );
+
+                       if ( $this->missingComment ) {
+                               $wgOut->addWikiText( wfMsg( 'missingcommenttext' ) );
+                       }
+                       
+                       if( $this->missingSummary ) {
+                               $wgOut->addWikiText( wfMsg( 'missingsummary' ) );
+                       }
+                       
+                       if( !$this->hookError == '' ) {
+                               $wgOut->addWikiText( $this->hookError );
+                       }
+
                        if ( !$this->checkUnicodeCompliantBrowser() ) {
                                $wgOut->addWikiText( wfMsg( 'nonunicodebrowser') );
                        }
@@ -728,31 +884,48 @@ class EditPage {
 
                if( wfReadOnly() ) {
                        $wgOut->addWikiText( wfMsg( 'readonlywarning' ) );
-               } else if ( $this->isCssJsSubpage and 'preview' != $this->formtype) {
-                       $wgOut->addWikiText( wfMsg( 'usercssjsyoucanpreview' ));
-               } else if( $wgUser->isAnon() && $this->formtype != 'preview' ) {
+               } elseif( $wgUser->isAnon() && $this->formtype != 'preview' ) {
                        $wgOut->addWikiText( wfMsg( 'anoneditwarning' ) );
+               } else {
+                       if( $this->isCssJsSubpage && $this->formtype != 'preview' ) {
+                               # Check the skin exists
+                               if( $this->isValidCssJsSubpage ) {
+                                       $wgOut->addWikiText( wfMsg( 'usercssjsyoucanpreview' ) );
+                               } else {
+                                       $wgOut->addWikiText( wfMsg( 'userinvalidcssjstitle', $this->mTitle->getSkinFromCssJsSubpage() ) );
+                               }
+                       }
                }
-               
+                       
                if( $this->mTitle->isProtected( 'edit' ) ) {
-                       if( $this->mTitle->isSemiProtected() ) {
+                       # Is the protection due to the namespace, e.g. interface text?
+                       if( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               # Yes; remind the user
+                               $notice = wfMsg( 'editinginterface' );
+                       } elseif( $this->mTitle->isSemiProtected() ) {
+                               # No; semi protected
                                $notice = wfMsg( 'semiprotectedpagewarning' );
                                if( wfEmptyMsg( 'semiprotectedpagewarning', $notice ) || $notice == '-' ) {
                                        $notice = '';
                                }
                        } else {
+                               # No; regular protection
                                $notice = wfMsg( 'protectedpagewarning' );
                        }
                        $wgOut->addWikiText( $notice );
                }
-               
-               $kblength = (int)(strlen( $this->textbox1 ) / 1024);
-               if( $kblength > 29 ) {
-                       $wgOut->addWikiText( wfMsg( 'longpagewarning', $wgLang->formatNum( $kblength ) ) );
+
+               if ( $this->kblength === false ) {
+                       $this->kblength = (int)(strlen( $this->textbox1 ) / 1024);
+               }
+               if ( $this->tooBig || $this->kblength > $wgMaxArticleSize ) {
+                       $wgOut->addWikiText( wfMsg( 'longpageerror', $wgLang->formatNum( $this->kblength ), $wgMaxArticleSize ) );
+               } elseif( $this->kblength > 29 ) {
+                       $wgOut->addWikiText( wfMsg( 'longpagewarning', $wgLang->formatNum( $this->kblength ) ) );
                }
 
-               $rows = $wgUser->getOption( 'rows' );
-               $cols = $wgUser->getOption( 'cols' );
+               $rows = $wgUser->getIntOption( 'rows' );
+               $cols = $wgUser->getIntOption( 'cols' );
 
                $ew = $wgUser->getOption( 'editwidth' );
                if ( $ew ) $ew = " style=\"width:100%\"";
@@ -764,12 +937,12 @@ class EditPage {
 
                $summary = wfMsg('summary');
                $subject = wfMsg('subject');
-               $minor   = wfMsg('minoredit');
-               $watchthis = wfMsg ('watchthis');
+               $minor   = wfMsgExt('minoredit', array('parseinline'));
+               $watchthis = wfMsgExt('watchthis', array('parseinline'));
 
                $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
-                               wfMsg('cancel') );
-               $edithelpurl = $sk->makeInternalOrExternalUrl( wfMsg( 'edithelppage' ));
+                               wfMsgExt('cancel', array('parseinline')) );
+               $edithelpurl = $sk->makeInternalOrExternalUrl( wfMsgForContent( 'edithelppage' ));
                $edithelp = '<a target="helpwindow" href="'.$edithelpurl.'">'.
                        htmlspecialchars( wfMsg( 'edithelp' ) ).'</a> '.
                        htmlspecialchars( wfMsg( 'newwindow' ) );
@@ -789,13 +962,19 @@ class EditPage {
 
                // activate checkboxes if user wants them to be always active
                if( !$this->preview && !$this->diff ) {
-                       if( $wgUser->getOption( 'watchdefault' ) ) $this->watchthis = true;
+                       # Sort out the "watch" checkbox
+                       if( $wgUser->getOption( 'watchdefault' ) ) {
+                               # Watch all edits
+                               $this->watchthis = true;
+                       } elseif( $wgUser->getOption( 'watchcreations' ) && !$this->mTitle->exists() ) {
+                               # Watch creations
+                               $this->watchthis = true;
+                       } elseif( $this->mTitle->userIsWatching() ) {
+                               # Already watched
+                               $this->watchthis = true;
+                       }
+                       
                        if( $wgUser->getOption( 'minordefault' ) ) $this->minoredit = true;
-
-                       // activate checkbox also if user is already watching the page,
-                       // require wpWatchthis to be unset so that second condition is not
-                       // checked unnecessarily
-                       if( !$this->watchthis && $this->mTitle->userIsWatching() ) $this->watchthis = true;
                }
 
                $minoredithtml = '';
@@ -803,8 +982,8 @@ class EditPage {
                if ( $wgUser->isAllowed('minoredit') ) {
                        $minoredithtml =
                                "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked='checked'":"").
-                               " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />".
-                               "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>";
+                               " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />\n".
+                               "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>\n";
                }
 
                $watchhtml = '';
@@ -812,9 +991,9 @@ class EditPage {
                if ( $wgUser->isLoggedIn() ) {
                        $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".
                                ($this->watchthis?" checked='checked'":"").
-                               " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis'  />".
+                               " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis'  />\n".
                                "<label for='wpWatchthis' title=\"" .
-                                       htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>";
+                                       htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>\n";
                }
 
                $checkboxhtml = $minoredithtml . $watchhtml;
@@ -837,11 +1016,11 @@ class EditPage {
                # Otherwise, show a summary field at the bottom
                $summarytext = htmlspecialchars( $wgContLang->recodeForEdit( $this->summary ) ); # FIXME
                if( $this->section == 'new' ) {
-                       $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span> <div class='editOptions'><input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
+                       $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<div class='editOptions'>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
                        $editsummary = '';
                } else {
                        $commentsubject = '';
-                       $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span> <div class='editOptions'><input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
+                       $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<div class='editOptions'>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
                }
 
                # Set focus to the edit box on load, except on preview or diff, where it would interfere with the display
@@ -854,8 +1033,7 @@ class EditPage {
                if ( $wgUseMetadataEdit ) {
                        $metadata = $this->mMetaData ;
                        $metadata = htmlspecialchars( $wgContLang->recodeForEdit( $metadata ) ) ;
-                       $helppage = Title::newFromText( wfMsg( "metadata_page" ) ) ;
-                       $top = wfMsg( 'metadata', $helppage->getLocalURL() );
+                       $top = wfMsgWikiHtml( 'metadata_help' );
                        $metadata = $top . "<textarea name='metadata' rows='3' cols='{$cols}'{$ew}>{$metadata}</textarea>" ;
                }
                else $metadata = "" ;
@@ -899,7 +1077,7 @@ class EditPage {
                $buttons['diff'] = wfElement('input', $temp, '');
 
                global $wgLivePreview;
-               if ( $wgLivePreview ) {
+               if ( $wgLivePreview && $wgUser->getOption( 'uselivepreview' ) ) {
                        $temp = array(
                                'id'        => 'wpPreview',
                                'name'      => 'wpPreview',
@@ -942,8 +1120,7 @@ class EditPage {
 
                $wgOut->addHTML( <<<END
 {$toolbar}
-<form id="editform" name="editform" method="post" action="$action"
-enctype="multipart/form-data">
+<form id="editform" name="editform" method="post" action="$action" enctype="multipart/form-data">
 END
 );
 
@@ -977,8 +1154,8 @@ END
 {$safemodehtml}
 ");
 
-               $wgOut->addHTML("
-<div class='editButtons'>
+               $wgOut->addHTML(
+"<div class='editButtons'>
        {$buttons['save']}
        {$buttons['preview']}
        {$buttons['live']}
@@ -1008,6 +1185,18 @@ END
                        $wgOut->addHTML( "\n<input type='hidden' value=\"$token\" name=\"wpEditToken\" />\n" );
                }
 
+               # If a blank edit summary was previously provided, and the appropriate
+               # user preference is active, pass a hidden tag here. This will stop the
+               # user being bounced back more than once in the event that a summary
+               # is not required.
+               if( $this->missingSummary ) {
+                       $wgOut->addHTML( "<input type=\"hidden\" name=\"wpIgnoreBlankSummary\" value=\"1\" />\n" );
+               }
+               
+               # For a bit more sophisticated detection of blank summaries, hash the
+               # automatic one and pass that in a hidden field.
+               $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
+               $wgOut->addHtml( wfHidden( 'wpAutoSummary', $autosumm ) );
 
                if ( $this->isConflict ) {
                        require_once( "DifferenceEngine.php" );
@@ -1042,7 +1231,7 @@ END
        /**
         * Append preview output to $wgOut.
         * Includes category rendering if this is a category page.
-        * @access private
+        * @private
         */
        function showPreview() {
                global $wgOut;
@@ -1081,7 +1270,7 @@ END
                        $batch->execute();
 
                        # Construct the HTML
-                       $outText = '<br />'. wfMsg( 'templatesused' ) . '<ul>';
+                       $outText = '<br />'. wfMsgExt( 'templatesused', array( 'parseinline' ) ) . '<ul>';
                        foreach ( $templates as $titleObj ) {
                                $outText .= '<li>' . $sk->makeLinkObj( $titleObj ) . '</li>';
                        }
@@ -1154,10 +1343,10 @@ END
                $fname = 'EditPage::getPreviewText';
                wfProfileIn( $fname );
 
-               if ( $this->mTokenOk ) {
-                       $msg = 'previewnote';
-               } else {
+               if ( $this->mTriedSave && !$this->mTokenOk ) {
                        $msg = 'session_fail_preview';
+               } else {
+                       $msg = 'previewnote';
                }
                $previewhead = '<h2>' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>\n" .
                        "<div class='previewnote'>" . $wgOut->parse( wfMsg( $msg ) ) . "</div>\n";
@@ -1168,26 +1357,29 @@ END
                $parserOptions = ParserOptions::newFromUser( $wgUser );
                $parserOptions->setEditSection( false );
 
+               global $wgRawHtml;
+               if( $wgRawHtml && !$this->mTokenOk ) {
+                       // Could be an offsite preview attempt. This is very unsafe if
+                       // HTML is enabled, as it could be an attack.
+                       return $wgOut->parse( "<div class='previewnote'>" .
+                               wfMsg( 'session_fail_preview_html' ) . "</div>" );
+               }
+
                # don't parse user css/js, show message about preview
                # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here
-
+               
                if ( $this->isCssJsSubpage ) {
                        if(preg_match("/\\.css$/", $wgTitle->getText() ) ) {
                                $previewtext = wfMsg('usercsspreview');
                        } else if(preg_match("/\\.js$/", $wgTitle->getText() ) ) {
                                $previewtext = wfMsg('userjspreview');
                        }
-                        $parserOptions->setTidy(true);
+                       $parserOptions->setTidy(true);
                        $parserOutput = $wgParser->parse( $previewtext , $wgTitle, $parserOptions );
                        $wgOut->addHTML( $parserOutput->mText );
                        wfProfileOut( $fname );
                        return $previewhead;
                } else {
-                       # if user want to see preview when he edit an article
-                       if( $wgUser->getOption('previewonfirst') and ($this->textbox1 == '')) {
-                               $this->textbox1 = $this->mArticle->getContent();
-                       }
-
                        $toparse = $this->textbox1;
 
                        # If we're adding a comment, we need to show the
@@ -1197,7 +1389,7 @@ END
                        }
 
                        if ( $this->mMetaData != "" ) $toparse .= "\n" . $this->mMetaData ;
-                        $parserOptions->setTidy(true);
+                       $parserOptions->setTidy(true);
                        $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $toparse ) ."\n\n",
                                        $wgTitle, $parserOptions );
 
@@ -1210,25 +1402,48 @@ END
        }
 
        /**
-        * @todo document
+        * Call the stock "user is blocked" page
         */
-       function blockedIPpage() {
-               global $wgOut;
-               $wgOut->blockedPage();
+       function blockedPage() {
+               global $wgOut, $wgUser;
+               $wgOut->blockedPage( false ); # Standard block notice on the top, don't 'return'
+               
+               # If the user made changes, preserve them when showing the markup
+               # (This happens when a user is blocked during edit, for instance)               
+               $first = $this->firsttime || ( !$this->save && $this->textbox1 == '' );
+               if( $first ) {
+                       $source = $this->mTitle->exists() ? $this->getContent() : false;
+               } else {
+                       $source = $this->textbox1;
+               }
+       
+               # Spit out the source or the user's modified version
+               if( $source !== false ) {
+                       $rows = $wgUser->getOption( 'rows' );
+                       $cols = $wgUser->getOption( 'cols' );
+                       $attribs = array( 'id' => 'wpTextbox1', 'name' => 'wpTextbox1', 'cols' => $cols, 'rows' => $rows, 'readonly' => 'readonly' );
+                       $wgOut->addHtml( '<hr />' );
+                       $wgOut->addWikiText( wfMsg( $first ? 'blockedoriginalsource' : 'blockededitsource', $this->mTitle->getPrefixedText() ) );
+                       $wgOut->addHtml( wfOpenElement( 'textarea', $attribs ) . htmlspecialchars( $source ) . wfCloseElement( 'textarea' ) );
+               }
        }
 
        /**
-        * @todo document
+        * Produce the stock "please login to edit pages" page
         */
        function userNotLoggedInPage() {
-               global $wgOut;
-
+               global $wgUser, $wgOut;
+               $skin = $wgUser->getSkin();
+               
+               $loginTitle = Title::makeTitle( NS_SPECIAL, 'Userlogin' );
+               $loginLink = $skin->makeKnownLinkObj( $loginTitle, wfMsgHtml( 'loginreqlink' ), 'returnto=' . $this->mTitle->getPrefixedUrl() );
+       
                $wgOut->setPageTitle( wfMsg( 'whitelistedittitle' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
-
-               $wgOut->addWikiText( wfMsg( 'whitelistedittext' ) );
-               $wgOut->returnToMain( false );
+               
+               $wgOut->addHtml( wfMsgWikiHtml( 'whitelistedittext', $loginLink ) );
+               $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
        }
 
        /**
@@ -1237,35 +1452,37 @@ END
         * allowed to edit.
         */
        function userNotConfirmedPage() {
-
                global $wgOut;
 
                $wgOut->setPageTitle( wfMsg( 'confirmedittitle' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
+               
                $wgOut->addWikiText( wfMsg( 'confirmedittext' ) );
                $wgOut->returnToMain( false );
        }
 
        /**
-        * @todo document
+        * Produce the stock "your edit contains spam" page
+        *
+        * @param $match Text which triggered one or more filters
         */
-       function spamPage ( $match = false )
-       {
+       function spamPage( $match = false ) {
                global $wgOut;
+
                $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
                $wgOut->addWikiText( wfMsg( 'spamprotectiontext' ) );
-               if ( $match ) {
+               if ( $match )
                        $wgOut->addWikiText( wfMsg( 'spamprotectionmatch', "<nowiki>{$match}</nowiki>" ) );
-               }
+                       
                $wgOut->returnToMain( false );
        }
 
        /**
-        * @access private
+        * @private
         * @todo document
         */
        function mergeChangesInto( &$editText ){
@@ -1307,7 +1524,7 @@ END
         * mangle UTF-8 data on form submission. Returns true if Unicode
         * should make it through, false if it's known to be a problem.
         * @return bool
-        * @access private
+        * @private
         */
        function checkUnicodeCompliantBrowser() {
                global $wgBrowserBlackList;
@@ -1328,7 +1545,7 @@ END
         * Format an anchor fragment as it would appear for a given section name
         * @param string $text
         * @return string
-        * @access private
+        * @private
         */
        function sectionAnchor( $text ) {
                $headline = Sanitizer::decodeCharReferences( $text );
@@ -1416,15 +1633,15 @@ END
                                        'key'   =>      'M'
                                ),
                        array(  'image' =>'button_math.png',
-                                       'open'  =>      "\\<math\\>",
-                                       'close' =>      "\\</math\\>",
+                                       'open'  =>      "<math>",
+                                       'close' =>      "<\\/math>",
                                        'sample'=>      wfMsg('math_sample'),
                                        'tip'   =>      wfMsg('math_tip'),
                                        'key'   =>      'C'
                                ),
                        array(  'image' =>'button_nowiki.png',
-                                       'open'  =>      "\\<nowiki\\>",
-                                       'close' =>      "\\</nowiki\\>",
+                                       'open'  =>      "<nowiki>",
+                                       'close' =>      "<\\/nowiki>",
                                        'sample'=>      wfMsg('nowiki_sample'),
                                        'tip'   =>      wfMsg('nowiki_tip'),
                                        'key'   =>      'N'
@@ -1444,9 +1661,9 @@ END
                                        'key'   =>      'R'
                                )
                );
-               $toolbar ="<script type='$wgJsMimeType'>\n/*<![CDATA[*/\n";
+               $toolbar = "<div id='toolbar'>\n";
+               $toolbar.="<script type='$wgJsMimeType'>\n/*<![CDATA[*/\n";
 
-               $toolbar.="document.writeln(\"<div id='toolbar'>\");\n";
                foreach($toolarray as $tool) {
 
                        $image=$wgStylePath.'/common/images/'.$tool['image'];
@@ -1465,8 +1682,8 @@ END
                        $toolbar.="addButton('$image','$tip','$open','$close','$sample');\n";
                }
 
-               $toolbar.="document.writeln(\"</div>\");\n";
                $toolbar.="/*]]>*/\n</script>";
+               $toolbar.="\n</div>";
                return $toolbar;
        }
 
@@ -1504,14 +1721,13 @@ END
         * @return string HTML
         */
        function getDiff() {
-               global $wgUser;
-
                require_once( 'DifferenceEngine.php' );
                $oldtext = $this->mArticle->fetchContent();
                $newtext = $this->mArticle->replaceSection(
                        $this->section, $this->textbox1, $this->summary, $this->edittime );
-               $oldtitle = wfMsg( 'currentrev' );
-               $newtitle = wfMsg( 'yourtext' );
+               $newtext = $this->mArticle->preSaveTransform( $newtext );
+               $oldtitle = wfMsgExt( 'currentrev', array('parseinline') );
+               $newtitle = wfMsgExt( 'yourtext', array('parseinline') );
                if ( $oldtext !== false  || $newtext != '' ) {
                        $de = new DifferenceEngine( $this->mTitle );
                        $de->setText( $oldtext, $newtext );
@@ -1530,7 +1746,7 @@ END
         * @param WebRequest $request
         * @param string $field
         * @return string
-        * @access private
+        * @private
         */
        function safeUnicodeInput( $request, $field ) {
                $text = rtrim( $request->getText( $field ) );
@@ -1545,7 +1761,7 @@ END
         *
         * @param string $text
         * @return string
-        * @access private
+        * @private
         */
        function safeUnicodeOutput( $text ) {
                global $wgContLang;
@@ -1566,7 +1782,7 @@ END
         *
         * @param string $invalue
         * @return string
-        * @access private
+        * @private
         */
        function makesafe( $invalue ) {
                // Armor existing references for reversability.
@@ -1608,7 +1824,7 @@ END
         *
         * @param string $invalue
         * @return string
-        * @access private
+        * @private
         */
        function unmakesafe( $invalue ) {
                $result = "";