After a longer phone call Erik and me agreed on working on an equivalent feature...
[lhc/web/wiklou.git] / includes / EditPage.php
index 999c65d..2c04c1f 100644 (file)
@@ -33,7 +33,7 @@ class EditPage {
                $this->importFormData( $wgRequest );
 
                if ( ! $this->mTitle->userCanEdit() ) {
-                       $wgOut->readOnlyPage( $this->mArticle->getContent(), true );
+                       $wgOut->readOnlyPage( $this->mArticle->getContent( true ), true );
                        return;
                }
                if ( $wgUser->isBlocked() ) {
@@ -48,11 +48,10 @@ class EditPage {
                        if( $this->save || $this->preview ) {
                                $this->editForm( "preview" );
                        } else {
-                               $wgOut->readOnlyPage( $this->mArticle->getContent() );
+                               $wgOut->readOnlyPage( $this->mArticle->getContent( true ) );
                        }
                        return;
                }
-               if( !$wgRequest->wasPosted() ) $this->save = false;
                if ( $this->save ) {
                        $this->editForm( "save" );
                } else if ( $this->preview ) {
@@ -73,8 +72,8 @@ class EditPage {
                $this->edittime = $request->getVal( 'wpEdittime' );
                if( !preg_match( '/^\d{14}$/', $this->edittime ) ) $this->edittime = "";
 
-               $this->save = $request->getCheck( 'wpSave' );
                $this->preview = $request->getCheck( 'wpPreview' );
+               $this->save = $request->wasPosted() && !$this->preview;
                $this->minoredit = $request->getCheck( 'wpMinoredit' );
                $this->watchthis = $request->getCheck( 'wpWatchthis' );
 
@@ -107,11 +106,14 @@ class EditPage {
        {
                global $wgOut, $wgUser;
                global $wgLang, $wgParser, $wgTitle;
-           global $wgAllowAnonymousMinor;
-           global $wgWhitelistEdit;
+               global $wgAllowAnonymousMinor;
+               global $wgWhitelistEdit;
+               global $wgSpamRegex;
 
                $sk = $wgUser->getSkin();
                $isConflict = false;
+               // css / js subpages of user pages get a special treatment
+               $isCssJsSubpage = Namespace::getUser() == $wgTitle->getNamespace() and preg_match("/\\.(css|js)$/", $wgTitle->getText() );
 
                if(!$this->mTitle->getArticleID()) { # new article
                        $wgOut->addWikiText(wfmsg("newarticletext"));
@@ -127,6 +129,12 @@ class EditPage {
                # in the back door with a hand-edited submission URL.
 
                if ( "save" == $formtype ) {
+                       # Check for spam
+                       if ( $wgSpamRegex && preg_match( $wgSpamRegex, $wpTextbox1 ) ) {
+                                       sleep(10);
+                                       $wgOut->redirect( $this->mTitle->getFullURL() );
+                                       return;
+                       }
                        if ( $wgUser->isBlocked() ) {
                                $this->blockedIPpage();
                                return;
@@ -172,7 +180,7 @@ class EditPage {
                        } else {
                                # switch from section editing to normal editing in edit conflict
                                if($isConflict) {
-                    # Attempt merge
+                                       # Attempt merge
                                        if( $this->mergeChangesInto( $text ) ){
                                                // Successful merge! Maybe we should tell the user the good news?
                                                $isConflict = false;
@@ -195,7 +203,7 @@ class EditPage {
 
                if ( "initial" == $formtype ) {
                        $this->edittime = $this->mArticle->getTimestamp();
-                       $this->textbox1 = $this->mArticle->getContent(true);
+                       $this->textbox1 = $this->mArticle->getContent( true );
                        $this->summary = "";
                        $this->proxyCheck();
                }
@@ -210,7 +218,7 @@ class EditPage {
                        $wgOut->addHTML( wfMsg( "explainconflict" ) );
 
                        $this->textbox2 = $this->textbox1;
-                       $this->textbox1 = $this->mArticle->getContent(true);
+                       $this->textbox1 = $this->mArticle->getContent( true );
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
                        $s = wfMsg( "editing", $this->mTitle->getPrefixedText() );
@@ -225,7 +233,7 @@ class EditPage {
                                        $sectitle=preg_match("/^=+(.*?)=+/mi",
                                        $this->textbox1,
                                        $matches);
-                                       if( !empty( $matches[1] ) {
+                                       if( !empty( $matches[1] ) {
                                                $this->summary = "/* ". trim($matches[1])." */ ";
                                        }
                                }
@@ -239,8 +247,10 @@ class EditPage {
 
                if( wfReadOnly() ) {
                        $wgOut->addHTML( "<strong>" .
-                               wfMsg( "readonlywarning" ) .
-                               "</strong>" );
+                       wfMsg( "readonlywarning" ) .
+                       "</strong>" );
+               } else if ( $isCssJsSubpage and "preview" != $formtype) {
+                       $wgOut->addHTML( wfMsg( "usercssjsyoucanpreview" ));
                }
                if( $this->mTitle->isProtected() ) {
                        $wgOut->addHTML( "<strong>" . wfMsg( "protectedpagewarning" ) .
@@ -274,14 +284,18 @@ class EditPage {
 
                $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedURL(),
                  wfMsg( "cancel" ) );
-               $edithelp = $sk->makeKnownLink( wfMsg( "edithelppage" ),
-                 wfMsg( "edithelp" ) );
+               $edithelpurl = $sk->makeUrl( wfMsg( "edithelppage" ));
+               $edithelp = '<a onclick="window.open('.
+               "'$edithelpurl', 'helpwindow', 'width=610,height=400,left=10,top=10'".'); return false;" href="'.$edithelpurl.'">'.
+               wfMsg( "edithelp" ).'</a>';
                $copywarn = wfMsg( "copyrightwarning", $sk->makeKnownLink(
                  wfMsg( "copyrightpage" ) ) );
 
-               if($wgUser->getOption("showtoolbar")) {
-                       // prepare toolbar for edit buttons
-                       $toolbar=$sk->getEditToolbar();
+               if( $wgUser->getOption("showtoolbar") and !$isCssJsSubpage ) {
+                       # prepare toolbar for edit buttons
+                       $toolbar = $sk->getEditToolbar();
+               } else {
+                       $toolbar = "";
                }
 
                // activate checkboxes if user wants them to be always active
@@ -299,15 +313,17 @@ class EditPage {
 
                if ( 0 != $wgUser->getID() || $wgAllowAnonymousMinor ) {
                        $minoredithtml =
-                       "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked":"")." id='wpMinoredit' />".
-                       "<label for='wpMinoredit'>{$minor}</label>";
+                       "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked='checked'":"").
+                       " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />".
+                       "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>";
                }
 
                $watchhtml = "";
 
                if ( 0 != $wgUser->getID() ) {
-                       $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".($this->watchthis?" checked":"")." id='wpWatchthis' />".
-                       "<label for='wpWatchthis'>{$watchthis}</label>";
+                       $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".($this->watchthis?" checked='checked'":"").
+                       " accesskey='".wfMsg('accesskey-watch')."' id='wpWatchthis'  />".
+                       "<label for='wpWatchthis' title='".wfMsg('tooltip-watch')."'>{$watchthis}</label>";
                }
 
                $checkboxhtml = $minoredithtml . $watchhtml . "<br />";
@@ -325,15 +341,27 @@ class EditPage {
                        $parserOptions->setUseCategoryMagic( false );
                        $parserOptions->setEditSection( false );
                        $parserOptions->setEditSectionOnRightClick( false );
-                       $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $previewtext ) ."\n\n",
+                       # don't parse user css/js, show message about preview
+                       # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here
+                       if ( $isCssJsSubpage ) {
+                               if(preg_match("/\\.css$/", $wgTitle->getText() ) ) {
+                                       $previewtext = wfMsg('usercsspreview');
+                               } else if(preg_match("/\\.js$/", $wgTitle->getText() ) ) {
+                                       $previewtext = wfMsg('userjspreview');
+                               }
+                               $parserOutput = $wgParser->parse( $previewtext , $wgTitle, $parserOptions );
+                               $wgOut->addHTML( $parserOutput->mText );
+                       } else {
+                               $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $previewtext ) ."\n\n",
                                $wgTitle, $parserOptions );
-                       $previewHTML = $parserOutput->mText;
+                               $previewHTML = $parserOutput->mText;
 
-                       if($wgUser->getOption("previewontop")) {
-                               $wgOut->addHTML($previewhead);
-                               $wgOut->addHTML($previewHTML);
+                               if($wgUser->getOption("previewontop")) {
+                                       $wgOut->addHTML($previewhead);
+                                       $wgOut->addHTML($previewHTML);
+                               }
+                               $wgOut->addHTML( "<br style=\"clear:both;\" />\n" );
                        }
-                       $wgOut->addHTML( "<br clear=\"all\" />\n" );
                }
 
                # if this is a comment, show a subject line at the top, which is also the edit summary.
@@ -356,15 +384,17 @@ class EditPage {
 <form id=\"editform\" name=\"editform\" method=\"post\" action=\"$action\"
 enctype=\"application/x-www-form-urlencoded\">
 {$commentsubject}
-<textarea tabindex='2' name=\"wpTextbox1\" rows='{$rows}'
-cols='{$cols}'{$ew} wrap=\"virtual\">" .
+<textarea tabindex='1' accesskey=\",\" name=\"wpTextbox1\" rows='{$rows}'
+cols='{$cols}'{$ew}>" .
 htmlspecialchars( $wgLang->recodeForEdit( $this->textbox1 ) ) .
 "
 </textarea>
 <br />{$editsummary}
 {$checkboxhtml}
-<input tabindex='5' type='submit' value=\"{$save}\" name=\"wpSave\" accesskey=\"s\" />
-<input tabindex='6' type='submit' value=\"{$prev}\" name=\"wpPreview\" accesskey=\"p\" />
+<input tabindex='5' type='submit' value=\"{$save}\" name=\"wpSave\" accesskey=\"".wfMsg('accesskey-save')."\"".
+" title=\"".wfMsg('tooltip-save')."\"/>
+<input tabindex='6' type='submit' value=\"{$prev}\" name=\"wpPreview\" accesskey=\"".wfMsg('accesskey-preview')."\"".
+" title=\"".wfMsg('tooltip-preview')."\"/>
 <em>{$cancel}</em> | <em>{$edithelp}</em>
 <br /><br />{$copywarn}
 <input type='hidden' value=\"" . htmlspecialchars( $this->section ) . "\" name=\"wpSection\" />
@@ -405,7 +435,7 @@ htmlspecialchars( $wgLang->recodeForEdit( $this->textbox1 ) ) .
                $link = "[[" . $wgLang->getNsText( Namespace::getUser() ) .
                  ":{$name}|{$name}]]";
 
-               $wgOut->addWikiText( wfMsg( "blockedtext", $link, $reason, $ip ) );
+               $wgOut->addWikiText( wfMsg( "blockedtext", $link, $reason, $ip, $name ) );
                $wgOut->returnToMain( false );
        }