Silenced this, $token["pos"] was undefined when parsing '''hi'''''hi'' which created...
[lhc/web/wiklou.git] / includes / EditPage.php
index c659e6e..2c04c1f 100644 (file)
@@ -33,7 +33,7 @@ class EditPage {
                $this->importFormData( $wgRequest );
 
                if ( ! $this->mTitle->userCanEdit() ) {
-                       $wgOut->readOnlyPage( $this->mArticle->getContent(), true );
+                       $wgOut->readOnlyPage( $this->mArticle->getContent( true ), true );
                        return;
                }
                if ( $wgUser->isBlocked() ) {
@@ -48,11 +48,10 @@ class EditPage {
                        if( $this->save || $this->preview ) {
                                $this->editForm( "preview" );
                        } else {
-                               $wgOut->readOnlyPage( $this->mArticle->getContent() );
+                               $wgOut->readOnlyPage( $this->mArticle->getContent( true ) );
                        }
                        return;
                }
-               if( !$wgRequest->wasPosted() ) $this->save = false;
                if ( $this->save ) {
                        $this->editForm( "save" );
                } else if ( $this->preview ) {
@@ -73,8 +72,8 @@ class EditPage {
                $this->edittime = $request->getVal( 'wpEdittime' );
                if( !preg_match( '/^\d{14}$/', $this->edittime ) ) $this->edittime = "";
 
-               $this->save = $request->getCheck( 'wpSave' );
                $this->preview = $request->getCheck( 'wpPreview' );
+               $this->save = $request->wasPosted() && !$this->preview;
                $this->minoredit = $request->getCheck( 'wpMinoredit' );
                $this->watchthis = $request->getCheck( 'wpWatchthis' );
 
@@ -107,10 +106,14 @@ class EditPage {
        {
                global $wgOut, $wgUser;
                global $wgLang, $wgParser, $wgTitle;
-           global $wgAllowAnonymousMinor;
+               global $wgAllowAnonymousMinor;
+               global $wgWhitelistEdit;
+               global $wgSpamRegex;
 
                $sk = $wgUser->getSkin();
                $isConflict = false;
+               // css / js subpages of user pages get a special treatment
+               $isCssJsSubpage = Namespace::getUser() == $wgTitle->getNamespace() and preg_match("/\\.(css|js)$/", $wgTitle->getText() );
 
                if(!$this->mTitle->getArticleID()) { # new article
                        $wgOut->addWikiText(wfmsg("newarticletext"));
@@ -126,6 +129,12 @@ class EditPage {
                # in the back door with a hand-edited submission URL.
 
                if ( "save" == $formtype ) {
+                       # Check for spam
+                       if ( $wgSpamRegex && preg_match( $wgSpamRegex, $wpTextbox1 ) ) {
+                                       sleep(10);
+                                       $wgOut->redirect( $this->mTitle->getFullURL() );
+                                       return;
+                       }
                        if ( $wgUser->isBlocked() ) {
                                $this->blockedIPpage();
                                return;
@@ -138,8 +147,8 @@ class EditPage {
                                $wgOut->readOnlyPage();
                                return;
                        }
-                       # If article is new, insert it.
 
+                       # If article is new, insert it.
                        $aid = $this->mTitle->getArticleID();
                        if ( 0 == $aid ) {
                                # Don't save a new article if it's blank.
@@ -170,9 +179,8 @@ class EditPage {
                                $isConflict = false;
                        } else {
                                # switch from section editing to normal editing in edit conflict
-                               # FIXME: This is confusing. In theory we should attempt to merge, finding
-                               # the equivalent section if it's unchanged and avoid the conflict.
                                if($isConflict) {
+                                       # Attempt merge
                                        if( $this->mergeChangesInto( $text ) ){
                                                // Successful merge! Maybe we should tell the user the good news?
                                                $isConflict = false;
@@ -195,7 +203,7 @@ class EditPage {
 
                if ( "initial" == $formtype ) {
                        $this->edittime = $this->mArticle->getTimestamp();
-                       $this->textbox1 = $this->mArticle->getContent(true);
+                       $this->textbox1 = $this->mArticle->getContent( true );
                        $this->summary = "";
                        $this->proxyCheck();
                }
@@ -210,7 +218,7 @@ class EditPage {
                        $wgOut->addHTML( wfMsg( "explainconflict" ) );
 
                        $this->textbox2 = $this->textbox1;
-                       $this->textbox1 = $this->mArticle->getContent(true);
+                       $this->textbox1 = $this->mArticle->getContent( true );
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
                        $s = wfMsg( "editing", $this->mTitle->getPrefixedText() );
@@ -221,6 +229,14 @@ class EditPage {
                                } else {
                                        $s.=wfMsg("sectionedit");
                                }
+                               if(!$this->preview) {
+                                       $sectitle=preg_match("/^=+(.*?)=+/mi",
+                                       $this->textbox1,
+                                       $matches);
+                                       if( !empty( $matches[1] ) ) {
+                                               $this->summary = "/* ". trim($matches[1])." */ ";
+                                       }
+                               }
                        }
                        $wgOut->setPageTitle( $s );
                        if ( $this->oldid ) {
@@ -231,8 +247,10 @@ class EditPage {
 
                if( wfReadOnly() ) {
                        $wgOut->addHTML( "<strong>" .
-                               wfMsg( "readonlywarning" ) .
-                               "</strong>" );
+                       wfMsg( "readonlywarning" ) .
+                       "</strong>" );
+               } else if ( $isCssJsSubpage and "preview" != $formtype) {
+                       $wgOut->addHTML( wfMsg( "usercssjsyoucanpreview" ));
                }
                if( $this->mTitle->isProtected() ) {
                        $wgOut->addHTML( "<strong>" . wfMsg( "protectedpagewarning" ) .
@@ -266,14 +284,18 @@ class EditPage {
 
                $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedURL(),
                  wfMsg( "cancel" ) );
-               $edithelp = $sk->makeKnownLink( wfMsg( "edithelppage" ),
-                 wfMsg( "edithelp" ) );
+               $edithelpurl = $sk->makeUrl( wfMsg( "edithelppage" ));
+               $edithelp = '<a onclick="window.open('.
+               "'$edithelpurl', 'helpwindow', 'width=610,height=400,left=10,top=10'".'); return false;" href="'.$edithelpurl.'">'.
+               wfMsg( "edithelp" ).'</a>';
                $copywarn = wfMsg( "copyrightwarning", $sk->makeKnownLink(
                  wfMsg( "copyrightpage" ) ) );
 
-               if($wgUser->getOption("showtoolbar")) {
-                       // prepare toolbar for edit buttons
-                       $toolbar=$sk->getEditToolbar();
+               if( $wgUser->getOption("showtoolbar") and !$isCssJsSubpage ) {
+                       # prepare toolbar for edit buttons
+                       $toolbar = $sk->getEditToolbar();
+               } else {
+                       $toolbar = "";
                }
 
                // activate checkboxes if user wants them to be always active
@@ -291,22 +313,24 @@ class EditPage {
 
                if ( 0 != $wgUser->getID() || $wgAllowAnonymousMinor ) {
                        $minoredithtml =
-                       "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked":"")." id='wpMinoredit'>".
-                       "<label for='wpMinoredit'>{$minor}</label>";
+                       "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked='checked'":"").
+                       " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />".
+                       "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>";
                }
 
                $watchhtml = "";
 
                if ( 0 != $wgUser->getID() ) {
-                       $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".($this->watchthis?" checked":"")." id='wpWatchthis'>".
-                       "<label for='wpWatchthis'>{$watchthis}</label>";
+                       $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".($this->watchthis?" checked='checked'":"").
+                       " accesskey='".wfMsg('accesskey-watch')."' id='wpWatchthis'  />".
+                       "<label for='wpWatchthis' title='".wfMsg('tooltip-watch')."'>{$watchthis}</label>";
                }
 
-               $checkboxhtml = $minoredithtml . $watchhtml . "<br>";
+               $checkboxhtml = $minoredithtml . $watchhtml . "<br />";
 
                if ( "preview" == $formtype) {
                        $previewhead="<h2>" . wfMsg( "preview" ) . "</h2>\n<p><large><center><font color=\"#cc0000\">" .
-                       wfMsg( "note" ) . wfMsg( "previewnote" ) . "</font></center></large><p>\n";
+                       wfMsg( "note" ) . wfMsg( "previewnote" ) . "</font></center></large></p>\n";
                        if ( $isConflict ) {
                                $previewhead.="<h2>" . wfMsg( "previewconflict" ) .
                                  "</h2>\n";
@@ -317,26 +341,38 @@ class EditPage {
                        $parserOptions->setUseCategoryMagic( false );
                        $parserOptions->setEditSection( false );
                        $parserOptions->setEditSectionOnRightClick( false );
-                       $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $previewtext ) ."\n\n",
+                       # don't parse user css/js, show message about preview
+                       # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here
+                       if ( $isCssJsSubpage ) {
+                               if(preg_match("/\\.css$/", $wgTitle->getText() ) ) {
+                                       $previewtext = wfMsg('usercsspreview');
+                               } else if(preg_match("/\\.js$/", $wgTitle->getText() ) ) {
+                                       $previewtext = wfMsg('userjspreview');
+                               }
+                               $parserOutput = $wgParser->parse( $previewtext , $wgTitle, $parserOptions );
+                               $wgOut->addHTML( $parserOutput->mText );
+                       } else {
+                               $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $previewtext ) ."\n\n",
                                $wgTitle, $parserOptions );
-                       $previewHTML = $parserOutput->mText;
+                               $previewHTML = $parserOutput->mText;
 
-                       if($wgUser->getOption("previewontop")) {
-                               $wgOut->addHTML($previewhead);
-                               $wgOut->addHTML($previewHTML);
+                               if($wgUser->getOption("previewontop")) {
+                                       $wgOut->addHTML($previewhead);
+                                       $wgOut->addHTML($previewHTML);
+                               }
+                               $wgOut->addHTML( "<br style=\"clear:both;\" />\n" );
                        }
-                       $wgOut->addHTML( "<br clear=\"all\" />\n" );
                }
 
                # if this is a comment, show a subject line at the top, which is also the edit summary.
                # Otherwise, show a summary field at the bottom
                $summarytext = htmlspecialchars( $wgLang->recodeForEdit( $this->summary ) ); # FIXME
                if( $this->section == "new" ) {
-                       $commentsubject="{$subject}: <input tabindex='1' type='text' value=\"$summarytext\" name=\"wpSummary\" maxlength='200' size='60'><br>";
+                       $commentsubject="{$subject}: <input tabindex='1' type='text' value=\"$summarytext\" name=\"wpSummary\" maxlength='200' size='60' /><br />";
                        $editsummary = "";
                } else {
                        $commentsubject = "";
-                       $editsummary="{$summary}: <input tabindex='3' type='text' value=\"$summarytext\" name=\"wpSummary\" maxlength='200' size='60'><br>";
+                       $editsummary="{$summary}: <input tabindex='3' type='text' value=\"$summarytext\" name=\"wpSummary\" maxlength='200' size='60' /><br />";
                }
 
                if( !$this->preview ) {
@@ -348,19 +384,21 @@ class EditPage {
 <form id=\"editform\" name=\"editform\" method=\"post\" action=\"$action\"
 enctype=\"application/x-www-form-urlencoded\">
 {$commentsubject}
-<textarea tabindex='2' name=\"wpTextbox1\" rows='{$rows}'
-cols='{$cols}'{$ew} wrap=\"virtual\">" .
+<textarea tabindex='1' accesskey=\",\" name=\"wpTextbox1\" rows='{$rows}'
+cols='{$cols}'{$ew}>" .
 htmlspecialchars( $wgLang->recodeForEdit( $this->textbox1 ) ) .
 "
 </textarea>
-<br>{$editsummary}
+<br />{$editsummary}
 {$checkboxhtml}
-<input tabindex='5' type='submit' value=\"{$save}\" name=\"wpSave\" accesskey=\"s\">
-<input tabindex='6' type='submit' value=\"{$prev}\" name=\"wpPreview\" accesskey=\"p\">
+<input tabindex='5' type='submit' value=\"{$save}\" name=\"wpSave\" accesskey=\"".wfMsg('accesskey-save')."\"".
+" title=\"".wfMsg('tooltip-save')."\"/>
+<input tabindex='6' type='submit' value=\"{$prev}\" name=\"wpPreview\" accesskey=\"".wfMsg('accesskey-preview')."\"".
+" title=\"".wfMsg('tooltip-preview')."\"/>
 <em>{$cancel}</em> | <em>{$edithelp}</em>
-<br><br>{$copywarn}
-<input type=hidden value=\"" . htmlspecialchars( $this->section ) . "\" name=\"wpSection\">
-<input type=hidden value=\"{$this->edittime}\" name=\"wpEdittime\">\n" );
+<br /><br />{$copywarn}
+<input type='hidden' value=\"" . htmlspecialchars( $this->section ) . "\" name=\"wpSection\" />
+<input type='hidden' value=\"{$this->edittime}\" name=\"wpEdittime\" />\n" );
 
                if ( $isConflict ) {
                        $wgOut->addHTML( "<h2>" . wfMsg( "yourdiff" ) . "</h2>\n" );
@@ -397,7 +435,7 @@ htmlspecialchars( $wgLang->recodeForEdit( $this->textbox1 ) ) .
                $link = "[[" . $wgLang->getNsText( Namespace::getUser() ) .
                  ":{$name}|{$name}]]";
 
-               $wgOut->addWikiText( wfMsg( "blockedtext", $link, $reason, $ip ) );
+               $wgOut->addWikiText( wfMsg( "blockedtext", $link, $reason, $ip, $name ) );
                $wgOut->returnToMain( false );
        }
 
@@ -439,14 +477,16 @@ htmlspecialchars( $wgLang->recodeForEdit( $this->textbox1 ) ) .
                # Fork the processes
                if ( !$skip ) {
                        $title = Title::makeTitle( NS_SPECIAL, "Blockme" );
-                       $url = $title->getFullURL();
+                       $iphash = md5( $wgIP . $wgProxyKey );
+                       $url = $title->getFullURL( "ip=$iphash" );
+
                        foreach ( $wgProxyPorts as $port ) {
                                $params = implode( " ", array(
-                                 escapeshellarg( $wgProxyScriptPath ),
-                                 escapeshellarg( $wgIP ),
-                                 escapeshellarg( $port ),
-                                 escapeshellarg( $url )
-                               ));
+                                                       escapeshellarg( $wgProxyScriptPath ),
+                                                       escapeshellarg( $wgIP ),
+                                                       escapeshellarg( $port ),
+                                                       escapeshellarg( $url )
+                                                       ));
                                exec( "php $params &>/dev/null &" );
                        }
                        # Set MemCached key
@@ -458,7 +498,7 @@ htmlspecialchars( $wgLang->recodeForEdit( $this->textbox1 ) ) .
 
        /* private */ function mergeChangesInto( &$text ){
                $oldDate = $this->edittime;
-               $res = wfQuery("SELECT cur_text FROM cur WHERE cur_id=" . 
+               $res = wfQuery("SELECT cur_text FROM cur WHERE cur_id=" .
                        $this->mTitle->getArticleID() . " FOR UPDATE", DB_WRITE);
                $obj = wfFetchObject($res);