Link to docs/magicword.txt
[lhc/web/wiklou.git] / includes / EditPage.php
index 4b44012..25f1e02 100644 (file)
@@ -8,8 +8,39 @@
  * The actual database and text munging is still in Article,
  * but it should get easier to call those from alternate
  * interfaces.
+ *
+ * EditPage cares about two distinct titles:
+ * $wgTitle is the page that forms submit to, links point to,
+ * redirects go to, etc. $this->mTitle (as well as $mArticle) is the
+ * page in the database that is actually being edited. These are
+ * usually the same, but they are now allowed to be different.
  */
 class EditPage {
+       const AS_SUCCESS_UPDATE                 = 200;
+       const AS_SUCCESS_NEW_ARTICLE            = 201;
+       const AS_HOOK_ERROR                     = 210;
+       const AS_FILTERING                      = 211;
+       const AS_HOOK_ERROR_EXPECTED            = 212;
+       const AS_BLOCKED_PAGE_FOR_USER          = 215;
+       const AS_CONTENT_TOO_BIG                = 216;
+       const AS_USER_CANNOT_EDIT               = 217;
+       const AS_READ_ONLY_PAGE_ANON            = 218;
+       const AS_READ_ONLY_PAGE_LOGGED          = 219;
+       const AS_READ_ONLY_PAGE                 = 220;
+       const AS_RATE_LIMITED                   = 221;
+       const AS_ARTICLE_WAS_DELETED            = 222;
+       const AS_NO_CREATE_PERMISSION           = 223;
+       const AS_BLANK_ARTICLE                  = 224;
+       const AS_CONFLICT_DETECTED              = 225;
+       const AS_SUMMARY_NEEDED                 = 226;
+       const AS_TEXTBOX_EMPTY                  = 228;
+       const AS_MAX_ARTICLE_SIZE_EXCEEDED      = 229;
+       const AS_OK                             = 230;
+       const AS_END                            = 231;
+       const AS_SPAM_ERROR                     = 232;
+       const AS_IMAGE_REDIRECT_ANON            = 233;
+       const AS_IMAGE_REDIRECT_LOGGED          = 234;
+
        var $mArticle;
        var $mTitle;
        var $mMetaData = '';
@@ -42,9 +73,15 @@ class EditPage {
        # extensions should take care to _append_ to the present value
        public $editFormPageTop; // Before even the preview
        public $editFormTextTop;
+       public $editFormTextBeforeContent;
        public $editFormTextAfterWarn;
        public $editFormTextAfterTools;
        public $editFormTextBottom;
+       
+       /* $didSave should be set to true whenever an article was succesfully altered. */
+       public $didSave = false;
+       
+       public $suppressIntro = false;
 
        /**
         * @todo document
@@ -52,12 +89,12 @@ class EditPage {
         */
        function EditPage( $article ) {
                $this->mArticle =& $article;
-               global $wgTitle;
-               $this->mTitle =& $wgTitle;
+               $this->mTitle = $article->getTitle();
 
                # Placeholders for text injection by hooks (empty per default)
                $this->editFormPageTop =
                $this->editFormTextTop =
+               $this->editFormTextBeforeContent =
                $this->editFormTextAfterWarn =
                $this->editFormTextAfterTools =
                $this->editFormTextBottom = "";
@@ -65,9 +102,10 @@ class EditPage {
        
        /**
         * Fetch initial editing page content.
+        * @private
         */
-       private function getContent( $def_text = '' ) {
-               global $wgOut, $wgRequest, $wgParser;
+       function getContent( $def_text = '' ) {
+               global $wgOut, $wgRequest, $wgParser, $wgMessageCache;
 
                # Get variables from query string :P
                $section = $wgRequest->getVal( 'section' );
@@ -80,6 +118,7 @@ class EditPage {
                $text = '';
                if( !$this->mTitle->exists() ) {
                        if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               $wgMessageCache->loadAllMessages();
                                # If this is a system message, get the default text. 
                                $text = wfMsgWeirdKey ( $this->mTitle->getText() ) ;
                        } else {
@@ -98,6 +137,11 @@ class EditPage {
 
                        $text = $this->mArticle->getContent();
 
+                       if ($undo > 0 && $undoafter > 0 && $undo < $undoafter) {
+                               # If they got undoafter and undo round the wrong way, switch them
+                               list( $undo, $undoafter ) = array( $undoafter, $undo );
+                       }
+
                        if ( $undo > 0 && $undo > $undoafter ) {
                                # Undoing a specific edit overrides section editing; section-editing
                                # doesn't work with undoing.
@@ -275,6 +319,25 @@ class EditPage {
                $this->mArticle->mContent = $t ;
                $this->mMetaData = $s ;
        }
+       
+       protected function wasDeletedSinceLastEdit() {
+               /* Note that we rely on the logging table, which hasn't been always there,
+                * but that doesn't matter, because this only applies to brand new
+                * deletes. 
+                */
+               if ( $this->deletedSinceEdit )
+                       return true;
+               if ( $this->mTitle->isDeleted() ) {
+                       $this->lastDelete = $this->getLastDelete();
+                       if ( !is_null($this->lastDelete) ) {
+                               $deletetime = $this->lastDelete->log_timestamp;
+                               if ( ($deletetime - $this->starttime) > 0 ) {
+                                       $this->deletedSinceEdit = true;
+                               }
+                       }
+               }
+               return $this->deletedSinceEdit;
+       }
 
        function submit() {
                $this->edit();
@@ -292,15 +355,13 @@ class EditPage {
         * the newly-edited page.
         */
        function edit() {
-               global $wgOut, $wgUser, $wgRequest, $wgTitle;
-               global $wgEmailConfirmToEdit;
+               global $wgOut, $wgUser, $wgRequest;
 
-               if ( ! wfRunHooks( 'AlternateEdit', array( &$this ) ) )
+               if ( !wfRunHooks( 'AlternateEdit', array( &$this ) ) )
                        return;
 
-               $fname = 'EditPage::edit';
-               wfProfileIn( $fname );
-               wfDebug( "$fname: enter\n" );
+               wfProfileIn( __METHOD__ );
+               wfDebug( __METHOD__.": enter\n" );
 
                // this is not an article
                $wgOut->setArticleFlag(false);
@@ -310,61 +371,48 @@ class EditPage {
 
                if( $this->live ) {
                        $this->livePreview();
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                        return;
                }
-
-               if ( ! $this->mTitle->userCan( 'edit' ) ) {
-                       wfDebug( "$fname: user can't edit\n" );
-                       $wgOut->readOnlyPage( $this->getContent(), true );
-                       wfProfileOut( $fname );
+               
+               if( wfReadOnly() ) {
+                       $this->readOnlyPage( $this->getContent() );
+                       wfProfileOut( __METHOD__ );
                        return;
                }
-               wfDebug( "$fname: Checking blocks\n" );
-               if ( !$this->preview && !$this->diff && $wgUser->isBlockedFrom( $this->mTitle, !$this->save ) ) {
-                       # When previewing, don't check blocked state - will get caught at save time.
-                       # Also, check when starting edition is done against slave to improve performance.
-                       wfDebug( "$fname: user is blocked\n" );
-                       $this->blockedPage();
-                       wfProfileOut( $fname );
-                       return;
+
+               $permErrors = $this->mTitle->getUserPermissionsErrors('edit', $wgUser);
+               if( !$this->mTitle->exists() ) {
+                       $permErrors = array_merge( $permErrors, 
+                               wfArrayDiff2( $this->mTitle->getUserPermissionsErrors('create', $wgUser), $permErrors ) );
                }
-               if ( !$wgUser->isAllowed('edit') ) {
-                       if ( $wgUser->isAnon() ) {
-                               wfDebug( "$fname: user must log in\n" );
-                               $this->userNotLoggedInPage();
-                               wfProfileOut( $fname );
-                               return;
-                       } else {
-                               wfDebug( "$fname: read-only page\n" );
-                               $wgOut->readOnlyPage( $this->getContent(), true );
-                               wfProfileOut( $fname );
-                               return;
+
+               # Ignore some permissions errors.
+               $remove = array();
+               foreach( $permErrors as $error ) {
+                       if ( ( $this->preview || $this->diff ) &&
+                               ($error[0] == 'blockedtext' || $error[0] == 'autoblockedtext'))
+                       {
+                               // Don't worry about blocks when previewing/diffing
+                               $remove[] = $error;
+                       }
+
+                       if ($error[0] == 'readonlytext')
+                       {
+                               if ($this->edit) {
+                                       $this->formtype = 'preview';
+                               } elseif ($this->save || $this->preview || $this->diff) {
+                                       $remove[] = $error;
+                               }
                        }
                }
-               if ($wgEmailConfirmToEdit && !$wgUser->isEmailConfirmed()) {
-                       wfDebug("$fname: user must confirm e-mail address\n");
-                       $this->userNotConfirmedPage();
-                       wfProfileOut($fname);
-                       return;
-               }
-               if ( !$this->mTitle->userCan( 'create' ) && !$this->mTitle->exists() ) {
-                       wfDebug( "$fname: no create permission\n" );
-                       $this->noCreatePermission();
-                       wfProfileOut( $fname );
+               $permErrors = wfArrayDiff2( $permErrors, $remove );
+
+               if ( $permErrors ) {
+                       wfDebug( __METHOD__.": User can't edit\n" );
+                       $this->readOnlyPage( $this->getContent(), true, $permErrors );
+                       wfProfileOut( __METHOD__ );
                        return;
-               }
-               if ( wfReadOnly() ) {
-                       wfDebug( "$fname: read-only mode is engaged\n" );
-                       if( $this->save || $this->preview ) {
-                               $this->formtype = 'preview';
-                       } else if ( $this->diff ) {
-                               $this->formtype = 'diff';
-                       } else {
-                               $wgOut->readOnlyPage( $this->getContent() );
-                               wfProfileOut( $fname );
-                               return;
-                       }
                } else {
                        if ( $this->save ) {
                                $this->formtype = 'save';
@@ -383,40 +431,19 @@ class EditPage {
                        }
                }
 
-               wfProfileIn( "$fname-business-end" );
+               wfProfileIn( __METHOD__."-business-end" );
 
                $this->isConflict = false;
                // css / js subpages of user pages get a special treatment
-               $this->isCssJsSubpage      = $wgTitle->isCssJsSubpage();
-               $this->isValidCssJsSubpage = $wgTitle->isValidCssJsSubpage();
-
-               /* Notice that we can't use isDeleted, because it returns true if article is ever deleted
-                * no matter it's current state
-                */
-               $this->deletedSinceEdit = false;
-               if ( $this->edittime != '' ) {
-                       /* Note that we rely on logging table, which hasn't been always there,
-                        * but that doesn't matter, because this only applies to brand new
-                        * deletes. This is done on every preview and save request. Move it further down
-                        * to only perform it on saves
-                        */
-                       if ( $this->mTitle->isDeleted() ) {
-                               $this->lastDelete = $this->getLastDelete();
-                               if ( !is_null($this->lastDelete) ) {
-                                       $deletetime = $this->lastDelete->log_timestamp;
-                                       if ( ($deletetime - $this->starttime) > 0 ) {
-                                               $this->deletedSinceEdit = true;
-                                       }
-                               }
-                       }
-               }
+               $this->isCssJsSubpage      = $this->mTitle->isCssJsSubpage();
+               $this->isValidCssJsSubpage = $this->mTitle->isValidCssJsSubpage();
 
                # Show applicable editing introductions
                if( $this->formtype == 'initial' || $this->firsttime )
                        $this->showIntro();
        
                if( $this->mTitle->isTalkPage() ) {
-                       $wgOut->addWikiText( wfMsg( 'talkpagetext' ) );
+                       $wgOut->addWikiMsg( 'talkpagetext' );
                }
 
                # Attempt submission here.  This will check for edit conflicts,
@@ -426,8 +453,8 @@ class EditPage {
 
                if ( 'save' == $this->formtype ) {
                        if ( !$this->attemptSave() ) {
-                               wfProfileOut( "$fname-business-end" );
-                               wfProfileOut( $fname );
+                               wfProfileOut( __METHOD__."-business-end" );
+                               wfProfileOut( __METHOD__ );
                                return;
                        }
                }
@@ -437,8 +464,8 @@ class EditPage {
                if ( 'initial' == $this->formtype || $this->firsttime ) {
                        if ($this->initialiseForm() === false) {
                                $this->noSuchSectionPage();
-                               wfProfileOut( "$fname-business-end" );
-                               wfProfileOut( $fname );
+                               wfProfileOut( __METHOD__."-business-end" );
+                               wfProfileOut( __METHOD__ );
                                return;
                        }
                        if( !$this->mTitle->getArticleId() ) 
@@ -446,22 +473,52 @@ class EditPage {
                }
 
                $this->showEditForm();
-               wfProfileOut( "$fname-business-end" );
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__."-business-end" );
+               wfProfileOut( __METHOD__ );
+       }
+
+       /**
+        * Show a read-only error
+        * Parameters are the same as OutputPage:readOnlyPage()
+        * Redirect to the article page if redlink=1
+        */
+       function readOnlyPage( $source = null, $protected = false, $reasons = array() ) {
+               global $wgRequest, $wgOut;
+               if ( $wgRequest->getBool( 'redlink' ) ) {
+                       // The edit page was reached via a red link.
+                       // Redirect to the article page and let them click the edit tab if 
+                       // they really want a permission error.
+                       $wgOut->redirect( $this->mTitle->getFullUrl() );
+               } else {
+                       $wgOut->readOnlyPage( $source, $protected, $reasons );
+               }
        }
 
        /**
-        * Return true if this page should be previewed when the edit form
-        * is initially opened.
+        * Should we show a preview when the edit form is first shown?
+        *
         * @return bool
-        * @private
         */
-       function previewOnOpen() {
-               global $wgUser;
-               return $this->section != 'new' &&
-                       ( ( $wgUser->getOption( 'previewonfirst' ) && $this->mTitle->exists() ) ||
-                               ( $this->mTitle->getNamespace() == NS_CATEGORY &&
-                                       !$this->mTitle->exists() ) );
+       private function previewOnOpen() {
+               global $wgRequest, $wgUser;
+               if( $wgRequest->getVal( 'preview' ) == 'yes' ) {
+                       // Explicit override from request
+                       return true;
+               } elseif( $wgRequest->getVal( 'preview' ) == 'no' ) {
+                       // Explicit override from request
+                       return false;
+               } elseif( $this->section == 'new' ) {
+                       // Nothing *to* preview for new sections
+                       return false;
+               } elseif( ( $wgRequest->getVal( 'preload' ) !== '' || $this->mTitle->exists() ) && $wgUser->getOption( 'previewonfirst' ) ) {
+                       // Standard preference behaviour
+                       return true;
+               } elseif( !$this->mTitle->exists() && $this->mTitle->getNamespace() == NS_CATEGORY ) {
+                       // Categories are special
+                       return true;
+               } else {
+                       return false;
+               }
        }
 
        /**
@@ -473,6 +530,9 @@ class EditPage {
                $fname = 'EditPage::importFormData';
                wfProfileIn( $fname );
 
+               # Section edit can come from either the form or a link
+               $this->section = $request->getVal( 'wpSection', $request->getVal( 'section' ) );
+
                if( $request->wasPosted() ) {
                        # These fields need to be checked for encoding.
                        # Also remove trailing whitespace, but don't remove _initial_
@@ -549,19 +609,21 @@ class EditPage {
                        $this->summary   = '';
                        $this->edittime  = '';
                        $this->starttime = wfTimestampNow();
+                       $this->edit      = false;
                        $this->preview   = false;
                        $this->save      = false;
-                       $this->diff      = false;
+                       $this->diff      = false;
                        $this->minoredit = false;
                        $this->watchthis = false;
                        $this->recreate  = false;
+
+                       if ( $this->section == 'new' && $request->getVal( 'preloadtitle' ) ) {
+                               $this->summary = $request->getVal( 'preloadtitle' );
+                       }
                }
 
                $this->oldid = $request->getInt( 'oldid' );
 
-               # Section edit can come from either the form or a link
-               $this->section = $request->getVal( 'wpSection', $request->getVal( 'section' ) );
-
                $this->live = $request->getCheck( 'live' );
                $this->editintro = $request->getText( 'editintro' );
 
@@ -588,16 +650,32 @@ class EditPage {
         */
        private function showIntro() {
                global $wgOut, $wgUser;
+               if( $this->suppressIntro )
+                       return;
+
+               # Show a warning message when someone creates/edits a user (talk) page but the user does not exists
+               if( $this->mTitle->getNamespace() == NS_USER || $this->mTitle->getNamespace() == NS_USER_TALK ) {
+                       $parts = explode( '/', $this->mTitle->getText(), 2 );
+                       $username = $parts[0];
+                       $id = User::idFromName( $username );
+                       $ip = User::isIP( $username );
+
+                       if ( $id == 0 && !$ip ) {
+                               $wgOut->wrapWikiMsg( '<div class="mw-userpage-userdoesnotexist error">$1</div>', 
+                                       array( 'userpage-userdoesnotexist', $username ) );
+                       }
+               }
+
                if( !$this->showCustomIntro() && !$this->mTitle->exists() ) {
                        if( $wgUser->isLoggedIn() ) {
-                               $wgOut->addWikiText( wfMsg( 'newarticletext' ) );
+                               $wgOut->wrapWikiMsg( '<div class="mw-newarticletext">$1</div>', 'newarticletext' );
                        } else {
-                               $wgOut->addWikiText( wfMsg( 'newarticletextanon' ) );
+                               $wgOut->wrapWikiMsg( '<div class="mw-newarticletextanon">$1</div>', 'newarticletextanon' );
                        }
                        $this->showDeletionLog( $wgOut );
                }
        }
-       
+
        /**
         * Attempt to show a custom editing introduction, if supplied
         *
@@ -620,11 +698,11 @@ class EditPage {
        }
 
        /**
-        * Attempt submission
-        * @return bool false if output is done, true if the rest of the form should be displayed
+        * Attempt submission (no UI)
+        * @return one of the constants describing the result
         */
-       function attemptSave() {
-               global $wgSpamRegex, $wgFilterCallback, $wgUser, $wgOut;
+       function internalAttemptSave( &$result, $bot = false ) {
+               global $wgSpamRegex, $wgFilterCallback, $wgUser, $wgOut, $wgParser;
                global $wgMaxArticleSize;
 
                $fname = 'EditPage::attemptSave';
@@ -634,7 +712,18 @@ class EditPage {
                if( !wfRunHooks( 'EditPage::attemptSave', array( &$this ) ) )
                {
                        wfDebug( "Hook 'EditPage::attemptSave' aborted article saving" );
-                       return false;
+                       return self::AS_HOOK_ERROR;
+               }
+
+               # Check image redirect
+               if ( $this->mTitle->getNamespace() == NS_IMAGE &&
+                       Title::newFromRedirect( $this->textbox1 ) instanceof Title &&
+                       !$wgUser->isAllowed( 'upload' ) ) {
+                               if( $wgUser->isAnon() ) {
+                                       return self::AS_IMAGE_REDIRECT_ANON;
+                               } else {
+                                       return self::AS_IMAGE_REDIRECT_LOGGED;
+                               }
                }
 
                # Reintegrate metadata
@@ -644,34 +733,33 @@ class EditPage {
                # Check for spam
                $matches = array();
                if ( $wgSpamRegex && preg_match( $wgSpamRegex, $this->textbox1, $matches ) ) {
-                       $this->spamPage ( $matches[0] );
+                       $result['spam'] = $matches[0];
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return false;
+                       return self::AS_SPAM_ERROR;
                }
                if ( $wgFilterCallback && $wgFilterCallback( $this->mTitle, $this->textbox1, $this->section ) ) {
                        # Error messages or other handling should be performed by the filter function
-                       wfProfileOut( $fname );
                        wfProfileOut( "$fname-checks" );
-                       return false;
+                       wfProfileOut( $fname );
+                       return self::AS_FILTERING;
                }
                if ( !wfRunHooks( 'EditFilter', array( $this, $this->textbox1, $this->section, &$this->hookError ) ) ) {
                        # Error messages etc. could be handled within the hook...
-                       wfProfileOut( $fname );
                        wfProfileOut( "$fname-checks" );
-                       return false;
+                       wfProfileOut( $fname );
+                       return self::AS_HOOK_ERROR;
                } elseif( $this->hookError != '' ) {
                        # ...or the hook could be expecting us to produce an error
-                       wfProfileOut( "$fname-checks " );
+                       wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return true;
+                       return self::AS_HOOK_ERROR_EXPECTED;
                }
                if ( $wgUser->isBlockedFrom( $this->mTitle, false ) ) {
                        # Check block state against master, thus 'false'.
-                       $this->blockedPage();
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return false;
+                       return self::AS_BLOCKED_PAGE_FOR_USER;
                }
                $this->kblength = (int)(strlen( $this->textbox1 ) / 1024);
                if ( $this->kblength > $wgMaxArticleSize ) {
@@ -679,43 +767,39 @@ class EditPage {
                        $this->tooBig = true;
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return true;
+                       return self::AS_CONTENT_TOO_BIG;
                }
 
                if ( !$wgUser->isAllowed('edit') ) {
                        if ( $wgUser->isAnon() ) {
-                               $this->userNotLoggedInPage();
                                wfProfileOut( "$fname-checks" );
                                wfProfileOut( $fname );
-                               return false;
+                               return self::AS_READ_ONLY_PAGE_ANON;
                        }
                        else {
-                               $wgOut->readOnlyPage();
                                wfProfileOut( "$fname-checks" );
                                wfProfileOut( $fname );
-                               return false;
+                               return self::AS_READ_ONLY_PAGE_LOGGED;
                        }
                }
 
                if ( wfReadOnly() ) {
-                       $wgOut->readOnlyPage();
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return false;
+                       return self::AS_READ_ONLY_PAGE;
                }
                if ( $wgUser->pingLimiter() ) {
-                       $wgOut->rateLimited();
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return false;
+                       return self::AS_RATE_LIMITED;
                }
 
                # If the article has been deleted while editing, don't save it without
                # confirmation
-               if ( $this->deletedSinceEdit && !$this->recreate ) {
+               if ( $this->wasDeletedSinceLastEdit() && !$this->recreate ) {
                        wfProfileOut( "$fname-checks" );
                        wfProfileOut( $fname );
-                       return true;
+                       return self::AS_ARTICLE_WAS_DELETED;
                }
 
                wfProfileOut( "$fname-checks" );
@@ -727,24 +811,30 @@ class EditPage {
                        // Late check for create permission, just in case *PARANOIA*
                        if ( !$this->mTitle->userCan( 'create' ) ) {
                                wfDebug( "$fname: no create permission\n" );
-                               $this->noCreatePermission();
                                wfProfileOut( $fname );
-                               return;
+                               return self::AS_NO_CREATE_PERMISSION;
                        }
 
                        # Don't save a new article if it's blank.
-                       if ( ( '' == $this->textbox1 ) ) {
-                                       $wgOut->redirect( $this->mTitle->getFullURL() );
+                       if ( '' == $this->textbox1 ) {
                                        wfProfileOut( $fname );
-                                       return false;
+                                       return self::AS_BLANK_ARTICLE;
                        }
 
-                       $isComment=($this->section=='new');
+                       // Run post-section-merge edit filter
+                       if ( !wfRunHooks( 'EditFilterMerged', array( $this, $this->textbox1, &$this->hookError ) ) ) {
+                               # Error messages etc. could be handled within the hook...
+                               wfProfileOut( $fname );
+                               return self::AS_HOOK_ERROR;
+                       }
+
+                       $isComment = ( $this->section == 'new' );
+                       
                        $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
-                               $this->minoredit, $this->watchthis, false, $isComment);
+                               $this->minoredit, $this->watchthis, false, $isComment, $bot);
 
                        wfProfileOut( $fname );
-                       return false;
+                       return self::AS_SUCCESS_NEW_ARTICLE;
                }
 
                # Article exists. Check for edit conflict.
@@ -774,7 +864,7 @@ class EditPage {
 
                if ( $this->isConflict) {
                        wfDebug( "EditPage::editForm conflict! getting section '$this->section' for time '$this->edittime' (article time '" .
-                               $this->mArticle->getTimestamp() . "'\n" );
+                               $this->mArticle->getTimestamp() . "')\n" );
                        $text = $this->mArticle->replaceSection( $this->section, $this->textbox1, $this->summary, $this->edittime);
                }
                else {
@@ -789,7 +879,7 @@ class EditPage {
 
                # Suppress edit conflict with self, except for section edits where merging is required.
                if ( ( $this->section == '' ) && ( 0 != $userid ) && ( $this->mArticle->getUser() == $userid ) ) {
-                       wfDebug( "Suppressing edit conflict, same user.\n" );
+                       wfDebug( "EditPage::editForm Suppressing edit conflict, same user.\n" );
                        $this->isConflict = false;
                } else {
                        # switch from section editing to normal editing in edit conflict
@@ -798,29 +888,36 @@ class EditPage {
                                if( $this->mergeChangesInto( $text ) ){
                                        // Successful merge! Maybe we should tell the user the good news?
                                        $this->isConflict = false;
-                                       wfDebug( "Suppressing edit conflict, successful merge.\n" );
+                                       wfDebug( "EditPage::editForm Suppressing edit conflict, successful merge.\n" );
                                } else {
                                        $this->section = '';
                                        $this->textbox1 = $text;
-                                       wfDebug( "Keeping edit conflict, failed merge.\n" );
+                                       wfDebug( "EditPage::editForm Keeping edit conflict, failed merge.\n" );
                                }
                        }
                }
 
                if ( $this->isConflict ) {
                        wfProfileOut( $fname );
-                       return true;
+                       return self::AS_CONFLICT_DETECTED;
                }
 
                $oldtext = $this->mArticle->getContent();
 
+               // Run post-section-merge edit filter
+               if ( !wfRunHooks( 'EditFilterMerged', array( $this, $text, &$this->hookError ) ) ) {
+                       # Error messages etc. could be handled within the hook...
+                       wfProfileOut( $fname );
+                       return self::AS_HOOK_ERROR;
+               }
+
                # Handle the user preference to force summaries here, but not for null edits
                if( $this->section != 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary')
                        &&  0 != strcmp($oldtext, $text) && !Article::getRedirectAutosummary( $text )) {
                        if( md5( $this->summary ) == $this->autoSumm ) {
                                $this->missingSummary = true;
                                wfProfileOut( $fname );
-                               return( true );
+                               return self::AS_SUMMARY_NEEDED;
                        }
                }
 
@@ -829,7 +926,7 @@ class EditPage {
                        if (trim($this->summary) == '') {
                                $this->missingSummary = true;
                                wfProfileOut( $fname );
-                               return( true );
+                               return self::AS_SUMMARY_NEEDED;
                        }
                }
 
@@ -839,10 +936,14 @@ class EditPage {
                if( $this->section == 'new' ) {
                        if ( $this->textbox1 == '' ) {
                                $this->missingComment = true;
-                               return true;
+                               return self::AS_TEXTBOX_EMPTY;
                        }
                        if( $this->summary != '' ) {
-                               $sectionanchor = $this->sectionAnchor( $this->summary );
+                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $this->summary );
+                               # This is a new section, so create a link to the new section
+                               # in the revision summary.
+                               $cleanSummary = $wgParser->stripSectionName( $this->summary );
+                               $this->summary = wfMsgForContent( 'newsectionsummary', $cleanSummary );
                        }
                } elseif( $this->section != '' ) {
                        # Try to get a section anchor from the section source, redirect to edited section if header found
@@ -852,7 +953,7 @@ class EditPage {
                        # we can't deal with anchors, includes, html etc in the header for now,
                        # headline would need to be parsed to improve this
                        if($hasmatch and strlen($matches[2]) > 0) {
-                               $sectionanchor = $this->sectionAnchor( $matches[2] );
+                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $matches[2] );
                        }
                }
                wfProfileOut( "$fname-sectionanchor" );
@@ -869,19 +970,19 @@ class EditPage {
                if ( $this->kblength > $wgMaxArticleSize ) {
                        $this->tooBig = true;
                        wfProfileOut( $fname );
-                       return true;
+                       return self::AS_MAX_ARTICLE_SIZE_EXCEEDED;
                }
 
                # update the article here
                if( $this->mArticle->updateArticle( $text, $this->summary, $this->minoredit,
-                       $this->watchthis, '', $sectionanchor ) ) {
+                       $this->watchthis, $bot, $sectionanchor ) ) {
                        wfProfileOut( $fname );
-                       return false;
+                       return self::AS_SUCCESS_UPDATE;
                } else {
                        $this->isConflict = true;
                }
                wfProfileOut( $fname );
-               return true;
+               return self::AS_END;
        }
 
        /**
@@ -890,12 +991,11 @@ class EditPage {
         */
        function initialiseForm() {
                $this->edittime = $this->mArticle->getTimestamp();
-               $this->summary = '';
                $this->textbox1 = $this->getContent(false);
                if ($this->textbox1 === false) return false;
 
-               if ( !$this->mArticle->exists() && $this->mArticle->mTitle->getNamespace() == NS_MEDIAWIKI )
-                       $this->textbox1 = wfMsgWeirdKey( $this->mArticle->mTitle->getText() );
+               if ( !$this->mArticle->exists() && $this->mTitle->getNamespace() == NS_MEDIAWIKI )
+                       $this->textbox1 = wfMsgWeirdKey( $this->mTitle->getText() );
                wfProxyCheck();
                return true;
        }
@@ -907,7 +1007,14 @@ class EditPage {
         *                      near the top, for captchas and the like.
         */
        function showEditForm( $formCallback=null ) {
-               global $wgOut, $wgUser, $wgLang, $wgContLang, $wgMaxArticleSize;
+               global $wgOut, $wgUser, $wgLang, $wgContLang, $wgMaxArticleSize, $wgTitle;
+               
+               # If $wgTitle is null, that means we're in API mode.
+               # Some hook probably called this function  without checking
+               # for is_null($wgTitle) first. Bail out right here so we don't
+               # do lots of work just to discard it right after.
+               if(is_null($wgTitle))
+                       return;
 
                $fname = 'EditPage::showEditForm';
                wfProfileIn( $fname );
@@ -921,116 +1028,128 @@ class EditPage {
                # Enabled article-related sidebar, toplinks, etc.
                $wgOut->setArticleRelated( true );
 
+               if ( $this->formtype == 'preview' ) {
+                       $wgOut->setPageTitleActionText( wfMsg( 'preview' ) );
+               }
+
                if ( $this->isConflict ) {
-                       $s = wfMsg( 'editconflict', $this->mTitle->getPrefixedText() );
+                       $s = wfMsg( 'editconflict', $wgTitle->getPrefixedText() );
                        $wgOut->setPageTitle( $s );
-                       $wgOut->addWikiText( wfMsg( 'explainconflict' ) );
+                       $wgOut->addWikiMsg( 'explainconflict' );
 
                        $this->textbox2 = $this->textbox1;
                        $this->textbox1 = $this->getContent();
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
-
                        if( $this->section != '' ) {
                                if( $this->section == 'new' ) {
-                                       $s = wfMsg('editingcomment', $this->mTitle->getPrefixedText() );
+                                       $s = wfMsg('editingcomment', $wgTitle->getPrefixedText() );
                                } else {
-                                       $s = wfMsg('editingsection', $this->mTitle->getPrefixedText() );
+                                       $s = wfMsg('editingsection', $wgTitle->getPrefixedText() );
                                        $matches = array();
                                        if( !$this->summary && !$this->preview && !$this->diff ) {
                                                preg_match( "/^(=+)(.+)\\1/mi",
                                                        $this->textbox1,
                                                        $matches );
                                                if( !empty( $matches[2] ) ) {
-                                                       $this->summary = "/* ". trim($matches[2])." */ ";
+                                                       global $wgParser;
+                                                       $this->summary = "/* " . 
+                                                               $wgParser->stripSectionName(trim($matches[2])) . 
+                                                               " */ ";
                                                }
                                        }
                                }
                        } else {
-                               $s = wfMsg( 'editing', $this->mTitle->getPrefixedText() );
+                               $s = wfMsg( 'editing', $wgTitle->getPrefixedText() );
                        }
                        $wgOut->setPageTitle( $s );
 
                        if ( $this->missingComment ) {
-                               $wgOut->addWikiText( wfMsg( 'missingcommenttext' ) );
+                               $wgOut->wrapWikiMsg( '<div id="mw-missingcommenttext">$1</div>',  'missingcommenttext' );
                        }
 
                        if( $this->missingSummary && $this->section != 'new' ) {
-                               $wgOut->addWikiText( wfMsg( 'missingsummary' ) );
+                               $wgOut->wrapWikiMsg( '<div id="mw-missingsummary">$1</div>', 'missingsummary' );
                        }
 
                        if( $this->missingSummary && $this->section == 'new' ) {
-                               $wgOut->addWikiText( wfMsg( 'missingcommentheader' ) );
+                               $wgOut->wrapWikiMsg( '<div id="mw-missingcommentheader">$1</div>', 'missingcommentheader' );
                        }
 
-                       if( !$this->hookError == '' ) {
+                       if( $this->hookError !== '' ) {
                                $wgOut->addWikiText( $this->hookError );
                        }
 
                        if ( !$this->checkUnicodeCompliantBrowser() ) {
-                               $wgOut->addWikiText( wfMsg( 'nonunicodebrowser') );
+                               $wgOut->addWikiMsg( 'nonunicodebrowser' );
                        }
                        if ( isset( $this->mArticle ) && isset( $this->mArticle->mRevision ) ) {
                        // Let sysop know that this will make private content public if saved
-                               if( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->addWikiText( wfMsg( 'rev-deleted-text-view' ) );
+                               
+                               if( !$this->mArticle->mRevision->userCan( Revision::DELETED_TEXT ) ) {
+                                       $wgOut->addWikiMsg( 'rev-deleted-text-permission' );
+                               } else if( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
+                                       $wgOut->addWikiMsg( 'rev-deleted-text-view' );
                                }
+                               
                                if( !$this->mArticle->mRevision->isCurrent() ) {
                                        $this->mArticle->setOldSubtitle( $this->mArticle->mRevision->getId() );
-                                       $wgOut->addWikiText( wfMsg( 'editingold' ) );
+                                       $wgOut->addWikiMsg( 'editingold' );
                                }
                        }
                }
 
                if( wfReadOnly() ) {
-                       $wgOut->addWikiText( wfMsg( 'readonlywarning' ) );
+                       $wgOut->addHTML( '<div id="mw-read-only-warning">'.wfMsgWikiHTML( 'readonlywarning' ).'</div>' );
                } elseif( $wgUser->isAnon() && $this->formtype != 'preview' ) {
-                       $wgOut->addWikiText( wfMsg( 'anoneditwarning' ) );
+                       $wgOut->addHTML( '<div id="mw-anon-edit-warning">'.wfMsgWikiHTML( 'anoneditwarning' ).'</div>' );
                } else {
                        if( $this->isCssJsSubpage && $this->formtype != 'preview' ) {
                                # Check the skin exists
                                if( $this->isValidCssJsSubpage ) {
-                                       $wgOut->addWikiText( wfMsg( 'usercssjsyoucanpreview' ) );
+                                       $wgOut->addWikiMsg( 'usercssjsyoucanpreview' );
                                } else {
-                                       $wgOut->addWikiText( wfMsg( 'userinvalidcssjstitle', $this->mTitle->getSkinFromCssJsSubpage() ) );
+                                       $wgOut->addWikiMsg( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() );
                                }
                        }
                }
 
                if( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
                        # Show a warning if editing an interface message
-                       $wgOut->addWikiText( wfMsg( 'editinginterface' ) );
+                       $wgOut->addWikiMsg( 'editinginterface' );
                } elseif( $this->mTitle->isProtected( 'edit' ) ) {
                        # Is the title semi-protected?
                        if( $this->mTitle->isSemiProtected() ) {
-                               $notice = wfMsg( 'semiprotectedpagewarning' );
-                               if( wfEmptyMsg( 'semiprotectedpagewarning', $notice ) || $notice == '-' )
-                                       $notice = '';
+                               $noticeMsg = 'semiprotectedpagewarning';
                        } else {
-                       # Then it must be protected based on static groups (regular)
-                               $notice = wfMsg( 'protectedpagewarning' );
+                               # Then it must be protected based on static groups (regular)
+                               $noticeMsg = 'protectedpagewarning';
                        }
-                       $wgOut->addWikiText( $notice );
+                       $wgOut->addWikiMsg( $noticeMsg );
                }
                if ( $this->mTitle->isCascadeProtected() ) {
                        # Is this page under cascading protection from some source pages?
                        list($cascadeSources, /* $restrictions */) = $this->mTitle->getCascadeProtectionSources();
+                       $notice = "$1\n";
                        if ( count($cascadeSources) > 0 ) {
                                # Explain, and list the titles responsible
-                               $notice = wfMsgExt( 'cascadeprotectedwarning', array('parsemag'), count($cascadeSources) ) . "\n";
-                               foreach( $cascadeSources as $id => $page )
+                               foreach( $cascadeSources as $page ) {
                                        $notice .= '* [[:' . $page->getPrefixedText() . "]]\n";
                                }
-                       $wgOut->addWikiText( $notice );
+                       }
+                       $wgOut->wrapWikiMsg( $notice, array( 'cascadeprotectedwarning', count($cascadeSources) ) );
+               }
+               if( !$this->mTitle->exists() && $this->mTitle->getRestrictions( 'create' ) != array() ){
+                       $wgOut->addWikiMsg( 'titleprotectedwarning' );
                }
 
                if ( $this->kblength === false ) {
                        $this->kblength = (int)(strlen( $this->textbox1 ) / 1024);
                }
                if ( $this->tooBig || $this->kblength > $wgMaxArticleSize ) {
-                       $wgOut->addWikiText( wfMsg( 'longpageerror', $wgLang->formatNum( $this->kblength ), $wgMaxArticleSize ) );
+                       $wgOut->addWikiMsg( 'longpageerror', $wgLang->formatNum( $this->kblength ), $wgMaxArticleSize );
                } elseif( $this->kblength > 29 ) {
-                       $wgOut->addWikiText( wfMsg( 'longpagewarning', $wgLang->formatNum( $this->kblength ) ) );
+                       $wgOut->addWikiMsg( 'longpagewarning', $wgLang->formatNum( $this->kblength ) );
                }
 
                #need to parse the preview early so that we know which templates are used,
@@ -1048,12 +1167,12 @@ class EditPage {
 
                $q = 'action=submit';
                #if ( "no" == $redirect ) { $q .= "&redirect=no"; }
-               $action = $this->mTitle->escapeLocalURL( $q );
+               $action = $wgTitle->escapeLocalURL( $q );
 
                $summary = wfMsg('summary');
                $subject = wfMsg('subject');
 
-               $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
+               $cancel = $sk->makeKnownLink( $wgTitle->getPrefixedText(),
                                wfMsgExt('cancel', array('parseinline')) );
                $edithelpurl = Skin::makeInternalOrExternalUrl( wfMsgForContent( 'edithelppage' ));
                $edithelp = '<a target="helpwindow" href="'.$edithelpurl.'">'.
@@ -1061,10 +1180,14 @@ class EditPage {
                        htmlspecialchars( wfMsg( 'newwindow' ) );
 
                global $wgRightsText;
-               $copywarn = "<div id=\"editpage-copywarn\">\n" .
-                       wfMsg( $wgRightsText ? 'copyrightwarning' : 'copyrightwarning2',
+               if ( $wgRightsText ) {
+                       $copywarnMsg = array( 'copyrightwarning', 
                                '[[' . wfMsgForContent( 'copyrightpage' ) . ']]',
-                               $wgRightsText ) . "\n</div>";
+                               $wgRightsText );
+               } else {
+                       $copywarnMsg = array( 'copyrightwarning2', 
+                               '[[' . wfMsgForContent( 'copyrightpage' ) . ']]' );
+               }
 
                if( $wgUser->getOption('showtoolbar') and !$this->isCssJsSubpage ) {
                        # prepare toolbar for edit buttons
@@ -1111,14 +1234,26 @@ class EditPage {
                # if this is a comment, show a subject line at the top, which is also the edit summary.
                # Otherwise, show a summary field at the bottom
                $summarytext = htmlspecialchars( $wgContLang->recodeForEdit( $this->summary ) ); # FIXME
+               
+               # If a blank edit summary was previously provided, and the appropriate
+               # user preference is active, pass a hidden tag as wpIgnoreBlankSummary. This will stop the
+               # user being bounced back more than once in the event that a summary
+               # is not required.
+               #####
+               # For a bit more sophisticated detection of blank summaries, hash the
+               # automatic one and pass that in the hidden field wpAutoSummary.
+               $summaryhiddens =  '';
+               if( $this->missingSummary ) $summaryhiddens .= wfHidden( 'wpIgnoreBlankSummary', true );
+               $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
+               $summaryhiddens .= wfHidden( 'wpAutoSummary', $autosumm );
                if( $this->section == 'new' ) {
-                       $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<div class='editOptions'>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
+                       $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<div class='editOptions'>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
                        $editsummary = '';
                        $subjectpreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('subject-preview').':'.$sk->commentBlock( $this->summary, $this->mTitle )."</div>\n" : '';
                        $summarypreview = '';
                } else {
                        $commentsubject = '';
-                       $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<div class='editOptions'>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
+                       $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<div class='editOptions'>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
                        $summarypreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('summary-preview').':'.$sk->commentBlock( $this->summary, $this->mTitle )."</div>\n" : '';
                        $subjectpreview = '';
                }
@@ -1130,6 +1265,9 @@ class EditPage {
                $templates = ($this->preview || $this->section != '') ? $this->mPreviewTemplates : $this->mArticle->getUsedTemplates();
                $formattedtemplates = $sk->formatTemplates( $templates, $this->preview, $this->section != '');
 
+               $hiddencats = $this->mArticle->getHiddenCategories();
+               $formattedhiddencats = $sk->formatHiddenCategories( $hiddencats );
+
                global $wgUseMetadataEdit ;
                if ( $wgUseMetadataEdit ) {
                        $metadata = $this->mMetaData ;
@@ -1141,9 +1279,9 @@ class EditPage {
 
                $hidden = '';
                $recreate = '';
-               if ($this->deletedSinceEdit) {
+               if ($this->wasDeletedSinceLastEdit()) {
                        if ( 'save' != $this->formtype ) {
-                               $wgOut->addWikiText( wfMsg('deletedwhileediting'));
+                               $wgOut->addWikiMsg('deletedwhileediting');
                        } else {
                                // Hide the toolbar and edit area, use can click preview to get it back
                                // Add an confirmation checkbox and explanation.
@@ -1192,6 +1330,7 @@ END
 $recreate
 {$commentsubject}
 {$subjectpreview}
+{$this->editFormTextBeforeContent}
 <textarea tabindex='1' accesskey="," name="wpTextbox1" id="wpTextbox1" rows='{$rows}'
 cols='{$cols}'{$ew} $hidden>
 END
@@ -1200,7 +1339,7 @@ END
 </textarea>
                " );
 
-               $wgOut->addWikiText( $copywarn );
+               $wgOut->wrapWikiMsg( "<div id=\"editpage-copywarn\">\n$1\n</div>", $copywarnMsg );
                $wgOut->addHTML( $this->editFormTextAfterWarn );
                $wgOut->addHTML( "
 {$metadata}
@@ -1217,18 +1356,6 @@ END
 </div><!-- editButtons -->
 </div><!-- editOptions -->");
 
-               $wgOut->addHtml( '<div class="mw-editTools">' );
-               $wgOut->addWikiText( wfMsgForContent( 'edittools' ) );
-               $wgOut->addHtml( '</div>' );
-
-               $wgOut->addHTML( $this->editFormTextAfterTools );
-
-               $wgOut->addHTML( "
-<div class='templatesUsed'>
-{$formattedtemplates}
-</div>
-" );
-
                /**
                 * To make it harder for someone to slip a user a page
                 * which submits an edit form to the wiki without their
@@ -1244,29 +1371,30 @@ END
                $token = htmlspecialchars( $wgUser->editToken() );
                $wgOut->addHTML( "\n<input type='hidden' value=\"$token\" name=\"wpEditToken\" />\n" );
 
+               $wgOut->addHtml( '<div class="mw-editTools">' );
+               $wgOut->addWikiMsgArray( 'edittools', array(), array( 'content' ) );
+               $wgOut->addHtml( '</div>' );
 
-               # If a blank edit summary was previously provided, and the appropriate
-               # user preference is active, pass a hidden tag here. This will stop the
-               # user being bounced back more than once in the event that a summary
-               # is not required.
-               if( $this->missingSummary ) {
-                       $wgOut->addHTML( "<input type=\"hidden\" name=\"wpIgnoreBlankSummary\" value=\"1\" />\n" );
-               }
+               $wgOut->addHTML( $this->editFormTextAfterTools );
 
-               # For a bit more sophisticated detection of blank summaries, hash the
-               # automatic one and pass that in a hidden field.
-               $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
-               $wgOut->addHtml( wfHidden( 'wpAutoSummary', $autosumm ) );
+               $wgOut->addHTML( "
+<div class='templatesUsed'>
+{$formattedtemplates}
+</div>
+<div class='hiddencats'>
+{$formattedhiddencats}
+</div>
+");
 
                if ( $this->isConflict ) {
-                       $wgOut->addWikiText( '==' . wfMsg( "yourdiff" ) . '==' );
+                       $wgOut->wrapWikiMsg( '==$1==', "yourdiff" );
 
                        $de = new DifferenceEngine( $this->mTitle );
                        $de->setText( $this->textbox2, $this->textbox1 );
                        $de->showDiff( wfMsg( "yourtext" ), wfMsg( "storedversion" ) );
 
-                       $wgOut->addWikiText( '==' . wfMsg( "yourtext" ) . '==' );
-                       $wgOut->addHTML( "<textarea tabindex=6 id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}' wrap='virtual'>"
+                       $wgOut->wrapWikiMsg( '==$1==', "yourtext" );
+                       $wgOut->addHTML( "<textarea tabindex='6' id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}'>"
                                . htmlspecialchars( $this->safeUnicodeOutput( $this->textbox2 ) ) . "\n</textarea>" );
                }
                $wgOut->addHTML( $this->editFormTextBottom );
@@ -1301,6 +1429,7 @@ END
                if($this->mTitle->getNamespace() == NS_CATEGORY) {
                        $this->mArticle->openShowCategory();
                }
+               wfRunHooks( 'OutputPageBeforeHTML',array( &$wgOut, &$text ) );
                $wgOut->addHTML( $text );
                if($this->mTitle->getNamespace() == NS_CATEGORY) {
                        $this->mArticle->closeShowCategory();
@@ -1324,8 +1453,7 @@ END
                        htmlspecialchars( "$wgStylePath/common/preview.js?$wgStyleVersion" ) .
                        '"></script>' . "\n" );
                $liveAction = $wgTitle->getLocalUrl( 'action=submit&wpPreview=true&live=true' );
-               return "return !livePreview(" .
-                       "getElementById('wikiPreview')," .
+               return "return !lpDoPreview(" .
                        "editform.wpTextbox1.value," .
                        '"' . $liveAction . '"' . ")";
        }
@@ -1366,24 +1494,19 @@ END
         * @todo document
         */
        function getPreviewText() {
-               global $wgOut, $wgUser, $wgTitle, $wgParser;
+               global $wgOut, $wgUser, $wgTitle, $wgParser, $wgLang, $wgContLang;
 
                $fname = 'EditPage::getPreviewText';
                wfProfileIn( $fname );
 
                if ( $this->mTriedSave && !$this->mTokenOk ) {
                        if ( $this->mTokenOkExceptSuffix ) {
-                               $msg = 'token_suffix_mismatch';
+                               $note = wfMsg( 'token_suffix_mismatch' );
                        } else {
-                               $msg = 'session_fail_preview';
+                               $note = wfMsg( 'session_fail_preview' );
                        }
                } else {
-                       $msg = 'previewnote';
-               }
-               $previewhead = '<h2>' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>\n" .
-                       "<div class='previewnote'>" . $wgOut->parse( wfMsg( $msg ) ) . "</div>\n";
-               if ( $this->isConflict ) {
-                       $previewhead.='<h2>' . htmlspecialchars( wfMsg( 'previewconflict' ) ) . "</h2>\n";
+                       $note = wfMsg( 'previewnote' );
                }
 
                $parserOptions = ParserOptions::newFromUser( $wgUser );
@@ -1401,16 +1524,15 @@ END
                # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here
 
                if ( $this->isCssJsSubpage ) {
-                       if(preg_match("/\\.css$/", $wgTitle->getText() ) ) {
+                       if(preg_match("/\\.css$/", $this->mTitle->getText() ) ) {
                                $previewtext = wfMsg('usercsspreview');
-                       } else if(preg_match("/\\.js$/", $wgTitle->getText() ) ) {
+                       } else if(preg_match("/\\.js$/", $this->mTitle->getText() ) ) {
                                $previewtext = wfMsg('userjspreview');
                        }
                        $parserOptions->setTidy(true);
-                       $parserOutput = $wgParser->parse( $previewtext , $wgTitle, $parserOptions );
+                       $parserOutput = $wgParser->parse( $previewtext , $this->mTitle, $parserOptions );
                        $wgOut->addHTML( $parserOutput->mText );
-                       wfProfileOut( $fname );
-                       return $previewhead;
+                       $previewHTML = '';
                } else {
                        $toparse = $this->textbox1;
 
@@ -1420,24 +1542,59 @@ END
                                $toparse="== {$this->summary} ==\n\n".$toparse;
                        }
 
-                       if ( $this->mMetaData != "" ) $toparse .= "\n" . $this->mMetaData ;
+                       if ( $this->mMetaData != "" ) $toparse .= "\n" . $this->mMetaData;
+
+                       // Parse mediawiki messages with correct target language
+                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               $pos = strrpos( $this->mTitle->getText(), '/' );
+                               if ( $pos !== false ) {
+                                       $code = substr( $this->mTitle->getText(), $pos+1 );
+                                       switch ($code) {
+                                               case $wgLang->getCode():
+                                                       $obj = $wgLang; break;
+                                               case $wgContLang->getCode():
+                                                       $obj = $wgContLang; break;
+                                               default:
+                                                       $obj = Language::factory( $code );
+                                       }
+                                       $parserOptions->setTargetLanguage( $obj );
+                               }
+                       }
+
+
                        $parserOptions->setTidy(true);
+                       $parserOptions->enableLimitReport();
                        $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $toparse ) ."\n\n",
-                                       $wgTitle, $parserOptions );
+                                       $this->mTitle, $parserOptions );
 
                        $previewHTML = $parserOutput->getText();
                        $wgOut->addParserOutputNoText( $parserOutput );
                        
                        # ParserOutput might have altered the page title, so reset it
-                       $wgOut->setPageTitle( wfMsg( 'editing', $this->mTitle->getPrefixedText() ) );                   
+                       # Also, use the title defined by DISPLAYTITLE magic word when present
+                       if( ( $dt = $parserOutput->getDisplayTitle() ) !== false ) {
+                               $wgOut->setPageTitle( wfMsg( 'editing', $dt ) );
+                       } else {
+                               $wgOut->setPageTitle( wfMsg( 'editing', $wgTitle->getPrefixedText() ) );                        
+                       }
 
                        foreach ( $parserOutput->getTemplates() as $ns => $template)
                                foreach ( array_keys( $template ) as $dbk)
                                        $this->mPreviewTemplates[] = Title::makeTitle($ns, $dbk);
 
-                       wfProfileOut( $fname );
-                       return $previewhead . $previewHTML;
+                       if ( count( $parserOutput->getWarnings() ) ) {
+                               $note .= "\n\n" . implode( "\n\n", $parserOutput->getWarnings() );
+                       }
+               }
+
+               $previewhead = '<h2>' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>\n" .
+                       "<div class='previewnote'>" . $wgOut->parse( $note ) . "</div>\n";
+               if ( $this->isConflict ) {
+                       $previewhead.='<h2>' . htmlspecialchars( wfMsg( 'previewconflict' ) ) . "</h2>\n";
                }
+
+               wfProfileOut( $fname );
+               return $previewhead . $previewHTML;
        }
 
        /**
@@ -1462,7 +1619,7 @@ END
                        $cols = $wgUser->getOption( 'cols' );
                        $attribs = array( 'id' => 'wpTextbox1', 'name' => 'wpTextbox1', 'cols' => $cols, 'rows' => $rows, 'readonly' => 'readonly' );
                        $wgOut->addHtml( '<hr />' );
-                       $wgOut->addWikiText( wfMsg( $first ? 'blockedoriginalsource' : 'blockededitsource', $this->mTitle->getPrefixedText() ) );
+                       $wgOut->addWikiMsg( $first ? 'blockedoriginalsource' : 'blockededitsource', $this->mTitle->getPrefixedText() );
                        $wgOut->addHtml( wfOpenElement( 'textarea', $attribs ) . htmlspecialchars( $source ) . wfCloseElement( 'textarea' ) );
                }
        }
@@ -1471,34 +1628,18 @@ END
         * Produce the stock "please login to edit pages" page
         */
        function userNotLoggedInPage() {
-               global $wgUser, $wgOut;
+               global $wgUser, $wgOut, $wgTitle;
                $skin = $wgUser->getSkin();
 
                $loginTitle = SpecialPage::getTitleFor( 'Userlogin' );
-               $loginLink = $skin->makeKnownLinkObj( $loginTitle, wfMsgHtml( 'loginreqlink' ), 'returnto=' . $this->mTitle->getPrefixedUrl() );
+               $loginLink = $skin->makeKnownLinkObj( $loginTitle, wfMsgHtml( 'loginreqlink' ), 'returnto=' . $wgTitle->getPrefixedUrl() );
 
                $wgOut->setPageTitle( wfMsg( 'whitelistedittitle' ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
                $wgOut->addHtml( wfMsgWikiHtml( 'whitelistedittext', $loginLink ) );
-               $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
-       }
-
-       /**
-        * Creates a basic error page which informs the user that
-        * they have to validate their email address before being
-        * allowed to edit.
-        */
-       function userNotConfirmedPage() {
-               global $wgOut;
-
-               $wgOut->setPageTitle( wfMsg( 'confirmedittitle' ) );
-               $wgOut->setRobotPolicy( 'noindex,nofollow' );
-               $wgOut->setArticleRelated( false );
-
-               $wgOut->addWikiText( wfMsg( 'confirmedittext' ) );
-               $wgOut->returnToMain( false );
+               $wgOut->returnToMain( false, $wgTitle );
        }
 
        /**
@@ -1506,14 +1647,14 @@ END
         * they have attempted to edit a nonexistant section.
         */
        function noSuchSectionPage() {
-               global $wgOut;
+               global $wgOut, $wgTitle;
 
                $wgOut->setPageTitle( wfMsg( 'nosuchsectiontitle' ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
-               $wgOut->addWikiText( wfMsg( 'nosuchsectiontext', $this->section ) );
-               $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
+               $wgOut->addWikiMsg( 'nosuchsectiontext', $this->section );
+               $wgOut->returnToMain( false, $wgTitle );
        }
 
        /**
@@ -1522,17 +1663,19 @@ END
         * @param $match Text which triggered one or more filters
         */
        function spamPage( $match = false ) {
-               global $wgOut;
+               global $wgOut, $wgTitle;
 
                $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
-               $wgOut->addWikiText( wfMsg( 'spamprotectiontext' ) );
+               $wgOut->addHtml( '<div id="spamprotected">' );
+               $wgOut->addWikiMsg( 'spamprotectiontext' );
                if ( $match )
-                       $wgOut->addWikiText( wfMsg( 'spamprotectionmatch', "<nowiki>{$match}</nowiki>" ) );
+                       $wgOut->addWikiMsg( 'spamprotectionmatch',wfEscapeWikiText( $match ) );
+               $wgOut->addHtml( '</div>' );
 
-               $wgOut->returnToMain( false );
+               $wgOut->returnToMain( false, $wgTitle );
        }
 
        /**
@@ -1547,7 +1690,7 @@ END
 
                // This is the revision the editor started from
                $baseRevision = Revision::loadFromTimestamp(
-                       $db, $this->mArticle->mTitle, $this->edittime );
+                       $db, $this->mTitle, $this->edittime );
                if( is_null( $baseRevision ) ) {
                        wfProfileOut( $fname );
                        return false;
@@ -1556,7 +1699,7 @@ END
 
                // The current state, we want to merge updates into it
                $currentRevision =  Revision::loadFromTitle(
-                       $db, $this->mArticle->mTitle );
+                       $db, $this->mTitle );
                if( is_null( $currentRevision ) ) {
                        wfProfileOut( $fname );
                        return false;
@@ -1596,6 +1739,14 @@ END
                return true;
        }
 
+       /**
+        * @deprecated use $wgParser->stripSectionName()
+        */
+       function pseudoParseSectionAnchor( $text ) {
+               global $wgParser;
+               return $wgParser->stripSectionName( $text );
+       }
+
        /**
         * Format an anchor fragment as it would appear for a given section name
         * @param string $text
@@ -1603,19 +1754,8 @@ END
         * @private
         */
        function sectionAnchor( $text ) {
-               $headline = Sanitizer::decodeCharReferences( $text );
-               # strip out HTML
-               $headline = preg_replace( '/<.*?' . '>/', '', $headline );
-               $headline = trim( $headline );
-               $sectionanchor = '#' . urlencode( str_replace( ' ', '_', $headline ) );
-               $replacearray = array(
-                       '%3A' => ':',
-                       '%' => '.'
-               );
-               return str_replace(
-                       array_keys( $replacearray ),
-                       array_values( $replacearray ),
-                       $sectionanchor );
+               global $wgParser;
+               return $wgParser->guessSectionNameFromWikiText( $text );
        }
 
        /**
@@ -1640,16 +1780,16 @@ END
                $toolarray = array(
                        array(  'image' => 'button_bold.png',
                                'id'    => 'mw-editbutton-bold',
-                               'open'  => '\\\'\\\'\\\'',
-                               'close' => '\\\'\\\'\\\'',
+                               'open'  => '\'\'\'',
+                               'close' => '\'\'\'',
                                'sample'=> wfMsg('bold_sample'),
                                'tip'   => wfMsg('bold_tip'),
                                'key'   => 'B'
                        ),
                        array(  'image' => 'button_italic.png',
                                'id'    => 'mw-editbutton-italic',
-                               'open'  => '\\\'\\\'',
-                               'close' => '\\\'\\\'',
+                               'open'  => '\'\'',
+                               'close' => '\'\'',
                                'sample'=> wfMsg('italic_sample'),
                                'tip'   => wfMsg('italic_tip'),
                                'key'   => 'I'
@@ -1672,8 +1812,8 @@ END
                        ),
                        array(  'image' => 'button_headline.png',
                                'id'    => 'mw-editbutton-headline',
-                               'open'  => "\\n== ",
-                               'close' => " ==\\n",
+                               'open'  => "\n== ",
+                               'close' => " ==\n",
                                'sample'=> wfMsg('headline_sample'),
                                'tip'   => wfMsg('headline_tip'),
                                'key'   => 'H'
@@ -1697,7 +1837,7 @@ END
                        array(  'image' => 'button_math.png',
                                'id'    => 'mw-editbutton-math',
                                'open'  => "<math>",
-                               'close' => "<\\/math>",
+                               'close' => "</math>",
                                'sample'=> wfMsg('math_sample'),
                                'tip'   => wfMsg('math_tip'),
                                'key'   => 'C'
@@ -1705,7 +1845,7 @@ END
                        array(  'image' => 'button_nowiki.png',
                                'id'    => 'mw-editbutton-nowiki',
                                'open'  => "<nowiki>",
-                               'close' => "<\\/nowiki>",
+                               'close' => "</nowiki>",
                                'sample'=> wfMsg('nowiki_sample'),
                                'tip'   => wfMsg('nowiki_tip'),
                                'key'   => 'N'
@@ -1720,7 +1860,7 @@ END
                        ),
                        array(  'image' => 'button_hr.png',
                                'id'    => 'mw-editbutton-hr',
-                               'open'  => "\\n----\\n",
+                               'open'  => "\n----\n",
                                'close' => '',
                                'sample'=> '',
                                'tip'   => wfMsg('hr_tip'),
@@ -1731,22 +1871,22 @@ END
                $toolbar.="<script type='$wgJsMimeType'>\n/*<![CDATA[*/\n";
 
                foreach($toolarray as $tool) {
-
-                       $cssId = $tool['id'];
-                       $image=$wgStylePath.'/common/images/'.$tool['image'];
-                       $open=$tool['open'];
-                       $close=$tool['close'];
-                       $sample = wfEscapeJsString( $tool['sample'] );
-
-                       // Note that we use the tip both for the ALT tag and the TITLE tag of the image.
-                       // Older browsers show a "speedtip" type message only for ALT.
-                       // Ideally these should be different, realistically they
-                       // probably don't need to be.
-                       $tip = wfEscapeJsString( $tool['tip'] );
-
-                       #$key = $tool["key"];
-
-                       $toolbar.="addButton('$image','$tip','$open','$close','$sample','$cssId');\n";
+                       $params = array(
+                               $image = $wgStylePath.'/common/images/'.$tool['image'],
+                               // Note that we use the tip both for the ALT tag and the TITLE tag of the image.
+                               // Older browsers show a "speedtip" type message only for ALT.
+                               // Ideally these should be different, realistically they
+                               // probably don't need to be.
+                               $tip = $tool['tip'],
+                               $open = $tool['open'],
+                               $close = $tool['close'],
+                               $sample = $tool['sample'],
+                               $cssId = $tool['id'],
+                       );
+                       
+                       $paramList = implode( ',',
+                               array_map( array( 'Xml', 'encodeJsVar' ), $params ) );
+                       $toolbar.="addButton($paramList);\n";
                }
 
                $toolbar.="/*]]>*/\n</script>";
@@ -1871,7 +2011,8 @@ END
                        'title'     => wfMsg( 'tooltip-diff' ).' ['.wfMsg( 'accesskey-diff' ).']',
                );
                $buttons['diff'] = wfElement('input', $temp, '');
-
+               
+               wfRunHooks( 'EditPageBeforeEditButtons', array( &$this, &$buttons ) );
                return $buttons;
        }
 
@@ -1893,12 +2034,15 @@ END
                header( 'Content-type: text/xml; charset=utf-8' );
                header( 'Cache-control: no-cache' );
 
+               $previewText = $this->getPreviewText();
+               #$categories = $skin->getCategoryLinks();
+
                $s =
                '<?xml version="1.0" encoding="UTF-8" ?>' . "\n" .
-               Xml::openElement( 'livepreview' ) .
-               Xml::element( 'preview', null, $this->getPreviewText() ) .
-               Xml::element( 'br', array( 'style' => 'clear: both;' ) ) .
-               Xml::closeElement( 'livepreview' );
+               Xml::tags( 'livepreview', null,
+                       Xml::element( 'preview', null, $previewText )
+                       #.      Xml::element( 'category', null, $categories )
+               );
                echo $s;
        }
 
@@ -2048,7 +2192,7 @@ END
        function noCreatePermission() {
                global $wgOut;
                $wgOut->setPageTitle( wfMsg( 'nocreatetitle' ) );
-               $wgOut->addWikiText( wfMsg( 'nocreatetext' ) );
+               $wgOut->addWikiMsg( 'nocreatetext' );
        }
        
        /**
@@ -2058,7 +2202,7 @@ END
         * @param OutputPage $out
         */
        private function showDeletionLog( $out ) {
-               $title = $this->mArticle->getTitle();
+               $title = $this->mTitle;
                $reader = new LogReader(
                        new FauxRequest(
                                array(
@@ -2069,13 +2213,80 @@ END
                );
                if( $reader->hasRows() ) {
                        $out->addHtml( '<div id="mw-recreate-deleted-warn">' );
-                       $out->addWikiText( wfMsg( 'recreate-deleted-warn' ) );
+                       $out->addWikiMsg( 'recreate-deleted-warn' );
                        $viewer = new LogViewer( $reader );
                        $viewer->showList( $out );
-                       $out->addHtml( '</div>' );                      
-               }                               
+                       $out->addHtml( '</div>' );
+               }
        }
-       
-}
 
+       /**
+        * Attempt submission
+        * @return bool false if output is done, true if the rest of the form should be displayed
+        */
+       function attemptSave() {
+               global $wgUser, $wgOut, $wgTitle, $wgRequest;
+
+               $resultDetails = false;
+               $value = $this->internalAttemptSave( $resultDetails, $wgUser->isAllowed('bot') && $wgRequest->getBool('bot', true) );
+               
+               if( $value == self::AS_SUCCESS_UPDATE || $value == self::AS_SUCCESS_NEW_ARTICLE ) {
+                       $this->didSave = true;
+               }
+
+               switch ($value) {
+                       case self::AS_HOOK_ERROR_EXPECTED:
+                       case self::AS_CONTENT_TOO_BIG:
+                       case self::AS_ARTICLE_WAS_DELETED:
+                       case self::AS_CONFLICT_DETECTED:
+                       case self::AS_SUMMARY_NEEDED:
+                       case self::AS_TEXTBOX_EMPTY:
+                       case self::AS_MAX_ARTICLE_SIZE_EXCEEDED:
+                       case self::AS_END:
+                               return true;
 
+                       case self::AS_HOOK_ERROR:
+                       case self::AS_FILTERING:
+                       case self::AS_SUCCESS_NEW_ARTICLE:
+                       case self::AS_SUCCESS_UPDATE:
+                               return false;
+
+                       case self::AS_SPAM_ERROR:
+                               $this->spamPage ( $resultDetails['spam'] );
+                               return false;
+
+                       case self::AS_BLOCKED_PAGE_FOR_USER:
+                               $this->blockedPage();
+                               return false;
+
+                       case self::AS_IMAGE_REDIRECT_ANON:
+                               $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
+                               return false;
+
+                       case self::AS_READ_ONLY_PAGE_ANON:
+                               $this->userNotLoggedInPage();
+                               return false;
+
+                       case self::AS_READ_ONLY_PAGE_LOGGED:
+                       case self::AS_READ_ONLY_PAGE:
+                               $wgOut->readOnlyPage();
+                               return false;
+
+                       case self::AS_RATE_LIMITED:
+                               $wgOut->rateLimited();
+                               return false;
+
+                       case self::AS_NO_CREATE_PERMISSION;
+                               $this->noCreatePermission();
+                               return;
+                       
+                       case self::AS_BLANK_ARTICLE:
+                               $wgOut->redirect( $wgTitle->getFullURL() );
+                               return false;
+
+                       case self::AS_IMAGE_REDIRECT_LOGGED:
+                               $wgOut->permissionRequired( 'upload' );
+                               return false;
+               }
+       }
+}