Performance improvements to diff algorithms
[lhc/web/wiklou.git] / includes / DifferenceEngine.php
index 48a8226..d3bf205 100644 (file)
@@ -1,8 +1,6 @@
 <?php
 /**
- * See diff.doc
- * @todo indicate where diff.doc can be found.
- * @addtogroup DifferenceEngine
+ * @defgroup DifferenceEngine DifferenceEngine
  */
 
 /**
@@ -15,8 +13,7 @@ define( 'MW_DIFF_VERSION', '1.11a' );
 
 /**
  * @todo document
- * @public
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class DifferenceEngine {
        /**#@+
@@ -40,7 +37,7 @@ class DifferenceEngine {
         * @param $rcid Integer: ??? FIXME (default 0)
         * @param $refreshCache boolean If set, refreshes the diff cache
         */
-       function DifferenceEngine( $titleObj = null, $old = 0, $new = 0, $rcid = 0, $refreshCache = false ) {
+       function __construct( $titleObj = null, $old = 0, $new = 0, $rcid = 0, $refreshCache = false ) {
                $this->mTitle = $titleObj;
                wfDebug("DifferenceEngine old '$old' new '$new' rcid '$rcid'\n");
 
@@ -72,12 +69,16 @@ class DifferenceEngine {
                $this->mRefreshCache = $refreshCache;
        }
 
+       function getTitle() {
+               return $this->mTitle;
+       }
+
        function showDiffPage( $diffOnly = false ) {
-               global $wgUser, $wgOut, $wgUseExternalEditor, $wgUseRCPatrol;
-               $fname = 'DifferenceEngine::showDiffPage';
-               wfProfileIn( $fname );
+               global $wgUser, $wgOut, $wgUseExternalEditor, $wgUseRCPatrol, $wgEnableHtmlDiff;
+               wfProfileIn( __METHOD__ );
+
 
-               # If external diffs are enabled both globally and for the user,
+               # If external diffs are enabled both globally and for the user,
                # we'll use the application/x-external-editor interface to call
                # an external diff tool like kompare, kdiff3, etc.
                if($wgUseExternalEditor && $wgUser->getOption('externaldiff')) {
@@ -88,19 +89,19 @@ class DifferenceEngine {
                        $url2=$this->mTitle->getFullURL("action=raw&oldid=".$this->mNewid);
                        $special=$wgLang->getNsText(NS_SPECIAL);
                        $control=<<<CONTROL
-[Process]
-Type=Diff text
-Engine=MediaWiki
-Script={$wgServer}{$wgScript}
-Special namespace={$special}
-
-[File]
-Extension=wiki
-URL=$url1
-
-[File 2]
-Extension=wiki
-URL=$url2
+                       [Process]
+                       Type=Diff text
+                       Engine=MediaWiki
+                       Script={$wgServer}{$wgScript}
+                       Special namespace={$special}
+
+                       [File]
+                       Extension=wiki
+                       URL=$url1
+
+                       [File 2]
+                       Extension=wiki
+                       URL=$url2
 CONTROL;
                        echo($control);
                        return;
@@ -108,13 +109,14 @@ CONTROL;
 
                $wgOut->setArticleFlag( false );
                if ( ! $this->loadRevisionData() ) {
-                       $t = $this->mTitle->getPrefixedText() . " (Diff: {$this->mOldid}, {$this->mNewid})";
+                       $t = $this->mTitle->getPrefixedText();
+                       $d = wfMsgExt( 'missingarticle-diff', array( 'escape' ), $this->mOldid, $this->mNewid );
                        $wgOut->setPagetitle( wfMsg( 'errorpagetitle' ) );
-                       $wgOut->addWikiMsg( 'missingarticle', "<nowiki>$t</nowiki>" );
-                       wfProfileOut( $fname );
+                       $wgOut->addWikiMsg( 'missing-article', "<nowiki>$t</nowiki>", $d );
+                       wfProfileOut( __METHOD__ );
                        return;
                }
-               
+
                wfRunHooks( 'DiffViewHeader', array( $this, $this->mOldRev, $this->mNewRev ) );
 
                if ( $this->mNewRev->isCurrent() ) {
@@ -127,7 +129,7 @@ CONTROL;
                if ( $this->mOldid === false ) {
                        $this->showFirstRevision();
                        $this->renderNewRevision();  // should we respect $diffOnly here or not?
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                        return;
                }
 
@@ -141,23 +143,25 @@ CONTROL;
                        $wgOut->setPageTitle( $oldTitle . ', ' . $newTitle );
                }
                $wgOut->setSubtitle( wfMsg( 'difference' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
 
                if ( !( $this->mOldPage->userCanRead() && $this->mNewPage->userCanRead() ) ) {
                        $wgOut->loginToUse();
                        $wgOut->output();
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                        exit;
                }
 
                $sk = $wgUser->getSkin();
 
-               if ( $this->mNewRev->isCurrent() && $wgUser->isAllowed('rollback') ) {
+               // Check if page is editable
+               $editable = $this->mNewRev->getTitle()->userCan( 'edit' );
+               if ( $editable && $this->mNewRev->isCurrent() && $wgUser->isAllowed( 'rollback' ) ) {
                        $rollback = '&nbsp;&nbsp;&nbsp;' . $sk->generateRollback( $this->mNewRev );
                } else {
                        $rollback = '';
                }
-               
+
                // Prepare a change patrol link, if applicable
                if( $wgUseRCPatrol && $wgUser->isAllowed( 'patrol' ) ) {
                        // If we've been given an explicit change identifier, use it; saves time
@@ -167,15 +171,15 @@ CONTROL;
                                // Look for an unpatrolled change corresponding to this diff
                                $db = wfGetDB( DB_SLAVE );
                                $change = RecentChange::newFromConds(
-                                       array(
-                                               // Add redundant user,timestamp condition so we can use the existing index
+                               array(
+                               // Add redundant user,timestamp condition so we can use the existing index
                                                'rc_user_text'  => $this->mNewRev->getRawUserText(),
                                                'rc_timestamp' => $db->timestamp( $this->mNewRev->getTimestamp() ),
                                                'rc_this_oldid' => $this->mNewid,
                                                'rc_last_oldid' => $this->mOldid,
                                                'rc_patrolled' => 0
-                                       ),
-                                       __METHOD__
+                               ),
+                               __METHOD__
                                );
                                if( $change instanceof RecentChange ) {
                                        $rcid = $change->mAttribs['rc_id'];
@@ -187,8 +191,8 @@ CONTROL;
                        // Build the link
                        if( $rcid ) {
                                $patrol = ' <span class="patrollink">[' . $sk->makeKnownLinkObj(
-                                       $this->mTitle,
-                                       wfMsgHtml( 'markaspatrolleddiff' ),
+                               $this->mTitle,
+                               wfMsgHtml( 'markaspatrolleddiff' ),
                                        "action=markpatrolled&rcid={$rcid}"
                                ) . ']</span>';
                        } else {
@@ -211,46 +215,44 @@ CONTROL;
                $newminor = '';
 
                if ($this->mOldRev->mMinorEdit == 1) {
-                       $oldminor = wfElement( 'span', array( 'class' => 'minor' ),
-                               wfMsg( 'minoreditletter') ) . ' ';
+                       $oldminor = Xml::span( wfMsg( 'minoreditletter'), 'minor' ) . ' ';
                }
 
                if ($this->mNewRev->mMinorEdit == 1) {
-                       $newminor = wfElement( 'span', array( 'class' => 'minor' ),
-                       wfMsg( 'minoreditletter') ) . ' ';
+                       $newminor = Xml::span( wfMsg( 'minoreditletter'), 'minor' ) . ' ';
                }
-               
+
                $rdel = ''; $ldel = '';
                if( $wgUser->isAllowed( 'deleterevision' ) ) {
                        $revdel = SpecialPage::getTitleFor( 'Revisiondelete' );
                        if( !$this->mOldRev->userCan( Revision::DELETED_RESTRICTED ) ) {
-                       // If revision was hidden from sysops
-                               $ldel = wfMsgHtml('rev-delundel');      
+                               // If revision was hidden from sysops
+                               $ldel = wfMsgHtml('rev-delundel');
                        } else {
                                $ldel = $sk->makeKnownLinkObj( $revdel,
-                                       wfMsgHtml('rev-delundel'),
+                               wfMsgHtml('rev-delundel'),
                                        'target=' . urlencode( $this->mOldRev->mTitle->getPrefixedDbkey() ) .
                                        '&oldid=' . urlencode( $this->mOldRev->getId() ) );
                                // Bolden oversighted content
                                if( $this->mOldRev->isDeleted( Revision::DELETED_RESTRICTED ) )
-                                       $ldel = "<strong>$ldel</strong>";
+                               $ldel = "<strong>$ldel</strong>";
                        }
                        $ldel = "&nbsp;&nbsp;&nbsp;<tt>(<small>$ldel</small>)</tt> ";
                        // We don't currently handle well changing the top revision's settings
                        if( $this->mNewRev->isCurrent() ) {
-                       // If revision was hidden from sysops
-                               $rdel = wfMsgHtml('rev-delundel');      
+                               // If revision was hidden from sysops
+                               $rdel = wfMsgHtml('rev-delundel');
                        } else if( !$this->mNewRev->userCan( Revision::DELETED_RESTRICTED ) ) {
-                       // If revision was hidden from sysops
-                               $rdel = wfMsgHtml('rev-delundel');      
+                               // If revision was hidden from sysops
+                               $rdel = wfMsgHtml('rev-delundel');
                        } else {
                                $rdel = $sk->makeKnownLinkObj( $revdel,
-                                       wfMsgHtml('rev-delundel'),
+                               wfMsgHtml('rev-delundel'),
                                        'target=' . urlencode( $this->mNewRev->mTitle->getPrefixedDbkey() ) .
                                        '&oldid=' . urlencode( $this->mNewRev->getId() ) );
                                // Bolden oversighted content
                                if( $this->mNewRev->isDeleted( Revision::DELETED_RESTRICTED ) )
-                                       $rdel = "<strong>$rdel</strong>";
+                               $rdel = "<strong>$rdel</strong>";
                        }
                        $rdel = "&nbsp;&nbsp;&nbsp;<tt>(<small>$rdel</small>)</tt> ";
                }
@@ -264,12 +266,17 @@ CONTROL;
                        '<div id="mw-diff-ntitle3">' . $newminor . $sk->revComment( $this->mNewRev, !$diffOnly, true ) . $rdel . "</div>" .
                        '<div id="mw-diff-ntitle4">' . $nextlink . $patrol . '</div>';
 
-               $this->showDiff( $oldHeader, $newHeader );
+               if($wgEnableHtmlDiff){
+                       $this->renderHtmlDiff();
+               }else{
 
-               if ( !$diffOnly )
-                       $this->renderNewRevision();
+                       $this->showDiff( $oldHeader, $newHeader );
 
-               wfProfileOut( $fname );
+                       if ( !$diffOnly ){
+                               $this->renderNewRevision();
+                       }
+               }
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -277,15 +284,14 @@ CONTROL;
         */
        function renderNewRevision() {
                global $wgOut;
-               $fname = 'DifferenceEngine::renderNewRevision';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $wgOut->addHTML( "<hr /><h2>{$this->mPagetitle}</h2>\n" );
                #add deleted rev tag if needed
                if( !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
-                       $wgOut->addWikiMsg( 'rev-deleted-text-permission' );
+                       $wgOut->addWikiMsg( 'rev-deleted-text-permission' );
                } else if( $this->mNewRev->isDeleted(Revision::DELETED_TEXT) ) {
-                       $wgOut->addWikiMsg( 'rev-deleted-text-view' );
+                       $wgOut->addWikiMsg( 'rev-deleted-text-view' );
                }
 
                if( !$this->mNewRev->isCurrent() ) {
@@ -310,13 +316,72 @@ CONTROL;
                                $wgOut->addHtml( "\n</pre>\n" );
                        }
                } else
-                       $wgOut->addWikiTextTidy( $this->mNewtext );
+               $wgOut->addWikiTextTidy( $this->mNewtext );
 
                if( !$this->mNewRev->isCurrent() ) {
                        $wgOut->parserOptions()->setEditSection( $oldEditSectionSetting );
                }
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
+       }
+
+
+       function renderHtmlDiff() {
+               global $wgOut;
+               wfProfileIn( __METHOD__ );
+
+               $this->showDiffStyle();
+
+               #add deleted rev tag if needed
+               if( !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
+                       $wgOut->addWikiMsg( 'rev-deleted-text-permission' );
+               } else if( $this->mNewRev->isDeleted(Revision::DELETED_TEXT) ) {
+                       $wgOut->addWikiMsg( 'rev-deleted-text-view' );
+               }
+
+               if( !$this->mNewRev->isCurrent() ) {
+                       $oldEditSectionSetting = $wgOut->parserOptions()->setEditSection( false );
+               }
+
+               $this->loadText();
+
+               if( is_object( $this->mOldRev ) ) {
+                       $wgOut->setRevisionId( $this->mOldRev->getId() );
+               }
+
+               global $wgTitle, $wgParser, $wgTitle;
+               $popts = $wgOut->parserOptions();
+               $oldTidy = $popts->setTidy( TRUE );
+
+               $parserOutput = $wgParser->parse($this->mOldtext, $wgTitle, $popts, TRUE, TRUE, $wgOut->mRevisionId );
+               $popts->setTidy( $oldTidy );
+
+               //only for new?
+               //$wgOut->addParserOutputNoText( $parserOutput );
+               $oldHtml =      $parserOutput->getText();
+               wfRunHooks( 'OutputPageBeforeHTML',array( &$wgOut, &$oldHtml ) );
+
+               if( is_object( $this->mNewRev ) ) {
+                       $wgOut->setRevisionId( $this->mNewRev->getId() );
+               }
+
+               $popts = $wgOut->parserOptions();
+               $oldTidy = $popts->setTidy( TRUE );
+
+               $parserOutput = $wgParser->parse($this->mNewtext, $wgTitle, $popts, TRUE, TRUE, $wgOut->mRevisionId );
+               $popts->setTidy( $oldTidy );
+
+               //only for new?
+               $wgOut->addParserOutputNoText( $parserOutput );
+               $newHtml =      $parserOutput->getText();
+               wfRunHooks( 'OutputPageBeforeHTML',array( &$wgOut, &$newHtml ) );
+
+               unset($parserOutput,$popts);
+
+               $differ = new HTMLDiffer(new DelegatingContentHandler($wgOut));
+               $differ->htmlDiff($oldHtml, $newHtml);
+
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -325,18 +390,16 @@ CONTROL;
         */
        function showFirstRevision() {
                global $wgOut, $wgUser;
-
-               $fname = 'DifferenceEngine::showFirstRevision';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                # Get article text from the DB
                #
                if ( ! $this->loadNewText() ) {
-                       $t = $this->mTitle->getPrefixedText() . " (Diff: {$this->mOldid}, " .
-                         "{$this->mNewid})";
+                       $t = $this->mTitle->getPrefixedText();
+                       $d = wfMsgExt( 'missingarticle-diff', array( 'escape' ), $this->mOldid, $this->mNewid );
                        $wgOut->setPagetitle( wfMsg( 'errorpagetitle' ) );
-                       $wgOut->addWikiMsg( 'missingarticle', "<nowiki>$t</nowiki>" );
-                       wfProfileOut( $fname );
+                       $wgOut->addWikiMsg( 'missing-article', "<nowiki>$t</nowiki>", $d );
+                       wfProfileOut( __METHOD__ );
                        return;
                }
                if ( $this->mNewRev->isCurrent() ) {
@@ -348,7 +411,7 @@ CONTROL;
                if ( !( $this->mTitle->userCanRead() ) ) {
                        $wgOut->loginToUse();
                        $wgOut->output();
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                        exit;
                }
 
@@ -358,16 +421,16 @@ CONTROL;
 
                $nextlink = $sk->makeKnownLinkObj( $this->mTitle, wfMsgHtml( 'nextdiff' ), 'diff=next&oldid='.$this->mNewid, '', '', 'id="differences-nextlink"' );
                $header = "<div class=\"firstrevisionheader\" style=\"text-align: center\"><strong>{$this->mOldtitle}</strong><br />" .
-                       $sk->revUserTools( $this->mNewRev ) . "<br />" .
-                       $sk->revComment( $this->mNewRev ) . "<br />" .
-                       $nextlink . "</div>\n";
+               $sk->revUserTools( $this->mNewRev ) . "<br />" .
+               $sk->revComment( $this->mNewRev ) . "<br />" .
+               $nextlink . "</div>\n";
 
                $wgOut->addHTML( $header );
 
                $wgOut->setSubtitle( wfMsg( 'difference' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -378,7 +441,7 @@ CONTROL;
                global $wgOut;
                $diff = $this->getDiff( $otitle, $ntitle );
                if ( $diff === false ) {
-                       $wgOut->addWikiMsg( 'missingarticle', "<nowiki>(fixme, bug)</nowiki>" );
+                       $wgOut->addWikiMsg( 'missing-article', "<nowiki>(fixme, bug)</nowiki>", '' );
                        return false;
                } else {
                        $this->showDiffStyle();
@@ -386,14 +449,14 @@ CONTROL;
                        return true;
                }
        }
-       
+
        /**
         * Add style sheets and supporting JS for diff display.
         */
        function showDiffStyle() {
                global $wgStylePath, $wgStyleVersion, $wgOut;
                $wgOut->addStyle( 'common/diff.css' );
-               
+
                // JS is needed to detect old versions of Mozilla to work around an annoyance bug.
                $wgOut->addScript( "<script type=\"text/javascript\" src=\"$wgStylePath/common/diff.js?$wgStyleVersion\"></script>" );
        }
@@ -422,9 +485,13 @@ CONTROL;
         */
        function getDiffBody() {
                global $wgMemc;
-               $fname = 'DifferenceEngine::getDiffBody';
-               wfProfileIn( $fname );
-               
+               wfProfileIn( __METHOD__ );
+               // Check if the diff should be hidden from this user
+               if ( $this->mOldRev && !$this->mOldRev->userCan(Revision::DELETED_TEXT) ) {
+                       return '';
+               } else if ( $this->mNewRev && !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
+                       return '';
+               }
                // Cacheable?
                $key = false;
                if ( $this->mOldid && $this->mNewid ) {
@@ -436,7 +503,7 @@ CONTROL;
                                        wfIncrStats( 'diff_cache_hit' );
                                        $difftext = $this->localiseLineNumbers( $difftext );
                                        $difftext .= "\n<!-- diff cache key $key -->\n";
-                                       wfProfileOut( $fname );
+                                       wfProfileOut( __METHOD__ );
                                        return $difftext;
                                }
                        } // don't try to load but save the result
@@ -444,23 +511,14 @@ CONTROL;
 
                // Loadtext is permission safe, this just clears out the diff
                if ( !$this->loadText() ) {
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                        return false;
-               } else if ( $this->mOldRev && !$this->mOldRev->userCan(Revision::DELETED_TEXT) ) {
-                       return '';
-               } else if ( $this->mNewRev && !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
-                       return '';
                }
 
                $difftext = $this->generateDiffBody( $this->mOldtext, $this->mNewtext );
-               
+
                // Save to cache for 7 days
-               // Only do this for public revs, otherwise an admin can view the diff and a non-admin can nab it!
-               if ( $this->mOldRev && $this->mOldRev->isDeleted(Revision::DELETED_TEXT) ) {
-                       wfIncrStats( 'diff_uncacheable' );
-               } else if ( $this->mNewRev && $this->mNewRev->isDeleted(Revision::DELETED_TEXT) ) {
-                       wfIncrStats( 'diff_uncacheable' );
-               } else if ( $key !== false && $difftext !== false ) {
+               if ( $key !== false && $difftext !== false ) {
                        wfIncrStats( 'diff_cache_miss' );
                        $wgMemc->set( $key, $difftext, 7*86400 );
                } else {
@@ -470,7 +528,7 @@ CONTROL;
                if ( $difftext !== false ) {
                        $difftext = $this->localiseLineNumbers( $difftext );
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $difftext;
        }
 
@@ -480,11 +538,10 @@ CONTROL;
         */
        function generateDiffBody( $otext, $ntext ) {
                global $wgExternalDiffEngine, $wgContLang;
-               $fname = 'DifferenceEngine::generateDiffBody';
 
                $otext = str_replace( "\r\n", "\n", $otext );
                $ntext = str_replace( "\r\n", "\n", $ntext );
-               
+
                if ( $wgExternalDiffEngine == 'wikidiff' ) {
                        # For historical reasons, external diff engine expects
                        # input text to be HTML-escaped already
@@ -493,25 +550,27 @@ CONTROL;
                        if( !function_exists( 'wikidiff_do_diff' ) ) {
                                dl('php_wikidiff.so');
                        }
-                       return $wgContLang->unsegementForDiff( wikidiff_do_diff( $otext, $ntext, 2 ) );
+                       return $wgContLang->unsegementForDiff( wikidiff_do_diff( $otext, $ntext, 2 ) ) .
+                       $this->debug( 'wikidiff1' );
                }
-               
+
                if ( $wgExternalDiffEngine == 'wikidiff2' ) {
                        # Better external diff engine, the 2 may some day be dropped
                        # This one does the escaping and segmenting itself
                        if ( !function_exists( 'wikidiff2_do_diff' ) ) {
-                               wfProfileIn( "$fname-dl" );
+                               wfProfileIn( __METHOD__ . "-dl" );
                                @dl('php_wikidiff2.so');
-                               wfProfileOut( "$fname-dl" );
+                               wfProfileOut( __METHOD__ . "-dl" );
                        }
                        if ( function_exists( 'wikidiff2_do_diff' ) ) {
                                wfProfileIn( 'wikidiff2_do_diff' );
                                $text = wikidiff2_do_diff( $otext, $ntext, 2 );
+                               $text .= $this->debug( 'wikidiff2' );
                                wfProfileOut( 'wikidiff2_do_diff' );
                                return $text;
                        }
                }
-               if ( $wgExternalDiffEngine !== false ) {
+               if ( $wgExternalDiffEngine != 'wikidiff3' && $wgExternalDiffEngine !== false ) {
                        # Diff via the shell
                        global $wgTmpDirectory;
                        $tempName1 = tempnam( $wgTmpDirectory, 'diff_' );
@@ -519,12 +578,12 @@ CONTROL;
 
                        $tempFile1 = fopen( $tempName1, "w" );
                        if ( !$tempFile1 ) {
-                               wfProfileOut( $fname );
+                               wfProfileOut( __METHOD__ );
                                return false;
                        }
                        $tempFile2 = fopen( $tempName2, "w" );
                        if ( !$tempFile2 ) {
-                               wfProfileOut( $fname );
+                               wfProfileOut( __METHOD__ );
                                return false;
                        }
                        fwrite( $tempFile1, $otext );
@@ -532,29 +591,49 @@ CONTROL;
                        fclose( $tempFile1 );
                        fclose( $tempFile2 );
                        $cmd = wfEscapeShellArg( $wgExternalDiffEngine, $tempName1, $tempName2 );
-                       wfProfileIn( "$fname-shellexec" );
+                       wfProfileIn( __METHOD__ . "-shellexec" );
                        $difftext = wfShellExec( $cmd );
-                       wfProfileOut( "$fname-shellexec" );
+                       $difftext .= $this->debug( "external $wgExternalDiffEngine" );
+                       wfProfileOut( __METHOD__ . "-shellexec" );
                        unlink( $tempName1 );
                        unlink( $tempName2 );
                        return $difftext;
                }
-               
+
                # Native PHP diff
                $ota = explode( "\n", $wgContLang->segmentForDiff( $otext ) );
                $nta = explode( "\n", $wgContLang->segmentForDiff( $ntext ) );
                $diffs = new Diff( $ota, $nta );
                $formatter = new TableDiffFormatter();
-               return $wgContLang->unsegmentForDiff( $formatter->format( $diffs ) );
+               return $wgContLang->unsegmentForDiff( $formatter->format( $diffs ) ) .
+               $this->debug();
+       }
+
+       /**
+        * Generate a debug comment indicating diff generating time,
+        * server node, and generator backend.
+        */
+       protected function debug( $generator="internal" ) {
+               global $wgShowHostnames, $wgNodeName;
+               $data = array( $generator );
+               if( $wgShowHostnames ) {
+                       $data[] = $wgNodeName;
+               }
+               $data[] = wfTimestamp( TS_DB );
+               return "<!-- diff generator: " .
+               implode( " ",
+               array_map(
+                                       "htmlspecialchars",
+               $data ) ) .
+                       " -->\n";
        }
-               
 
        /**
         * Replace line numbers with the text in the user's language
         */
        function localiseLineNumbers( $text ) {
                return preg_replace_callback( '/<!--LINE (\d+)-->/',
-                       array( &$this, 'localiseLineNumbersCb' ), $text );
+               array( &$this, 'localiseLineNumbersCb' ), $text );
        }
 
        function localiseLineNumbersCb( $matches ) {
@@ -562,19 +641,19 @@ CONTROL;
                return wfMsgExt( 'lineno', array('parseinline'), $wgLang->formatNum( $matches[1] ) );
        }
 
-       
+
        /**
         * If there are revisions between the ones being compared, return a note saying so.
         */
        function getMultiNotice() {
                if ( !is_object($this->mOldRev) || !is_object($this->mNewRev) )
-                       return '';
-               
+               return '';
+
                if( !$this->mOldPage->equals( $this->mNewPage ) ) {
                        // Comparing two different pages? Count would be meaningless.
                        return '';
                }
-               
+
                $oldid = $this->mOldRev->getId();
                $newid = $this->mNewRev->getId();
                if ( $oldid > $newid ) {
@@ -583,7 +662,7 @@ CONTROL;
 
                $n = $this->mTitle->countRevisionsBetween( $oldid, $newid );
                if ( !$n )
-                       return '';
+               return '';
 
                return wfMsgExt( 'diff-multi', array( 'parseinline' ), $n );
        }
@@ -596,19 +675,19 @@ CONTROL;
                global $wgOut;
 
                $header = "
-                       <table class='diff'>
-                       <col class='diff-marker' />
-                       <col class='diff-content' />
-                       <col class='diff-marker' />
-                       <col class='diff-content' />
-                       <tr>
-                               <td colspan='2' class='diff-otitle'>{$otitle}</td>
-                               <td colspan='2' class='diff-ntitle'>{$ntitle}</td>
-                       </tr>
+               <table class='diff'>
+               <col class='diff-marker' />
+               <col class='diff-content' />
+               <col class='diff-marker' />
+               <col class='diff-content' />
+               <tr valign='top'>
+               <td colspan='2' class='diff-otitle'>{$otitle}</td>
+               <td colspan='2' class='diff-ntitle'>{$ntitle}</td>
+               </tr>
                ";
 
                if ( $multi != '' )
-                       $header .= "<tr><td colspan='4' align='center' class='diff-multi'>{$multi}</td></tr>";
+               $header .= "<tr><td colspan='4' align='center' class='diff-multi'>{$multi}</td></tr>";
 
                return $header . $diff . "</table>";
        }
@@ -643,37 +722,40 @@ CONTROL;
 
                // Load the new revision object
                $this->mNewRev = $this->mNewid
-                       ? Revision::newFromId( $this->mNewid )
-                       : Revision::newFromTitle( $this->mTitle );
+               ? Revision::newFromId( $this->mNewid )
+               : Revision::newFromTitle( $this->mTitle );
                if( !$this->mNewRev instanceof Revision )
-                       return false;
-               
+               return false;
+
                // Update the new revision ID in case it was 0 (makes life easier doing UI stuff)
                $this->mNewid = $this->mNewRev->getId();
-               
+
+               // Check if page is editable
+               $editable = $this->mNewRev->getTitle()->userCan( 'edit' );
+
                // Set assorted variables
                $timestamp = $wgLang->timeanddate( $this->mNewRev->getTimestamp(), true );
                $this->mNewPage = $this->mNewRev->getTitle();
                if( $this->mNewRev->isCurrent() ) {
-                       $newLink = $this->mNewPage->escapeLocalUrl();
+                       $newLink = $this->mNewPage->escapeLocalUrl( 'oldid=' . $this->mNewid );
                        $this->mPagetitle = htmlspecialchars( wfMsg( 'currentrev' ) );
                        $newEdit = $this->mNewPage->escapeLocalUrl( 'action=edit' );
 
-                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a> ($timestamp)"
-                               . " (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
+                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a> ($timestamp)";
+                       $this->mNewtitle .= " (<a href='$newEdit'>" . wfMsgHtml( $editable ? 'editold' : 'viewsourceold' ) . "</a>)";
 
                } else {
                        $newLink = $this->mNewPage->escapeLocalUrl( 'oldid=' . $this->mNewid );
                        $newEdit = $this->mNewPage->escapeLocalUrl( 'action=edit&oldid=' . $this->mNewid );
                        $this->mPagetitle = wfMsgHTML( 'revisionasof', $timestamp );
 
-                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a>"
-                               . " (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
+                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a>";
+                       $this->mNewtitle .= " (<a href='$newEdit'>" . wfMsgHtml( $editable ? 'editold' : 'viewsourceold' ) . "</a>)";
                }
                if ( !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
-                       $this->mNewtitle = "<span class='history-deleted'>{$this->mPagetitle}</span>";
+                       $this->mNewtitle = "<span class='history-deleted'>{$this->mPagetitle}</span>";
                } else if ( $this->mNewRev->isDeleted(Revision::DELETED_TEXT) ) {
-                       $this->mNewtitle = '<span class="history-deleted">'.$this->mNewtitle.'</span>';
+                       $this->mNewtitle = '<span class="history-deleted">'.$this->mNewtitle.'</span>';
                }
 
                // Load the old revision object
@@ -703,18 +785,19 @@ CONTROL;
                        $oldLink = $this->mOldPage->escapeLocalUrl( 'oldid=' . $this->mOldid );
                        $oldEdit = $this->mOldPage->escapeLocalUrl( 'action=edit&oldid=' . $this->mOldid );
                        $this->mOldPagetitle = htmlspecialchars( wfMsg( 'revisionasof', $t ) );
-                       
+
                        $this->mOldtitle = "<a href='$oldLink'>{$this->mOldPagetitle}</a>"
-                               . " (<a href='$oldEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
+                       . " (<a href='$oldEdit'>" . wfMsgHtml( $editable ? 'editold' : 'viewsourceold' ) . "</a>)";
                        // Add an "undo" link
                        $newUndo = $this->mNewPage->escapeLocalUrl( 'action=edit&undoafter=' . $this->mOldid . '&undo=' . $this->mNewid);
-                       if ( $this->mNewRev->userCan(Revision::DELETED_TEXT) )
+                       if( $editable && !$this->mOldRev->isDeleted( Revision::DELETED_TEXT ) && !$this->mNewRev->isDeleted( Revision::DELETED_TEXT ) ) {
                                $this->mNewtitle .= " (<a href='$newUndo'>" . htmlspecialchars( wfMsg( 'editundo' ) ) . "</a>)";
-                       
-                       if ( !$this->mOldRev->userCan(Revision::DELETED_TEXT) ) {
-                               $this->mOldtitle = "<span class='history-deleted'>{$this->mOldPagetitle}</span>";
-                       } else if ( $this->mOldRev->isDeleted(Revision::DELETED_TEXT) ) {
-                               $this->mOldtitle = '<span class="history-deleted">'.$this->mOldtitle.'</span>';
+                       }
+
+                       if( !$this->mOldRev->userCan( Revision::DELETED_TEXT ) ) {
+                               $this->mOldtitle = '<span class="history-deleted">' . $this->mOldPagetitle . '</span>';
+                       } else if( $this->mOldRev->isDeleted( Revision::DELETED_TEXT ) ) {
+                               $this->mOldtitle = '<span class="history-deleted">' . $this->mOldtitle . '</span>';
                        }
                }
 
@@ -780,7 +863,7 @@ define('USE_ASSERTS', function_exists('assert'));
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class _DiffOp {
        var $type;
@@ -803,14 +886,14 @@ class _DiffOp {
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class _DiffOp_Copy extends _DiffOp {
        var $type = 'copy';
 
        function _DiffOp_Copy ($orig, $closing = false) {
                if (!is_array($closing))
-                       $closing = $orig;
+               $closing = $orig;
                $this->orig = $orig;
                $this->closing = $closing;
        }
@@ -823,7 +906,7 @@ class _DiffOp_Copy extends _DiffOp {
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class _DiffOp_Delete extends _DiffOp {
        var $type = 'delete';
@@ -841,7 +924,7 @@ class _DiffOp_Delete extends _DiffOp {
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class _DiffOp_Add extends _DiffOp {
        var $type = 'add';
@@ -859,7 +942,7 @@ class _DiffOp_Add extends _DiffOp {
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class _DiffOp_Change extends _DiffOp {
        var $type = 'change';
@@ -874,7 +957,6 @@ class _DiffOp_Change extends _DiffOp {
        }
 }
 
-
 /**
  * Class used internally by Diff to actually compute the diffs.
  *
@@ -893,72 +975,30 @@ class _DiffOp_Change extends _DiffOp {
  * are my own.
  *
  * Line length limits for robustness added by Tim Starling, 2005-08-31
+ * Alternative implementation added by Guy Van den Broeck, 2008-07-30
  *
- * @author Geoffrey T. Dairiki, Tim Starling
+ * @author Geoffrey T. Dairiki, Tim Starling, Guy Van den Broeck
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
-class _DiffEngine
-{
-       const MAX_XREF_LENGTH =  10000;
-
-       function diff ($from_lines, $to_lines) {
-               $fname = '_DiffEngine::diff';
-               wfProfileIn( $fname );
-
-               $n_from = sizeof($from_lines);
-               $n_to = sizeof($to_lines);
-
-               $this->xchanged = $this->ychanged = array();
-               $this->xv = $this->yv = array();
-               $this->xind = $this->yind = array();
-               unset($this->seq);
-               unset($this->in_seq);
-               unset($this->lcs);
-
-               // Skip leading common lines.
-               for ($skip = 0; $skip < $n_from && $skip < $n_to; $skip++) {
-                       if ($from_lines[$skip] !== $to_lines[$skip])
-                               break;
-                       $this->xchanged[$skip] = $this->ychanged[$skip] = false;
-               }
-               // Skip trailing common lines.
-               $xi = $n_from; $yi = $n_to;
-               for ($endskip = 0; --$xi > $skip && --$yi > $skip; $endskip++) {
-                       if ($from_lines[$xi] !== $to_lines[$yi])
-                               break;
-                       $this->xchanged[$xi] = $this->ychanged[$yi] = false;
-               }
+class _DiffEngine {
 
-               // Ignore lines which do not exist in both files.
-               for ($xi = $skip; $xi < $n_from - $endskip; $xi++) {
-                       $xhash[$this->_line_hash($from_lines[$xi])] = 1;
-               }
+       const MAX_XREF_LENGTH =  10000;
 
-               for ($yi = $skip; $yi < $n_to - $endskip; $yi++) {
-                       $line = $to_lines[$yi];
-                       if ( ($this->ychanged[$yi] = empty($xhash[$this->_line_hash($line)])) )
-                               continue;
-                       $yhash[$this->_line_hash($line)] = 1;
-                       $this->yv[] = $line;
-                       $this->yind[] = $yi;
-               }
-               for ($xi = $skip; $xi < $n_from - $endskip; $xi++) {
-                       $line = $from_lines[$xi];
-                       if ( ($this->xchanged[$xi] = empty($yhash[$this->_line_hash($line)])) )
-                               continue;
-                       $this->xv[] = $line;
-                       $this->xind[] = $xi;
-               }
+       function diff ($from_lines, $to_lines){
+               wfProfileIn( __METHOD__ );
 
-               // Find the LCS.
-               $this->_compareseq(0, sizeof($this->xv), 0, sizeof($this->yv));
+               // Diff and store locally
+               $this->diff_local($from_lines, $to_lines);
 
                // Merge edits when possible
                $this->_shift_boundaries($from_lines, $this->xchanged, $this->ychanged);
                $this->_shift_boundaries($to_lines, $this->ychanged, $this->xchanged);
 
                // Compute the edit operations.
+               $n_from = sizeof($from_lines);
+               $n_to = sizeof($to_lines);
+
                $edits = array();
                $xi = $yi = 0;
                while ($xi < $n_from || $yi < $n_to) {
@@ -968,33 +1008,96 @@ class _DiffEngine
                        // Skip matching "snake".
                        $copy = array();
                        while ( $xi < $n_from && $yi < $n_to
-                                       && !$this->xchanged[$xi] && !$this->ychanged[$yi]) {
+                       && !$this->xchanged[$xi] && !$this->ychanged[$yi]) {
                                $copy[] = $from_lines[$xi++];
                                ++$yi;
                        }
                        if ($copy)
-                               $edits[] = new _DiffOp_Copy($copy);
+                       $edits[] = new _DiffOp_Copy($copy);
 
                        // Find deletes & adds.
                        $delete = array();
                        while ($xi < $n_from && $this->xchanged[$xi])
-                               $delete[] = $from_lines[$xi++];
+                       $delete[] = $from_lines[$xi++];
 
                        $add = array();
                        while ($yi < $n_to && $this->ychanged[$yi])
-                               $add[] = $to_lines[$yi++];
+                       $add[] = $to_lines[$yi++];
 
                        if ($delete && $add)
-                               $edits[] = new _DiffOp_Change($delete, $add);
+                       $edits[] = new _DiffOp_Change($delete, $add);
                        elseif ($delete)
-                               $edits[] = new _DiffOp_Delete($delete);
+                       $edits[] = new _DiffOp_Delete($delete);
                        elseif ($add)
-                               $edits[] = new _DiffOp_Add($add);
+                       $edits[] = new _DiffOp_Add($add);
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $edits;
        }
 
+       function diff_local ($from_lines, $to_lines) {
+               global $wgExternalDiffEngine;
+               wfProfileIn( __METHOD__);
+
+               if($wgExternalDiffEngine == 'wikidiff3'){
+                       // wikidiff3
+                       $wikidiff3 = new WikiDiff3();
+                       $wikidiff3->diff($from_lines, $to_lines);
+                       $this->xchanged = $wikidiff3->removed;
+                       $this->ychanged = $wikidiff3->added;
+                       unset($wikidiff3);
+               }else{
+                       // old diff
+                       $n_from = sizeof($from_lines);
+                       $n_to = sizeof($to_lines);
+                       $this->xchanged = $this->ychanged = array();
+                       $this->xv = $this->yv = array();
+                       $this->xind = $this->yind = array();
+                       unset($this->seq);
+                       unset($this->in_seq);
+                       unset($this->lcs);
+
+                       // Skip leading common lines.
+                       for ($skip = 0; $skip < $n_from && $skip < $n_to; $skip++) {
+                               if ($from_lines[$skip] !== $to_lines[$skip])
+                               break;
+                               $this->xchanged[$skip] = $this->ychanged[$skip] = false;
+                       }
+                       // Skip trailing common lines.
+                       $xi = $n_from; $yi = $n_to;
+                       for ($endskip = 0; --$xi > $skip && --$yi > $skip; $endskip++) {
+                               if ($from_lines[$xi] !== $to_lines[$yi])
+                               break;
+                               $this->xchanged[$xi] = $this->ychanged[$yi] = false;
+                       }
+
+                       // Ignore lines which do not exist in both files.
+                       for ($xi = $skip; $xi < $n_from - $endskip; $xi++) {
+                               $xhash[$this->_line_hash($from_lines[$xi])] = 1;
+                       }
+
+                       for ($yi = $skip; $yi < $n_to - $endskip; $yi++) {
+                               $line = $to_lines[$yi];
+                               if ( ($this->ychanged[$yi] = empty($xhash[$this->_line_hash($line)])) )
+                               continue;
+                               $yhash[$this->_line_hash($line)] = 1;
+                               $this->yv[] = $line;
+                               $this->yind[] = $yi;
+                       }
+                       for ($xi = $skip; $xi < $n_from - $endskip; $xi++) {
+                               $line = $from_lines[$xi];
+                               if ( ($this->xchanged[$xi] = empty($yhash[$this->_line_hash($line)])) )
+                               continue;
+                               $this->xv[] = $line;
+                               $this->xind[] = $xi;
+                       }
+
+                       // Find the LCS.
+                       $this->_compareseq(0, sizeof($this->xv), 0, sizeof($this->yv));
+               }
+               wfProfileOut( __METHOD__ );
+       }
+
        /**
         * Returns the whole line if it's small enough, or the MD5 hash otherwise
         */
@@ -1006,7 +1109,6 @@ class _DiffEngine
                }
        }
 
-
        /* Divide the Largest Common Subsequence (LCS) of the sequences
         * [XOFF, XLIM) and [YOFF, YLIM) into NCHUNKS approximately equally
         * sized segments.
@@ -1024,24 +1126,22 @@ class _DiffEngine
         * of the portions it is going to specify.
         */
        function _diag ($xoff, $xlim, $yoff, $ylim, $nchunks) {
-               $fname = '_DiffEngine::_diag';
-               wfProfileIn( $fname );
                $flip = false;
 
                if ($xlim - $xoff > $ylim - $yoff) {
                        // Things seems faster (I'm not sure I understand why)
-                               // when the shortest sequence in X.
-                               $flip = true;
+                       // when the shortest sequence in X.
+                       $flip = true;
                        list ($xoff, $xlim, $yoff, $ylim)
                        = array( $yoff, $ylim, $xoff, $xlim);
                }
 
                if ($flip)
-                       for ($i = $ylim - 1; $i >= $yoff; $i--)
-                               $ymatches[$this->xv[$i]][] = $i;
+               for ($i = $ylim - 1; $i >= $yoff; $i--)
+               $ymatches[$this->xv[$i]][] = $i;
                else
-                       for ($i = $ylim - 1; $i >= $yoff; $i--)
-                               $ymatches[$this->yv[$i]][] = $i;
+               for ($i = $ylim - 1; $i >= $yoff; $i--)
+               $ymatches[$this->yv[$i]][] = $i;
 
                $this->lcs = 0;
                $this->seq[0]= $yoff - 1;
@@ -1051,25 +1151,24 @@ class _DiffEngine
                $numer = $xlim - $xoff + $nchunks - 1;
                $x = $xoff;
                for ($chunk = 0; $chunk < $nchunks; $chunk++) {
-                       wfProfileIn( "$fname-chunk" );
                        if ($chunk > 0)
-                               for ($i = 0; $i <= $this->lcs; $i++)
-                                       $ymids[$i][$chunk-1] = $this->seq[$i];
+                       for ($i = 0; $i <= $this->lcs; $i++)
+                       $ymids[$i][$chunk-1] = $this->seq[$i];
 
                        $x1 = $xoff + (int)(($numer + ($xlim-$xoff)*$chunk) / $nchunks);
                        for ( ; $x < $x1; $x++) {
                                $line = $flip ? $this->yv[$x] : $this->xv[$x];
-                                       if (empty($ymatches[$line]))
-                                               continue;
+                               if (empty($ymatches[$line]))
+                               continue;
                                $matches = $ymatches[$line];
                                reset($matches);
                                while (list ($junk, $y) = each($matches))
-                                       if (empty($this->in_seq[$y])) {
-                                               $k = $this->_lcs_pos($y);
-                                               USE_ASSERTS && assert($k > 0);
-                                               $ymids[$k] = $ymids[$k-1];
-                                               break;
-                                       }
+                               if (empty($this->in_seq[$y])) {
+                                       $k = $this->_lcs_pos($y);
+                                       USE_ASSERTS && assert($k > 0);
+                                       $ymids[$k] = $ymids[$k-1];
+                                       break;
+                               }
                                while (list ( /* $junk */, $y) = each($matches)) {
                                        if ($y > $this->seq[$k-1]) {
                                                USE_ASSERTS && assert($y < $this->seq[$k]);
@@ -1085,7 +1184,6 @@ class _DiffEngine
                                        }
                                }
                        }
-                       wfProfileOut( "$fname-chunk" );
                }
 
                $seps[] = $flip ? array($yoff, $xoff) : array($xoff, $yoff);
@@ -1097,19 +1195,14 @@ class _DiffEngine
                }
                $seps[] = $flip ? array($ylim, $xlim) : array($xlim, $ylim);
 
-               wfProfileOut( $fname );
                return array($this->lcs, $seps);
        }
 
        function _lcs_pos ($ypos) {
-               $fname = '_DiffEngine::_lcs_pos';
-               wfProfileIn( $fname );
-
                $end = $this->lcs;
                if ($end == 0 || $ypos > $this->seq[$end]) {
                        $this->seq[++$this->lcs] = $ypos;
                        $this->in_seq[$ypos] = 1;
-                       wfProfileOut( $fname );
                        return $this->lcs;
                }
 
@@ -1117,9 +1210,9 @@ class _DiffEngine
                while ($beg < $end) {
                        $mid = (int)(($beg + $end) / 2);
                        if ( $ypos > $this->seq[$mid] )
-                               $beg = $mid + 1;
+                       $beg = $mid + 1;
                        else
-                               $end = $mid;
+                       $end = $mid;
                }
 
                USE_ASSERTS && assert($ypos != $this->seq[$end]);
@@ -1127,7 +1220,6 @@ class _DiffEngine
                $this->in_seq[$this->seq[$end]] = false;
                $this->seq[$end] = $ypos;
                $this->in_seq[$ypos] = 1;
-               wfProfileOut( $fname );
                return $end;
        }
 
@@ -1143,25 +1235,22 @@ class _DiffEngine
         * All line numbers are origin-0 and discarded lines are not counted.
         */
        function _compareseq ($xoff, $xlim, $yoff, $ylim) {
-               $fname = '_DiffEngine::_compareseq';
-               wfProfileIn( $fname );
-
                // Slide down the bottom initial diagonal.
                while ($xoff < $xlim && $yoff < $ylim
-                          && $this->xv[$xoff] == $this->yv[$yoff]) {
+               && $this->xv[$xoff] == $this->yv[$yoff]) {
                        ++$xoff;
                        ++$yoff;
                }
 
                // Slide up the top initial diagonal.
                while ($xlim > $xoff && $ylim > $yoff
-                          && $this->xv[$xlim - 1] == $this->yv[$ylim - 1]) {
+               && $this->xv[$xlim - 1] == $this->yv[$ylim - 1]) {
                        --$xlim;
                        --$ylim;
                }
 
                if ($xoff == $xlim || $yoff == $ylim)
-                       $lcs = 0;
+               $lcs = 0;
                else {
                        // This is ad hoc but seems to work well.
                        //$nchunks = sqrt(min($xlim - $xoff, $ylim - $yoff) / 2.5);
@@ -1175,9 +1264,9 @@ class _DiffEngine
                        // X and Y sequences have no common subsequence:
                        // mark all changed.
                        while ($yoff < $ylim)
-                               $this->ychanged[$this->yind[$yoff++]] = 1;
+                       $this->ychanged[$this->yind[$yoff++]] = 1;
                        while ($xoff < $xlim)
-                               $this->xchanged[$this->xind[$xoff++]] = 1;
+                       $this->xchanged[$this->xind[$xoff++]] = 1;
                } else {
                        // Use the partitions to split this problem into subproblems.
                        reset($seps);
@@ -1187,7 +1276,6 @@ class _DiffEngine
                                $pt1 = $pt2;
                        }
                }
-               wfProfileOut( $fname );
        }
 
        /* Adjust inserts/deletes of identical lines to join changes
@@ -1203,8 +1291,7 @@ class _DiffEngine
         * This is extracted verbatim from analyze.c (GNU diffutils-2.7).
         */
        function _shift_boundaries ($lines, &$changed, $other_changed) {
-               $fname = '_DiffEngine::_shift_boundaries';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
                $i = 0;
                $j = 0;
 
@@ -1225,23 +1312,23 @@ class _DiffEngine
                         * $other_changed[$j] == false.
                         */
                        while ($j < $other_len && $other_changed[$j])
-                               $j++;
+                       $j++;
 
                        while ($i < $len && ! $changed[$i]) {
                                USE_ASSERTS && assert('$j < $other_len && ! $other_changed[$j]');
                                $i++; $j++;
                                while ($j < $other_len && $other_changed[$j])
-                                       $j++;
+                               $j++;
                        }
 
                        if ($i == $len)
-                               break;
+                       break;
 
                        $start = $i;
 
                        // Find the end of this run of changes.
                        while (++$i < $len && $changed[$i])
-                               continue;
+                       continue;
 
                        do {
                                /*
@@ -1259,10 +1346,10 @@ class _DiffEngine
                                        $changed[--$start] = 1;
                                        $changed[--$i] = false;
                                        while ($start > 0 && $changed[$start - 1])
-                                               $start--;
+                                       $start--;
                                        USE_ASSERTS && assert('$j > 0');
                                        while ($other_changed[--$j])
-                                               continue;
+                                       continue;
                                        USE_ASSERTS && assert('$j >= 0 && !$other_changed[$j]');
                                }
 
@@ -1284,14 +1371,14 @@ class _DiffEngine
                                        $changed[$start++] = false;
                                        $changed[$i++] = 1;
                                        while ($i < $len && $changed[$i])
-                                               $i++;
+                                       $i++;
 
                                        USE_ASSERTS && assert('$j < $other_len && ! $other_changed[$j]');
                                        $j++;
                                        if ($j < $other_len && $other_changed[$j]) {
                                                $corresponding = $i;
                                                while ($j < $other_len && $other_changed[$j])
-                                                       $j++;
+                                               $j++;
                                        }
                                }
                        } while ($runlength != $i - $start);
@@ -1305,11 +1392,11 @@ class _DiffEngine
                                $changed[--$i] = 0;
                                USE_ASSERTS && assert('$j > 0');
                                while ($other_changed[--$j])
-                                       continue;
+                               continue;
                                USE_ASSERTS && assert('$j >= 0 && !$other_changed[$j]');
                        }
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 }
 
@@ -1317,7 +1404,7 @@ class _DiffEngine
  * Class representing a 'diff' between two sequences of strings.
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class Diff
 {
@@ -1364,7 +1451,7 @@ class Diff
        function isEmpty () {
                foreach ($this->edits as $edit) {
                        if ($edit->type != 'copy')
-                               return false;
+                       return false;
                }
                return true;
        }
@@ -1380,7 +1467,7 @@ class Diff
                $lcs = 0;
                foreach ($this->edits as $edit) {
                        if ($edit->type == 'copy')
-                               $lcs += sizeof($edit->orig);
+                       $lcs += sizeof($edit->orig);
                }
                return $lcs;
        }
@@ -1398,7 +1485,7 @@ class Diff
 
                foreach ($this->edits as $edit) {
                        if ($edit->orig)
-                               array_splice($lines, sizeof($lines), 0, $edit->orig);
+                       array_splice($lines, sizeof($lines), 0, $edit->orig);
                }
                return $lines;
        }
@@ -1416,7 +1503,7 @@ class Diff
 
                foreach ($this->edits as $edit) {
                        if ($edit->closing)
-                               array_splice($lines, sizeof($lines), 0, $edit->closing);
+                       array_splice($lines, sizeof($lines), 0, $edit->closing);
                }
                return $lines;
        }
@@ -1427,37 +1514,36 @@ class Diff
         * This is here only for debugging purposes.
         */
        function _check ($from_lines, $to_lines) {
-               $fname = 'Diff::_check';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
                if (serialize($from_lines) != serialize($this->orig()))
-                       trigger_error("Reconstructed original doesn't match", E_USER_ERROR);
+               trigger_error("Reconstructed original doesn't match", E_USER_ERROR);
                if (serialize($to_lines) != serialize($this->closing()))
-                       trigger_error("Reconstructed closing doesn't match", E_USER_ERROR);
+               trigger_error("Reconstructed closing doesn't match", E_USER_ERROR);
 
                $rev = $this->reverse();
                if (serialize($to_lines) != serialize($rev->orig()))
-                       trigger_error("Reversed original doesn't match", E_USER_ERROR);
+               trigger_error("Reversed original doesn't match", E_USER_ERROR);
                if (serialize($from_lines) != serialize($rev->closing()))
-                       trigger_error("Reversed closing doesn't match", E_USER_ERROR);
+               trigger_error("Reversed closing doesn't match", E_USER_ERROR);
 
 
                $prevtype = 'none';
                foreach ($this->edits as $edit) {
                        if ( $prevtype == $edit->type )
-                               trigger_error("Edit sequence is non-optimal", E_USER_ERROR);
+                       trigger_error("Edit sequence is non-optimal", E_USER_ERROR);
                        $prevtype = $edit->type;
                }
 
                $lcs = $this->lcs();
                trigger_error('Diff okay: LCS = '.$lcs, E_USER_NOTICE);
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 }
 
 /**
  * @todo document, bad name.
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class MappedDiff extends Diff
 {
@@ -1485,9 +1571,8 @@ class MappedDiff extends Diff
         *      have the same number of elements as $to_lines.
         */
        function MappedDiff($from_lines, $to_lines,
-                                               $mapped_from_lines, $mapped_to_lines) {
-               $fname = 'MappedDiff::MappedDiff';
-               wfProfileIn( $fname );
+       $mapped_from_lines, $mapped_to_lines) {
+               wfProfileIn( __METHOD__ );
 
                assert(sizeof($from_lines) == sizeof($mapped_from_lines));
                assert(sizeof($to_lines) == sizeof($mapped_to_lines));
@@ -1508,7 +1593,7 @@ class MappedDiff extends Diff
                                $yi += sizeof($closing);
                        }
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 }
 
@@ -1520,10 +1605,9 @@ class MappedDiff extends Diff
  * to obtain fancier outputs.
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
-class DiffFormatter
-{
+class DiffFormatter {
        /**
         * Number of leading context "lines" to preserve.
         *
@@ -1547,8 +1631,7 @@ class DiffFormatter
         * @return string The formatted output.
         */
        function format($diff) {
-               $fname = 'DiffFormatter::format';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $xi = $yi = 1;
                $block = false;
@@ -1571,8 +1654,8 @@ class DiffFormatter
                                                        $block[] = new _DiffOp_Copy($context);
                                                }
                                                $this->_block($x0, $ntrail + $xi - $x0,
-                                                                         $y0, $ntrail + $yi - $y0,
-                                                                         $block);
+                                               $y0, $ntrail + $yi - $y0,
+                                               $block);
                                                $block = false;
                                        }
                                }
@@ -1585,45 +1668,44 @@ class DiffFormatter
                                        $y0 = $yi - sizeof($context);
                                        $block = array();
                                        if ($context)
-                                               $block[] = new _DiffOp_Copy($context);
+                                       $block[] = new _DiffOp_Copy($context);
                                }
                                $block[] = $edit;
                        }
 
                        if ($edit->orig)
-                               $xi += sizeof($edit->orig);
+                       $xi += sizeof($edit->orig);
                        if ($edit->closing)
-                               $yi += sizeof($edit->closing);
+                       $yi += sizeof($edit->closing);
                }
 
                if (is_array($block))
-                       $this->_block($x0, $xi - $x0,
-                                                 $y0, $yi - $y0,
-                                                 $block);
+               $this->_block($x0, $xi - $x0,
+               $y0, $yi - $y0,
+               $block);
 
                $end = $this->_end_diff();
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $end;
        }
 
        function _block($xbeg, $xlen, $ybeg, $ylen, &$edits) {
-               $fname = 'DiffFormatter::_block';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
                $this->_start_block($this->_block_header($xbeg, $xlen, $ybeg, $ylen));
                foreach ($edits as $edit) {
                        if ($edit->type == 'copy')
-                               $this->_context($edit->orig);
+                       $this->_context($edit->orig);
                        elseif ($edit->type == 'add')
-                               $this->_added($edit->closing);
+                       $this->_added($edit->closing);
                        elseif ($edit->type == 'delete')
-                               $this->_deleted($edit->orig);
+                       $this->_deleted($edit->orig);
                        elseif ($edit->type == 'change')
-                               $this->_changed($edit->orig, $edit->closing);
+                       $this->_changed($edit->orig, $edit->closing);
                        else
-                               trigger_error('Unknown edit type', E_USER_ERROR);
+                       trigger_error('Unknown edit type', E_USER_ERROR);
                }
                $this->_end_block();
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 
        function _start_diff() {
@@ -1638,9 +1720,9 @@ class DiffFormatter
 
        function _block_header($xbeg, $xlen, $ybeg, $ylen) {
                if ($xlen > 1)
-                       $xbeg .= "," . ($xbeg + $xlen - 1);
+               $xbeg .= "," . ($xbeg + $xlen - 1);
                if ($ylen > 1)
-                       $ybeg .= "," . ($ybeg + $ylen - 1);
+               $ybeg .= "," . ($ybeg + $ylen - 1);
 
                return $xbeg . ($xlen ? ($ylen ? 'c' : 'd') : 'a') . $ybeg;
        }
@@ -1654,7 +1736,7 @@ class DiffFormatter
 
        function _lines($lines, $prefix = ' ') {
                foreach ($lines as $line)
-                       echo "$prefix $line\n";
+               echo "$prefix $line\n";
        }
 
        function _context($lines) {
@@ -1677,14 +1759,13 @@ class DiffFormatter
 
 /**
  * A formatter that outputs unified diffs
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 
-class UnifiedDiffFormatter extends DiffFormatter
-{
+class UnifiedDiffFormatter extends DiffFormatter {
        var $leading_context_lines = 2;
        var $trailing_context_lines = 2;
-       
+
        function _added($lines) {
                $this->_lines($lines, '+');
        }
@@ -1702,56 +1783,50 @@ class UnifiedDiffFormatter extends DiffFormatter
 
 /**
  * A pseudo-formatter that just passes along the Diff::$edits array
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
-class ArrayDiffFormatter extends DiffFormatter
-{
-       function format($diff)
-       {
+class ArrayDiffFormatter extends DiffFormatter {
+       function format($diff) {
                $oldline = 1;
                $newline = 1;
                $retval = array();
                foreach($diff->edits as $edit)
-                       switch($edit->type)
-                       {
-                               case 'add':
-                                       foreach($edit->closing as $l)
-                                       {
-                                               $retval[] = array(
+               switch($edit->type) {
+                       case 'add':
+                               foreach($edit->closing as $l) {
+                                       $retval[] = array(
                                                        'action' => 'add',
                                                        'new'=> $l,
                                                        'newline' => $newline++
-                                               );
-                                       }
-                                       break;
-                               case 'delete':
-                                       foreach($edit->orig as $l)
-                                       {
-                                               $retval[] = array(
+                                       );
+                               }
+                               break;
+                       case 'delete':
+                               foreach($edit->orig as $l) {
+                                       $retval[] = array(
                                                        'action' => 'delete',
                                                        'old' => $l,
                                                        'oldline' => $oldline++,
-                                               );
-                                       }
-                                       break;
-                               case 'change':
-                                       foreach($edit->orig as $i => $l)
-                                       {
-                                               $retval[] = array(
+                                       );
+                               }
+                               break;
+                       case 'change':
+                               foreach($edit->orig as $i => $l) {
+                                       $retval[] = array(
                                                        'action' => 'change',
                                                        'old' => $l,
                                                        'new' => @$edit->closing[$i],
                                                        'oldline' => $oldline++,
                                                        'newline' => $newline++,
-                                               );
-                                       }
-                                       break;
-                               case 'copy':
-                                       $oldline += count($edit->orig);
-                                       $newline += count($edit->orig);
-                       }
+                                       );
+                               }
+                               break;
+                       case 'copy':
+                               $oldline += count($edit->orig);
+                               $newline += count($edit->orig);
+               }
                return $retval;
-       }                       
+       }
 }
 
 /**
@@ -1759,12 +1834,12 @@ class ArrayDiffFormatter extends DiffFormatter
  *
  */
 
-define('NBSP', '&#160;');                      // iso-8859-x non-breaking space.
+define('NBSP', '&#160;'); // iso-8859-x non-breaking space.
 
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
 class _HWLDF_WordAccumulator {
        function _HWLDF_WordAccumulator () {
@@ -1777,13 +1852,13 @@ class _HWLDF_WordAccumulator {
        function _flushGroup ($new_tag) {
                if ($this->_group !== '') {
                        if ($this->_tag == 'ins')
-                               $this->_line .= '<ins class="diffchange">' .
-                                       htmlspecialchars ( $this->_group ) . '</ins>';
+                       $this->_line .= '<ins class="diffchange diffchange-inline">' .
+                       htmlspecialchars ( $this->_group ) . '</ins>';
                        elseif ($this->_tag == 'del')
-                               $this->_line .= '<del class="diffchange">' .
-                                       htmlspecialchars ( $this->_group ) . '</del>';
+                       $this->_line .= '<del class="diffchange diffchange-inline">' .
+                       htmlspecialchars ( $this->_group ) . '</del>';
                        else
-                               $this->_line .= htmlspecialchars ( $this->_group );
+                       $this->_line .= htmlspecialchars ( $this->_group );
                }
                $this->_group = '';
                $this->_tag = $new_tag;
@@ -1792,21 +1867,21 @@ class _HWLDF_WordAccumulator {
        function _flushLine ($new_tag) {
                $this->_flushGroup($new_tag);
                if ($this->_line != '')
-                       array_push ( $this->_lines, $this->_line );
+               array_push ( $this->_lines, $this->_line );
                else
-                       # make empty lines visible by inserting an NBSP
-                       array_push ( $this->_lines, NBSP );
+               # make empty lines visible by inserting an NBSP
+               array_push ( $this->_lines, NBSP );
                $this->_line = '';
        }
 
        function addWords ($words, $tag = '') {
                if ($tag != $this->_tag)
-                       $this->_flushGroup($tag);
+               $this->_flushGroup($tag);
 
                foreach ($words as $word) {
                        // new-line should only come as first char of word.
                        if ($word == '')
-                               continue;
+                       continue;
                        if ($word[0] == "\n") {
                                $this->_flushLine($tag);
                                $word = substr($word, 1);
@@ -1825,27 +1900,24 @@ class _HWLDF_WordAccumulator {
 /**
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
-class WordLevelDiff extends MappedDiff
-{
+class WordLevelDiff extends MappedDiff {
        const MAX_LINE_LENGTH = 10000;
 
        function WordLevelDiff ($orig_lines, $closing_lines) {
-               $fname = 'WordLevelDiff::WordLevelDiff';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                list ($orig_words, $orig_stripped) = $this->_split($orig_lines);
                list ($closing_words, $closing_stripped) = $this->_split($closing_lines);
 
                $this->MappedDiff($orig_words, $closing_words,
-                                                 $orig_stripped, $closing_stripped);
-               wfProfileOut( $fname );
+               $orig_stripped, $closing_stripped);
+               wfProfileOut( __METHOD__ );
        }
 
        function _split($lines) {
-               $fname = 'WordLevelDiff::_split';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $words = array();
                $stripped = array();
@@ -1865,63 +1937,67 @@ class WordLevelDiff extends MappedDiff
                        } else {
                                $m = array();
                                if (preg_match_all('/ ( [^\S\n]+ | [0-9_A-Za-z\x80-\xff]+ | . ) (?: (?!< \n) [^\S\n])? /xs',
-                                       $line, $m))
+                               $line, $m))
                                {
                                        $words = array_merge( $words, $m[0] );
                                        $stripped = array_merge( $stripped, $m[1] );
                                }
                        }
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return array($words, $stripped);
        }
 
        function orig () {
-               $fname = 'WordLevelDiff::orig';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
                $orig = new _HWLDF_WordAccumulator;
 
                foreach ($this->edits as $edit) {
                        if ($edit->type == 'copy')
-                               $orig->addWords($edit->orig);
+                       $orig->addWords($edit->orig);
                        elseif ($edit->orig)
-                               $orig->addWords($edit->orig, 'del');
+                       $orig->addWords($edit->orig, 'del');
                }
                $lines = $orig->getLines();
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $lines;
        }
 
        function closing () {
-               $fname = 'WordLevelDiff::closing';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
                $closing = new _HWLDF_WordAccumulator;
 
                foreach ($this->edits as $edit) {
                        if ($edit->type == 'copy')
-                               $closing->addWords($edit->closing);
+                       $closing->addWords($edit->closing);
                        elseif ($edit->closing)
-                               $closing->addWords($edit->closing, 'ins');
+                       $closing->addWords($edit->closing, 'ins');
                }
                $lines = $closing->getLines();
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $lines;
        }
 }
 
 /**
- *     Wikipedia Table style diff formatter.
+ * Wikipedia Table style diff formatter.
  * @todo document
  * @private
- * @addtogroup DifferenceEngine
+ * @ingroup DifferenceEngine
  */
-class TableDiffFormatter extends DiffFormatter
-{
+class TableDiffFormatter extends DiffFormatter {
        function TableDiffFormatter() {
                $this->leading_context_lines = 2;
                $this->trailing_context_lines = 2;
        }
 
+       public static function escapeWhiteSpace( $msg ) {
+               $msg = preg_replace( '/^ /m', '&nbsp; ', $msg );
+               $msg = preg_replace( '/ $/m', ' &nbsp;', $msg );
+               $msg = preg_replace( '/  /', '&nbsp; ', $msg );
+               return $msg;
+       }
+
        function _block_header( $xbeg, $xlen, $ybeg, $ylen ) {
                $r = '<tr><td colspan="2" class="diff-lineno"><!--LINE '.$xbeg."--></td>\n" .
                  '<td colspan="2" class="diff-lineno"><!--LINE '.$ybeg."--></td></tr>\n";
@@ -1952,11 +2028,11 @@ class TableDiffFormatter extends DiffFormatter
        function contextLine( $line ) {
                return $this->wrapLine( ' ', 'diff-context', $line );
        }
-       
+
        private function wrapLine( $marker, $class, $line ) {
                if( $line !== '' ) {
                        // The <div> wrapper is needed for 'overflow: auto' style to scroll properly
-                       $line = "<div>$line</div>";
+                       $line = Xml::tags( 'div', null, $this->escapeWhiteSpace( $line ) );
                }
                return "<td class='diff-marker'>$marker</td><td class='$class'>$line</td>";
        }
@@ -1968,30 +2044,29 @@ class TableDiffFormatter extends DiffFormatter
        function _added( $lines ) {
                foreach ($lines as $line) {
                        echo '<tr>' . $this->emptyLine() .
-                               $this->addedLine( '<ins class="diffchange">' .
-                                       htmlspecialchars ( $line ) . '</ins>' ) . "</tr>\n";
+                       $this->addedLine( '<ins class="diffchange">' .
+                       htmlspecialchars ( $line ) . '</ins>' ) . "</tr>\n";
                }
        }
 
        function _deleted($lines) {
                foreach ($lines as $line) {
                        echo '<tr>' . $this->deletedLine( '<del class="diffchange">' .
-                               htmlspecialchars ( $line ) . '</del>' ) .
-                         $this->emptyLine() . "</tr>\n";
+                       htmlspecialchars ( $line ) . '</del>' ) .
+                       $this->emptyLine() . "</tr>\n";
                }
        }
 
        function _context( $lines ) {
                foreach ($lines as $line) {
                        echo '<tr>' .
-                               $this->contextLine( htmlspecialchars ( $line ) ) .
-                               $this->contextLine( htmlspecialchars ( $line ) ) . "</tr>\n";
+                       $this->contextLine( htmlspecialchars ( $line ) ) .
+                       $this->contextLine( htmlspecialchars ( $line ) ) . "</tr>\n";
                }
        }
 
        function _changed( $orig, $closing ) {
-               $fname = 'TableDiffFormatter::_changed';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $diff = new WordLevelDiff( $orig, $closing );
                $del = $diff->orig();
@@ -2003,15 +2078,12 @@ class TableDiffFormatter extends DiffFormatter
                while ( $line = array_shift( $del ) ) {
                        $aline = array_shift( $add );
                        echo '<tr>' . $this->deletedLine( $line ) .
-                               $this->addedLine( $aline ) . "</tr>\n";
+                       $this->addedLine( $aline ) . "</tr>\n";
                }
                foreach ($add as $line) {       # If any leftovers
                        echo '<tr>' . $this->emptyLine() .
-                               $this->addedLine( $line ) . "</tr>\n";
+                       $this->addedLine( $line ) . "</tr>\n";
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
-}
-
-
-
+}
\ No newline at end of file