Fix a race condition in classic edit toolbar setup

[lhc/web/wiklou.git] / includes / ChangesFeed.php

diff --git a/includes/ChangesFeed.php b/includes/ChangesFeed.php
index 23fb923..bcedf2f 100644 (file)
--- a/includes/ChangesFeed.php
+++ b/includes/ChangesFeed.php
@@ -34,6 +34,11 @@ class ChangesFeed {
                        return false;
                }
 
+               if( !array_key_exists( $this->format, $wgFeedClasses ) ) {
+                       // falling back to atom
+                       $this->format = 'atom';
+               }
+
                $feedTitle = "$wgSitename  - {$title} [$wgLanguageCode]";
                return new $wgFeedClasses[$this->format](
                        $feedTitle, htmlspecialchars( $description ), $url );
@@ -61,11 +66,11 @@ class ChangesFeed {
 
                FeedUtils::checkPurge( $timekey, $key );
 
-               /*
-               * Bumping around loading up diffs can be pretty slow, so where
-               * possible we want to cache the feed output so the next visitor
-               * gets it quick too.
-               */
+               /**
+                * Bumping around loading up diffs can be pretty slow, so where
+                * possible we want to cache the feed output so the next visitor
+                * gets it quick too.
+                */
                $cachedFeed = $this->loadFromCache( $lastmod, $timekey, $key );
                if( is_string( $cachedFeed ) ) {
                        wfDebug( "RC: Outputting cached feed\n" );
@@ -110,12 +115,12 @@ class ChangesFeed {
                $feedLastmod = $messageMemc->get( $timekey );
 
                if( ( $wgFeedCacheTimeout > 0 ) && $feedLastmod ) {
-                       /*
-                       * If the cached feed was rendered very recently, we may
-                       * go ahead and use it even if there have been edits made
-                       * since it was rendered. This keeps a swarm of requests
-                       * from being too bad on a super-frequently edited wiki.
-                       */
+                   /**
+                        * If the cached feed was rendered very recently, we may
+                        * go ahead and use it even if there have been edits made
+                        * since it was rendered. This keeps a swarm of requests
+                        * from being too bad on a super-frequently edited wiki.
+                        */
 
                        $feedAge = time() - wfTimestamp( TS_UNIX, $feedLastmod );
                        $feedLastmodUnix = wfTimestamp( TS_UNIX, $feedLastmod );
@@ -149,6 +154,7 @@ class ChangesFeed {
                $n = 0;
                foreach( $rows as $obj ) {
                        if( $n > 0 &&
+                               $obj->rc_type == RC_EDIT &&
                                $obj->rc_namespace >= 0 &&
                                $obj->rc_cur_id == $sorted[$n-1]->rc_cur_id &&
                                $obj->rc_user_text == $sorted[$n-1]->rc_user_text ) {
@@ -164,10 +170,21 @@ class ChangesFeed {
                        $talkpage = MWNamespace::canTalk( $obj->rc_namespace ) ? $title->getTalkPage()->getFullUrl() : '';
                        // Skip items with deleted content (avoids partially complete/inconsistent output)
                        if( $obj->rc_deleted ) continue;
+
+                       if ( $obj->rc_this_oldid ) {
+                               $url = $title->getFullURL(
+                                       'diff=' . $obj->rc_this_oldid .
+                                       '&oldid=' . $obj->rc_last_oldid
+                               );
+                       } else {
+                               // log entry or something like that.
+                               $url = $title->getFullURL();
+                       }
+
                        $item = new FeedItem(
                                $title->getPrefixedText(),
                                FeedUtils::formatDiff( $obj ),
-                               $obj->rc_this_oldid ? $title->getFullURL( 'diff=' . $obj->rc_this_oldid . '&oldid=prev' ) : $title->getFullURL(),
+                               $url,
                                $obj->rc_timestamp,
                                ($obj->rc_deleted & Revision::DELETED_USER) ? wfMsgHtml('rev-deleted-user') : $obj->rc_user_text,
                                $talkpage