Use wfGetDB(DB_SLAVE) when appropriate. Changed deletion summary autogeneration to...
[lhc/web/wiklou.git] / includes / Article.php
index 47d091f..39c551a 100644 (file)
@@ -36,20 +36,22 @@ class Article {
        var $mOldId;
        var $mRevIdFetched;
        var $mRevision;
+       var $mRedirectUrl;
        /**#@-*/
 
        /**
         * Constructor and clear the article
-        * @param mixed &$title
+        * @param Title &$title
+        * @param integer $oldId Revision ID, null to fetch from request, zero for current
         */
-       function Article( &$title ) {
+       function Article( &$title, $oldId = null ) {
                $this->mTitle =& $title;
+               $this->mOldId = $oldId;
                $this->clear();
        }
 
        /**
         * get the title object of the article
-        * @public
         */
        function getTitle() {
                return $this->mTitle;
@@ -57,7 +59,7 @@ class Article {
 
        /**
          * Clear the object
-         * @private
+         * @access private
          */
        function clear() {
                $this->mDataLoaded    = false;
@@ -71,6 +73,7 @@ class Article {
                $this->mForUpdate = false;
                $this->mIsRedirect = false;
                $this->mRevIdFetched = 0;
+               $this->mRedirectUrl = false;
        }
 
        /**
@@ -105,8 +108,13 @@ class Article {
                        }
                        wfProfileOut( $fname );
                        $wgOut->setRobotpolicy( 'noindex,nofollow' );
-                       
-                       $ret = wfMsg( $wgUser->isLoggedIn() ? 'noarticletext' : 'noarticletextanon' );
+
+                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               $ret = wfMsgWeirdKey ( $this->mTitle->getText() ) ;
+                       } else {
+                               $ret = wfMsg( $wgUser->isLoggedIn() ? 'noarticletext' : 'noarticletextanon' );
+                       }
+
                        return "<div class='noarticletext'>$ret</div>";
                } else {
                        $this->loadContent( $noredir );
@@ -140,24 +148,33 @@ class Article {
        }
 
        /**
-               This function accepts a title string as parameter
-               ($preload). If this string is non-empty, it attempts
-               to fetch the current revision text. It respects
-               <includeonly>.
-       */
+        * Get the contents of a page from its title and remove includeonly tags
+        *
+        * TODO FIXME: This is only here because of the inputbox extension and
+        * should be moved there
+        *
+        * @deprecated
+        *
+        * @param string The title of the page
+        * @return string The contents of the page
+        */
        function getPreloadedText($preload) {
-               if($preload) {
-                       $preloadTitle=Title::newFromText($preload);
-                       if(isset($preloadTitle) && $preloadTitle->userCanRead()) {
-                       $rev=Revision::newFromTitle($preloadTitle);
-                       if($rev) {
-                               $text=$rev->getText();
-                               $text=preg_replace('/<\/?includeonly>/i','',$text);
-                               return $text;
-                               }
+               if ( $preload === '' )
+                       return '';
+               else {
+                       $preloadTitle = Title::newFromText( $preload );
+                       if ( isset( $preloadTitle ) && $preloadTitle->userCanRead() ) {
+                               $rev=Revision::newFromTitle($preloadTitle);
+                               if ( is_object( $rev ) ) {
+                                       $text = $rev->getText();
+                                       // TODO FIXME: AAAAAAAAAAA, this shouldn't be implementing
+                                       // its own mini-parser! -ævar
+                                       $text = preg_replace( '~</?includeonly>~', '', $text );
+                                       return $text;
+                               } else
+                                       return '';
                        }
                }
-               return '';
        }
 
        /**
@@ -185,14 +202,14 @@ class Article {
                # split it up by section
                $secs =
                  preg_split(
-                 '/(^=+.+?=+|^<h[1-6].*?' . '>.*?<\/h[1-6].*?' . '>)(?!\S)/mi',
+                 '/(^=+.+?=+|^<h[1-6].*?>.*?<\/h[1-6].*?>)(?!\S)/mi',
                  $striptext, -1,
                  PREG_SPLIT_DELIM_CAPTURE);
                if($section==0) {
                        $rv=$secs[0];
                } else {
                        $headline=$secs[$section*2-1];
-                       preg_match( '/^(=+).+?=+|^<h([1-6]).*?' . '>.*?<\/h[1-6].*?' . '>(?!\S)/mi',$headline,$matches);
+                       preg_match( '/^(=+).+?=+|^<h([1-6]).*?>.*?<\/h[1-6].*?>(?!\S)/mi',$headline,$matches);
                        $hlevel=$matches[1];
 
                        # translate wiki heading into level
@@ -207,7 +224,7 @@ class Article {
                        while(!empty($secs[$count*2-1]) && !$break) {
 
                                $subheadline=$secs[$count*2-1];
-                               preg_match( '/^(=+).+?=+|^<h([1-6]).*?' . '>.*?<\/h[1-6].*?' . '>(?!\S)/mi',$subheadline,$matches);
+                               preg_match( '/^(=+).+?=+|^<h([1-6]).*?>.*?<\/h[1-6].*?>(?!\S)/mi',$subheadline,$matches);
                                $subhlevel=$matches[1];
                                if(strpos($subhlevel,'=')!==false) {
                                        $subhlevel=strlen($subhlevel);
@@ -231,18 +248,24 @@ class Article {
        }
 
        /**
-        * Return the oldid of the article that is to be shown.
-        * For requests with a "direction", this is not the oldid of the
-        * query
+        * @return int The oldid of the article that is to be shown, 0 for the
+        *             current revision
         */
        function getOldID() {
-               global $wgRequest, $wgOut;
-               static $lastid;
-
-               if ( isset( $lastid ) ) {
-                       return $lastid;
+               if ( is_null( $this->mOldId ) ) {
+                       $this->mOldId = $this->getOldIDFromRequest();
                }
-               # Query variables :P
+               return $this->mOldId;
+       }
+
+       /**
+        * Sets $this->mRedirectUrl to a correct URL if the query parameters are incorrect
+        *
+        * @return int The old id for the request
+        */
+       function getOldIDFromRequest() {
+               global $wgRequest;
+               $this->mRedirectUrl = false;
                $oldid = $wgRequest->getVal( 'oldid' );
                if ( isset( $oldid ) ) {
                        $oldid = intval( $oldid );
@@ -251,7 +274,7 @@ class Article {
                                if ( $nextid  ) {
                                        $oldid = $nextid;
                                } else {
-                                       $wgOut->redirect( $this->mTitle->getFullURL( 'redirect=no' ) );
+                                       $this->mRedirectUrl = $this->mTitle->getFullURL( 'redirect=no' );
                                }
                        } elseif ( $wgRequest->getVal( 'direction' ) == 'prev' ) {
                                $previd = $this->mTitle->getPreviousRevisionID( $oldid );
@@ -263,12 +286,14 @@ class Article {
                        }
                        $lastid = $oldid;
                }
-               return @$oldid; # "@" to be able to return "unset" without PHP complaining
+               if ( !$oldid ) {
+                       $oldid = 0;
+               }
+               return $oldid;
        }
 
-
        /**
-        * Load the revision (including cur_text) into this object
+        * Load the revision (including text) into this object
         */
        function loadContent( $noredir = false ) {
                global $wgOut, $wgRequest;
@@ -321,15 +346,22 @@ class Article {
                return $row ;
        }
 
+       /**
+        * @param Database $dbr
+        * @param Title $title
+        */
        function pageDataFromTitle( &$dbr, $title ) {
                return $this->pageData( $dbr, array(
                        'page_namespace' => $title->getNamespace(),
                        'page_title'     => $title->getDBkey() ) );
        }
 
+       /**
+        * @param Database $dbr
+        * @param int $id
+        */
        function pageDataFromId( &$dbr, $id ) {
-               return $this->pageData( $dbr, array(
-                       'page_id' => intval( $id ) ) );
+               return $this->pageData( $dbr, array( 'page_id' => $id ) );
        }
 
        /**
@@ -343,12 +375,12 @@ class Article {
                $this->mTitle->loadRestrictions( $data->page_restrictions );
                $this->mTitle->mRestrictionsLoaded = true;
 
-               $this->mCounter    = $data->page_counter;
-               $this->mTouched    = wfTimestamp( TS_MW, $data->page_touched );
-               $this->mIsRedirect = $data->page_is_redirect;
-               $this->mLatest     = $data->page_latest;
+               $this->mCounter     = $data->page_counter;
+               $this->mTouched     = wfTimestamp( TS_MW, $data->page_touched );
+               $this->mIsRedirect  = $data->page_is_redirect;
+               $this->mLatest      = $data->page_latest;
 
-               $this->mDataLoaded = true;
+               $this->mDataLoaded  = true;
        }
 
        /**
@@ -362,6 +394,7 @@ class Article {
                if ( $this->mContentLoaded ) {
                        return $this->mContent;
                }
+
                $dbr =& $this->getDB();
                $fname = 'Article::fetchContent';
 
@@ -375,7 +408,7 @@ class Article {
                        $redirect = ($redirect == 'no') ? 'no' : 'yes';
                        $t .= ',redirect='.$redirect;
                }
-               $this->mContent = wfMsg( 'missingarticle', $t );
+               $this->mContent = wfMsg( 'missingarticle', $t ) ;
 
                if( $oldid ) {
                        $revision = Revision::newFromId( $oldid );
@@ -464,14 +497,19 @@ class Article {
                $this->mContentLoaded = true;
                $this->mRevision =& $revision;
 
+               wfRunHooks( 'ArticleAfterFetchContent', array( &$this, &$this->mContent ) ) ;
+
                return $this->mContent;
        }
 
        /**
         * Gets the article text without using so many damn globals
-        * Returns false on error
         *
-        * @param integer $oldid
+        * Used by maintenance/importLogs.php
+        *
+        * @param int $oldid
+        * @param bool $noredir Whether to follow redirects
+        * @return mixed the content (string) or false on error
         */
        function getContentWithoutUsingSoManyDamnGlobals( $oldid = 0, $noredir = false ) {
                return $this->fetchContent( $oldid, $noredir, false );
@@ -479,6 +517,8 @@ class Article {
 
        /**
         * Read/write accessor to select FOR UPDATE
+        *
+        * @param mixed $x
         */
        function forUpdate( $x = NULL ) {
                return wfSetVar( $this->mForUpdate, $x );
@@ -486,21 +526,20 @@ class Article {
 
        /**
         * Get the database which should be used for reads
+        *
+        * @return Database
         */
        function &getDB() {
                $ret =& wfGetDB( DB_MASTER );
                return $ret;
-               #if ( $this->mForUpdate ) {
-                       $ret =& wfGetDB( DB_MASTER );
-               #} else {
-               #       $ret =& wfGetDB( DB_SLAVE );
-               #}
-               return $ret;
        }
 
        /**
         * Get options for all SELECT statements
-        * Can pass an option array, to which the class-wide options will be appended
+        *
+        * @param array $options an optional options array which'll be appended to
+        *                       the default
+        * @return array Options
         */
        function getSelectOptions( $options = '' ) {
                if ( $this->mForUpdate ) {
@@ -514,7 +553,7 @@ class Article {
        }
 
        /**
-        * Return the Article ID
+        * @return int Page ID
         */
        function getID() {
                if( $this->mTitle ) {
@@ -525,20 +564,19 @@ class Article {
        }
 
        /**
-        * Returns true if this article exists in the database.
-        * @return bool
+        * @return bool Whether or not the page exists in the database
         */
        function exists() {
                return $this->getId() != 0;
        }
 
        /**
-        * Get the view count for this article
+        * @return int The view count for the page
         */
        function getCount() {
                if ( -1 == $this->mCounter ) {
                        $id = $this->getID();
-                       $dbr =& $this->getDB();
+                       $dbr =& wfGetDB( DB_SLAVE );
                        $this->mCounter = $dbr->selectField( 'page', 'page_counter', array( 'page_id' => $id ),
                                'Article::getCount', $this->getSelectOptions() );
                }
@@ -546,23 +584,27 @@ class Article {
        }
 
        /**
-        * Would the given text make this article a "good" article (i.e.,
-        * suitable for including in the article count)?
+        * Determine whether a page  would be suitable for being counted as an
+        * article in the site_stats table based on the title & its content
+        *
         * @param string $text Text to analyze
-        * @return integer 1 if it can be counted else 0
+        * @return bool
         */
        function isCountable( $text ) {
                global $wgUseCommaCount;
 
-               if ( NS_MAIN != $this->mTitle->getNamespace() ) { return 0; }
-               if ( $this->isRedirect( $text ) ) { return 0; }
-               $token = ($wgUseCommaCount ? ',' : '[[' );
-               if ( false === strstr( $text, $token ) ) { return 0; }
-               return 1;
+               $token = $wgUseCommaCount ? ',' : '[[';
+               return
+                       $this->mTitle->getNamespace() == NS_MAIN
+                       && ! $this->isRedirect( $text )
+                       && in_string( $token, $text );
        }
 
        /**
         * Tests if the article text represents a redirect
+        *
+        * @param string $text
+        * @return bool
         */
        function isRedirect( $text = false ) {
                if ( $text === false ) {
@@ -588,7 +630,7 @@ class Article {
        /**
         * Loads everything except the text
         * This isn't necessary for all uses, so it's only done if needed.
-        * @private
+        * @access private
         */
        function loadLastEdit() {
                global $wgOut;
@@ -607,6 +649,7 @@ class Article {
                        $this->mTimestamp = $this->mLastRevision->getTimestamp();
                        $this->mComment   = $this->mLastRevision->getComment();
                        $this->mMinorEdit = $this->mLastRevision->isMinor();
+                       $this->mRevIdFetched = $this->mLastRevision->getID();
                }
        }
 
@@ -647,7 +690,7 @@ class Article {
 
                $title = $this->mTitle;
                $contribs = array();
-               $dbr =& $this->getDB();
+               $dbr =& wfGetDB( DB_SLAVE );
                $revTable = $dbr->tableName( 'revision' );
                $userTable = $dbr->tableName( 'user' );
                $encDBkey = $dbr->addQuotes( $title->getDBkey() );
@@ -682,13 +725,22 @@ class Article {
        function view() {
                global $wgUser, $wgOut, $wgRequest, $wgOnlySysopsCanPatrol, $wgContLang;
                global $wgEnableParserCache, $wgStylePath, $wgUseRCPatrol, $wgParser;
-               global $wgParserCache, $wgUseTrackbacks;
+               global $wgUseTrackbacks;
                $sk = $wgUser->getSkin();
 
                $fname = 'Article::view';
                wfProfileIn( $fname );
+               $parserCache =& ParserCache::singleton();
                # Get variables from query string
                $oldid = $this->getOldID();
+
+               # getOldID may want us to redirect somewhere else
+               if ( $this->mRedirectUrl ) {
+                       $wgOut->redirect( $this->mRedirectUrl );
+                       wfProfileOut( $fname );
+                       return;
+               }
+
                $diff = $wgRequest->getVal( 'diff' );
                $rcid = $wgRequest->getVal( 'rcid' );
                $rdfrom = $wgRequest->getVal( 'rdfrom' );
@@ -716,7 +768,7 @@ class Article {
                }
 
                if ( empty( $oldid ) && $this->checkTouched() ) {
-                       $wgOut->setETag($wgParserCache->getETag($this, $wgUser));
+                       $wgOut->setETag($parserCache->getETag($this, $wgUser));
 
                        if( $wgOut->checkLastModified( $this->mTouched ) ){
                                wfProfileOut( $fname );
@@ -735,6 +787,9 @@ class Article {
                        $this->exists() &&
                        empty( $oldid );
                wfDebug( 'Article::view using parser cache: ' . ($pcache ? 'yes' : 'no' ) . "\n" );
+               if ( $wgUser->getOption( 'stubthreshold' ) ) {
+                       wfIncrStats( 'pcache_miss_stub' );
+               }
 
                $outputDone = false;
                if ( $pcache ) {
@@ -744,6 +799,18 @@ class Article {
                }
                if ( !$outputDone ) {
                        $text = $this->getContent( false ); # May change mTitle by following a redirect
+                       if ( $text === false ) {
+                               # Failed to load, replace text with error message
+                               $t = $this->mTitle->getPrefixedText();
+                               if( $oldid ) {
+                                       $t .= ',oldid='.$oldid;
+                               }
+                               if( isset( $redirect ) ) {
+                                       $redirect = ($redirect == 'no') ? 'no' : 'yes';
+                                       $t .= ',redirect='.$redirect;
+                               }
+                               $text = wfMsg( 'missingarticle', $t );
+                       }
 
                        # Another whitelist check in case oldid or redirects are altering the title
                        if ( !$this->mTitle->userCanRead() ) {
@@ -765,7 +832,7 @@ class Article {
                                        $redir = $sk->makeKnownLink( $this->mRedirectedFrom, '', 'redirect=no' );
                                        $s = wfMsg( 'redirectedfrom', $redir );
                                        $wgOut->setSubtitle( $s );
-                                       
+
                                        // Check the parser cache again, for the target page
                                        if( $pcache ) {
                                                if( $wgOut->tryParserCache( $this, $wgUser ) ) {
@@ -786,7 +853,12 @@ class Article {
                        }
                }
                if( !$outputDone ) {
+                       /**
+                        * @fixme: this hook doesn't work most of the time, as it doesn't
+                        * trigger when the parser cache is used.
+                        */
                        wfRunHooks( 'ArticleViewHeader', array( &$this ) ) ;
+                       $wgOut->setRevisionId( $this->getRevIdFetched() );
                        # wrap user css and user js in pre and don't parse
                        # XXX: use $this->mTitle->usCssJsSubpage() when php is fixed/ a workaround is found
                        if (
@@ -810,12 +882,9 @@ class Article {
                                  '<span class="redirectText">'.$link.'</span>' );
 
                                $parseout = $wgParser->parse($text, $this->mTitle, ParserOptions::newFromUser($wgUser));
-                               $catlinks = $parseout->getCategoryLinks();
-                               $wgOut->addCategoryLinks($catlinks);
-                               $skin = $wgUser->getSkin();
+                               $wgOut->addParserOutputNoText( $parseout );
                        } else if ( $pcache ) {
                                # Display content and save to parser cache
-                               $wgOut->setRevisionId( $this->getRevIdFetched() );
                                $wgOut->addPrimaryWikiText( $text, $this );
                        } else {
                                # Display content, don't attempt to save to parser cache
@@ -824,7 +893,6 @@ class Article {
                                if( !$this->isCurrent() ) {
                                        $oldEditSectionSetting = $wgOut->mParserOptions->setEditSection( false );
                                }
-                               $wgOut->setRevisionId( $this->getRevIdFetched() );
                                $wgOut->addWikiText( $text );
 
                                if( !$this->isCurrent() ) {
@@ -859,9 +927,6 @@ class Article {
                if ($wgUseTrackbacks)
                        $this->addTrackbacks();
 
-               # Add link titles as META keywords
-               $wgOut->addMetaTags() ;
-
                $this->viewUpdates();
                wfProfileOut( $fname );
        }
@@ -927,11 +992,11 @@ class Article {
                $wgOut->setArticleBodyOnly(true);
                $this->view();
        }
-       
+
        function purge() {
                global $wgUser, $wgRequest, $wgOut, $wgUseSquid;
 
-               if ( $wgUser->isLoggedIn() || $wgRequest->wasPosted() ) {
+               if ( $wgUser->isLoggedIn() || $wgRequest->wasPosted() || ! wfRunHooks( 'ArticlePurge', array( &$this ) ) ) {
                        // Invalidate the cache
                        $this->mTitle->invalidateCache();
 
@@ -949,7 +1014,7 @@ class Article {
                        $msg = $wgOut->parse( wfMsg( 'confirm_purge' ) );
                        $action = $this->mTitle->escapeLocalURL( 'action=purge' );
                        $button = htmlspecialchars( wfMsg( 'confirm_purge_button' ) );
-                       $msg = str_replace( '$1', 
+                       $msg = str_replace( '$1',
                                "<form method=\"post\" action=\"$action\">\n" .
                                "<input type=\"submit\" name=\"submit\" value=\"$button\" />\n" .
                                "</form>\n", $msg );
@@ -1002,12 +1067,12 @@ class Article {
         * Update the page record to point to a newly saved revision.
         *
         * @param Database $dbw
-        * @param Revision $revision -- for ID number, and text used to set
-                                       length and redirect status fields
-        * @param int $lastRevision -- if given, will not overwrite the page field
-        *                             when different from the currently set value.
-        *                             Giving 0 indicates the new page flag should
-        *                             be set on.
+        * @param Revision $revision For ID number, and text used to set
+                                    length and redirect status fields
+        * @param int $lastRevision If given, will not overwrite the page field
+        *                          when different from the currently set value.
+        *                          Giving 0 indicates the new page flag should
+        *                          be set on.
         * @return bool true on success, false on failure
         * @access private
         */
@@ -1076,7 +1141,7 @@ class Article {
         * functions for after display, but that's taking a big leap
         * of faith, and we want to be able to report database
         * errors at some point.
-        * @private
+        * @access private
         */
        function insertNewArticle( $text, $summary, $isminor, $watchthis, $suppressRC=false, $comment=false ) {
                global $wgOut, $wgUser, $wgUseSquid;
@@ -1090,8 +1155,8 @@ class Article {
                        wfProfileOut( $fname );
                        return false;
                }
-               
-               $this->mGoodAdjustment = $this->isCountable( $text );
+
+               $this->mGoodAdjustment = (int)$this->isCountable( $text );
                $this->mTotalAdjustment = 1;
 
                $ns = $this->mTitle->getNamespace();
@@ -1102,7 +1167,9 @@ class Article {
                        $text="== {$summary} ==\n\n".$text;
                }
                $text = $this->preSaveTransform( $text );
-               $isminor = ( $isminor && $wgUser->isLoggedIn() ) ? 1 : 0;
+
+               /* Silently ignore minoredit if not allowed */
+               $isminor = $isminor && $wgUser->isAllowed('minoredit');
                $now = wfTimestampNow();
 
                $dbw =& wfGetDB( DB_MASTER );
@@ -1147,11 +1214,14 @@ class Article {
                        $fname );
 
                # standard deferred updates
-               $this->editUpdates( $text, $summary, $isminor, $now );
+               $this->editUpdates( $text, $summary, $isminor, $now, $revisionId );
 
                $oldid = 0; # new article
-               $this->showArticle( $text, wfMsg( 'newarticle' ), false, $isminor, $now, $summary, $oldid, $revisionId );
+               $this->showArticle( $text, wfMsg( 'newarticle' ), false, $isminor, $now, $summary, $oldid );
 
+               wfRunHooks( 'ArticleInsertComplete', array( &$this, &$wgUser, $text,
+                       $summary, $isminor,
+                       $watchthis, NULL ) );
                wfRunHooks( 'ArticleSaveComplete', array( &$this, &$wgUser, $text,
                        $summary, $isminor,
                        $watchthis, NULL ) );
@@ -1200,7 +1270,7 @@ class Article {
                                # split it up
                                # Unfortunately we can't simply do a preg_replace because that might
                                # replace the wrong section, so we have to use the section counter instead
-                               $secs=preg_split('/(^=+.+?=+|^<h[1-6].*?' . '>.*?<\/h[1-6].*?' . '>)(?!\S)/mi',
+                               $secs=preg_split('/(^=+.+?=+|^<h[1-6].*?>.*?<\/h[1-6].*?>)(?!\S)/mi',
                                  $oldtext,-1,PREG_SPLIT_DELIM_CAPTURE);
                                $secs[$section*2]=$text."\n\n"; // replace with edited
 
@@ -1212,7 +1282,7 @@ class Article {
                                        # be erased, as the mother section has been replaced with
                                        # the text of all subsections.
                                        $headline=$secs[$section*2-1];
-                                       preg_match( '/^(=+).+?=+|^<h([1-6]).*?' . '>.*?<\/h[1-6].*?' . '>(?!\S)/mi',$headline,$matches);
+                                       preg_match( '/^(=+).+?=+|^<h([1-6]).*?>.*?<\/h[1-6].*?>(?!\S)/mi',$headline,$matches);
                                        $hlevel=$matches[1];
 
                                        # determine headline level for wikimarkup headings
@@ -1227,7 +1297,7 @@ class Article {
 
                                                $subheadline=$secs[$count*2-1];
                                                preg_match(
-                                                '/^(=+).+?=+|^<h([1-6]).*?' . '>.*?<\/h[1-6].*?' . '>(?!\S)/mi',$subheadline,$matches);
+                                                '/^(=+).+?=+|^<h([1-6]).*?>.*?<\/h[1-6].*?>(?!\S)/mi',$subheadline,$matches);
                                                $subhlevel=$matches[1];
                                                if(strpos($subhlevel,'=')!==false) {
                                                        $subhlevel=strlen($subhlevel);
@@ -1279,18 +1349,8 @@ class Article {
                        return false;
                }
 
-               $isminor = ( $minor && $wgUser->isLoggedIn() );
-               if ( $this->isRedirect( $text ) ) {
-                       # Remove all content but redirect
-                       # This could be done by reconstructing the redirect from a title given by
-                       # Title::newFromRedirect(), but then we wouldn't know which synonym the user
-                       # wants to see
-                       if ( preg_match( "/^((" . $wgMwRedir->getBaseRegex() . ')[^\\n]+)/i', $text, $m ) ) {
-                               $redir = 1;
-                               $text = $m[1] . "\n";
-                       }
-               }
-               else { $redir = 0; }
+               $isminor = $minor && $wgUser->isAllowed('minoredit');
+               $redir = (int)$this->isRedirect( $text );
 
                $text = $this->preSaveTransform( $text );
                $dbw =& wfGetDB( DB_MASTER );
@@ -1309,10 +1369,11 @@ class Article {
                $oldsize = strlen( $oldtext );
                $newsize = strlen( $text );
                $lastRevision = 0;
+               $revisionId = 0;
 
                if ( 0 != strcmp( $text, $oldtext ) ) {
-                       $this->mGoodAdjustment = $this->isCountable( $text )
-                         - $this->isCountable( $oldtext );
+                       $this->mGoodAdjustment = (int)$this->isCountable( $text )
+                         - (int)$this->isCountable( $oldtext );
                        $this->mTotalAdjustment = 0;
                        $now = wfTimestampNow();
 
@@ -1325,7 +1386,7 @@ class Article {
                                'minor_edit' => $isminor,
                                'text'       => $text
                                ) );
-                       
+
                        $dbw->immediateCommit();
                        $dbw->begin();
                        $revisionId = $revision->insertOn( $dbw );
@@ -1344,10 +1405,13 @@ class Article {
                                        $lastRevision, $this->getTimestamp(), $bot, '', $oldsize, $newsize,
                                        $revisionId );
                                $dbw->commit();
-                               
+
                                // Update caches outside the main transaction
                                Article::onArticleEdit( $this->mTitle );
                        }
+               } else {
+                       // Keep the same revision ID, but do some updates on it
+                       $revisionId = $this->getRevIdFetched();
                }
 
                if( !$wgDBtransactions ) {
@@ -1371,10 +1435,36 @@ class Article {
                                }
                        }
                        # standard deferred updates
-                       $this->editUpdates( $text, $summary, $minor, $now );
+                       $this->editUpdates( $text, $summary, $minor, $now, $revisionId );
+
 
+                       $urls = array();
+                       # Invalidate caches of all articles using this article as a template
 
-                       $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $isminor, $now, $summary, $lastRevision, $revisionId );
+                       # Template namespace
+                       # Purge all articles linking here
+                       $titles = $this->mTitle->getTemplateLinksTo();
+                       Title::touchArray( $titles );
+                       if ( $wgUseSquid ) {
+                                       foreach ( $titles as $title ) {
+                                               $urls[] = $title->getInternalURL();
+                                       }
+                       }
+
+                       # Squid updates
+                       if ( $wgUseSquid ) {
+                               $urls = array_merge( $urls, $this->mTitle->getSquidURLs() );
+                               $u = new SquidUpdate( $urls );
+                               array_push( $wgPostCommitUpdateList, $u );
+                       }
+
+                       # File cache
+                       if ( $wgUseFileCache ) {
+                               $cm = new CacheManager($this->mTitle);
+                               @unlink($cm->fileCacheName());
+                       }
+
+                       $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $isminor, $now, $summary, $lastRevision );
                }
                wfRunHooks( 'ArticleSaveComplete',
                        array( &$this, &$wgUser, $text,
@@ -1388,48 +1478,20 @@ class Article {
         * After we've either updated or inserted the article, update
         * the link tables and redirect to the new page.
         */
-       function showArticle( $text, $subtitle , $sectionanchor = '', $me2, $now, $summary, $oldid, $newid ) {
-               global $wgUseDumbLinkUpdate, $wgAntiLockFlags, $wgOut, $wgUser, $wgLinkCache;
+       function showArticle( $text, $subtitle , $sectionanchor = '', $me2, $now, $summary, $oldid ) {
+               global $wgOut, $wgUser;
                global $wgUseEnotif;
 
                $fname = 'Article::showArticle';
                wfProfileIn( $fname );
 
-               $wgLinkCache = new LinkCache();
-
-               if ( !$wgUseDumbLinkUpdate ) {
-                       # Preload links to reduce lock time
-                       if ( $wgAntiLockFlags & ALF_PRELOAD_LINKS ) {
-                               $wgLinkCache->preFill( $this->mTitle );
-                               $wgLinkCache->clear();
-                       }
-               }
-
-               # Parse the text and save it to the parser cache
-               $wgOut = new OutputPage();
-               $wgOut->setParserOptions( ParserOptions::newFromUser( $wgUser ) );
-               $wgOut->setRevisionId( $newid );
-               $wgOut->addPrimaryWikiText( $text, $this );
-
-               if ( !$wgUseDumbLinkUpdate ) {
-                       # Move the current links back to the second register
-                       $wgLinkCache->swapRegisters();
-
-                       # Get old version of link table to allow incremental link updates
-                       # Lock this data now since it is needed for an update
-                       $wgLinkCache->forUpdate( true );
-                       $wgLinkCache->preFill( $this->mTitle );
-
-                       # Swap this old version back into its rightful place
-                       $wgLinkCache->swapRegisters();
-               }
-
+               # Output the redirect
                if( $this->isRedirect( $text ) )
                        $r = 'redirect=no';
                else
                        $r = '';
                $wgOut->redirect( $this->mTitle->getFullURL( $r ).$sectionanchor );
-               
+
                wfProfileOut( $fname );
        }
 
@@ -1458,10 +1520,12 @@ class Article {
                $rcid = $wgRequest->getVal( 'rcid' );
                if ( !is_null ( $rcid ) )
                {
-                       RecentChange::markPatrolled( $rcid );
-                       $wgOut->setPagetitle( wfMsg( 'markedaspatrolled' ) );
-                       $wgOut->addWikiText( wfMsg( 'markedaspatrolledtext' ) );
-
+                       if( wfRunHooks( 'MarkPatrolled', array( &$rcid, &$wgUser, $wgOnlySysopsCanPatrol ) ) ) {
+                               RecentChange::markPatrolled( $rcid );
+                               wfRunHooks( 'MarkPatrolledComplete', array( &$rcid, &$wgUser, $wgOnlySysopsCanPatrol ) );
+                               $wgOut->setPagetitle( wfMsg( 'markedaspatrolled' ) );
+                               $wgOut->addWikiText( wfMsg( 'markedaspatrolledtext' ) );
+                       }
                        $rcTitle = Title::makeTitle( NS_SPECIAL, 'Recentchanges' );
                        $wgOut->returnToMain( false, $rcTitle->getPrefixedText() );
                }
@@ -1471,34 +1535,6 @@ class Article {
                }
        }
 
-       /**
-        * Validate function
-        */
-       function validate() {
-               global $wgOut, $wgUser, $wgRequest, $wgUseValidation;
-
-               if ( !$wgUseValidation ) # Are we using article validation at all?
-               {
-                       $wgOut->errorpage( "nosuchspecialpage", "nospecialpagetext" );
-                       return ;
-               }
-
-               $wgOut->setRobotpolicy( 'noindex,follow' );
-               $revision = $wgRequest->getVal( 'revision' );
-
-               include_once ( "SpecialValidate.php" ) ; # The "Validation" class
-
-               $v = new Validation ;
-               if ( $wgRequest->getVal ( "mode" , "" ) == "list" )
-                       $t = $v->showList ( $this ) ;
-               else if ( $wgRequest->getVal ( "mode" , "" ) == "details" )
-                       $t = $v->showDetails ( $this , $wgRequest->getVal( 'revision' ) ) ;
-               else
-                       $t = $v->validatePageForm ( $this , $revision ) ;
-
-               $wgOut->addHTML ( $t ) ;
-       }
-
        /**
         * Add this page to $wgUser's watchlist
         */
@@ -1570,147 +1606,91 @@ class Article {
        }
 
        /**
-        * protect a page
+        * action=protect handler
         */
-       function protect( $limit = 'sysop' ) {
+       function protect() {
+               require_once 'ProtectionForm.php';
+               $form = new ProtectionForm( $this );
+               $form->show();
+       }
+
+       /**
+        * action=unprotect handler (alias)
+        */
+       function unprotect() {
+               $this->protect();
+       }
+
+       /**
+        * Update the article's restriction field, and leave a log entry.
+        *
+        * @param array $limit set of restriction keys
+        * @param string $reason
+        * @return bool true on success
+        */
+       function updateRestrictions( $limit = array(), $reason = '' ) {
                global $wgUser, $wgOut, $wgRequest;
 
-               if ( ! $wgUser->isAllowed('protect') ) {
-                       $wgOut->sysopRequired();
-                       return;
+               if ( !$wgUser->isAllowed( 'protect' ) ) {
+                       return false;
                }
-               if ( wfReadOnly() ) {
-                       $wgOut->readOnlyPage();
-                       return;
+
+               if( wfReadOnly() ) {
+                       return false;
                }
+
                $id = $this->mTitle->getArticleID();
                if ( 0 == $id ) {
-                       $wgOut->fatalError( wfMsg( 'badarticleerror' ) );
-                       return;
+                       return false;
                }
 
-               $confirm = $wgRequest->wasPosted() &&
-                       $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) );
-               $moveonly = $wgRequest->getBool( 'wpMoveOnly' );
-               $reason = $wgRequest->getText( 'wpReasonProtect' );
+               $flat = Article::flattenRestrictions( $limit );
+               $protecting = ($flat != '');
+
+               if( wfRunHooks( 'ArticleProtect', array( &$this, &$wgUser,
+                       $limit, $reason ) ) ) {
 
-               if ( $confirm ) {
                        $dbw =& wfGetDB( DB_MASTER );
                        $dbw->update( 'page',
                                array( /* SET */
                                        'page_touched' => $dbw->timestamp(),
-                                       'page_restrictions' => (string)$limit
+                                       'page_restrictions' => $flat
                                ), array( /* WHERE */
                                        'page_id' => $id
                                ), 'Article::protect'
                        );
 
-                       $restrictions = "move=" . $limit;
-                       if( !$moveonly ) {
-                               $restrictions .= ":edit=" . $limit;
-                       }
-                       if (wfRunHooks('ArticleProtect', array(&$this, &$wgUser, $limit == 'sysop', $reason, $moveonly))) {
+                       wfRunHooks( 'ArticleProtectComplete', array( &$this, &$wgUser,
+                               $limit, $reason ) );
 
-                               $dbw =& wfGetDB( DB_MASTER );
-                               $dbw->update( 'page',
-                                                         array( /* SET */
-                                                                        'page_touched' => $dbw->timestamp(),
-                                                                        'page_restrictions' => $restrictions
-                                                                        ), array( /* WHERE */
-                                                                                          'page_id' => $id
-                                                                                          ), 'Article::protect'
-                                                         );
-
-                               wfRunHooks('ArticleProtectComplete', array(&$this, &$wgUser, $limit == 'sysop', $reason, $moveonly));
-
-                               $log = new LogPage( 'protect' );
-                               if ( $limit === '' ) {
-                                       $log->addEntry( 'unprotect', $this->mTitle, $reason );
-                               } else {
-                                       $log->addEntry( 'protect', $this->mTitle, $reason );
-                               }
-                               $wgOut->redirect( $this->mTitle->getFullURL() );
+                       $log = new LogPage( 'protect' );
+                       if( $protecting ) {
+                               $log->addEntry( 'protect', $this->mTitle, trim( $reason . " [$flat]" ) );
+                       } else {
+                               $log->addEntry( 'unprotect', $this->mTitle, $reason );
                        }
-                       return;
-               } else {
-                       return $this->confirmProtect( '', '', $limit );
                }
+               return true;
        }
 
        /**
-        * Output protection confirmation dialog
+        * Take an array of page restrictions and flatten it to a string
+        * suitable for insertion into the page_restrictions field.
+        * @param array $limit
+        * @return string
+        * @access private
         */
-       function confirmProtect( $par, $reason, $limit = 'sysop'  ) {
-               global $wgOut, $wgUser;
-
-               wfDebug( "Article::confirmProtect\n" );
-
-               $sub = htmlspecialchars( $this->mTitle->getPrefixedText() );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
-
-               $check = '';
-               $protcom = '';
-               $moveonly = '';
-
-               if ( $limit === '' ) {
-                       $wgOut->setPageTitle( wfMsg( 'confirmunprotect' ) );
-                       $wgOut->setSubtitle( wfMsg( 'unprotectsub', $sub ) );
-                       $wgOut->addWikiText( wfMsg( 'confirmunprotecttext' ) );
-                       $protcom = htmlspecialchars( wfMsg( 'unprotectcomment' ) );
-                       $formaction = $this->mTitle->escapeLocalURL( 'action=unprotect' . $par );
-               } else {
-                       $wgOut->setPageTitle( wfMsg( 'confirmprotect' ) );
-                       $wgOut->setSubtitle( wfMsg( 'protectsub', $sub ) );
-                       $wgOut->addWikiText( wfMsg( 'confirmprotecttext' ) );
-                       $moveonly = htmlspecialchars( wfMsg( 'protectmoveonly' ) );
-                       $protcom = htmlspecialchars( wfMsg( 'protectcomment' ) );
-                       $formaction = $this->mTitle->escapeLocalURL( 'action=protect' . $par );
-               }
-
-               $confirm = htmlspecialchars( wfMsg( 'protectpage' ) );
-               $token = htmlspecialchars( $wgUser->editToken() );
-
-               $wgOut->addHTML( "
-<form id='protectconfirm' method='post' action=\"{$formaction}\">
-       <table border='0'>
-               <tr>
-                       <td align='right'>
-                               <label for='wpReasonProtect'>{$protcom}:</label>
-                       </td>
-                       <td align='left'>
-                               <input type='text' size='60' name='wpReasonProtect' id='wpReasonProtect' value=\"" . htmlspecialchars( $reason ) . "\" />
-                       </td>
-               </tr>" );
-               if($moveonly != '') {
-                       $wgOut->AddHTML( "
-               <tr>
-                       <td align='right'>
-                               <input type='checkbox' name='wpMoveOnly' value='1' id='wpMoveOnly' />
-                       </td>
-                       <td align='left'>
-                               <label for='wpMoveOnly'>{$moveonly}</label>
-                       </td>
-               </tr> " );
+       function flattenRestrictions( $limit ) {
+               if( !is_array( $limit ) ) {
+                       wfDebugDieBacktrace( 'Article::flattenRestrictions given non-array restriction set' );
+               }
+               $bits = array();
+               foreach( $limit as $action => $restrictions ) {
+                       if( $restrictions != '' ) {
+                               $bits[] = "$action=$restrictions";
+                       }
                }
-               $wgOut->addHTML( "
-               <tr>
-                       <td>&nbsp;</td>
-                       <td>
-                               <input type='submit' name='wpConfirmProtectB' value=\"{$confirm}\" />
-                       </td>
-               </tr>
-       </table>
-       <input type='hidden' name='wpEditToken' value=\"{$token}\" />
-</form>" );
-
-               $wgOut->returnToMain( false );
-       }
-
-       /**
-        * Unprotect the pages
-        */
-       function unprotect() {
-               return $this->protect( '' );
+               return implode( ':', $bits );
        }
 
        /*
@@ -1726,18 +1706,28 @@ class Article {
                # This code desperately needs to be totally rewritten
 
                # Check permissions
-               if( ( !$wgUser->isAllowed( 'delete' ) ) ) {
+               if( $wgUser->isAllowed( 'delete' ) ) {
+                       if( $wgUser->isBlocked() ) {
+                               $wgOut->blockedPage();
+                               return;
+                       }
+               } else {
                        $wgOut->sysopRequired();
                        return;
                }
+
                if( wfReadOnly() ) {
                        $wgOut->readOnlyPage();
                        return;
                }
 
-               # Better double-check that it hasn't been deleted yet!
                $wgOut->setPagetitle( wfMsg( 'confirmdelete' ) );
-               if( !$this->mTitle->exists() ) {
+               
+               # Better double-check that it hasn't been deleted yet!
+               $dbw =& wfGetDB( DB_MASTER );
+               $conds = $this->mTitle->pageCond();
+               $latest = $dbw->selectField( 'page', 'page_latest', $conds, $fname );
+               if ( $latest === false ) {
                        $wgOut->fatalError( wfMsg( 'cannotdelete' ) );
                        return;
                }
@@ -1749,38 +1739,30 @@ class Article {
 
                # determine whether this page has earlier revisions
                # and insert a warning if it does
-               # we select the text because it might be useful below
-               $dbr =& $this->getDB();
-               $ns = $this->mTitle->getNamespace();
-               $title = $this->mTitle->getDBkey();
-               $revisions = $dbr->select( array( 'page', 'revision' ),
-                       array( 'rev_id', 'rev_user_text' ),
-                       array(
-                               'page_namespace' => $ns,
-                               'page_title' => $title,
-                               'rev_page = page_id'
-                       ), $fname, $this->getSelectOptions( array( 'ORDER BY' => 'rev_timestamp DESC' ) )
-               );
-
-               if( $dbr->numRows( $revisions ) > 1 && !$confirm ) {
+               $maxRevisions = 20;
+               $authors = $this->getLastNAuthors( $maxRevisions, $latest );
+               
+               if( count( $authors ) > 1 && !$confirm ) {
                        $skin=$wgUser->getSkin();
                        $wgOut->addHTML('<b>'.wfMsg('historywarning'));
                        $wgOut->addHTML( $skin->historyLink() .'</b>');
                }
 
-               # Fetch cur_text
-               $rev = Revision::newFromTitle( $this->mTitle );
-
-               # Fetch name(s) of contributors
-               $rev_name = '';
-               $all_same_user = true;
-               while( $row = $dbr->fetchObject( $revisions ) ) {
-                       if( $rev_name != '' && $rev_name != $row->rev_user_text ) {
-                               $all_same_user = false;
-                       } else {
-                               $rev_name = $row->rev_user_text;
+               # If a single user is responsible for all revisions, find out who they are
+               if ( count( $authors ) == $maxRevisions ) {
+                       // Query bailed out, too many revisions to find out if they're all the same
+                       $authorOfAll = false;
+               } else {
+                       $authorOfAll = reset( $authors );
+                       foreach ( $authors as $author ) {
+                               if ( $authorOfAll != $author ) {
+                                       $authorOfAll = false;
+                                       break;
+                               }
                        }
                }
+               # Fetch article text
+               $rev = Revision::newFromTitle( $this->mTitle );
 
                if( !is_null( $rev ) ) {
                        # if this is a mini-text, we can paste part of it into the deletion reason
@@ -1814,10 +1796,10 @@ class Article {
                                $text = preg_replace( "/[\n\r]/", '', $text );
 
                                if( !$blanked ) {
-                                       if( !$all_same_user ) {
+                                       if( $authorOfAll === false ) {
                                                $reason = wfMsgForContent( 'excontent', $text );
                                        } else {
-                                               $reason = wfMsgForContent( 'excontentauthor', $text, $rev_name );
+                                               $reason = wfMsgForContent( 'excontentauthor', $text, $authorOfAll );
                                        }
                                } else {
                                        $reason = wfMsgForContent( 'exbeforeblank', $text );
@@ -1828,6 +1810,53 @@ class Article {
                return $this->confirmDelete( '', $reason );
        }
 
+       /**
+        * Get the last N authors 
+        * @param int $num Number of revisions to get
+        * @param string $revLatest The latest rev_id, selected from the master (optional)
+        * @return array Array of authors, duplicates not removed
+        */
+       function getLastNAuthors( $num, $revLatest = 0 ) {
+               $fname = 'Article::getLastNAuthors';
+               wfProfileIn( $fname );
+
+               // First try the slave
+               // If that doesn't have the latest revision, try the master
+               $continue = 2;
+               $db =& wfGetDB( DB_SLAVE );
+               do {
+                       $res = $db->select( array( 'page', 'revision' ),
+                               array( 'rev_id', 'rev_user_text' ),
+                               array(
+                                       'page_namespace' => $this->mTitle->getNamespace(),
+                                       'page_title' => $this->mTitle->getDBkey(),
+                                       'rev_page = page_id'
+                               ), $fname, $this->getSelectOptions( array( 
+                                       'ORDER BY' => 'rev_timestamp DESC',
+                                       'LIMIT' => $num
+                               ) )
+                       );
+                       if ( !$res ) {
+                               wfProfileOut( $fname );
+                               return array();
+                       }
+                       $row = $db->fetchObject( $res );
+                       if ( $continue == 2 && $revLatest && $row->rev_id != $revLatest ) {
+                               $db =& wfGetDB( DB_MASTER );
+                               $continue--;
+                       } else {
+                               $continue = 0;
+                       }
+               } while ( $continue );
+
+               $authors = array( $row->rev_user_text );
+               while ( $row = $db->fetchObject( $res ) ) {
+                       $authors[] = $row->rev_user_text;
+               }
+               wfProfileOut( $fname );
+               return $authors;
+       }
+       
        /**
         * Output deletion confirmation dialog
         */
@@ -1920,7 +1949,7 @@ class Article {
                        return false;
                }
 
-               $u = new SiteStatsUpdate( 0, 1, -$this->isCountable( $this->getContent( true ) ), -1 );
+               $u = new SiteStatsUpdate( 0, 1, -(int)$this->isCountable( $this->getContent( true ) ), -1 );
                array_push( $wgDeferredUpdateList, $u );
 
                $linksTo = $this->mTitle->getLinksTo();
@@ -2002,13 +2031,19 @@ class Article {
         * Revert a modification
         */
        function rollback() {
-               global $wgUser, $wgOut, $wgRequest;
+               global $wgUser, $wgOut, $wgRequest, $wgUseRCPatrol;
                $fname = 'Article::rollback';
 
-               if ( ! $wgUser->isAllowed('rollback') ) {
+               if( $wgUser->isAllowed( 'rollback' ) ) {
+                       if( $wgUser->isBlocked() ) {
+                               $wgOut->blockedPage();
+                               return;
+                       }
+               } else {
                        $wgOut->sysopRequired();
                        return;
                }
+
                if ( wfReadOnly() ) {
                        $wgOut->readOnlyPage( $this->getContent( true ) );
                        return;
@@ -2075,12 +2110,19 @@ class Article {
                        return;
                }
 
+               $set = array();
                if ( $bot ) {
                        # Mark all reverted edits as bot
-                       $dbw->update( 'recentchanges',
-                               array( /* SET */
-                                       'rc_bot' => 1
-                               ), array( /* WHERE */
+                       $set['rc_bot'] = 1;
+               }
+               if ( $wgUseRCPatrol ) {
+                       # Mark all reverted edits as patrolled
+                       $set['rc_patrolled'] = 1;
+               }
+
+               if ( $set ) {
+                       $dbw->update( 'recentchanges', $set,
+                               array( /* WHERE */
                                        'rc_cur_id'    => $current->getPage(),
                                        'rc_user_text' => $current->getUserText(),
                                        "rc_timestamp > '{$s->rev_timestamp}'",
@@ -2108,7 +2150,7 @@ class Article {
 
        /**
         * Do standard deferred updates after page view
-        * @private
+        * @access private
         */
        function viewUpdates() {
                global $wgDeferredUpdateList;
@@ -2130,18 +2172,33 @@ class Article {
        /**
         * Do standard deferred updates after page edit.
         * Every 1000th edit, prune the recent changes table.
-        * @private
+        * @access private
         * @param string $text
         */
-       function editUpdates( $text, $summary, $minoredit, $timestamp_of_pagechange) {
-               global $wgDeferredUpdateList, $wgMessageCache, $wgUser;
+       function editUpdates( $text, $summary, $minoredit, $timestamp_of_pagechange, $newid) {
+               global $wgDeferredUpdateList, $wgMessageCache, $wgUser, $wgParser;
+
+               $fname = 'Article::editUpdates';
+               wfProfileIn( $fname );
+
+               # Parse the text
+               $options = new ParserOptions;
+               $poutput = $wgParser->parse( $text, $this->mTitle, $options, true, true, $newid );
+
+               # Save it to the parser cache
+               $parserCache =& ParserCache::singleton();
+               $parserCache->save( $poutput, $this, $wgUser );
+
+               # Update the links tables
+               $u = new LinksUpdate( $this->mTitle, $poutput );
+               $u->doUpdate();
 
                if ( wfRunHooks( 'ArticleEditUpdatesDeleteFromRecentchanges', array( &$this ) ) ) {
                        wfSeedRandom();
                        if ( 0 == mt_rand( 0, 999 ) ) {
                                # Periodically flush old entries from the recentchanges table.
                                global $wgRCMaxAge;
-                               
+
                                $dbw =& wfGetDB( DB_MASTER );
                                $cutoff = $dbw->timestamp( time() - $wgRCMaxAge );
                                $recentchanges = $dbw->tableName( 'recentchanges' );
@@ -2154,37 +2211,40 @@ class Article {
                $title = $this->mTitle->getPrefixedDBkey();
                $shortTitle = $this->mTitle->getDBkey();
 
-               if ( 0 != $id ) {
-                       $u = new LinksUpdate( $id, $title );
-                       array_push( $wgDeferredUpdateList, $u );
-                       $u = new SiteStatsUpdate( 0, 1, $this->mGoodAdjustment, $this->mTotalAdjustment );
-                       array_push( $wgDeferredUpdateList, $u );
-                       $u = new SearchUpdate( $id, $title, $text );
-                       array_push( $wgDeferredUpdateList, $u );
-
-                       # If this is another user's talk page, update newtalk
-
-                       if ($this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getName()) {
-                               $other = User::newFromName( $shortTitle );
-                               if( is_null( $other ) && User::isIP( $shortTitle ) ) {
-                                       // An anonymous user
-                                       $other = new User();
-                                       $other->setName( $shortTitle );
-                               }
-                               if( $other ) {
-                                       $other->setNewtalk( true );
-                               }
-                       }
+               if ( 0 == $id ) {
+                       wfProfileOut( $fname );
+                       return;
+               }
 
-                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
-                               $wgMessageCache->replace( $shortTitle, $text );
+               $u = new SiteStatsUpdate( 0, 1, $this->mGoodAdjustment, $this->mTotalAdjustment );
+               array_push( $wgDeferredUpdateList, $u );
+               $u = new SearchUpdate( $id, $title, $text );
+               array_push( $wgDeferredUpdateList, $u );
+
+               # If this is another user's talk page, update newtalk
+
+               if ($this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getName()) {
+                       $other = User::newFromName( $shortTitle );
+                       if( is_null( $other ) && User::isIP( $shortTitle ) ) {
+                               // An anonymous user
+                               $other = new User();
+                               $other->setName( $shortTitle );
+                       }
+                       if( $other ) {
+                               $other->setNewtalk( true );
                        }
                }
+
+               if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                       $wgMessageCache->replace( $shortTitle, $text );
+               }
+
+               wfProfileOut( $fname );
        }
 
        /**
         * @todo document this function
-        * @private
+        * @access private
         * @param string $oldid         Revision ID of this article revision
         */
        function setOldSubtitle( $oldid=0 ) {
@@ -2269,7 +2329,7 @@ class Article {
        }
 
        /**
-        * Loads cur_touched and returns a value indicating if it should be used
+        * Loads page_touched and returns a value indicating if it should be used
         *
         */
        function checkTouched() {
@@ -2284,6 +2344,21 @@ class Article {
                return !$this->mIsRedirect;
        }
 
+       /**
+        * Get the page_touched field
+        */
+       function getTouched() {
+               # Ensure that page data has been loaded
+               if( !$this->mDataLoaded ) {
+                       $dbr =& $this->getDB();
+                       $data = $this->pageDataFromId( $dbr, $this->getId() );
+                       if( $data ) {
+                               $this->loadPageData( $data );
+                       }
+               }
+               return $this->mTouched;
+       }
+
        /**
         * Edit an article without doing all that other stuff
         * The article must already exist; link tables etc
@@ -2398,9 +2473,9 @@ class Article {
 
        function onArticleDelete( $title ) {
                global $wgMessageCache;
-               
+
                $title->touchLinks();
-               
+
                if( $title->getNamespace() == NS_MEDIAWIKI) {
                        $wgMessageCache->replace( $title->getDBkey(), false );
                }
@@ -2411,9 +2486,9 @@ class Article {
         */
        function onArticleEdit( $title ) {
                global $wgUseSquid, $wgPostCommitUpdateList, $wgUseFileCache;
-               
+
                $urls = array();
-               
+
                // Template namespace? Purge all articles linking here.
                // FIXME: When a templatelinks table arrives, use it for all includes.
                if ( $title->getNamespace() == NS_TEMPLATE) {
@@ -2428,7 +2503,7 @@ class Article {
 
                # Squid updates
                if ( $wgUseSquid ) {
-                       $urls = array_merge( $urls, $this->mTitle->getSquidURLs() );
+                       $urls = array_merge( $urls, $title->getSquidURLs() );
                        $u = new SquidUpdate( $urls );
                        array_push( $wgPostCommitUpdateList, $u );
                }
@@ -2465,9 +2540,13 @@ class Article {
                # first, see if the page exists at all.
                $exists = $page->getArticleId() != 0;
                if( !$exists ) {
-                       $wgOut->addHTML( wfMsg( $wgUser->isLoggedIn() ? 'noarticletext' : 'noarticletextanon' ) );
+                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               $wgOut->addHTML(wfMsgWeirdKey ( $this->mTitle->getText() ) );
+                       } else {
+                               $wgOut->addHTML(wfMsg( $wgUser->isLoggedIn() ? 'noarticletext' : 'noarticletextanon' ) );
+                       }
                } else {
-                       $dbr =& $this->getDB( DB_SLAVE );
+                       $dbr =& wfGetDB( DB_SLAVE );
                        $wl_clause = array(
                                'wl_title'     => $page->getDBkey(),
                                'wl_namespace' => $page->getNamespace() );
@@ -2509,7 +2588,7 @@ class Article {
                        return false;
                }
 
-               $dbr =& $this->getDB( DB_SLAVE );
+               $dbr =& wfGetDB( DB_SLAVE );
 
                $rev_clause = array( 'rev_page' => $id );
                $fname = 'Article::pageCountInfo';
@@ -2533,29 +2612,27 @@ class Article {
 
        /**
         * Return a list of templates used by this article.
-        * Uses the links table to find the templates
+        * Uses the templatelinks table
         *
-        * @return array
+        * @return array Array of Title objects
         */
        function getUsedTemplates() {
                $result = array();
                $id = $this->mTitle->getArticleID();
 
-               $db =& wfGetDB( DB_SLAVE );
-               $res = $db->select( array( 'pagelinks' ),
-                       array( 'pl_title' ),
-                       array(
-                               'pl_from' => $id,
-                               'pl_namespace' => NS_TEMPLATE ),
+               $dbr =& wfGetDB( DB_SLAVE );
+               $res = $dbr->select( array( 'templatelinks' ),
+                       array( 'tl_namespace', 'tl_title' ),
+                       array( 'tl_from' => $id ),
                        'Article:getUsedTemplates' );
                if ( false !== $res ) {
-                       if ( $db->numRows( $res ) ) {
-                               while ( $row = $db->fetchObject( $res ) ) {
-                                       $result[] = $row->pl_title;
+                       if ( $dbr->numRows( $res ) ) {
+                               while ( $row = $dbr->fetchObject( $res ) ) {
+                                       $result[] = Title::makeTitle( $row->tl_namespace, $row->tl_title );
                                }
                        }
                }
-               $db->freeResult( $res );
+               $dbr->freeResult( $res );
                return $result;
        }
 }