3 namespace MediaWiki\Tests\Storage
;
5 use CommentStoreComment
;
8 use InvalidArgumentException
;
10 use MediaWiki\Linker\LinkTarget
;
11 use MediaWiki\MediaWikiServices
;
12 use MediaWiki\Storage\BlobStoreFactory
;
13 use MediaWiki\Storage\IncompleteRevisionException
;
14 use MediaWiki\Storage\MutableRevisionRecord
;
15 use MediaWiki\Storage\RevisionRecord
;
16 use MediaWiki\Storage\RevisionStore
;
17 use MediaWiki\Storage\SlotRecord
;
18 use MediaWiki\Storage\SqlBlobStore
;
19 use MediaWikiTestCase
;
24 use Wikimedia\Rdbms\Database
;
25 use Wikimedia\Rdbms\DatabaseSqlite
;
26 use Wikimedia\Rdbms\FakeResultWrapper
;
27 use Wikimedia\Rdbms\LoadBalancer
;
28 use Wikimedia\Rdbms\TransactionProfiler
;
35 class RevisionStoreDbTest
extends MediaWikiTestCase
{
37 public function setUp() {
39 $this->tablesUsed
[] = 'archive';
40 $this->tablesUsed
[] = 'page';
41 $this->tablesUsed
[] = 'revision';
42 $this->tablesUsed
[] = 'comment';
46 * @return LoadBalancer
48 private function getLoadBalancerMock( array $server ) {
49 $lb = $this->getMockBuilder( LoadBalancer
::class )
50 ->setMethods( [ 'reallyOpenConnection' ] )
51 ->setConstructorArgs( [ [ 'servers' => [ $server ] ] ] )
54 $lb->method( 'reallyOpenConnection' )->willReturnCallback(
55 function ( array $server, $dbNameOverride ) {
56 return $this->getDatabaseMock( $server );
66 private function getDatabaseMock( array $params ) {
67 $db = $this->getMockBuilder( DatabaseSqlite
::class )
68 ->setMethods( [ 'select', 'doQuery', 'open', 'closeConnection', 'isOpen' ] )
69 ->setConstructorArgs( [ $params ] )
72 $db->method( 'select' )->willReturn( new FakeResultWrapper( [] ) );
73 $db->method( 'isOpen' )->willReturn( true );
78 public function provideDomainCheck() {
79 yield
[ false, 'test', '' ];
80 yield
[ 'test', 'test', '' ];
82 yield
[ false, 'test', 'foo_' ];
83 yield
[ 'test-foo_', 'test', 'foo_' ];
85 yield
[ false, 'dash-test', '' ];
86 yield
[ 'dash-test', 'dash-test', '' ];
88 yield
[ false, 'underscore_test', 'foo_' ];
89 yield
[ 'underscore_test-foo_', 'underscore_test', 'foo_' ];
93 * @dataProvider provideDomainCheck
94 * @covers \MediaWiki\Storage\RevisionStore::checkDatabaseWikiId
96 public function testDomainCheck( $wikiId, $dbName, $dbPrefix ) {
99 'wgDBname' => $dbName,
100 'wgDBprefix' => $dbPrefix,
104 $loadBalancer = $this->getLoadBalancerMock(
107 'dbDirectory' => '*dummy*',
109 'password' => 'test',
117 'trxProfiler' => new TransactionProfiler(),
118 'connLogger' => new \Psr\Log\
NullLogger(),
119 'queryLogger' => new \Psr\Log\
NullLogger(),
120 'errorLogger' => new \Psr\Log\
NullLogger(),
123 'tablePrefix' => $dbPrefix,
126 $db = $loadBalancer->getConnection( DB_REPLICA
);
128 $blobStore = $this->getMockBuilder( SqlBlobStore
::class )
129 ->disableOriginalConstructor()
132 $store = new RevisionStore(
135 new WANObjectCache( [ 'cache' => new HashBagOStuff() ] ),
136 MediaWikiServices
::getInstance()->getCommentStore(),
137 MediaWikiServices
::getInstance()->getActorMigration(),
141 $count = $store->countRevisionsByPageId( $db, 0 );
143 // Dummy check to make PhpUnit happy. We are really only interested in
144 // countRevisionsByPageId not failing due to the DB domain check.
145 $this->assertSame( 0, $count );
148 private function assertLinkTargetsEqual( LinkTarget
$l1, LinkTarget
$l2 ) {
149 $this->assertEquals( $l1->getDBkey(), $l2->getDBkey() );
150 $this->assertEquals( $l1->getNamespace(), $l2->getNamespace() );
151 $this->assertEquals( $l1->getFragment(), $l2->getFragment() );
152 $this->assertEquals( $l1->getInterwiki(), $l2->getInterwiki() );
155 private function assertRevisionRecordsEqual( RevisionRecord
$r1, RevisionRecord
$r2 ) {
156 $this->assertEquals( $r1->getUser()->getName(), $r2->getUser()->getName() );
157 $this->assertEquals( $r1->getUser()->getId(), $r2->getUser()->getId() );
158 $this->assertEquals( $r1->getComment(), $r2->getComment() );
159 $this->assertEquals( $r1->getPageAsLinkTarget(), $r2->getPageAsLinkTarget() );
160 $this->assertEquals( $r1->getTimestamp(), $r2->getTimestamp() );
161 $this->assertEquals( $r1->getVisibility(), $r2->getVisibility() );
162 $this->assertEquals( $r1->getSha1(), $r2->getSha1() );
163 $this->assertEquals( $r1->getParentId(), $r2->getParentId() );
164 $this->assertEquals( $r1->getSize(), $r2->getSize() );
165 $this->assertEquals( $r1->getPageId(), $r2->getPageId() );
166 $this->assertEquals( $r1->getSlotRoles(), $r2->getSlotRoles() );
167 $this->assertEquals( $r1->getWikiId(), $r2->getWikiId() );
168 $this->assertEquals( $r1->isMinor(), $r2->isMinor() );
169 foreach ( $r1->getSlotRoles() as $role ) {
170 $this->assertSlotRecordsEqual( $r1->getSlot( $role ), $r2->getSlot( $role ) );
171 $this->assertTrue( $r1->getContent( $role )->equals( $r2->getContent( $role ) ) );
174 RevisionRecord
::DELETED_TEXT
,
175 RevisionRecord
::DELETED_COMMENT
,
176 RevisionRecord
::DELETED_USER
,
177 RevisionRecord
::DELETED_RESTRICTED
,
179 $this->assertEquals( $r1->isDeleted( $field ), $r2->isDeleted( $field ) );
183 private function assertSlotRecordsEqual( SlotRecord
$s1, SlotRecord
$s2 ) {
184 $this->assertSame( $s1->getRole(), $s2->getRole() );
185 $this->assertSame( $s1->getModel(), $s2->getModel() );
186 $this->assertSame( $s1->getFormat(), $s2->getFormat() );
187 $this->assertSame( $s1->getSha1(), $s2->getSha1() );
188 $this->assertSame( $s1->getSize(), $s2->getSize() );
189 $this->assertTrue( $s1->getContent()->equals( $s2->getContent() ) );
191 $s1->hasRevision() ?
$this->assertSame( $s1->getRevision(), $s2->getRevision() ) : null;
192 $s1->hasAddress() ?
$this->assertSame( $s1->hasAddress(), $s2->hasAddress() ) : null;
195 private function assertRevisionCompleteness( RevisionRecord
$r ) {
196 foreach ( $r->getSlotRoles() as $role ) {
197 $this->assertSlotCompleteness( $r, $r->getSlot( $role ) );
201 private function assertSlotCompleteness( RevisionRecord
$r, SlotRecord
$slot ) {
202 $this->assertTrue( $slot->hasAddress() );
203 $this->assertSame( $r->getId(), $slot->getRevision() );
207 * @param mixed[] $details
209 * @return RevisionRecord
211 private function getRevisionRecordFromDetailsArray( $title, $details = [] ) {
212 // Convert some values that can't be provided by dataProviders
213 $page = WikiPage
::factory( $title );
214 if ( isset( $details['user'] ) && $details['user'] === true ) {
215 $details['user'] = $this->getTestUser()->getUser();
217 if ( isset( $details['page'] ) && $details['page'] === true ) {
218 $details['page'] = $page->getId();
220 if ( isset( $details['parent'] ) && $details['parent'] === true ) {
221 $details['parent'] = $page->getLatest();
224 // Create the RevisionRecord with any available data
225 $rev = new MutableRevisionRecord( $title );
226 isset( $details['slot'] ) ?
$rev->setSlot( $details['slot'] ) : null;
227 isset( $details['parent'] ) ?
$rev->setParentId( $details['parent'] ) : null;
228 isset( $details['page'] ) ?
$rev->setPageId( $details['page'] ) : null;
229 isset( $details['size'] ) ?
$rev->setSize( $details['size'] ) : null;
230 isset( $details['sha1'] ) ?
$rev->setSha1( $details['sha1'] ) : null;
231 isset( $details['comment'] ) ?
$rev->setComment( $details['comment'] ) : null;
232 isset( $details['timestamp'] ) ?
$rev->setTimestamp( $details['timestamp'] ) : null;
233 isset( $details['minor'] ) ?
$rev->setMinorEdit( $details['minor'] ) : null;
234 isset( $details['user'] ) ?
$rev->setUser( $details['user'] ) : null;
235 isset( $details['visibility'] ) ?
$rev->setVisibility( $details['visibility'] ) : null;
236 isset( $details['id'] ) ?
$rev->setId( $details['id'] ) : null;
241 private function getRandomCommentStoreComment() {
242 return CommentStoreComment
::newUnsavedComment( __METHOD__
. '.' . rand( 0, 1000 ) );
245 public function provideInsertRevisionOn_successes() {
246 yield
'Bare minimum revision insertion' => [
247 Title
::newFromText( 'UTPage' ),
249 'slot' => SlotRecord
::newUnsaved( 'main', new WikitextContent( 'Chicken' ) ),
251 'comment' => $this->getRandomCommentStoreComment(),
252 'timestamp' => '20171117010101',
256 yield
'Detailed revision insertion' => [
257 Title
::newFromText( 'UTPage' ),
259 'slot' => SlotRecord
::newUnsaved( 'main', new WikitextContent( 'Chicken' ) ),
262 'comment' => $this->getRandomCommentStoreComment(),
263 'timestamp' => '20171117010101',
266 'visibility' => RevisionRecord
::DELETED_RESTRICTED
,
272 * @dataProvider provideInsertRevisionOn_successes
273 * @covers \MediaWiki\Storage\RevisionStore::insertRevisionOn
275 public function testInsertRevisionOn_successes( Title
$title, array $revDetails = [] ) {
276 $rev = $this->getRevisionRecordFromDetailsArray( $title, $revDetails );
278 $store = MediaWikiServices
::getInstance()->getRevisionStore();
279 $return = $store->insertRevisionOn( $rev, wfGetDB( DB_MASTER
) );
281 $this->assertLinkTargetsEqual( $title, $return->getPageAsLinkTarget() );
282 $this->assertRevisionRecordsEqual( $rev, $return );
283 $this->assertRevisionCompleteness( $return );
287 * @covers \MediaWiki\Storage\RevisionStore::insertRevisionOn
289 public function testInsertRevisionOn_blobAddressExists() {
290 $title = Title
::newFromText( 'UTPage' );
292 'slot' => SlotRecord
::newUnsaved( 'main', new WikitextContent( 'Chicken' ) ),
294 'comment' => $this->getRandomCommentStoreComment(),
295 'timestamp' => '20171117010101',
299 $store = MediaWikiServices
::getInstance()->getRevisionStore();
301 // Insert the first revision
302 $revOne = $this->getRevisionRecordFromDetailsArray( $title, $revDetails );
303 $firstReturn = $store->insertRevisionOn( $revOne, wfGetDB( DB_MASTER
) );
304 $this->assertLinkTargetsEqual( $title, $firstReturn->getPageAsLinkTarget() );
305 $this->assertRevisionRecordsEqual( $revOne, $firstReturn );
307 // Insert a second revision inheriting the same blob address
308 $revDetails['slot'] = SlotRecord
::newInherited( $firstReturn->getSlot( 'main' ) );
309 $revTwo = $this->getRevisionRecordFromDetailsArray( $title, $revDetails );
310 $secondReturn = $store->insertRevisionOn( $revTwo, wfGetDB( DB_MASTER
) );
311 $this->assertLinkTargetsEqual( $title, $secondReturn->getPageAsLinkTarget() );
312 $this->assertRevisionRecordsEqual( $revTwo, $secondReturn );
314 // Assert that the same blob address has been used.
316 $firstReturn->getSlot( 'main' )->getAddress(),
317 $secondReturn->getSlot( 'main' )->getAddress()
319 // And that different revisions have been created.
320 $this->assertNotSame(
321 $firstReturn->getId(),
322 $secondReturn->getId()
326 public function provideInsertRevisionOn_failures() {
328 Title
::newFromText( 'UTPage' ),
330 'comment' => $this->getRandomCommentStoreComment(),
331 'timestamp' => '20171117010101',
334 new InvalidArgumentException( 'At least one slot needs to be defined!' )
336 yield
'slot that is not main slot' => [
337 Title
::newFromText( 'UTPage' ),
339 'slot' => SlotRecord
::newUnsaved( 'lalala', new WikitextContent( 'Chicken' ) ),
340 'comment' => $this->getRandomCommentStoreComment(),
341 'timestamp' => '20171117010101',
344 new InvalidArgumentException( 'Only the main slot is supported for now!' )
346 yield
'no timestamp' => [
347 Title
::newFromText( 'UTPage' ),
349 'slot' => SlotRecord
::newUnsaved( 'main', new WikitextContent( 'Chicken' ) ),
350 'comment' => $this->getRandomCommentStoreComment(),
353 new IncompleteRevisionException( 'timestamp field must not be NULL!' )
355 yield
'no comment' => [
356 Title
::newFromText( 'UTPage' ),
358 'slot' => SlotRecord
::newUnsaved( 'main', new WikitextContent( 'Chicken' ) ),
359 'timestamp' => '20171117010101',
362 new IncompleteRevisionException( 'comment must not be NULL!' )
365 Title
::newFromText( 'UTPage' ),
367 'slot' => SlotRecord
::newUnsaved( 'main', new WikitextContent( 'Chicken' ) ),
368 'comment' => $this->getRandomCommentStoreComment(),
369 'timestamp' => '20171117010101',
371 new IncompleteRevisionException( 'user must not be NULL!' )
376 * @dataProvider provideInsertRevisionOn_failures
377 * @covers \MediaWiki\Storage\RevisionStore::insertRevisionOn
379 public function testInsertRevisionOn_failures(
381 array $revDetails = [],
382 Exception
$exception ) {
383 $rev = $this->getRevisionRecordFromDetailsArray( $title, $revDetails );
385 $store = MediaWikiServices
::getInstance()->getRevisionStore();
387 $this->setExpectedException(
388 get_class( $exception ),
389 $exception->getMessage(),
390 $exception->getCode()
392 $store->insertRevisionOn( $rev, wfGetDB( DB_MASTER
) );
395 public function provideNewNullRevision() {
397 Title
::newFromText( 'UTPage' ),
398 CommentStoreComment
::newUnsavedComment( __METHOD__
. ' comment1' ),
402 Title
::newFromText( 'UTPage' ),
403 CommentStoreComment
::newUnsavedComment( __METHOD__
. ' comment2', [ 'a' => 1 ] ),
409 * @dataProvider provideNewNullRevision
410 * @covers \MediaWiki\Storage\RevisionStore::newNullRevision
412 public function testNewNullRevision( Title
$title, $comment, $minor ) {
413 $store = MediaWikiServices
::getInstance()->getRevisionStore();
414 $user = TestUserRegistry
::getMutableTestUser( __METHOD__
)->getUser();
416 $parent = $store->getRevisionByTitle( $title );
417 $record = $store->newNullRevision(
418 wfGetDB( DB_MASTER
),
425 $this->assertEquals( $title->getNamespace(), $record->getPageAsLinkTarget()->getNamespace() );
426 $this->assertEquals( $title->getDBkey(), $record->getPageAsLinkTarget()->getDBkey() );
427 $this->assertEquals( $comment, $record->getComment() );
428 $this->assertEquals( $minor, $record->isMinor() );
429 $this->assertEquals( $user->getName(), $record->getUser()->getName() );
430 $this->assertEquals( $parent->getId(), $record->getParentId() );
432 $parentSlot = $parent->getSlot( 'main' );
433 $slot = $record->getSlot( 'main' );
435 $this->assertTrue( $slot->isInherited(), 'isInherited' );
436 $this->assertSame( $parentSlot->getOrigin(), $slot->getOrigin(), 'getOrigin' );
437 $this->assertSame( $parentSlot->getAddress(), $slot->getAddress(), 'getAddress' );
441 * @covers \MediaWiki\Storage\RevisionStore::newNullRevision
443 public function testNewNullRevision_nonExistingTitle() {
444 $store = MediaWikiServices
::getInstance()->getRevisionStore();
445 $record = $store->newNullRevision(
446 wfGetDB( DB_MASTER
),
447 Title
::newFromText( __METHOD__
. '.iDontExist!' ),
448 CommentStoreComment
::newUnsavedComment( __METHOD__
. ' comment' ),
450 TestUserRegistry
::getMutableTestUser( __METHOD__
)->getUser()
452 $this->assertNull( $record );
456 * @covers \MediaWiki\Storage\RevisionStore::getRcIdIfUnpatrolled
458 public function testGetRcIdIfUnpatrolled_returnsRecentChangesId() {
459 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
460 $status = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
);
461 /** @var Revision $rev */
462 $rev = $status->value
['revision'];
464 $store = MediaWikiServices
::getInstance()->getRevisionStore();
465 $revisionRecord = $store->getRevisionById( $rev->getId() );
466 $result = $store->getRcIdIfUnpatrolled( $revisionRecord );
468 $this->assertGreaterThan( 0, $result );
470 $page->getRevision()->getRecentChange()->getAttribute( 'rc_id' ),
476 * @covers \MediaWiki\Storage\RevisionStore::getRcIdIfUnpatrolled
478 public function testGetRcIdIfUnpatrolled_returnsZeroIfPatrolled() {
479 // This assumes that sysops are auto patrolled
480 $sysop = $this->getTestSysop()->getUser();
481 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
482 $status = $page->doEditContent(
483 new WikitextContent( __METHOD__
),
489 /** @var Revision $rev */
490 $rev = $status->value
['revision'];
492 $store = MediaWikiServices
::getInstance()->getRevisionStore();
493 $revisionRecord = $store->getRevisionById( $rev->getId() );
494 $result = $store->getRcIdIfUnpatrolled( $revisionRecord );
496 $this->assertSame( 0, $result );
500 * @covers \MediaWiki\Storage\RevisionStore::getRecentChange
502 public function testGetRecentChange() {
503 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
504 $content = new WikitextContent( __METHOD__
);
505 $status = $page->doEditContent( $content, __METHOD__
);
506 /** @var Revision $rev */
507 $rev = $status->value
['revision'];
509 $store = MediaWikiServices
::getInstance()->getRevisionStore();
510 $revRecord = $store->getRevisionById( $rev->getId() );
511 $recentChange = $store->getRecentChange( $revRecord );
513 $this->assertEquals( $rev->getId(), $recentChange->getAttribute( 'rc_this_oldid' ) );
514 $this->assertEquals( $rev->getRecentChange(), $recentChange );
518 * @covers \MediaWiki\Storage\RevisionStore::getRevisionById
520 public function testGetRevisionById() {
521 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
522 $content = new WikitextContent( __METHOD__
);
523 $status = $page->doEditContent( $content, __METHOD__
);
524 /** @var Revision $rev */
525 $rev = $status->value
['revision'];
527 $store = MediaWikiServices
::getInstance()->getRevisionStore();
528 $revRecord = $store->getRevisionById( $rev->getId() );
530 $this->assertSame( $rev->getId(), $revRecord->getId() );
531 $this->assertTrue( $revRecord->getSlot( 'main' )->getContent()->equals( $content ) );
532 $this->assertSame( __METHOD__
, $revRecord->getComment()->text
);
536 * @covers \MediaWiki\Storage\RevisionStore::getRevisionByTitle
538 public function testGetRevisionByTitle() {
539 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
540 $content = new WikitextContent( __METHOD__
);
541 $status = $page->doEditContent( $content, __METHOD__
);
542 /** @var Revision $rev */
543 $rev = $status->value
['revision'];
545 $store = MediaWikiServices
::getInstance()->getRevisionStore();
546 $revRecord = $store->getRevisionByTitle( $page->getTitle() );
548 $this->assertSame( $rev->getId(), $revRecord->getId() );
549 $this->assertTrue( $revRecord->getSlot( 'main' )->getContent()->equals( $content ) );
550 $this->assertSame( __METHOD__
, $revRecord->getComment()->text
);
554 * @covers \MediaWiki\Storage\RevisionStore::getRevisionByPageId
556 public function testGetRevisionByPageId() {
557 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
558 $content = new WikitextContent( __METHOD__
);
559 $status = $page->doEditContent( $content, __METHOD__
);
560 /** @var Revision $rev */
561 $rev = $status->value
['revision'];
563 $store = MediaWikiServices
::getInstance()->getRevisionStore();
564 $revRecord = $store->getRevisionByPageId( $page->getId() );
566 $this->assertSame( $rev->getId(), $revRecord->getId() );
567 $this->assertTrue( $revRecord->getSlot( 'main' )->getContent()->equals( $content ) );
568 $this->assertSame( __METHOD__
, $revRecord->getComment()->text
);
572 * @covers \MediaWiki\Storage\RevisionStore::getRevisionByTimestamp
574 public function testGetRevisionByTimestamp() {
575 // Make sure there is 1 second between the last revision and the rev we create...
576 // Otherwise we might not get the correct revision and the test may fail...
579 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
580 $content = new WikitextContent( __METHOD__
);
581 $status = $page->doEditContent( $content, __METHOD__
);
582 /** @var Revision $rev */
583 $rev = $status->value
['revision'];
585 $store = MediaWikiServices
::getInstance()->getRevisionStore();
586 $revRecord = $store->getRevisionByTimestamp(
591 $this->assertSame( $rev->getId(), $revRecord->getId() );
592 $this->assertTrue( $revRecord->getSlot( 'main' )->getContent()->equals( $content ) );
593 $this->assertSame( __METHOD__
, $revRecord->getComment()->text
);
596 private function revisionToRow( Revision
$rev ) {
597 $page = WikiPage
::factory( $rev->getTitle() );
600 'rev_id' => (string)$rev->getId(),
601 'rev_page' => (string)$rev->getPage(),
602 'rev_text_id' => (string)$rev->getTextId(),
603 'rev_timestamp' => (string)$rev->getTimestamp(),
604 'rev_user_text' => (string)$rev->getUserText(),
605 'rev_user' => (string)$rev->getUser(),
606 'rev_minor_edit' => $rev->isMinor() ?
'1' : '0',
607 'rev_deleted' => (string)$rev->getVisibility(),
608 'rev_len' => (string)$rev->getSize(),
609 'rev_parent_id' => (string)$rev->getParentId(),
610 'rev_sha1' => (string)$rev->getSha1(),
611 'rev_comment_text' => $rev->getComment(),
612 'rev_comment_data' => null,
613 'rev_comment_cid' => null,
614 'rev_content_format' => $rev->getContentFormat(),
615 'rev_content_model' => $rev->getContentModel(),
616 'page_namespace' => (string)$page->getTitle()->getNamespace(),
617 'page_title' => $page->getTitle()->getDBkey(),
618 'page_id' => (string)$page->getId(),
619 'page_latest' => (string)$page->getLatest(),
620 'page_is_redirect' => $page->isRedirect() ?
'1' : '0',
621 'page_len' => (string)$page->getContent()->getSize(),
622 'user_name' => (string)$rev->getUserText(),
626 private function assertRevisionRecordMatchesRevision(
628 RevisionRecord
$record
630 $this->assertSame( $rev->getId(), $record->getId() );
631 $this->assertSame( $rev->getPage(), $record->getPageId() );
632 $this->assertSame( $rev->getTimestamp(), $record->getTimestamp() );
633 $this->assertSame( $rev->getUserText(), $record->getUser()->getName() );
634 $this->assertSame( $rev->getUser(), $record->getUser()->getId() );
635 $this->assertSame( $rev->isMinor(), $record->isMinor() );
636 $this->assertSame( $rev->getVisibility(), $record->getVisibility() );
637 $this->assertSame( $rev->getSize(), $record->getSize() );
639 * @note As of MW 1.31, the database schema allows the parent ID to be
640 * NULL to indicate that it is unknown.
642 $expectedParent = $rev->getParentId();
643 if ( $expectedParent === null ) {
646 $this->assertSame( $expectedParent, $record->getParentId() );
647 $this->assertSame( $rev->getSha1(), $record->getSha1() );
648 $this->assertSame( $rev->getComment(), $record->getComment()->text
);
649 $this->assertSame( $rev->getContentFormat(), $record->getContent( 'main' )->getDefaultFormat() );
650 $this->assertSame( $rev->getContentModel(), $record->getContent( 'main' )->getModel() );
651 $this->assertLinkTargetsEqual( $rev->getTitle(), $record->getPageAsLinkTarget() );
655 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromRow
656 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromRow_1_29
658 public function testNewRevisionFromRow_anonEdit() {
659 $this->setMwGlobals( 'wgActorTableSchemaMigrationStage', MIGRATION_WRITE_BOTH
);
660 $this->overrideMwServices();
662 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
663 $text = __METHOD__
. 'a-ä';
664 /** @var Revision $rev */
665 $rev = $page->doEditContent(
666 new WikitextContent( $text ),
668 )->value
['revision'];
670 $store = MediaWikiServices
::getInstance()->getRevisionStore();
671 $record = $store->newRevisionFromRow(
672 $this->revisionToRow( $rev ),
676 $this->assertRevisionRecordMatchesRevision( $rev, $record );
677 $this->assertSame( $text, $rev->getContent()->serialize() );
681 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromRow
682 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromRow_1_29
684 public function testNewRevisionFromRow_anonEdit_legacyEncoding() {
685 $this->setMwGlobals( 'wgLegacyEncoding', 'windows-1252' );
686 $this->overrideMwServices();
687 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
688 $text = __METHOD__
. 'a-ä';
689 /** @var Revision $rev */
690 $rev = $page->doEditContent(
691 new WikitextContent( $text ),
693 )->value
['revision'];
695 $store = MediaWikiServices
::getInstance()->getRevisionStore();
696 $record = $store->newRevisionFromRow(
697 $this->revisionToRow( $rev ),
701 $this->assertRevisionRecordMatchesRevision( $rev, $record );
702 $this->assertSame( $text, $rev->getContent()->serialize() );
706 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromRow
707 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromRow_1_29
709 public function testNewRevisionFromRow_userEdit() {
710 $this->setMwGlobals( 'wgActorTableSchemaMigrationStage', MIGRATION_WRITE_BOTH
);
711 $this->overrideMwServices();
713 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
714 $text = __METHOD__
. 'b-ä';
715 /** @var Revision $rev */
716 $rev = $page->doEditContent(
717 new WikitextContent( $text ),
721 $this->getTestUser()->getUser()
722 )->value
['revision'];
724 $store = MediaWikiServices
::getInstance()->getRevisionStore();
725 $record = $store->newRevisionFromRow(
726 $this->revisionToRow( $rev ),
730 $this->assertRevisionRecordMatchesRevision( $rev, $record );
731 $this->assertSame( $text, $rev->getContent()->serialize() );
735 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromArchiveRow
737 public function testNewRevisionFromArchiveRow() {
738 $store = MediaWikiServices
::getInstance()->getRevisionStore();
739 $title = Title
::newFromText( __METHOD__
);
740 $text = __METHOD__
. '-bä';
741 $page = WikiPage
::factory( $title );
742 /** @var Revision $orig */
743 $orig = $page->doEditContent( new WikitextContent( $text ), __METHOD__
)
745 $page->doDeleteArticle( __METHOD__
);
747 $db = wfGetDB( DB_MASTER
);
748 $arQuery = $store->getArchiveQueryInfo();
750 $arQuery['tables'], $arQuery['fields'], [ 'ar_rev_id' => $orig->getId() ],
751 __METHOD__
, [], $arQuery['joins']
753 $this->assertTrue( is_object( $res ), 'query failed' );
755 $row = $res->fetchObject();
757 $record = $store->newRevisionFromArchiveRow( $row );
759 $this->assertRevisionRecordMatchesRevision( $orig, $record );
760 $this->assertSame( $text, $record->getContent( 'main' )->serialize() );
764 * @covers \MediaWiki\Storage\RevisionStore::newRevisionFromArchiveRow
766 public function testNewRevisionFromArchiveRow_legacyEncoding() {
767 $this->setMwGlobals( 'wgLegacyEncoding', 'windows-1252' );
768 $this->overrideMwServices();
769 $store = MediaWikiServices
::getInstance()->getRevisionStore();
770 $title = Title
::newFromText( __METHOD__
);
771 $text = __METHOD__
. '-bä';
772 $page = WikiPage
::factory( $title );
773 /** @var Revision $orig */
774 $orig = $page->doEditContent( new WikitextContent( $text ), __METHOD__
)
776 $page->doDeleteArticle( __METHOD__
);
778 $db = wfGetDB( DB_MASTER
);
779 $arQuery = $store->getArchiveQueryInfo();
781 $arQuery['tables'], $arQuery['fields'], [ 'ar_rev_id' => $orig->getId() ],
782 __METHOD__
, [], $arQuery['joins']
784 $this->assertTrue( is_object( $res ), 'query failed' );
786 $row = $res->fetchObject();
788 $record = $store->newRevisionFromArchiveRow( $row );
790 $this->assertRevisionRecordMatchesRevision( $orig, $record );
791 $this->assertSame( $text, $record->getContent( 'main' )->serialize() );
795 * @covers \MediaWiki\Storage\RevisionStore::loadRevisionFromId
797 public function testLoadRevisionFromId() {
798 $title = Title
::newFromText( __METHOD__
);
799 $page = WikiPage
::factory( $title );
800 /** @var Revision $rev */
801 $rev = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
)
804 $store = MediaWikiServices
::getInstance()->getRevisionStore();
805 $result = $store->loadRevisionFromId( wfGetDB( DB_MASTER
), $rev->getId() );
806 $this->assertRevisionRecordMatchesRevision( $rev, $result );
810 * @covers \MediaWiki\Storage\RevisionStore::loadRevisionFromPageId
812 public function testLoadRevisionFromPageId() {
813 $title = Title
::newFromText( __METHOD__
);
814 $page = WikiPage
::factory( $title );
815 /** @var Revision $rev */
816 $rev = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
)
819 $store = MediaWikiServices
::getInstance()->getRevisionStore();
820 $result = $store->loadRevisionFromPageId( wfGetDB( DB_MASTER
), $page->getId() );
821 $this->assertRevisionRecordMatchesRevision( $rev, $result );
825 * @covers \MediaWiki\Storage\RevisionStore::loadRevisionFromTitle
827 public function testLoadRevisionFromTitle() {
828 $title = Title
::newFromText( __METHOD__
);
829 $page = WikiPage
::factory( $title );
830 /** @var Revision $rev */
831 $rev = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
)
834 $store = MediaWikiServices
::getInstance()->getRevisionStore();
835 $result = $store->loadRevisionFromTitle( wfGetDB( DB_MASTER
), $title );
836 $this->assertRevisionRecordMatchesRevision( $rev, $result );
840 * @covers \MediaWiki\Storage\RevisionStore::loadRevisionFromTimestamp
842 public function testLoadRevisionFromTimestamp() {
843 $title = Title
::newFromText( __METHOD__
);
844 $page = WikiPage
::factory( $title );
845 /** @var Revision $revOne */
846 $revOne = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
)
848 // Sleep to ensure different timestamps... )(evil)
850 /** @var Revision $revTwo */
851 $revTwo = $page->doEditContent( new WikitextContent( __METHOD__
. 'a' ), '' )
854 $store = MediaWikiServices
::getInstance()->getRevisionStore();
856 $store->loadRevisionFromTimestamp( wfGetDB( DB_MASTER
), $title, '20150101010101' )
860 $store->loadRevisionFromTimestamp(
861 wfGetDB( DB_MASTER
),
863 $revOne->getTimestamp()
868 $store->loadRevisionFromTimestamp(
869 wfGetDB( DB_MASTER
),
871 $revTwo->getTimestamp()
877 * @covers \MediaWiki\Storage\RevisionStore::listRevisionSizes
879 public function testGetParentLengths() {
880 $page = WikiPage
::factory( Title
::newFromText( __METHOD__
) );
881 /** @var Revision $revOne */
882 $revOne = $page->doEditContent(
883 new WikitextContent( __METHOD__
), __METHOD__
884 )->value
['revision'];
885 /** @var Revision $revTwo */
886 $revTwo = $page->doEditContent(
887 new WikitextContent( __METHOD__
. '2' ), __METHOD__
888 )->value
['revision'];
890 $store = MediaWikiServices
::getInstance()->getRevisionStore();
893 $revOne->getId() => strlen( __METHOD__
),
895 $store->listRevisionSizes(
896 wfGetDB( DB_MASTER
),
902 $revOne->getId() => strlen( __METHOD__
),
903 $revTwo->getId() => strlen( __METHOD__
) +
1,
905 $store->listRevisionSizes(
906 wfGetDB( DB_MASTER
),
907 [ $revOne->getId(), $revTwo->getId() ]
913 * @covers \MediaWiki\Storage\RevisionStore::getPreviousRevision
915 public function testGetPreviousRevision() {
916 $page = WikiPage
::factory( Title
::newFromText( __METHOD__
) );
917 /** @var Revision $revOne */
918 $revOne = $page->doEditContent(
919 new WikitextContent( __METHOD__
), __METHOD__
920 )->value
['revision'];
921 /** @var Revision $revTwo */
922 $revTwo = $page->doEditContent(
923 new WikitextContent( __METHOD__
. '2' ), __METHOD__
924 )->value
['revision'];
926 $store = MediaWikiServices
::getInstance()->getRevisionStore();
928 $store->getPreviousRevision( $store->getRevisionById( $revOne->getId() ) )
932 $store->getPreviousRevision( $store->getRevisionById( $revTwo->getId() ) )->getId()
937 * @covers \MediaWiki\Storage\RevisionStore::getNextRevision
939 public function testGetNextRevision() {
940 $page = WikiPage
::factory( Title
::newFromText( __METHOD__
) );
941 /** @var Revision $revOne */
942 $revOne = $page->doEditContent(
943 new WikitextContent( __METHOD__
), __METHOD__
944 )->value
['revision'];
945 /** @var Revision $revTwo */
946 $revTwo = $page->doEditContent(
947 new WikitextContent( __METHOD__
. '2' ), __METHOD__
948 )->value
['revision'];
950 $store = MediaWikiServices
::getInstance()->getRevisionStore();
953 $store->getNextRevision( $store->getRevisionById( $revOne->getId() ) )->getId()
956 $store->getNextRevision( $store->getRevisionById( $revTwo->getId() ) )
961 * @covers \MediaWiki\Storage\RevisionStore::getTimestampFromId
963 public function testGetTimestampFromId_found() {
964 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
965 /** @var Revision $rev */
966 $rev = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
)
969 $store = MediaWikiServices
::getInstance()->getRevisionStore();
970 $result = $store->getTimestampFromId(
975 $this->assertSame( $rev->getTimestamp(), $result );
979 * @covers \MediaWiki\Storage\RevisionStore::getTimestampFromId
981 public function testGetTimestampFromId_notFound() {
982 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
983 /** @var Revision $rev */
984 $rev = $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
)
987 $store = MediaWikiServices
::getInstance()->getRevisionStore();
988 $result = $store->getTimestampFromId(
993 $this->assertFalse( $result );
997 * @covers \MediaWiki\Storage\RevisionStore::countRevisionsByPageId
999 public function testCountRevisionsByPageId() {
1000 $store = MediaWikiServices
::getInstance()->getRevisionStore();
1001 $page = WikiPage
::factory( Title
::newFromText( __METHOD__
) );
1005 $store->countRevisionsByPageId( wfGetDB( DB_MASTER
), $page->getId() )
1007 $page->doEditContent( new WikitextContent( 'a' ), 'a' );
1010 $store->countRevisionsByPageId( wfGetDB( DB_MASTER
), $page->getId() )
1012 $page->doEditContent( new WikitextContent( 'b' ), 'b' );
1015 $store->countRevisionsByPageId( wfGetDB( DB_MASTER
), $page->getId() )
1020 * @covers \MediaWiki\Storage\RevisionStore::countRevisionsByTitle
1022 public function testCountRevisionsByTitle() {
1023 $store = MediaWikiServices
::getInstance()->getRevisionStore();
1024 $page = WikiPage
::factory( Title
::newFromText( __METHOD__
) );
1028 $store->countRevisionsByTitle( wfGetDB( DB_MASTER
), $page->getTitle() )
1030 $page->doEditContent( new WikitextContent( 'a' ), 'a' );
1033 $store->countRevisionsByTitle( wfGetDB( DB_MASTER
), $page->getTitle() )
1035 $page->doEditContent( new WikitextContent( 'b' ), 'b' );
1038 $store->countRevisionsByTitle( wfGetDB( DB_MASTER
), $page->getTitle() )
1043 * @covers \MediaWiki\Storage\RevisionStore::userWasLastToEdit
1045 public function testUserWasLastToEdit_false() {
1046 $sysop = $this->getTestSysop()->getUser();
1047 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
1048 $page->doEditContent( new WikitextContent( __METHOD__
), __METHOD__
);
1050 $store = MediaWikiServices
::getInstance()->getRevisionStore();
1051 $result = $store->userWasLastToEdit(
1052 wfGetDB( DB_MASTER
),
1057 $this->assertFalse( $result );
1061 * @covers \MediaWiki\Storage\RevisionStore::userWasLastToEdit
1063 public function testUserWasLastToEdit_true() {
1064 $startTime = wfTimestampNow();
1065 $sysop = $this->getTestSysop()->getUser();
1066 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
1067 $page->doEditContent(
1068 new WikitextContent( __METHOD__
),
1075 $store = MediaWikiServices
::getInstance()->getRevisionStore();
1076 $result = $store->userWasLastToEdit(
1077 wfGetDB( DB_MASTER
),
1082 $this->assertTrue( $result );
1086 * @covers \MediaWiki\Storage\RevisionStore::getKnownCurrentRevision
1088 public function testGetKnownCurrentRevision() {
1089 $page = WikiPage
::factory( Title
::newFromText( 'UTPage' ) );
1090 /** @var Revision $rev */
1091 $rev = $page->doEditContent(
1092 new WikitextContent( __METHOD__
. 'b' ),
1096 $this->getTestUser()->getUser()
1097 )->value
['revision'];
1099 $store = MediaWikiServices
::getInstance()->getRevisionStore();
1100 $record = $store->getKnownCurrentRevision(
1105 $this->assertRevisionRecordMatchesRevision( $rev, $record );
1108 public function provideNewMutableRevisionFromArray() {
1109 yield
'Basic array, with page & id' => [
1114 'timestamp' => '20171017114835',
1115 'user_text' => '111.0.1.2',
1117 'minor_edit' => false,
1121 'sha1' => 'rdqbbzs3pkhihgbs8qf2q9jsvheag5z',
1122 'comment' => 'Goat Comment!',
1123 'content_format' => 'text/x-wiki',
1124 'content_model' => 'wikitext',
1127 yield
'Basic array, content object' => [
1131 'timestamp' => '20171017114835',
1132 'user_text' => '111.0.1.2',
1134 'minor_edit' => false,
1138 'sha1' => 'rdqbbzs3pkhihgbs8qf2q9jsvheag5z',
1139 'comment' => 'Goat Comment!',
1140 'content' => new WikitextContent( 'Some Content' ),
1143 yield
'Basic array, serialized text' => [
1147 'timestamp' => '20171017114835',
1148 'user_text' => '111.0.1.2',
1150 'minor_edit' => false,
1154 'sha1' => 'rdqbbzs3pkhihgbs8qf2q9jsvheag5z',
1155 'comment' => 'Goat Comment!',
1156 'text' => ( new WikitextContent( 'Söme Content' ) )->serialize(),
1159 yield
'Basic array, serialized text, utf-8 flags' => [
1163 'timestamp' => '20171017114835',
1164 'user_text' => '111.0.1.2',
1166 'minor_edit' => false,
1170 'sha1' => 'rdqbbzs3pkhihgbs8qf2q9jsvheag5z',
1171 'comment' => 'Goat Comment!',
1172 'text' => ( new WikitextContent( 'Söme Content' ) )->serialize(),
1176 yield
'Basic array, with title' => [
1178 'title' => Title
::newFromText( 'SomeText' ),
1180 'timestamp' => '20171017114835',
1181 'user_text' => '111.0.1.2',
1183 'minor_edit' => false,
1187 'sha1' => 'rdqbbzs3pkhihgbs8qf2q9jsvheag5z',
1188 'comment' => 'Goat Comment!',
1189 'content_format' => 'text/x-wiki',
1190 'content_model' => 'wikitext',
1193 yield
'Basic array, no user field' => [
1198 'timestamp' => '20171017114835',
1199 'user_text' => '111.0.1.3',
1200 'minor_edit' => false,
1204 'sha1' => 'rdqbbzs3pkhihgbs8qf2q9jsvheag5z',
1205 'comment' => 'Goat Comment!',
1206 'content_format' => 'text/x-wiki',
1207 'content_model' => 'wikitext',
1213 * @dataProvider provideNewMutableRevisionFromArray
1214 * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray
1216 public function testNewMutableRevisionFromArray( array $array ) {
1217 $store = MediaWikiServices
::getInstance()->getRevisionStore();
1219 $result = $store->newMutableRevisionFromArray( $array );
1221 if ( isset( $array['id'] ) ) {
1222 $this->assertSame( $array['id'], $result->getId() );
1224 if ( isset( $array['page'] ) ) {
1225 $this->assertSame( $array['page'], $result->getPageId() );
1227 $this->assertSame( $array['timestamp'], $result->getTimestamp() );
1228 $this->assertSame( $array['user_text'], $result->getUser()->getName() );
1229 if ( isset( $array['user'] ) ) {
1230 $this->assertSame( $array['user'], $result->getUser()->getId() );
1232 $this->assertSame( (bool)$array['minor_edit'], $result->isMinor() );
1233 $this->assertSame( $array['deleted'], $result->getVisibility() );
1234 $this->assertSame( $array['len'], $result->getSize() );
1235 $this->assertSame( $array['parent_id'], $result->getParentId() );
1236 $this->assertSame( $array['sha1'], $result->getSha1() );
1237 $this->assertSame( $array['comment'], $result->getComment()->text
);
1238 if ( isset( $array['content'] ) ) {
1240 $result->getSlot( 'main' )->getContent()->equals( $array['content'] )
1242 } elseif ( isset( $array['text'] ) ) {
1243 $this->assertSame( $array['text'], $result->getSlot( 'main' )->getContent()->serialize() );
1246 $array['content_format'],
1247 $result->getSlot( 'main' )->getContent()->getDefaultFormat()
1249 $this->assertSame( $array['content_model'], $result->getSlot( 'main' )->getModel() );
1254 * @dataProvider provideNewMutableRevisionFromArray
1255 * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray
1257 public function testNewMutableRevisionFromArray_legacyEncoding( array $array ) {
1258 $cache = new WANObjectCache( [ 'cache' => new HashBagOStuff() ] );
1259 $blobStore = new SqlBlobStore( wfGetLB(), $cache );
1260 $blobStore->setLegacyEncoding( 'windows-1252', Language
::factory( 'en' ) );
1262 $factory = $this->getMockBuilder( BlobStoreFactory
::class )
1263 ->setMethods( [ 'newBlobStore', 'newSqlBlobStore' ] )
1264 ->disableOriginalConstructor()
1266 $factory->expects( $this->any() )
1267 ->method( 'newBlobStore' )
1268 ->willReturn( $blobStore );
1269 $factory->expects( $this->any() )
1270 ->method( 'newSqlBlobStore' )
1271 ->willReturn( $blobStore );
1273 $this->setService( 'BlobStoreFactory', $factory );
1275 $this->testNewMutableRevisionFromArray( $array );